| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2017-02-23 | |||
| 18:57:28 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Improve assertJsonEqual error reporting https://review.openstack.org/428199 | |
| 19:05:19 | openstackgerrit | Stephen Finucane proposed openstack/nova master: libvirt: drop MIN_LIBVIRT_NUMA_VERSION https://review.openstack.org/437561 | |
| 19:05:19 | openstackgerrit | Stephen Finucane proposed openstack/nova master: libvirt: drop MIN_QEMU_NUMA_HUGEPAGE_VERSION https://review.openstack.org/437560 | |
| 19:05:20 | openstackgerrit | Stephen Finucane proposed openstack/nova master: libvirt: drop MIN_LIBVIRT_HUGEPAGE_VERSION https://review.openstack.org/437562 | |
| 19:05:30 | sfinucan | mriedem2: ^ | |
| 19:05:54 | oomichi | alex_xu: I found some non-good api on tempest https://review.openstack.org/#/c/435630 . https://developer.openstack.org/api-ref/compute/?expanded=check-tag-existence-detail#check-tag-existence should be HEAD, not GET | |
| 19:10:20 | bauzas | yay, Launchpad timeout issue \o/ | |
| 19:17:10 | mriedem | sfinucan: yeah so you found out why i didn't tackle the numa stuff right? :) | |
| 19:17:13 | mriedem | b/c of the test gorp | |
| 19:18:22 | sfinucan | mriedem: Aye. Looked tough until I realised having hugepages meant having NUMA support :) | |
| 19:18:49 | sfinucan | *needed NUMA support | |
| 19:18:58 | sfinucan | ...and having NUMA support implicitly meant you had huge page support | |
| 19:19:25 | sfinucan | Hence, bye bye swathes of test code | |
| 19:38:47 | openstackgerrit | Anusha Unnam proposed openstack/nova master: Add unit tests for cinderclient https://review.openstack.org/437575 | |
| 19:45:32 | openstackgerrit | Diana Clarke proposed openstack/python-novaclient master: Fix devstack python-novaclient warning https://review.openstack.org/436975 | |
| 19:57:46 | diana_clarke | andreykurilin: You at PTG? I'm not seeing existing tests in python-novaclient for stuff like: https://review.openstack.org/436975 But perhaps I'm just missing the obvious. | |
| 19:58:33 | diana_clarke | andreykurilin: Anyhoo, when you have a change, can you please sanity check that and point me in the right direction from tests. I noticed test_auth.py was recently deleted. Thx! | |
| 19:58:43 | diana_clarke | s/from/for | |
| 19:59:18 | andreykurilin | diana_clarke: hi! Yes, I'm at PTG :) | |
| 19:59:38 | diana_clarke | andreykurilin: I thought I saw your hair in one of the pics :) | |
| 19:59:53 | andreykurilin | diana_clarke: heh | |
| 20:00:34 | miss_hypothermia | mriedem: ok, I think I got your point regarding that terminate_connection call | |
| 20:01:22 | diana_clarke | andreykurilin: Anyhoo, the TL;DR is that on stable/ocata devstack, you see this warning for each nova command: http://paste.openstack.org/show/598407/ | |
| 20:01:53 | miss_hypothermia | mriedem: as for unreserving the volume in case of Quota error, I got myself confused with where the volume creation happens, when Nova creates it compared to _validate_bdm | |
| 20:02:04 | miss_hypothermia | mriedem: can you by any chance point me to that? | |
| 20:02:55 | andreykurilin | diana_clarke: I'm not at Sheraton right now, will ping you when I will be there or at least the PC will be near me:) | |
| 20:03:46 | diana_clarke | andreykurilin: Okie dokie, no rush. I'm almost done for the day anyway. But I think you're the best person to take a look at this when you have time. | |
| 20:03:57 | sfinucan | lyarwood: http://ricostacruz.com/cheatsheets/rst.html | |
| 20:04:29 | sfinucan | lyarwood: https://github.com/ralsina/rst-cheatsheet/blob/master/rst-cheatsheet.rst | |
| 20:08:18 | openstackgerrit | Lee Yarwood proposed openstack/nova master: Make BlockDeviceMapping object support uuid https://review.openstack.org/242603 | |
| 20:08:19 | openstackgerrit | Lee Yarwood proposed openstack/nova master: Add attachment_id to BlockDeviceMapping https://review.openstack.org/437597 | |
| 20:08:19 | mriedem | miss_hypothermia: nova creates the volume in nova/virt/block_device.py for the image/snapshot/blank drivers | |
| 20:08:19 | openstackgerrit | Lee Yarwood proposed openstack/nova master: Add uuid column to BlockDeviceMapping https://review.openstack.org/242602 | |
| 20:09:04 | mriedem | miss_hypothermia: in the cinder channel smcginnis said that the volume drivers in cinder should not fail on terminate_connection if the init never happened | |
| 20:09:48 | mriedem | so, the only difference in behavior is that now in boot from volume when you provide a volume to nova, if something fails the volume is going to be 'locked' by nova until the instance is deleted | |
| 20:10:05 | mriedem | 'locked' meaning it's going to be in 'attaching' status until the admin force detaches/unreserves it, something like that | |
| 20:10:15 | mriedem | we'd need that in a release note | |
| 20:12:08 | gibi | jo | |
| 20:12:11 | gibi | sorry | |
| 20:14:53 | openstackgerrit | Jay Pipes proposed openstack/nova master: placement: ironic inventory reporting https://review.openstack.org/437602 | |
| 20:15:10 | jaypipes | dansmith, mriedem, cdent: ^ | |
| 20:15:32 | cdent | ✔ | |
| 20:23:48 | dansmith | jaypipes: that looks a lot like what I was thinking | |
| 20:23:55 | dansmith | jaypipes: I shall return to it when I have full brains | |
| 20:24:09 | dansmith | melwitt: so.......... | |
| 20:24:31 | dansmith | melwitt: target_cell doesn't target mq, only database | |
| 20:24:47 | dansmith | melwitt: which we discussed previously as handled in the rpc layer and I think re-discussed recently as also putting in target_cell | |
| 20:25:15 | dansmith | melwitt: so now I'm hitting a problem because I need to call conductor's rpcapi for an instance, and have it go to the right cell's conductor | |
| 20:25:30 | dansmith | melwitt: and since we don't have that in there, I go by default to superconductor and fail | |
| 20:25:39 | dansmith | which I think is further justification for my opinion that target_cell should do mq too | |
| 20:25:41 | melwitt | dansmith: I know. it's on my todo list to add it back to target_cell and move the caching to there, maybe | |
| 20:25:42 | dansmith | thoughts? | |
| 20:25:50 | dansmith | okay | |
| 20:26:07 | melwitt | dansmith: yeah, I agree. maybe just a small patch to start to let it be possible, then the move of the cache and everything will be a bigger haul | |
| 20:26:18 | dansmith | melwitt: yeah, I shall do that thing then | |
| 20:27:28 | melwitt | dansmith: I can put up a change based on what I had way back when, before all of it moved to compute/rpcapi | |
| 20:27:40 | melwitt | it's an earlier PS of that patch | |
| 20:28:09 | dansmith | melwitt: okay would you rather do that than me just do it? | |
| 20:30:16 | melwitt | dansmith: you can do it, I didn't remember what there was to it. turns out it was only this https://review.openstack.org/#/c/274955/12/nova/context.py | |
| 20:30:36 | dansmith | melwitt: ack, yeah, thanks | |
| 20:31:08 | melwitt | I'm not sure if we need the special-casing of 'none:///'. that was to avoid doing something for cell0 | |
| 20:31:44 | spiantino | hey all - i found some logs from november discussing adding the ability to include "<kvm><hidden state='on'/><kvm>" to the libvirt domain via nova | |
| 20:32:16 | spiantino | is there an implementation of that? or any advice on how to hackily get that field included in a VM? without it NVidia GPUs don't work in a VM | |
| 20:35:24 | spiantino | mgariepy: were you ever able to get that option added to driver.py? | |
| 20:35:40 | spiantino | happy to submit the pr | |
| 20:39:49 | oomichi | alex_xu: sdague: johnthetubaguy: can you take a look at https://review.openstack.org/#/c/406377 ? | |
| 20:40:07 | oomichi | that could fix potential server internal error | |
| 20:40:55 | miss_hypothermia | mriedem: that seems like a fair deal, I mean have the volume locked | |
| 20:41:42 | miss_hypothermia | mriedem: so in this sense I will remove the compute service version bump and the additional unreserve call and add a release note to describe the change | |
| 20:42:06 | mriedem | miss_hypothermia: ok | |
| 20:42:10 | mriedem | i think i'm ok with that :) | |
| 20:42:25 | miss_hypothermia | mriedem: \o/ :) | |
| 20:42:33 | miss_hypothermia | mriedem: thanks! | |
| 20:42:53 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Transform missing delete notifications https://review.openstack.org/410297 | |
| 20:53:28 | andreykurilin | diana_clarke: ping | |
| 20:53:38 | diana_clarke | andreykurilin: allo! | |
| 20:54:40 | andreykurilin | diana_clarke: I'm at Sheraton now, can answer all questions :) | |
| 20:54:58 | diana_clarke | It was more fun when there was video and I could see you all. | |
| 20:55:14 | andreykurilin | Oh, you are not here? | |
| 20:55:18 | andreykurilin | :( | |
| 20:56:00 | dansmith | melwitt: actually, we still need to do stuff to conductor rpcapi to make it even honor the context I guess | |
| 20:56:22 | diana_clarke | andreykurilin: No, sadly. I've been detained multiple times at the US border in the past... sitting this one out. | |
| 20:57:55 | diana_clarke | andreykurilin: Mostly, I just wanted a sanity check on the change. When you made similar changes in the past, you changed test_auth.py but that's since been deleted. | |
| 20:58:51 | andreykurilin | diana_clarke: at least I have a PC now, so I can give you some answers | |
| 20:59:03 | mriedem | sdague: https://review.openstack.org/#/c/435563/ | |
| 20:59:08 | diana_clarke | andreykurilin: I didn't look all that hard today, but before that merges it should probably have tests. But when I grep recursively for project_name, no tests cover those paths, so I wondered if you had thoughts on that front. | |
| 20:59:16 | melwitt | dansmith: ah, right. the way it is right now, you'd add a ClientRouter to conductor/rpcapi and use by_host or by_instance | |
| 20:59:30 | dansmith | melwitt: yeah | |
| 20:59:32 | dansmith | hrmph | |
| 20:59:36 | melwitt | hah | |
| 20:59:49 | andreykurilin | diana_clarke: so test_auth was only about authentication in HTTPClient | |
| 21:00:04 | andreykurilin | now it is gone and there is only session client | |
| 21:00:13 | andreykurilin | we have functional tests for it | |
| 21:00:29 | diana_clarke | andreykurilin: yeah... I gathered that. I mention it only b/c related changes originally resulted in test changes there. | |
| 21:00:51 | andreykurilin | diana_clarke: https://github.com/openstack/python-novaclient/blob/master/novaclient/tests/functional/test_auth.py | |
| 21:01:00 | andreykurilin | there is only one place of testing auth stuff | |
| 21:04:46 | diana_clarke | andreykurilin: I'm only 50% sure that change is correct given the bazillion kwargs and similar environment variables. But if you're okay with it, I trust you :) | |
| 21:05:09 | diana_clarke | andreykurilin: I did manually test it, and it does indeed make the warnings go way. | |
| 21:05:49 | diana_clarke | And I suppose it does have all of pike to stew. | |
| 21:07:38 | mriedem | sfinucan: replied to your question in https://review.openstack.org/#/c/429413/ | |