Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2017-02-08
01:42:38 mriedem Kevin_Zheng: i left a comment in your change
01:42:50 openstackgerrit Matt Riedemann proposed openstack/nova master: Allow None for block_device_mapping_v2.boot_index https://review.openstack.org/430497
01:42:56 mriedem mordred: dhellmann: alex_xu: oomichi: gmann: Kevin_Zheng: fix for the boot_index=None thing ^
01:43:09 Kevin_Zheng thanks
01:44:44 Kevin_Zheng mriedem: yeah, my initial plan was to fail
01:45:13 Kevin_Zheng mriedem: so should we make destination_type checked in schema or in python?
01:46:46 mriedem Kevin_Zheng: i'm not sure, it would be good to understand what cases, if any, that destination_type could be None
01:48:13 Kevin_Zheng mriedem: Ok, I understand, I will try more cases
01:48:50 mriedem Kevin_Zheng: oh i see your defaults are copied from what novaclient does
01:48:56 mriedem i didn't know that novaclient did that
01:48:57 mriedem odd
01:50:00 mriedem mdbooth might have ideas on this
01:50:03 Kevin_Zheng mriedem: but at least with source_type=volume and snapshot, with a None destination_type a bdm will be create and nothing in cinder will happen
01:50:57 gmann mriedem: yes, you are right, its v2.1 schema validation made it to stop None
01:51:43 gmann and we have to fix this all the way till mitaka ?
01:52:25 Kevin_Zheng I think thats also what I did, but suggested by Kevin L Mitchell
01:52:57 mriedem Kevin_Zheng: yeah i see you made that change in novaclient
01:53:08 mriedem i don't think nova (or the client) should guess
01:53:35 mriedem gmann: it's been regressed since probably we added that schema
01:53:42 mriedem gmann: so i plan on backporting it as far as possible
01:53:56 gmann yea :(
01:54:08 mriedem i believe we deprecated the v2 api in liberty
01:54:37 openstackgerrit Matt Riedemann proposed openstack/nova master: Allow None for block_device_mapping_v2.boot_index https://review.openstack.org/430497
01:54:48 Kevin_Zheng I think we have to dig deeper with the destination_type one, because at least for some cases, it will leave a bdm but nothing else
01:55:31 mriedem Kevin_Zheng: with source_type in 'volume' or 'snapshot' then yes i agree we can default destination_type to 'volume'
01:55:36 mriedem since that's the only dest type for those source types
01:55:48 mriedem but source_type in image or blank it's not that simple
01:56:10 huanxie Hi all, could you help review my patch to fix live migration problems with XenServer https://review.openstack.org/#/c/424428/, thanks a lot~
01:56:53 Kevin_Zheng hmm, but if the user don't provide destination_type, maybe a default one is reasonable
01:57:45 mriedem Kevin_Zheng: that would be a change in the api behavior
01:58:36 Kevin_Zheng I will check what soure=image and blank goes with None
01:58:52 mriedem now if source_type=blank and guest_format is not None, you could maybe assume destination_type=local
02:00:08 Kevin_Zheng should we cleanup client also?
02:02:18 mriedem Kevin_Zheng: probably, at least for the source_type case
02:02:30 mriedem i mean, source_type in ('image', 'blank')
02:02:54 Kevin_Zheng seems the only confusing type is source=image?
02:03:11 Kevin_Zheng I think source=image dest=None won't work
02:03:24 Kevin_Zheng I will check this one
02:12:17 gmann mriedem: we did in mitaka actually, so in mitaka None should work - https://github.com/openstack/nova/tree/stable/mitaka/nova/api/openstack/compute/legacy_v2
02:13:13 gmann I mean Mitaka have legacy code and so boot_index on /v2 should go with legacy code not via schema
02:13:56 mriedem gmann: but if you're using the v2.1 API in mitaka, this is still a bug yes?
02:14:12 mriedem because https://github.com/openstack/nova/blob/stable/mitaka/nova/api/openstack/compute/schemas/block_device_mapping.py#L59
02:16:55 gmann mriedem: yea for /v2.1 it is bug from starting
02:21:21 openstackgerrit Matt Riedemann proposed openstack/nova master: Allow None for block_device_mapping_v2.boot_index https://review.openstack.org/430497
03:59:12 openstackgerrit yuhui proposed openstack/nova master: [Trivial]Fix some type errors https://review.openstack.org/430548
03:59:38 openstackgerrit Takashi NATSUME proposed openstack/nova master: api-ref: Fix network_label parameter type https://review.openstack.org/429659
03:59:45 openstackgerrit Takashi NATSUME proposed openstack/nova master: api-ref: Fix network_label parameter type https://review.openstack.org/429659
04:01:21 openstackgerrit Diana Clarke proposed openstack/nova master: Reduce the number of COMMIT & SELECT 1 statements https://review.openstack.org/430390
04:10:58 Kevin_Zheng mriedem, gmann, ommichi, alex_xu: I did some test about bdm with source=image and it seems quite a mess, at least when I'm using novaclient
04:11:11 openstack Launchpad bug 1662748 in OpenStack Compute (nova) "Boot instance with bdm source=image dest=local/None cannot work" [Undecided,New] - Assigned to Zhenyu Zheng (zhengzhenyu)
04:11:11 Kevin_Zheng https://bugs.launchpad.net/nova/+bug/1662748
04:11:22 Kevin_Zheng ^ seems not usable at all
05:42:39 openstackgerrit Emilien Macchi proposed openstack/nova master: DNM - test tripleo without nova api in WSGI/apache https://review.openstack.org/429008
06:26:37 openstackgerrit Tuan Luong-Anh proposed openstack/nova master: Fix hypervisor-stats show invalid info of baremetal resource https://review.openstack.org/391415
06:46:16 openstackgerrit Wang Qing wu proposed openstack/nova master: WIP(5): PowerVM driver: ovs vif https://review.openstack.org/422512
06:48:22 openstackgerrit melanie witt proposed openstack/nova master: Claim and report zero root disk for boot-from-volume instances https://review.openstack.org/428505
06:48:22 openstackgerrit melanie witt proposed openstack/nova master: Request zero root disk for boot-from-volume instances https://review.openstack.org/428481
07:25:18 openstackgerrit Takashi NATSUME proposed openstack/nova master: List/show all server migration types https://review.openstack.org/430608
07:26:29 pkholkin alex_xu: thank you!)
07:32:24 openstackgerrit Takashi NATSUME proposed openstack/nova master: List/show all server migration types https://review.openstack.org/430608
07:37:18 openstackgerrit Takashi NATSUME proposed openstack/nova master: Enable cold migration with target host(1/2) https://review.openstack.org/408955
07:37:31 openstackgerrit Takashi NATSUME proposed openstack/nova master: Enable cold migration with target host(2/2) https://review.openstack.org/408964
07:38:03 openstackgerrit Takashi NATSUME proposed openstack/nova master: api-ref: Fix parameters and examples in aggregate API https://review.openstack.org/425512
07:38:44 openstackgerrit Takashi NATSUME proposed openstack/nova master: api-ref: Fix keypair API parameters https://review.openstack.org/420626
07:39:07 openstackgerrit Takashi NATSUME proposed openstack/nova master: Use ListOfIntegersField in oslo.versionedobjects https://review.openstack.org/423912
07:39:16 openstackgerrit Takashi NATSUME proposed openstack/nova master: Fix doc generation warnings https://review.openstack.org/425549
07:39:22 openstackgerrit Takashi NATSUME proposed openstack/nova master: api-ref: Fix deprecated proxy API parameters https://review.openstack.org/416882
07:39:32 openstackgerrit Takashi NATSUME proposed openstack/nova master: Refactor a test method including 3 test cases https://review.openstack.org/394738
07:39:40 openstackgerrit Takashi NATSUME proposed openstack/nova master: Refactor a test method including 7 test cases https://review.openstack.org/395436
07:39:50 openstackgerrit Takashi NATSUME proposed openstack/nova master: api-ref: Fix parameters in os-hosts.inc https://review.openstack.org/416444
07:39:58 openstackgerrit Takashi NATSUME proposed openstack/nova master: api-ref: Add parameters in cold migrate action https://review.openstack.org/410042
07:40:07 openstackgerrit Takashi NATSUME proposed openstack/nova master: Add functional tests for cold migration to same host https://review.openstack.org/414926
07:45:12 wllabs morning
07:45:34 wllabs good morning
07:54:02 openstackgerrit Takashi NATSUME proposed openstack/python-novaclient master: Microversion 2.42 - Fix tag attribute disappearing https://review.openstack.org/429512
07:55:08 openstackgerrit Takashi NATSUME proposed openstack/python-novaclient master: Microversion 2.43 - Enable cold migration with target host https://review.openstack.org/406707
08:14:07 openstackgerrit yuhui proposed openstack/nova master: Fix some type errors https://review.openstack.org/430629
08:38:36 openstackgerrit melanie witt proposed openstack/nova master: Claim and report zero root disk for boot-from-volume instances https://review.openstack.org/428505
08:38:39 openstackgerrit yuhui proposed openstack/nova master: Correct some spelling errors https://review.openstack.org/430646
09:25:22 openstackgerrit John Garbutt proposed openstack/nova master: Stop _undefine_domain erroring if domain not found https://review.openstack.org/430400
09:25:31 openstackgerrit John Garbutt proposed openstack/nova master: Stop _undefine_domain erroring if domain not found https://review.openstack.org/430400
09:25:42 openstackgerrit John Garbutt proposed openstack/nova master: WIP: Stop leaving failed live-migrates in the migrating state https://review.openstack.org/430404
09:31:15 mdbooth http://logs.openstack.org/09/395709/7/check/gate-tempest-dsvm-full-devstack-plugin-nfs-nv/a4c1057/logs/screen-n-cpu.txt.gz?level=ERROR
09:31:23 mdbooth The qemu-img info errors are new
09:31:31 mdbooth Anybody know anything about those?
09:32:56 openstackgerrit keerthivasan selvaraj proposed openstack/python-novaclient master: Adding cpu_allocation_ratio in the python-novaclient https://review.openstack.org/430684
09:41:38 lyarwood mdbooth: morning, nope but that's during swap_volume so I'll take a look
09:42:46 lyarwood mdbooth: ah no it's not, nvm
09:44:13 openstackgerrit Alex Szarka proposed openstack/nova master: Reduce code complexity - servers.py https://review.openstack.org/359861
09:45:00 nikeshm lyarwood: hi
09:46:02 openstack Launchpad bug 1662820 in OpenStack Compute (nova) "test_volume_swap failed in Kaminario Cinder Driver CI" [Undecided,New]
09:46:02 nikeshm lyarwood: https://bugs.launchpad.net/nova/+bug/1662820
09:46:21 lyarwood nikeshm: morning, thanks I'll take a look at that shortly
10:08:50 openstackgerrit Alex Szarka proposed openstack/nova master: Transform instance-exists notification https://review.openstack.org/403660
10:09:52 nikeshm lyarwood: thanks
10:10:00 nikeshm good morning
10:11:43 lyarwood nikeshm: updated with a comment, I'd have to check but I don't think Trusty is supported or used in the gate anymore
10:12:15 lyarwood nikeshm: this smells like a libvirt issue that was fixed in the Xenial version of libvirt btw
10:13:23 openstackgerrit Gábor Antal proposed openstack/nova master: Update hacking version in test-requirements.txt https://review.openstack.org/430702
10:14:29 mdbooth lyarwood: Found the root cause of those qemu-img errors I mentioned earlier, btw

Earlier   Later