| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2017-02-07 | |||
| 13:35:19 | openstackgerrit | Matthew Booth proposed openstack/nova master: Fix various races with detach_volume https://review.openstack.org/430213 | |
| 13:36:01 | pumaranikar | johnthetubaguy, cdent can you please check https://review.openstack.org/#/c/395194/ . Placement json formatter change | |
| 13:39:11 | mdbooth | lyarwood: A festival of obscure syntax: https://github.com/mdbooth/openstack-dev-hacks/commit/1e13942134c298dd27af674fdcaf7a5ac72b1e82 :) | |
| 13:39:17 | johnthetubaguy | pumaranikar: whats the plan for all the other handlers? | |
| 13:40:00 | mdbooth | To top it off, here's how I just called it: ci_log_fetch http://logs.openstack.org/09/395709/6/check/gate-tempest-dsvm-full-devstack-plugin-nfs-nv/f829785/logs/ {c-{api,vol},n-{api,cond,cpu}} | |
| 13:40:03 | pumaranikar | johnthetubaguy, will be addressing in follow up patches | |
| 13:43:46 | johnthetubaguy | pumaranikar: that LOG.error in your handler, did the original bug want that added? | |
| 13:43:59 | tdurakov | pkoniszewski: hi, are you around? | |
| 13:44:37 | pumaranikar | johnthetubaguy, it was not a requirement to add logging here | |
| 13:45:33 | johnthetubaguy | pumaranikar: have you seen this, its worth a read: https://specs.openstack.org/openstack/openstack-specs/specs/log-guidelines.html | |
| 13:47:46 | pkoniszewski | tdurakov: yes | |
| 13:48:26 | lyarwood | mdbooth: nice! | |
| 13:48:36 | tdurakov | pkoniszewski: there are some intersections in my schedule today, could you chair l-m meeting? | |
| 13:48:50 | pkoniszewski | i'm afraid i need to skip the meeting today | |
| 13:48:57 | pkoniszewski | leaving office in 10-15 minutes | |
| 13:49:59 | tdurakov | pkoniszewski: ok | |
| 13:51:40 | pumaranikar | johnthetubaguy, do you think error log level is not appropriate here ? | |
| 13:51:58 | johnthetubaguy | pumaranikar: yeah, added comments | |
| 13:52:02 | tdurakov | mdbooth: hi, are you ok chairing lm meeting today? | |
| 13:52:11 | johnthetubaguy | pumaranikar: "Error: Serious issue with cloud, administrator should be notified immediately via email/pager. On call people expected to respond." | |
| 13:52:25 | mdbooth | tdurakov: Not really, I'm totally not on top of it | |
| 13:52:38 | johnthetubaguy | pumaranikar: sometimes these errors raised by placement are almost expected, like not found error when you check something is deleted, etc | |
| 13:52:42 | mdbooth | tdurakov: If you'd asked me yesterday, maybe :) | |
| 13:53:35 | pumaranikar | johnthetubaguy, yes. I thought of error level logging since it is in exception block | |
| 13:53:43 | tdurakov | paul-carlton2 eliqiao shaohe_feng pkoniszewski yuntongjin kashyap kmartin claudiub tobasco abhishekk mrhillsman raj_singh wznoinsk siva_krishnan, folks, let's skip the l-m meeting this week. | |
| 13:53:59 | johnthetubaguy | pumaranikar: yeah, need to think about the consumer of the message, it doesn't rally help them in this case | |
| 13:54:20 | johnthetubaguy | pumaranikar: but a debug log might be a good idea, if we include information on the specific exception | |
| 13:55:03 | johnthetubaguy | tdurakov: did you see this: https://review.openstack.org/#/c/429798/ | |
| 13:55:14 | johnthetubaguy | tdurakov: trying to get it into RC2, if possible | |
| 13:56:19 | pumaranikar | johnthetubaguy, ok. i will have look at your comment and make change accordingly | |
| 13:56:55 | tdurakov | johnthetubaguy: I'll review it in 1.5 hours, or earlier | |
| 13:57:54 | johnthetubaguy | tdurakov: I was wondering if the folks in the meeting agree if we should try get that into RC2 I guess | |
| 13:59:32 | tdurakov | johnthetubaguy: btw, have you seen this one https://review.openstack.org/#/c/408002 | |
| 14:00:01 | johnthetubaguy | tdurakov: yeah, I need to look at that one again | |
| 14:00:23 | johnthetubaguy | tdurakov: thats a new option though, not suitable past feature freeze, but good for pike | |
| 14:05:59 | markus_z | Is the placement service mandatory? (I'm still living under a rock :/ ) | |
| 14:07:19 | johnthetubaguy | markus_z: it is for ocata | |
| 14:07:39 | johnthetubaguy | markus_z: n-cpu should fail to start if its not configured with the placement URL now | |
| 14:08:32 | markus_z | johnthetubaguy: Hm, I think that's the issue in our s390 CI. We don't start the placement service (because we have an outdated version of devstack-gate). | |
| 14:10:05 | markus_z | johnthetubaguy: Even if it is not the root-cause, good to know that we are behind (again). I have to fix that. | |
| 14:10:28 | markus_z | johnthetubaguy: dammit, yeah, that's it | |
| 14:10:31 | markus_z | Thanks! | |
| 14:10:56 | johnthetubaguy | np | |
| 14:11:17 | openstackgerrit | Trevor McCasland proposed openstack/nova-specs master: Add spec for Accelerating SR-IOV with DPDK https://review.openstack.org/429867 | |
| 14:13:07 | openstackgerrit | John Garbutt proposed openstack/nova master: Default live_migration_progress_timeout to off https://review.openstack.org/429798 | |
| 14:13:20 | openstackgerrit | John Garbutt proposed openstack/nova master: WIP: Remove stuck live-migration detection https://review.openstack.org/430218 | |
| 14:14:28 | openstackgerrit | Pushkar Umaranikar proposed openstack/nova master: Placement api: set custom json_error_formatter in allocations https://review.openstack.org/395194 | |
| 14:16:46 | johnthetubaguy | pumaranikar: thanks | |
| 14:18:42 | pumaranikar | johnthetubaguy, thanks for quick review | |
| 14:25:13 | openstackgerrit | Ed Leafe proposed openstack/nova master: Add check for invalid inventory amounts https://review.openstack.org/428800 | |
| 14:25:14 | openstackgerrit | Ed Leafe proposed openstack/nova master: Add check for invalid allocation amounts https://review.openstack.org/416752 | |
| 14:27:17 | openstackgerrit | Stephen Finucane proposed openstack/nova master: trivial: Standardize indentation of test_vif https://review.openstack.org/430271 | |
| 14:27:17 | openstackgerrit | Stephen Finucane proposed openstack/nova master: conf: Deprecate two more nova-net options https://review.openstack.org/412390 | |
| 14:27:18 | openstackgerrit | Stephen Finucane proposed openstack/nova master: trivial: Standardize naming of variables https://review.openstack.org/430272 | |
| 14:28:21 | openstackgerrit | Silvan Kaiser proposed openstack/nova master: Removes getfattr from Quobyte Nova driver https://review.openstack.org/428646 | |
| 14:38:29 | johnthetubaguy | sfinucan: doesn't allow_same_net_traffic get used by neutron, or do we use a different firewall driver? | |
| 14:38:45 | sfinucan | johnthetubaguy: What's that in context to? | |
| 14:39:53 | sfinucan | johnthetubaguy: I'm pretty sure it's mainly used by nova-network, but libvirt also overloads it for its own firewall | |
| 14:40:10 | johnthetubaguy | sfinucan: https://review.openstack.org/#/c/412390/6/nova/conf/network.py@957 | |
| 14:40:55 | sfinucan | johnthetubaguy: Yeah, so my reply to the first option also stands for the second one | |
| 14:41:16 | sfinucan | We're overloading the value for libvirt's firewall and that option should be either (a) removed altogether or (b) moved to the libvirt group | |
| 14:41:32 | johnthetubaguy | sfinucan: agreed with the first one, but trying to workout what does the neutron firewalling? isn't it using this code too? https://github.com/openstack/nova/blob/d5f113de34589933c23a7cecc25ca0bf5f47207d/nova/virt/libvirt/firewall.py#L165 | |
| 14:42:01 | johnthetubaguy | sfinucan: I think its shared in virt via this one though: https://github.com/openstack/nova/blob/4f91ed3a547965ed96a22520edcfb783e7936e95/nova/virt/firewall.py#L307 | |
| 14:42:18 | johnthetubaguy | sfinucan: I guess the others maybe don't use it for any neutron drivers yet, unsure | |
| 14:43:24 | sfinucan | johnthetubaguy: Hmm, that's a good point | |
| 14:45:23 | sfinucan | johnthetubaguy: If we're reading that right, the comments for 'use_ipv6' are also wrong https://github.com/openstack/nova/blob/d5f113de34589933c23a7cecc25ca0bf5f47207d/nova/virt/libvirt/firewall.py#L158 | |
| 14:45:49 | sfinucan | https://github.com/openstack/nova/blob/d5f113de34589933c23a7cecc25ca0bf5f47207d/nova/conf/netconf.py#L68-L70 | |
| 14:45:53 | johnthetubaguy | sfinucan: yeah, it looks that way | |
| 14:46:26 | sfinucan | grr, whoever thought it was a good idea to reuse nova-net options for neutron deserves a smack | |
| 14:46:27 | sfinucan | :) | |
| 14:51:57 | sfinucan | And use_ipv6 is *also* used for that injected network template (compute.injected_network_template). Ugh... | |
| 15:00:28 | lyarwood | https://review.openstack.org/#/c/427364/ - I'd appreciate reviews on this swap_volume bugfix if any cores have time today. sfinucan, mdbooth's NFS fix now depends on this btw. | |
| 15:02:47 | sfinucan | lyarwood: I'll take a gawk shortly | |
| 15:02:55 | lyarwood | sfinucan: cheers | |
| 15:05:01 | openstackgerrit | Jordan Pittier proposed openstack/nova master: api-ref: document the 'tenant_id' query parameter https://review.openstack.org/430290 | |
| 15:06:15 | lyarwood | hmmmm there's no #openstack-devstack channel, does anyone know if openstack-infra is the best place to ask for devstack reviews? I'm looking for reviews on https://review.openstack.org/#/c/427602/ so our ceph job can pass again... | |
| 15:06:41 | dansmith | lyarwood: -qa | |
| 15:07:01 | lyarwood | dansmith: thanks | |
| 15:20:53 | sfinucan | johnthetubaguy: Out of curiosity, what's the finger in the air estimate for cells v1 going bye bye? | |
| 15:21:00 | sfinucan | ...and, in turn, nova-network | |
| 15:21:05 | openstackgerrit | Christopher Martin proposed openstack/nova master: Stop using mox in test_compute_cells.py https://review.openstack.org/389750 | |
| 15:22:01 | johnthetubaguy | sfinucan: we need to implement the transition code, then let that cook for a release. | |
| 15:22:12 | johnthetubaguy | sfinucan: after we actually support two cells v2 cells | |
| 15:22:30 | johnthetubaguy | sfinucan: so another two or three cycles till we delete, maybe :( | |
| 15:22:41 | sfinucan | ouch | |
| 15:23:04 | johnthetubaguy | sfinucan: looking after our users is expensive | |
| 15:23:14 | sfinucan | johnthetubaguy: aye, and sadly necessary | |
| 15:32:55 | dansmith | sfinucan: but we should only maintain n-net for cellsv1 users with legit bugs I think, not just anyone | |
| 15:34:10 | sfinucan | dansmith: I was hoping for an easy way out of unravelling the nest of conf options that are shared between nova-net and libvirt/Xen/other things | |
| 15:34:25 | sfinucan | namely, wait until nova-net is gone then remove the ones we don't have references for anymore :) | |
| 15:34:29 | dansmith | heh | |
| 15:37:15 | sfinucan | johnthetubaguy: So I'm figuring out what nova-network options /have been/ repurposed and duplicate them in other groups with UPGRADE renos | |
| 15:37:56 | sfinucan | then I'm going to mass migrate all nova-net opts to a single conf file which we can leave to d̶i̶e̶ mature | |
| 15:38:01 | sfinucan | Sound fair? | |
| 15:38:21 | johnthetubaguy | that sounds like a good plan | |
| 15:40:41 | sfinucan | (y) | |
| 15:46:13 | BobBall | johnthetubaguy: Thanks for the review - are you +2 on the revision to https://review.openstack.org/#/c/424428/ or are further changes needed? | |
| 15:52:51 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: handle uninited fields in notification payload https://review.openstack.org/415857 | |
| 16:06:43 | pkholkin | johnthetubaguy: mriedem: jaypipes: baoli | |
| 16:07:15 | pkholkin | oops | |