Posted	Nick	Remark
#openstack-nova - 2017-02-06
18:29:23	johnthetubaguy	cfriesen: does the above description make more sense now ^
18:34:15	mriedem	melwitt: posted some comments/questions in https://review.openstack.org/#/c/427981/
18:35:02	mriedem	owalsh-afk raises a good point about whether or not the hosts are up (compute_nodes entries created) before running discover_hosts
18:38:40	melwitt	mriedem: thanks. it got approved a couple of minutes earlier. I can do a follow up to address your comments. or maybe roll them into my existing follow up that adds the cells v1 steps https://review.openstack.org/#/c/429075
18:39:22	mriedem	i'd leave the cells v1 patch for just cells v1 and handle additional cleanups in a separate change
18:39:41	pkoniszewski	cfriesen: so info.data_remaining is not useful at all, it is not correleted with whole live migration process, but only with a single iteration
18:40:09	pkoniszewski	cfriesen: libvirt would need to expose something like low watermark for the whole process
18:50:52	openstackgerrit	John Garbutt proposed openstack/nova master: Default live_migration_progress_timeout to off https://review.openstack.org/429798
19:08:53	openstackgerrit	Jay Pipes proposed openstack/nova master: placement: RT now adds proper Ironic inventory https://review.openstack.org/404472
19:09:28	openstackgerrit	Jay Pipes proposed openstack/nova master: placement: RT now adds proper Ironic inventory https://review.openstack.org/404472
19:12:43	cfriesen	johnthetubaguy: pkoniszewski: agreed...reviewing latest now. where there earlier discussions about whether to do complete removal in Pike, or do we still need to decide that?
19:12:52	cfriesen	s/where/were
19:43:46	pkoniszewski	cfriesen: i see no point in keeping broken bits
19:44:12	pkoniszewski	and those bits can cause headache to operators
19:48:07	jaypipes	pkoniszewski: ++
21:06:53	openstackgerrit	Trevor McCasland proposed openstack/nova-specs master: Add spec for Accelerating SR-IOV with DPDK https://review.openstack.org/429867
21:08:43	cfriesen	pkoniszewski: are you planning on submitting the removal for Pike? If not, I could take it.
21:15:20	openstackgerrit	Pushkar Umaranikar proposed openstack/nova master: [WIP] Placement api: Add json_error_formatter to defaults https://review.openstack.org/395194
21:18:01	openstackgerrit	Pushkar Umaranikar proposed openstack/nova master: [WIP] Placement api: Add json_error_formatter to defaults https://review.openstack.org/395194
21:21:07	openstackgerrit	Pushkar Umaranikar proposed openstack/nova master: Placement api: Add json_error_formatter to defaults https://review.openstack.org/395194
21:26:05	openstackgerrit	Pushkar Umaranikar proposed openstack/nova master: Placement api: Add json_error_formatter to defaults https://review.openstack.org/395194
22:43:43	openstackgerrit	Dan Smith proposed openstack/nova master: Allow pattern-based substitutions in CellMapping URLs https://review.openstack.org/429910
22:49:07	openstackgerrit	Sivasathurappan Radhakrishnan proposed openstack/nova-specs master: Live Migration of Rescued Instances https://review.openstack.org/429913
22:58:03	openstackgerrit	Dan Smith proposed openstack/nova master: Allow pattern-based substitutions in CellMapping URLs https://review.openstack.org/429910
23:39:40	oomichi	alex_xu: can you take a look at a critical patch: https://review.openstack.org/#/c/410006/ ?
#openstack-nova - 2017-02-07
02:18:40	openstackgerrit	ChangBo Guo(gcb) proposed openstack/nova master: Enable more virt.xenapi tests on Python 3 https://review.openstack.org/414421
02:18:53	openstackgerrit	ChangBo Guo(gcb) proposed openstack/nova master: Skip unit tests for SSL + py3 https://review.openstack.org/426505
02:32:42	openstackgerrit	Huan Xie proposed openstack/nova master: Fix live migrate with XenServer https://review.openstack.org/424428
02:51:05	alex_xu	oomichi: yea, will check that after meeting
03:29:48	openstackgerrit	Vladik Romanovsky proposed openstack/nova master: neutron: retrieve physical netwrok name from a multi-provider network https://review.openstack.org/430026
03:29:51	openstackgerrit	ChangBo Guo(gcb) proposed openstack/nova master: Use min parameter to restrict live-migration config options https://review.openstack.org/323313
04:15:27	openstackgerrit	Emilien Macchi proposed openstack/nova master: DNM - test tripleo without nova api in WSGI/apache https://review.openstack.org/429008
04:55:49	Kevin_Zheng	oomichi: could you check https://review.openstack.org/#/c/403568/ it is also high bug
05:47:40	openstackgerrit	Li Yingjun proposed openstack/nova master: libvirt: Enable custom video vgamem setting https://review.openstack.org/411191
06:57:52	openstackgerrit	MarkMielke proposed openstack/nova master: DiskFilter should only check if sufficient available storage exists, if storage has been requested. https://review.openstack.org/430091
07:13:16	openstackgerrit	Zhenyu Zheng proposed openstack/nova-specs master: WIP add FusionCompute driver https://review.openstack.org/430099
07:16:39	openstackgerrit	Zhenyu Zheng proposed openstack/nova-specs master: WIP add FusionCompute driver https://review.openstack.org/430099
07:59:17	openstackgerrit	Sergey Nikitin proposed openstack/nova-specs master: PCI NUMA Policies https://review.openstack.org/361140
08:41:40	openstackgerrit	melanie witt proposed openstack/nova master: WIP Request zero root disk for boot-from-volume instances https://review.openstack.org/428481
08:41:41	openstackgerrit	melanie witt proposed openstack/nova master: Report zero root disk for boot-from-volume instances https://review.openstack.org/428505
08:53:30	gcb	sfinucan, https://review.openstack.org/#/c/414421/ is ready to merge now.
08:58:04	openstackgerrit	xianming.mao proposed openstack/nova-specs master: Add support for volume online-migrate when backend has RBD https://review.openstack.org/430131
09:08:15	johnthetubaguy	gcb: do we thing those tests are OK now because mox has been removed?
09:09:26	gcb	johnthetubaguy, I don't look too much about mox issue
09:09:41	johnthetubaguy	gcb: how did we prove they don't still randomly fail?
09:11:15	gcb	johnthetubaguy, we discussed this before and get conclusion: enable one each in one week to make sure we can figure out failure reason.
09:12:00	gcb	johnthetubaguy, let me find out the discussion
09:12:37	johnthetubaguy	gcb: yeah, I think I remember that now. It would be good to add that context in the git commit message, so others all know why it was done
09:13:38	gcb	johnthetubaguy, will update it now
09:13:54	johnthetubaguy	gcb: seriously though, we disable them because mox3 was failing randomly, I would rather do the mox conversion before we enabled them
09:16:39	gcb	johnthetubaguy, what's the reason ? mox3 or usage of mox3
09:18:05	johnthetubaguy	gcb: basically mox3 assertions seemed to fail randomly with py3, we never got to the root cause, but we decided to remove all mox from our tests to avoid hitting this issue: https://blueprints.launchpad.net/nova/+spec/remove-mox-pike
09:18:18	johnthetubaguy	gcb: I think sdague might remember the details more
09:18:33	openstackgerrit	xianming.mao proposed openstack/nova-specs master: Add support for volume online-migrate when backend has RBD https://review.openstack.org/430131
09:18:45	johnthetubaguy	gcb: a tiny bit more context is here: https://blueprints.launchpad.net/nova/+spec/remove-mox
09:18:54	gcb	johnthetubaguy, thanks
09:22:13	gcb	johnthetubaguy, make removing mox/mox3 as a community goal ? :)
09:23:13	johnthetubaguy	gcb: possibly, although all the slots are full for pike right now
09:23:47	johnthetubaguy	gcb: not sure how many projects actually use mox, that might be an interesting thing to check (it might just be Nova!)
09:24:57	gcb	johnthetubaguy, http://codesearch.openstack.org/?q=mox3&i=nope&files=&repos= Nova and horizon use a lot of them :)
09:25:14	johnthetubaguy	its probably an age thing
09:25:34	robcresswell	Mox makes us sad :(
09:25:40	robcresswell	(Horizon, that is)
09:26:03	johnthetubaguy	robcresswell: you are not alone in that
09:26:06	gcb	then we can retire mox3 from oslo side
09:26:11	johnthetubaguy	I never like the record/reply pattern
09:27:10	robcresswell	I've just dealt with far too many cryptic failures. Testing with mox should not be *that* much more difficult than writing your actual logic.
09:27:26	openstackgerrit	John Garbutt proposed openstack/nova master: Default live_migration_progress_timeout to off https://review.openstack.org/429798
09:27:34	robcresswell	That said, its generally been "good enough" so we've never actually removed it. There's always been higher priority issues.
09:27:57	gcb	The third party mock module doesn't seem to be maintained anymore, suggest use unittest.mock on Python 3
09:28:38	gcb	I try to use unittest.mock on Python 3 , there is an example https://review.openstack.org/#/c/429196/
09:28:51	sfinucan	gcb: We do that anyway on Python3, no?
09:28:58	sfinucan	...and fall back to mock from pip for Python2.7
09:29:10	sfinucan	(seeing as Python2.7 doesn't have it)
09:29:35	gcb	mock works well for python 2.7, just use unittest.mock on Python 3
09:29:53	johnthetubaguy	gcb: I thought thats what we did, but not 100% sure
09:30:28	johnthetubaguy	gcb: it might be that mock got ahead of the py3 lib at one point, but I don't 100% remember now
09:31:02	gcb	oslotest add this for six in https://github.com/openstack/oslotest/blob/master/oslotest/__init__.py
09:31:35	johnthetubaguy	gcb: ah, so we don't use the standard one, I see now
09:31:42	johnthetubaguy	gcb: yeah, thats worth doing then
09:31:58	gcb	johnthetubaguy, yeah
09:32:25	sfinucan	ah, they're different imports. oops
09:32:34	sfinucan	Yeah, definitely worth doing
09:32:42	sfinucan	though lower than mox->mock :)
09:32:45	johnthetubaguy	gcb: FWIW, its when mock looked like it was getting into python we totally stopped allowing more mox tests
09:32:55	johnthetubaguy	sfinucan
09:32:59	sfinucan	johnthetubaguy: We're ok to go merge stuff again, right?
09:33:01	johnthetubaguy	sfinucan: that was news to me too
09:33:16	sfinucan	i.e. trivial mox->mock stuff
09:33:20	johnthetubaguy	sfinucan: ish, so the limitation is we don't want to make backports too hard, for the next week or so
09:33:31	sfinucan	ah, I'll hold off on those so
09:33:50	sfinucan	lest anyone want to backport tests too
09:36:08	johnthetubaguy	sfinucan: yeah, its worth waiting a week I think
09:36:19	gcb	let me add one item on https://etherpad.openstack.org/p/community-goals later, then we can start to move and set the the target in following cycle
09:37:23	johnthetubaguy	gcb: it feels like part of the prep for py3, so its probably a good stepping stone I guess
09:37:48	johnthetubaguy	gcb: although I honestly think it would be quicker to get the functional tests passing on py3, before we get all the unit tests passing on py3
09:37:56	johnthetubaguy	for Nova that is
09:40:03	gcb	johnthetubaguy, I added gate-nova-tox-db-functional-py35-ubuntu-xenial as non-voting, maybe we can make it votable
09:40:25	johnthetubaguy	gcb: I think that would be a good thing to try
09:41:10	johnthetubaguy	gcb: you can always to a tempest skip list, like we have for cellsv1: https://github.com/openstack/nova/blob/master/devstack/tempest-dsvm-cells-rc

Earlier   Later