Earlier  
Posted Nick Remark
#openstack-nova - 2017-02-05
11:40:27 openstackgerrit Alex Xu proposed openstack/nova master: [POC][placement] Add Trait and TraitList objects https://review.openstack.org/376199
11:40:27 openstackgerrit Alex Xu proposed openstack/nova master: [POC][placement] Add resource provider traits API https://review.openstack.org/376202
15:03:40 openstackgerrit Andreas Jaeger proposed openstack/nova master: Prepare for using standard python tests https://review.openstack.org/429391
15:06:59 openstackgerrit Andreas Jaeger proposed openstack/nova master: Prepare for using standard python tests https://review.openstack.org/429391
15:13:25 openstackgerrit Andreas Jaeger proposed openstack/nova master: Prepare for using standard python tests https://review.openstack.org/429391
21:03:09 openstackgerrit Matt Riedemann proposed openstack/nova master: Handle VolumeBDMIsMultiAttach in os-assisted-volume-snapshots https://review.openstack.org/429413
21:17:02 mriedem mdbooth: lyarwood: any idea what power state a guest needs to be in to perform guest-assisted volume snapshot? active obviously, but not sure about stopped or paused
21:17:36 mriedem looks like the libvirt driver attempts to quiesce the guest first but if that fails it just doesn't quiesce, so i was thinking paused/stopped might work
21:18:38 mriedem https://libvirt.org/formatsnapshot.html makes it sound like active/inactive are both ok
22:01:26 smcginnis mriedem: Stopped should, by its nature, be quiesced. I'd wonder about paused though.
22:01:50 mriedem i only included paused because we allow attaching volumes to a paused guest
22:02:02 mriedem but i don't have a setup to test this stuff out really
22:02:28 mriedem could do it with nfs at some point if i have some time to setup devstack with the nfs snapshots patch
22:02:48 smcginnis mriedem: I guess as long as flushing IO is the last step before pausing it should work. But if it just "freezed" the guest, then there's a chance there's things in flight.
22:03:06 openstack Launchpad bug 1657585 in OpenStack Compute (nova) "HTTP 500 for assisted volume snapshot on shelved instance" [Medium,Triaged] - Assigned to Matt Riedemann (mriedem)
22:03:06 mriedem we don't check instance state at all for this operation right now, so https://bugs.launchpad.net/nova/+bug/1657585 is very obvious
22:03:15 mriedem if the instance is shelved-offloaded then guest-assisted snapshot is a 500
#openstack-nova - 2017-02-06
00:37:26 mikal mriedem: you still around?
01:17:11 openstackgerrit Michael Still proposed openstack/nova master: Update devref with vendordata changes. https://review.openstack.org/429431
01:56:02 openstackgerrit Zhenyu Zheng proposed openstack/nova-specs master: Extend tag length limit to 80 https://review.openstack.org/423112
02:26:22 openstackgerrit Huan Xie proposed openstack/nova master: Fix live migrate with XenServer https://review.openstack.org/424428
02:38:27 openstackgerrit Zhenyu Zheng proposed openstack/nova-specs master: Repropose tag-instance-when-boot https://review.openstack.org/415315
03:39:20 mriedem mikal: sort of
03:39:56 mikal mriedem: I posted a devref update for you, but I'm not really clear on what you think it should cover so I'm not sure it hits the mark
03:40:19 mikal mriedem: https://review.openstack.org/#/c/429431/
03:41:15 mriedem mikal: cool. was just looking for some words on features you added in ocata related to vendordata, like the service user stuff, the config to blow up on spawn, etc
03:41:18 mriedem nothing major
03:41:31 mikal mriedem: why would that be in the devref though and not the user guide?
03:41:38 mriedem i've just been in this mode of documenting some of the related config stuff for these features because we've been doing it with the cells and placement docs too
03:41:40 mikal mriedem: do we now describe all features in the devref?
03:41:46 mriedem mikal: because we don't have a user guide :)
03:41:59 mriedem mikal: the devref gets a lot more current traction yes
03:42:04 mikal mriedem: ok, well I'll do an update when I get out of this mandatory training course
03:42:08 mriedem thanks
03:42:27 mriedem i've found that when we tell people to doc stuff and that means external to nova, it's essentially meaning it's never going to happen
03:43:10 mriedem the nova devref is also indexed in the docs.o.o search so from my pov it's kind of all the same at this point
03:43:48 mikal Ok
03:45:01 openstackgerrit Matt Riedemann proposed openstack/nova master: Handle InstanceInvalidState for os-assisted-volume-snapshots https://review.openstack.org/429476
03:47:15 openstackgerrit Nam Nguyen Hoai proposed openstack/nova master: Use oslo_serialization.base64 to follow OpenStack Python3 https://review.openstack.org/413885
05:46:14 alex_xu Kevin_Zheng: fyi, the reno part of this patch https://review.openstack.org/#/c/421760/ is separated to another patch https://review.openstack.org/#/c/428285/, you just need update the part of api-ref.
05:54:27 openstackgerrit Takashi NATSUME proposed openstack/nova master: api-ref: Fix keypair API parameters https://review.openstack.org/420626
05:54:39 openstackgerrit Takashi NATSUME proposed openstack/nova master: api-ref: Fix deprecated proxy API parameters https://review.openstack.org/416882
05:54:50 openstackgerrit Takashi NATSUME proposed openstack/nova master: api-ref: Fix parameters and examples in aggregate API https://review.openstack.org/425512
05:54:55 openstackgerrit Takashi NATSUME proposed openstack/nova master: Use ListOfIntegersField in oslo.versionedobjects https://review.openstack.org/423912
05:55:00 openstackgerrit Takashi NATSUME proposed openstack/nova master: api-ref: Fix parameters in os-hosts.inc https://review.openstack.org/416444
05:55:11 openstackgerrit Takashi NATSUME proposed openstack/nova master: Refactor a test method including 7 test cases https://review.openstack.org/395436
05:55:52 openstackgerrit Takashi NATSUME proposed openstack/nova master: Refactor a test method including 3 test cases https://review.openstack.org/394738
05:55:58 openstackgerrit Takashi NATSUME proposed openstack/nova master: Fix doc generation warnings https://review.openstack.org/425549
06:04:18 openstackgerrit Takashi NATSUME proposed openstack/python-novaclient master: Microversion 2.42 - Fix tag attribute disappearing https://review.openstack.org/429512
06:07:30 Kevin_Zheng alex_xu: thanks
06:07:38 alex_xu Kevin_Zheng: np
06:08:23 Kevin_Zheng https://review.openstack.org/#/c/403568/ could you review this one if you got time? seems a high priority bug
06:10:26 alex_xu Kevin_Zheng: will check that
06:14:26 openstackgerrit Zhenguo Niu proposed openstack/nova master: Fix breaking out of nested loops https://review.openstack.org/424931
06:23:05 openstackgerrit LIU Yulong proposed openstack/nova-specs master: Reset the instance keypair while rebuilding (spec) https://review.openstack.org/375221
06:23:18 openstackgerrit LIU Yulong proposed openstack/nova master: Enable reset keypair while rebuilding instance https://review.openstack.org/379128
06:24:33 liuyulong alex_xu, ^^, can we move on these patch sets?
06:25:52 alex_xu liuyulong: yes, we can, as Pike is open, just need some reviews on the spec first
06:26:29 liuyulong alex_xu, thanks, :)
06:26:36 alex_xu liuyulong: np :)
06:32:32 openstackgerrit Takashi NATSUME proposed openstack/nova master: Avoid forcing translation on logging calls https://review.openstack.org/413876
06:34:32 liuyulong alex_xu, hi, could you please approve this bp https://blueprints.launchpad.net/nova/+spec/rebuild-keypair-reset on pike cycle?
06:35:15 liuyulong alex_xu, and remove the -2 here https://review.openstack.org/#/c/379128/, : )
06:36:28 alex_xu liuyulong: I will remove -2 after the spec approved. The BP only can be approved after the spec approved
06:36:54 liuyulong alex_xu, got it, thanks.
06:37:16 alex_xu liuyulong: np
06:53:35 openstackgerrit Takashi NATSUME proposed openstack/python-novaclient master: Microversion 2.43 - Enable cold migration with target host https://review.openstack.org/406707
06:57:44 litao alex_xu: I left some comments in my path
06:58:45 alex_xu litao: actually the updated_at you seen in the API isn't the heartbeat timestamp
06:59:30 alex_xu litao: for db driver, the 'last_seen_up' is the field for that https://github.com/openstack/nova/blob/master/nova/servicegroup/drivers/db.py#L60
07:01:03 alex_xu litao: the updated_at's meaning actually changed by this patch https://review.openstack.org/#/c/163060/26
07:03:58 litao alex_xu: I think you meaning is just to decide the status of a service using 'last_seen_up'
07:04:37 litao alex_xu: I meaning the display of 'nova service-list
07:04:44 litao '
07:04:48 alex_xu litao: no, I mean the meanning of 'updated_at' is for that
07:05:23 litao alex_xu: but the output of 'nova service-list' will display the column
07:05:35 litao alex_xu: updated_at
07:06:11 alex_xu litao: yes, 'updated_at' means 'the timestamp when db record of service updated'
07:07:18 litao so i think the value should be updated regardless of db or mc driver
07:08:46 litao alex_xu: If it retains for a long time not to update, it will give us a doubt that is the service really up?
07:09:14 alex_xu litao: the patch https://review.openstack.org/#/c/163060/ separate the db record update time and the heartbeat update time. After that patch 'updated_at' means db record time. Maybe we can have another field for heartbeat timestamp, but i'm not sure
07:09:39 alex_xu litao: yes, but
07:09:51 alex_xu 'updated_at' isn't for determine whether the service is up
07:10:54 alex_xu 'last_seen_at' and your change for mc is for determine that, but that isn't expose in the API
07:11:27 litao alex_xu: but i think it should be same as db drvier to be updated since it presents to us
07:11:59 litao alex_xu: or remove it when using mc driver
07:12:01 alex_xu litao: db driver didn't update 'updated_at' also
07:13:03 litao alex_xu: it does
07:13:12 alex_xu litao: there is field 'State' for determine whether service is up, why you need to lookup another timestamp?
07:14:05 litao alex_xu: I mean that it just a display, not to determine the state of a service
07:15:12 litao alex_xu: I just want to display the same output of 'nova service-list' when using mc driver
07:20:10 alex_xu litao: emm...I see now, it will update. sorry, I missed that. But it still didn't equal to the your change for the mc driver I think
07:21:10 alex_xu litao: for db driver, 'updated_at' mixes db record update and heartbeat update.
07:24:36 litao alex_xu: yes, so what do you think to deal it?
07:24:46 alex_xu litao: I just comment on the patch
07:58:35 openstackgerrit Sergey Nikitin proposed openstack/nova-specs master: PCI NUMA Policies https://review.openstack.org/361140
08:23:52 openstackgerrit Zhenyu Zheng proposed openstack/nova-specs master: Repropose tag-instance-when-boot https://review.openstack.org/415315
08:44:32 openstackgerrit Zhenyu Zheng proposed openstack/nova-specs master: Send out notifications when instance tags chaned https://review.openstack.org/429569
08:53:03 openstackgerrit Zhenyu Zheng proposed openstack/nova-specs master: Extend tag length limit to 80 https://review.openstack.org/423112
09:01:34 litao alex_xu: thanks

Earlier   Later