| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2017-02-03 | |||
| 00:00:27 | dansmith | yeah, gotta do it, or change a bunch of RT code | |
| 00:00:30 | mriedem | edleafe: what do you mean to get safe_connect? | |
| 00:00:35 | mriedem | that's already in the report client | |
| 00:00:36 | dansmith | it's just -> :/ | |
| 00:00:42 | melwitt | yeah | |
| 00:01:02 | mriedem | edleafe: if you're rebasing on https://review.openstack.org/#/c/404472/ then your fixes are effectively not making ocata | |
| 00:01:28 | edleafe | mriedem: hmmm... for some reason I thought we added it in that patch | |
| 00:01:37 | edleafe | mriedem: let me un-rebase it | |
| 00:02:06 | gmann | mriedem: oh, that huge list is really difficult tasks always :) | |
| 00:02:22 | mriedem | gmann: yeah i compared it one by one with the schema validation code | |
| 00:02:30 | mriedem | and now my eyes are bleeding | |
| 00:02:38 | gmann | mriedem: also we should mention internal attributes also along with joined table | |
| 00:03:14 | gmann | i am going to do "find and search" each one | |
| 00:03:34 | mriedem | gmann: these? https://github.com/openstack/nova/blob/c90acdbc55b743666baa9ef82c56a8e85475f739/nova/api/openstack/compute/schemas/servers.py#L280 | |
| 00:03:51 | mriedem | the joined table ones are a 400 error, ^ are just ignored | |
| 00:03:57 | gmann | no | |
| 00:03:58 | gmann | https://github.com/openstack/nova/blob/c90acdbc55b743666baa9ef82c56a8e85475f739/nova/api/openstack/compute/schemas/servers.py#L365 | |
| 00:04:26 | gmann | ignore for sort only but we changed 500 -> 400 in filter and same foe _* | |
| 00:04:35 | gmann | for | |
| 00:05:23 | mriedem | gmann: so mention anything with ^_.* in with this list https://review.openstack.org/#/c/428285/2/releasenotes/notes/add-whitelist-for-server-list-filter-sort-params-2ae766d03ba895e5.yaml@103 ? | |
| 00:05:30 | mriedem | gmann: i'm not going to actually go and hunt those down | |
| 00:05:37 | gmann | https://github.com/openstack/nova/blob/c90acdbc55b743666baa9ef82c56a8e85475f739/nova/api/openstack/compute/servers.py#L234 | |
| 00:05:49 | mriedem | i could just say, joined tables or internal data model attributes | |
| 00:06:03 | gmann | yea that is enough | |
| 00:06:13 | mriedem | ok | |
| 00:13:30 | mriedem | edleafe: i was wondering if that delete RP fix was a blocker but then i remembered again that ironic basically can't schedule if you're all upgraded and have one of those things lying around | |
| 00:13:34 | mriedem | so yeah i guess it's a blocker | |
| 00:14:33 | edleafe | mriedem:yeah, pretty much | |
| 00:14:53 | edleafe | mriedem: running tests locally on the un-rebased change | |
| 00:16:36 | mriedem | ok | |
| 00:16:50 | mriedem | i've gone through and marked everything with rc1, rc2 or defer https://etherpad.openstack.org/p/nova-ocata-rc1-todos | |
| 00:16:55 | mriedem | dansmith: melwitt: jaypipes: ^ | |
| 00:16:59 | jroll | can't schedule? or may schedule to a thing that doesn't exist | |
| 00:17:07 | mriedem | schedule to a thing that blows up | |
| 00:17:12 | jroll | right | |
| 00:17:42 | jroll | a build failing here and there isn't the worst thing that could happen | |
| 00:17:48 | mriedem | i don't know how to talk about scheduling to ironic compute nodes when the nodes are deleted | |
| 00:17:53 | mriedem | or they are hosts, or wtf they are | |
| 00:17:54 | mriedem | it's ironic | |
| 00:18:02 | jroll | and how often to people actually delete machines from ironic | |
| 00:18:04 | jroll | s/to/do/ | |
| 00:18:05 | mriedem | jroll: does it retry in this case? | |
| 00:18:19 | jroll | mriedem: dunno, I didn't reproduce, I'm guessing not | |
| 00:18:56 | jroll | I guess I'm just thinking as long as this gets in rc2, it isn't a big deal if it's in rc1 | |
| 00:18:58 | jroll | I could be wrong ofc | |
| 00:19:30 | mriedem | jroll: i think it will reschedule https://github.com/openstack/nova/blob/master/nova/compute/manager.py#L2015 | |
| 00:20:18 | jroll | mriedem: maaaybe, that's a lot of except blocks | |
| 00:20:21 | mriedem | yeah we call spawn here https://github.com/openstack/nova/blob/master/nova/compute/manager.py#L1927 | |
| 00:20:27 | mriedem | ironicclient returns node not found | |
| 00:20:36 | mriedem | which gets handled here https://github.com/openstack/nova/blob/master/nova/compute/manager.py#L2008 | |
| 00:21:06 | jroll | huh, I swear it said something about not rescheduling in the bug | |
| 00:21:08 | jroll | I could be drunk | |
| 00:21:24 | mriedem | he said it didn't cleanup in a periodic run | |
| 00:21:29 | mriedem | but i could also be drunk | |
| 00:21:36 | jroll | yeah I guess not | |
| 00:22:06 | jroll | I think it's fine | |
| 00:22:15 | openstackgerrit | melanie witt proposed openstack/nova master: WIP Add functional test for boot-from-volume instances https://review.openstack.org/428505 | |
| 00:23:09 | melwitt | dansmith: ^ I put the RT change into there for testing. the instance create works but then fails the resize bc it's requesting disk | |
| 00:23:57 | dansmith | yeah was just looking at it | |
| 00:24:09 | dansmith | I've got a little bit more time and then I'm really out | |
| 00:24:15 | dansmith | mriedem: when do you cut the tag? | |
| 00:26:14 | openstackgerrit | Ed Leafe proposed openstack/nova master: Delete a compute node's resource provider when node is deleted https://review.openstack.org/428375 | |
| 00:26:29 | edleafe | mriedem: ^^ un-rebased | |
| 00:28:13 | melwitt | dansmith: it doesn't look like mriedem put it on the RC1 things etherpad. maybe we could hope for RC2? since other stuff is slated for it also anyway | |
| 00:28:32 | dansmith | melwitt: I wasn't asking for this, I assume this isn't going to make it | |
| 00:28:38 | edleafe | jroll: and while this was noticed by ironic, it aaplies to any compute node | |
| 00:28:45 | melwitt | dansmith: oh, okay. yeah | |
| 00:28:51 | jroll | edleafe: damnit I have draft comments | |
| 00:28:56 | dansmith | melwitt: until your claim thing, I was going to say it looked pretty backportable, but.. | |
| 00:29:32 | edleafe | jroll: gerrit needs a "move to latest PS" button | |
| 00:29:51 | jroll | or a "don't let someone update this patch for a sec" button | |
| 00:29:53 | jroll | :P | |
| 00:30:32 | melwitt | dansmith: yeah. it would still be technically, no db messings up. assuming that legacy request spec doesn't ever get saved anywhere but if it did, that would be a problem anyway | |
| 00:31:04 | edleafe | Ah, I don't mind commenting on a stale patch. I really hate it when I write these deep comments, and then find that someone beat me to it, and mine sound like "me too" | |
| 00:31:06 | dansmith | melwitt: but the scheduler would start sending instances to computes without knowing if they would agree to not count root_gb, if you updated scheduler first | |
| 00:31:28 | dansmith | melwitt: so no architectural blocks, but still probably not free of bumbs | |
| 00:31:32 | dansmith | er, bumps heh :) | |
| 00:31:57 | melwitt | oh, hm | |
| 00:32:13 | jroll | edleafe: yeah, I'm kidding :) | |
| 00:32:16 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Add release note for filter/sort whitelist https://review.openstack.org/428285 | |
| 00:32:16 | dansmith | I'm projecting a little of our OSP backport rules here, but still | |
| 00:32:34 | jroll | edleafe: I'm investigating that big comment to be sure, but have a few there for you | |
| 00:32:35 | edleafe | jroll: heh, but I'm not :) | |
| 00:32:39 | mriedem | laura kicked my ass into eating dinner with her so i'll be back in a bit | |
| 00:32:45 | mriedem | and all questions will be answered | |
| 00:33:40 | melwitt | dansmith: yeah. it takes me awhile to understand the backport implications to upgrades | |
| 00:33:53 | dims_ | mriedem : better listen to her :) | |
| 00:34:15 | dansmith | melwitt: wish you had brought this up earlier, but the actual patch for this request to the scheduler took like four weeks longer than expected, so :? | |
| 00:34:18 | dansmith | er -> :/ | |
| 00:34:58 | edleafe | jroll: doh! Yeah, the way that the merge conflicts were marked in git didn't help | |
| 00:35:08 | edleafe | cleaning that up now | |
| 00:35:15 | jroll | edleafe: yeah no worries | |
| 00:35:26 | jroll | the main problem is the get_by_host thing | |
| 00:35:38 | jroll | I think it should likely be get_by_host_and_node | |
| 00:36:03 | melwitt | dansmith: yeah, I should have been paying more attention to that. I didn't know whether the bfv thing was planned to be handled this cycle. and cells v2 madness occurred, yadayada | |
| 00:39:36 | dansmith | melwitt: yeah | |
| 00:40:19 | edleafe | jroll: the get_by_host_and_node makes sense. I was using what jaypipes suggested, but I think he typed that off the top of his head. | |
| 00:41:05 | jroll | edleafe: the host/node thing is weird when you aren't an ironic person :) | |
| 00:41:45 | edleafe | jroll: and I thought it was always weird | |
| 00:41:54 | dansmith | edleafe: and you would be right | |