Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2017-01-31
20:14:34 mriedem dansmith: melwitt: ^
20:14:35 mordred mriedem: ++
20:14:50 mordred jeblair: OOOOHHHHHH - we install nodepool as a devstack plugin - we do not install it during the post_test_hook
20:14:52 mriedem i'll push something up to test that out
20:15:11 jeblair mordred: aha, of course. :)
20:15:26 mriedem mordred: it's always good when it's the users fault :)
20:15:50 mordred mriedem: :)
20:16:01 mordred mriedem: although I vote for moving the cells call way further up too
20:16:09 mriedem yeah i can still tinker on that
20:16:20 sdague mordred: yeh, the post_test_hook should give you a better guaruntee of where you want to be
20:16:36 sdague you only need to move your start there, right?
20:16:37 mordred sdague: ++
20:16:57 sdague all the install / configure can happen earlier I would think
20:17:31 sdague the post_test_hook is kind of recent, because ironic needed to ensure they could do a thing after tempest was installed and configured
20:18:01 mordred well, we're already using post_test_hook too
20:18:07 sdague mordred: oh, interesting
20:18:08 mordred so I think we just need to consolidate a bit
20:18:24 mtreinish sdague: I thought post_test_hook was the d-g for running things after testing is done?
20:18:51 sdague mtreinish: oh, sorry, there is a new devstack plugin phase
20:18:53 sdague one sec
20:19:04 mtreinish I thought I called the plugin phase test-config or something like that
20:19:12 sdague yeh, that
20:19:13 mordred I may need/want that - because we're using devstack functions like crazy
20:19:29 mordred so I make a test_config_nodepool function?
20:19:33 mordred to use that phase?
20:19:46 sdague mordred: yeh, test-config
20:20:00 sdague mordred: so change https://github.com/openstack-infra/nodepool/blob/12d3caf560aa827ed47f320259cdb66a20f1e24b/devstack/plugin.sh#L465-L469
20:20:05 sdague s/extra/test-config/
20:20:14 mordred cool. thank you! that'll be super helpful
20:20:39 sdague that executes here in stack.sh - https://github.com/openstack-dev/devstack/blob/e6f8dbb55fc8fccb18f4ccb5ed5723a2efc3b025/stack.sh#L1401
20:22:32 mriedem mordred: sdague: here is the devstack change https://review.openstack.org/427392
20:23:17 mordred mriedem: I tell you what - we can get some code written aroud here
20:23:28 mriedem just not reviewed or merged :)
20:23:30 mriedem hi-o!
20:24:30 mordred :)
20:24:44 mordred I've been trying to land a shade patch since last tuesday
20:24:59 mordred I'm going to get it landed today if I have to write and land a patch to every repo in openstack
20:27:14 openstackgerrit melanie witt proposed openstack/nova: Read instances from API cell for cells v1 https://review.openstack.org/427394
20:27:27 mtreinish mordred: don't you have ninja merge powers...
20:28:17 mordred mtreinish: don't tempt me
20:29:51 melwitt dansmith: ^ see if that's what you expect for the cells v1 get_all
20:30:38 openstackgerrit Eric Fried proposed openstack/nova: Introduce base PowerVM driver (disk drv) https://review.openstack.org/409401
20:46:03 mriedem melwitt: lgtm for the most part - would be nice to have a comment in there about the conditional
20:46:06 mriedem like we have in _get_instance
20:46:19 cdent we collided a bit on that
20:46:21 melwitt mriedem: yeah, adding now
20:46:30 melwitt I saw cdent's comment
20:46:58 mriedem i had to pull it down to make sure the else condition was being hit in tests
20:47:12 mriedem since the compute api unit tests are confusing with the cells v1 and non-cells v1 stuff
20:49:43 dansmith melwitt: effectively, yeah
20:51:16 openstackgerrit melanie witt proposed openstack/nova: Read instances from API cell for cells v1 https://review.openstack.org/427394
20:53:02 mriedem +2
20:53:31 openstackgerrit Anusha Unnam proposed openstack/nova: Add post hook script to run tempest with old n-api https://review.openstack.org/401395
20:54:19 openstackgerrit Eric Fried proposed openstack/nova: Introduce base PowerVM driver https://review.openstack.org/391288
20:55:55 openstackgerrit Eric Fried proposed openstack/nova: PowerVM Driver: power_on/off and reboot https://review.openstack.org/427380
20:56:31 mriedem oomichi: you were +2 before https://review.openstack.org/#/c/422171/ want to get that one now?
20:56:53 openstackgerrit Eric Fried proposed openstack/nova: Introduce base PowerVM driver (disk drv) https://review.openstack.org/409401
21:02:54 openstackgerrit Matt Riedemann proposed openstack/nova: doc: add some detail to the map_cell0 man page https://review.openstack.org/427450
21:02:58 mriedem diana_clarke: ^ addresses something i noted in your map_cell0 man page change after it was approved
21:04:06 openstackgerrit Eric Fried proposed openstack/nova: PowerVM Driver: spawn/destroy https://review.openstack.org/391288
21:06:27 openstackgerrit Eric Fried proposed openstack/nova: PowerVM Driver: power_on/off and reboot https://review.openstack.org/427380
21:07:18 openstackgerrit Eric Fried proposed openstack/nova: Introduce base PowerVM driver (disk drv) https://review.openstack.org/409401
21:16:20 openstackgerrit Scott DAngelo proposed openstack/nova: WIP Support cinder v3 API https://review.openstack.org/420201
21:17:45 mriedem browne: so looking at when the newton version aliases were made, that happened in ocata https://review.openstack.org/#/c/386625/
21:18:03 mriedem browne: which leads me to believe we should wait to do https://review.openstack.org/#/c/425958/ in pike
21:18:10 mriedem dansmith: is that right? or does it not matter? ^
21:19:46 browne mriedem: ok, so maybe it can wait
21:20:22 mriedem ooo i found the checklist https://wiki.openstack.org/wiki/Nova/ReleaseChecklist
21:21:35 openstackgerrit Chris Dent proposed openstack/nova: Optional separate database for placement API https://review.openstack.org/362766
21:21:58 cdent omg, "scheduler calling the placement api" just merged.
21:22:07 bauzas indeed
21:22:15 mriedem i thought it was getting bumped again
21:22:17 bauzas back from the cave
21:22:54 bauzas mriedem: you okay if I'm just providing a new revision for the reno branch ?
21:23:13 mriedem bauzas: yes
21:23:19 bauzas k
21:23:20 dansmith mriedem: we need to add the aliases once know it's never going to change for a release, which usually means "after the release"
21:23:58 browne ah ok
21:25:14 cdent mriedem: I'm done for the day, but can I assume that https://etherpad.openstack.org/p/nova-ocata-rc1-todos is still the place to go tomorrow morning for things, like, to do?
21:25:46 mriedem cdent: yup
21:25:49 mriedem good progress today
21:25:51 cdent cool
21:25:58 cdent goodnight everybody
21:28:22 mriedem dansmith: https://wiki.openstack.org/wiki/Nova/ReleaseChecklist#Pre-release_Checklist is a bit confusing since it says "Ideally add the RPC version alias just before opening the next release"
21:28:29 mriedem i guess ideally is, well, ideal
21:28:30 mriedem but optional
21:28:31 kencjohnston Where would I find the name of Nova's default read-only role, if there is one?
21:28:35 dansmith mriedem: right
21:33:08 openstackgerrit Matt Riedemann proposed openstack/nova: doc: refer to the cell_v2 man pages from the cells v2 doc https://review.openstack.org/427459
21:33:09 openstackgerrit Matt Riedemann proposed openstack/nova: doc: update the man page entry for nova-manage db sync https://review.openstack.org/427460
21:51:01 openstackgerrit Sylvain Bauza proposed openstack/nova: Add release note for nova-status upgrade check CLI https://review.openstack.org/426911
21:51:01 openstackgerrit Sylvain Bauza proposed openstack/nova: Collected release notes for Ocata CellsV2 https://review.openstack.org/424737
21:51:02 openstackgerrit Sylvain Bauza proposed openstack/nova: Add prelude section for Ocata https://review.openstack.org/426864
22:15:32 sfinucan mriedem: Bit late, but ':doc:/<path>' is relative to root
22:15:59 sfinucan re: mriedem> sfinucan: do you know the ReST magic to find the root of a doc tree? for a link
22:16:11 mriedem sfinucan: not too late yet
22:16:12 mriedem thanks
22:19:21 openstackgerrit Eric Fried proposed openstack/nova: PowerVM Driver: localdisk https://review.openstack.org/409401
22:26:37 openstackgerrit Eric Fried proposed openstack/nova: PowerVM Driver: console https://review.openstack.org/409402
22:26:52 openstackgerrit Eric Fried proposed openstack/nova: Introduce base PowerVM driver (cfg drv) https://review.openstack.org/409404

Earlier   Later