| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2017-01-26 | |||
| 18:10:21 | bauzas | andreykurilin: oh, it's missing another +2/+W | |
| 18:10:52 | melwitt | johnthetubaguy: I had been thinking it's good to not reflect the usage until it's really actually used. but, that opens the window for things to get past and go over quota when confirm happens later | |
| 18:10:53 | bauzas | andreykurilin: when are you planning to deliver a new revision ? | |
| 18:11:09 | openstackgerrit | Eric Fried proposed openstack/nova: Introduce base PowerVM driver (console) https://review.openstack.org/409402 | |
| 18:11:21 | openstackgerrit | Eric Fried proposed openstack/nova: Introduce base PowerVM driver (cfg drv) https://review.openstack.org/409404 | |
| 18:11:41 | bauzas | andreykurilin: oh, you're saying all johnthetubaguy's comments can be addressed in a follow-up | |
| 18:11:42 | andreykurilin | mriedem bauzas : let's release novaclient without merging fix for token+cli. It was broken for a year, so it looks like this feature is not in demand, but we need to release new version of novaclient now to release all warning messages which were introduced in 7.0.0 + we need full keystone v3 support | |
| 18:12:29 | bauzas | andreykurilin: the token thing is fixed, that's just the CLI which is not yet fixed, right? | |
| 18:12:45 | bauzas | andreykurilin: unless I'm wrong | |
| 18:13:00 | andreykurilin | bauzas: yes. Token with via python novaclient's API is fixed | |
| 18:13:08 | andreykurilin | *Token auth | |
| 18:13:31 | bauzas | andreykurilin: could you then split your CLI change and just leave the reno file in a separate change ? | |
| 18:13:37 | melwitt | johnthetubaguy: yeah, that would not be great to have to consider pending resize. I wonder if it could be as simple as checking count and quota in the confirm too. and if you are late with your confirm, you may not get to confirm it and have to revert | |
| 18:13:45 | bauzas | andreykurilin: I'd like to include that note for the 7.1.0 release notes | |
| 18:14:00 | bauzas | andreykurilin: and I feel brave enough for a single +2/+W | |
| 18:14:07 | melwitt | but I guess that's not a good experience | |
| 18:14:10 | andreykurilin | bauzas: sorry, I'm not near PC now:( | |
| 18:14:37 | bauzas | andreykurilin: okay, lemme do that then | |
| 18:15:00 | andreykurilin | bauzas Ok, it looks like I'll able to do it in 10-15 mini | |
| 18:15:06 | andreykurilin | *minutes | |
| 18:15:11 | openstackgerrit | Dirk Mueller proposed openstack/nova: [WIP] Handle boot_index in block_device_info also for volumes https://review.openstack.org/425813 | |
| 18:15:14 | bauzas | andreykurilin: I'll need to bail out for 1.5 hours | |
| 18:15:14 | johnthetubaguy | melwitt: I did wonder about that, it just feels like you could do loads of resizes to use too much quota, and just not bother doing and confirms so you get to keep the extra big instances | |
| 18:15:26 | bauzas | andreykurilin: so it's up to you, your call | |
| 18:15:35 | melwitt | johnthetubaguy: oh, heh. yeah | |
| 18:15:36 | johnthetubaguy | melwitt: we do have auto resize confirm to protect against that, but I duno, seems funky | |
| 18:15:44 | andreykurilin | bauzas: oh.. we need to propose a release as soon as possible | |
| 18:15:46 | bauzas | andreykurilin: if you can split that, I can +2 and ask another core to quickly +W the reno change only | |
| 18:16:10 | openstackgerrit | Ed Leafe proposed openstack/nova: placement: RT now adds proper Ironic inventory https://review.openstack.org/404472 | |
| 18:16:12 | bauzas | andreykurilin: I know, but I don't want to ship a release without the proper release note | |
| 18:16:13 | johnthetubaguy | melwitt: I should probably worry that that attack is the first thing that pops into my head! | |
| 18:16:29 | edleafe | jaypipes_: ^^ should fix mriedem's concerns | |
| 18:16:29 | bauzas | and we can still tag the release in the next hours | |
| 18:16:51 | bauzas | there is no rush, the deadline can be very late PST | |
| 18:17:00 | andreykurilin | bauzas maybe johnthetubaguy can find a bit of time to review my answers to his comments? | |
| 18:17:11 | melwitt | johnthetubaguy: haha :) well, it's good you're thinking of those cases | |
| 18:17:12 | bauzas | ask him :) | |
| 18:17:17 | andreykurilin | bauzas g-r will be closed in an hour I think | |
| 18:17:25 | bauzas | what I want is at least the reno file | |
| 18:17:39 | johnthetubaguy | andreykurilin: I just don't understand that keychain stuff, and haven't had chance to read into it :( | |
| 18:17:52 | bauzas | okay, too risky then | |
| 18:17:59 | bauzas | let's just merge the reno file | |
| 18:18:03 | johnthetubaguy | andreykurilin: once you delete that code, I can't see that class being used anywhere | |
| 18:18:30 | johnthetubaguy | so we can always do a stable branch backport for this one | |
| 18:18:34 | johnthetubaguy | for the CLI users | |
| 18:18:55 | melwitt | johnthetubaguy: so on the race prevention thing, you were just thinking of checking the limit twice? once before object create and once after? | |
| 18:19:09 | johnthetubaguy | melwitt: yeah, I mean thats racey, but in a quota goes low sense | |
| 18:19:19 | melwitt | I guess you'd have to redo the count too | |
| 18:19:21 | melwitt | yeah | |
| 18:20:34 | johnthetubaguy | melwitt: yeah | |
| 18:20:57 | johnthetubaguy | melwitt: its just easier to reason about the correctness | |
| 18:21:17 | melwitt | yeah | |
| 18:22:43 | melwitt | that's actually a painfully easy fix for a bug we have open where someone was able to create 100+ more keypairs than the quota | |
| 18:23:24 | melwitt | well, I guess there's still a window there so I dunno how much it would lessen it | |
| 18:24:43 | andreykurilin | ok, I'm near PC | |
| 18:24:58 | johnthetubaguy | melwitt: I think it would mean we would delete too many though, I could be wrong | |
| 18:25:49 | melwitt | cool, thanks for all the comments on the review | |
| 18:26:33 | andreykurilin | johnthetubaguy SecretHelper is used at L851 - https://review.openstack.org/#/c/424256/10/novaclient/shell.py . It check args and if password is not there it create "prompt" | |
| 18:26:54 | andreykurilin | let's do it in Pike... | |
| 18:27:00 | bauzas | andreykurilin: I need to bail out, but I leave you do the change and ping one of us for single-approving the reno change | |
| 18:27:10 | openstackgerrit | Sergey Nikitin proposed openstack/nova: Standardization of VM diagnostics info API. https://review.openstack.org/355540 | |
| 18:27:10 | openstackgerrit | Sergey Nikitin proposed openstack/nova: Change parent of diagnostics objects to NovaObject class https://review.openstack.org/394480 | |
| 18:27:11 | andreykurilin | bauzas: I need a minute | |
| 18:27:12 | bauzas | andreykurilin: just tell the other core that I'm +2 | |
| 18:27:12 | openstackgerrit | Sergey Nikitin proposed openstack/nova: Completed implementation of instance diagnostics for Xen https://review.openstack.org/399613 | |
| 18:27:27 | bauzas | andreykurilin: we need the patch to be merged because we can tag the release | |
| 18:27:31 | bauzas | before* | |
| 18:27:42 | bauzas | andreykurilin: as I need the SHA1 of the merge commit | |
| 18:27:48 | snikitin | sfinucan, johnthetubaguy: Hi guys! I fixed your nits in diagnoistics. Could you please look? https://review.openstack.org/#/c/394480/ | |
| 18:28:04 | cdent | bauzas: i'm around for the next three hours, anything in partivular i should watching? | |
| 18:28:24 | bauzas | cdent: I think we addressed most of the concerns | |
| 18:28:31 | openstackgerrit | Andrey Kurilin proposed openstack/python-novaclient: Add release not for fixing token auth method https://review.openstack.org/425822 | |
| 18:28:38 | bauzas | cdent: the scheduler series is in good path, we're waiting for CI results | |
| 18:28:48 | andreykurilin | bauzas: you can add Depends-On | |
| 18:28:49 | cdent | awesome | |
| 18:29:07 | andreykurilin | bauzas: https://review.openstack.org/#/c/425822/1 | |
| 18:29:09 | bauzas | cdent: dansmith had a good valid point about how we should cache the min version | |
| 18:31:27 | bauzas | andreykurilin: fast-approved | |
| 18:31:53 | andreykurilin | bauzas: thanks | |
| 18:32:12 | bauzas | andreykurilin: I can't add a Depends-On as I wouldn't know the SHA1 | |
| 18:32:35 | bauzas | that's not a change-id that I need to provide | |
| 18:32:55 | andreykurilin | bauzas: why? you can use SHA1 from my commit and do not wait for merge-commit. I think it worked before | |
| 18:33:15 | bauzas | andreykurilin: because I'm not sure we won't get a merge commit | |
| 18:33:20 | andreykurilin | heh | |
| 18:33:48 | andreykurilin | ok, np. It looks like requirements team is ok to wait a bit:) | |
| 18:34:00 | bauzas | if I'm tagging based on your patch SHA1, then it would cut the release based on your local branch, not gerrit's | |
| 18:38:24 | bauzas | andreykurilin: we now support 2.41 ? | |
| 18:38:46 | bauzas | just writing release highlights | |
| 18:39:34 | andreykurilin | bauzas: Human beings have dreams. Even dogs have dreams, but not gerrit, gerrit is just a program. An imitation of life. Can a program write a symphony? Can a program turn a... canvas into a beautiful masterpiece?... My local branch is better that gerrit's one. lol | |
| 18:40:15 | andreykurilin | bauzas: yes, 2.41 is latest supported api version | |
| 18:40:37 | bauzas | andreykurilin: okay, so it's confirmed, I can't use your SHA1 | |
| 18:40:44 | bauzas | andreykurilin: http://git.openstack.org/cgit/openstack/python-novaclient/log/ | |
| 18:41:02 | bauzas | andreykurilin: compared to https://review.openstack.org/#/c/425822/1//COMMIT_MSG@1 | |
| 18:41:15 | bauzas | andreykurilin: your parent patch is not HEAD | |
| 18:41:44 | andreykurilin | bauzas: It can be fixed easily by pushing "Rebase" button via gerrit | |
| 18:42:00 | bauzas | don't | |
| 18:42:13 | bauzas | leave the patch be merged and I'll pick the merge commit sha1 | |
| 18:42:19 | andreykurilin | np :) | |
| 18:44:41 | bauzas | andreykurilin: FYI https://review.openstack.org/#/c/425827/ | |
| 18:44:57 | bauzas | andreykurilin: it's pointing on the current HEAD | |