Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2017-01-26
17:28:01 melwitt johnthetubaguy: it could. I wasn't opinionated about it. I feel like there might be an example of a count on an existing list object already
17:28:39 johnthetubaguy melwitt: I could see arguments both ways I guess
17:29:38 mriedem vladikr: similar in https://review.openstack.org/#/c/405951/
17:29:54 mriedem vladikr: basically, we're doing the same stuff in both the metadata api code as in the libvirt driver,
17:30:14 mriedem vladikr: i'm not sure why we don't just store the vlan on the NetworkInterfaceMetadata object in the libvirt driver, like the tag,
17:30:18 mriedem and then use that in the metadata api
17:30:52 melwitt johnthetubaguy: yeah. I just did a quick grep and didn't find an existing example of a count. so I think I just guessed :P
17:31:28 melwitt there's the InstanceGroup.count_members_by_user but it counts members for a single group so that makes sense
17:31:32 vladikr mriedem, yes, in the first patch we need to determine which vifs to include in the list of device that the metadata will receive and then in the second patch we will create the metadata only for those device that has a vlan or a tag
17:31:38 vladikr mriedem, https://review.openstack.org/#/c/405951/13/nova/api/metadata/base.py@428
17:36:52 mriedem vladikr: yeah but we build that list twice
17:36:59 mriedem when we already know it in the libvirt driver,
17:37:08 mriedem and could store the vlan on the same object that has the tag
17:37:39 mriedem dansmith: bauzas: johnthetubaguy: i'm heading out for a few hours,
17:37:51 mriedem just a reminder on https://review.openstack.org/#/c/424256/ so we can release novaclient 7.1.0
17:38:34 bauzas mriedem: want me to tag the release btw. ?
17:38:49 vladikr mriedem, yes, that's what the previous iteration of the code was doing
17:39:03 openstackgerrit Sylvain Bauza proposed openstack/nova: Fix server group functional test by using all filters https://review.openstack.org/425185
17:39:03 openstackgerrit Sylvain Bauza proposed openstack/nova: Scheduler calling the Placement API https://review.openstack.org/417961
17:39:04 openstackgerrit Sylvain Bauza proposed openstack/nova: Block starting compute unless placement conf is provided https://review.openstack.org/425806
17:39:20 vladikr mriedem, I'll look at it again
17:39:23 mriedem bauzas: i'll be back around this afternoon to do that assuming we get the other things merged
17:39:35 bauzas dansmith: mriedem: the branch is now up ^
17:40:13 bauzas mriedem: okay, I'll have to bail out by around 11pm UTC because I have to wake up early tomorrow
17:40:21 bauzas mriedem: ie. midnight my time
17:40:32 bauzas not sure which TZ you're in
17:40:44 mriedem bauzas: GMT
17:40:52 bauzas mriedem: I need to go back and forth tomorrow to Patis
17:40:56 bauzas Paris even
17:40:58 mriedem bauzas: i'm asking about the o-3 timeline + FF in the release channel too
17:41:03 bauzas so mostly on train during the day
17:41:55 bauzas mriedem: oh f*** I tought I was following
17:42:51 dansmith bauzas: is the change to _enabled_filters still needed there?
17:43:02 johnthetubaguy melwitt: that destroy_and_raise_if_over_quota, is that worth the extra maintenance cost?
17:43:06 bauzas you mean the bottom change?
17:43:09 bauzas dansmith: ^
17:43:24 melwitt johnthetubaguy: replying to that right now on the review
17:43:25 dansmith bauzas: L48 of the bottom change
17:43:39 bauzas dansmith: yeah it should still, because we have a different behaviour in case we don't have all the filters
17:44:10 bauzas dansmith:oh sec
17:44:15 bauzas dansmith: I misunderstood your question
17:44:22 dansmith I don't think it should be different if we're ignoring those filters
17:44:27 bauzas dansmith: in theory, the affinity filters are part of the default
17:44:39 dansmith bauzas: also, the other tests didn't have a list for that parameter?
17:44:41 bauzas dansmith: so we should not need L48 theorically
17:44:46 bauzas dansmith: but
17:45:15 dansmith bauzas: what about the service_down_time thing?
17:45:18 openstackgerrit Eric Fried proposed openstack/nova: Introduce base PowerVM driver https://review.openstack.org/391288
17:45:41 bauzas dansmith: I forgot to make a note here
17:45:54 bauzas dansmith: I answered edleafe's on a previous PS
17:46:15 bauzas and sorry pidgin crashed when I was replying to you about the _enabled_filters
17:46:39 bauzas I preferred to explicitly ask for them in L48 given we could remove them from the default list later on
17:46:51 dansmith you use pidgin for irc like a n00b? :)
17:46:52 dansmith alright
17:47:41 bauzas dansmith: indeed, I love GUIs
17:47:51 melwitt that was a burn
17:48:05 bauzas and you know what ? I loooove Atom
17:48:10 artom dansmith, let me guess, you jiggle magnets around some wires to send your messages?
17:48:14 bauzas we're almost Friday
17:48:28 bauzas so I think I have the wildcard for telling that
17:48:52 dansmith bauzas: -1 on the middle patch
17:48:55 dansmith I think the test is broken
17:49:03 bauzas dansmith: ack, lookind
17:49:05 dansmith bauzas: I love guis too
17:49:20 bauzas oh "this" ans "that"
17:49:31 bauzas my English teacher should hit me
17:49:53 dansmith bauzas: that's the bottom, see the middle one
17:50:17 bauzas dansmith: I know :)
17:50:20 dansmith okay
17:50:22 bauzas dansmith: I just saw your comment :)
17:50:26 bauzas dansmith: for the middle patch
17:50:28 bauzas good points
17:50:32 bauzas I can respin quickly
17:50:39 bauzas for the 2nd test I'm adding
17:51:10 dansmith I would recommend waiting until we get a run so we know if the top one is going to work, but if you have to go before it will finish, then just push
17:51:15 bauzas that is not running init_host, that's rather a defensive patch for making sure anyone can't just change nova.conf.placement opt and add a default without being kicked in the ass
17:51:34 bauzas dansmith: well, I'll get an IndentationError anyway, right?
17:51:41 bauzas dansmith: so I'm pretty sure it would fail anyway
17:51:52 bauzas don't know how I left that FWIW
17:52:05 bauzas probably because I said I love Atom in public
17:52:12 dansmith oh I see, well, might be good to assert the positive case in another test anyway
17:53:55 bauzas dansmith: I can put that elsewhere
17:54:08 bauzas dansmith: if you have ideas
17:54:20 bauzas dansmith: I'm just about uploading a new Ps
17:54:28 bauzas dansmith: unless you disagree
17:54:39 dansmith don't disagree
17:57:40 bauzas k
17:57:44 bauzas shooting, then
18:02:14 johnthetubaguy melwitt: oh, resize is a bit of a bummer in that quota logic.
18:02:20 openstackgerrit Sylvain Bauza proposed openstack/nova: Scheduler calling the Placement API https://review.openstack.org/417961
18:02:21 openstackgerrit Sylvain Bauza proposed openstack/nova: Block starting compute unless placement conf is provided https://review.openstack.org/425806
18:05:12 melwitt johnthetubaguy: yeah, it's ugly. it would look a lot better with the check_deltas idea
18:05:46 johnthetubaguy melwitt: I was thinking, its not until resize confim that we update the DB with the new larger flavor so its counted correctly, thats quite a big window
18:06:09 dansmith bauzas: did you not see my comment on the last patch about enabling service version caching?
18:06:18 bauzas dansmith: it seems not
18:06:23 dansmith bauzas: okay, I'll fix
18:06:25 bauzas my bad
18:06:38 dansmith oh,
18:06:51 dansmith I thought you were leaving soon, it's only 1900 your time right?
18:07:18 bauzas dansmith: I'm still here for a couple of hours :)

Earlier   Later