Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2017-01-26
15:31:19 bauzas dansmith: but I was basically doing the same, including the try/except clause in the cmd
15:33:40 mriedem i don't think create() is the correct method to handle,
15:33:46 mriedem that just creates the service object,
15:33:48 dansmith bauzas: just use something else and we can merge my graceful bit later and I will clean it up
15:33:49 mriedem start() is the thing that blows up
15:34:03 bauzas dansmith: okay
15:34:08 dansmith mriedem: yep, you're right
15:34:16 dansmith mriedem: but I think I want to catch around both
15:34:25 dansmith mriedem: in case we had to abort in low-level init or something
15:34:27 mriedem i just don't know if serve() or wait() calls start()
15:34:31 andreykurilin johnthetubaguy: I answered all your comments and all both patches are vaiting for your review:)
15:34:51 dansmith serve calls launch
15:34:54 dansmith which calls start I think
15:35:04 dansmith this is why I made it fail so we can see :)
15:35:17 openstackgerrit Dan Smith proposed openstack/nova: WIP: Allow graceful service exits from compute https://review.openstack.org/425751
15:41:45 cdent mriedem: if we stick to one full circle, I think we should consider that a win
15:42:04 mriedem heh
15:42:12 openstackgerrit melanie witt proposed openstack/nova: Count resources to check quota for cells https://review.openstack.org/416521
15:42:25 mriedem sfinucan: if you're looking for things, https://review.openstack.org/#/c/404990/ and the one after it have +2s
15:42:37 mriedem pretty simple
15:44:41 sfinucan mriedem: I'll give it a shot
15:45:55 mriedem none of that is sqla stuff
15:46:00 mriedem even though it's a jaypipes patch
15:46:00 raj_singh mriedem: If you have time, I got +2's on last two patches of service token bp.
15:47:03 mfeoktistov sfinucan: mriedem: mdbooth: sorry for disturbing you, I updated https://review.openstack.org/#/c/312488/ (rootwrap instead of privsep and small cleanup). Virtuozzo Storage CI fails because we have problem with cinder now, it's not releated to this review.
15:47:39 melwitt johnthetubaguy, mriedem: I took the WIP off the counting quota patch last night after adding more test coverage
15:48:08 bauzas interesting, how can I test that I don't have a conf section yet ?
15:48:28 andreykurilin mriedem bauzas johnthetubaguy: hi all! Do we want to put latest 7.1.0 (which is not released) to u-c ? If yes, there is only ~ 4 hours away now to make a release and propose c change to g-r repo
15:48:30 bauzas I could mock the CONF object tho but I'd prefer to mimic
15:48:37 dansmith bauzas: don't test for the section, test for the keys
15:48:53 bauzas dansmith: same question, how could I unset that ?
15:48:56 mriedem mfeoktistov: +2
15:49:50 mriedem melwitt: how comfortable are you with the counting quotas stuff? is it too risky at this point? and if counting quotas doesn't get in, should we still block the patches below it to move those other quotas tables to the api db (except reservations and usages)?
15:50:16 mriedem andreykurilin: are the patches all in for novaclient 7.1.0 yet?
15:50:38 mdbooth mfeoktistov: Did you change anything else?
15:50:38 mriedem bauzas: by default the tests won't have anything set in the CONF.placement values
15:50:42 mriedem unless we have defaults
15:50:45 openstackgerrit Chris Dent proposed openstack/nova: Add more debug logging on RP inventory update failures https://review.openstack.org/414230
15:50:53 mriedem mfeoktistov: he moved some small things around it looks like
15:51:02 mriedem mdbooth: ^
15:51:09 mdbooth IIRC I was +1 on this before, so if they only thing you've change is privsep I'm still +1.
15:51:11 cdent mriedem: that's ^ the long promised test additions to that logging thing you did a while back. with some adjustments
15:51:17 andreykurilin mriedem: only one(+one not critical in the chain) left - https://review.openstack.org/#/c/424256/ . It has one +2 and answered all comments
15:51:58 bauzas mriedem: dansmith: the only problem I see is that we expect keystone config options
15:52:05 mriedem andreykurilin: ok, looks like johnthetubaguy has been reviewing https://review.openstack.org/#/c/424256/ so i'll leave the +W to him
15:52:10 bauzas so I need to verify them
15:52:18 melwitt mriedem: I'm pretty confident in the counting stuff. I think it's no worse than what's already there. we would trade known issues and out-of-sync problems for something with a lot smaller footprint, but obviously has some element of the unknown compared to something we've had for years
15:53:19 mfeoktistov mdbooth: no, just rootwrap instead of privsep, move two lines of code from libvirt_driver to libvirt_utils and fix tests for it
15:53:23 mriedem bauzas: i think you just need to check for CONF.placement.password
15:53:26 mriedem that *has* to be set
15:53:38 bauzas mriedem: okay, I can just do that
15:53:42 melwitt mriedem: as for the bottom patches, if we assume a single cell, I think it still works, it's just reservations and usages would be in the main db whereas the limits and classes would be in the api db.
15:53:54 mriedem http://logs.openstack.org/72/404472/20/check/gate-tempest-dsvm-neutron-full-ubuntu-xenial/8aafdf2/logs/etc/nova/nova.conf.txt.gz
15:54:02 mriedem bauzas: ^ for what we set in devstack
15:54:21 mriedem but there are some deprecated things in ksa so i'd just stick with checking for the password option
15:54:22 bauzas mriedem: yup, I know
15:54:29 mriedem like user_id vs username, etc
15:54:38 bauzas mriedem: I'm just hesitating about checking things related to keystone diretly
15:54:43 mriedem and the 10 different ways you can specify a project in ksa
15:54:50 mfeoktistov mdbooth: code which gets default filesystem type from nova conf or ext4 as default value
15:54:59 bauzas mriedem: given we don't verify that by us but instead straight passing it to keystoneauth
15:55:08 mdbooth mfeoktistov: Yep, spotted
15:55:17 mriedem bauzas: i don't know what that means, or why we care
15:55:22 bauzas anyway, let's not overcomplicate things
15:55:23 cdent sfinucan: on https://review.openstack.org/#/c/404990/ there's this to fix that regex (next cycle): https://review.openstack.org/#/c/418393/
15:55:32 mriedem bauzas: init_host just checks, if CONF.placement.password is None: raise Exception
15:55:33 bauzas my patch is almost ready and I have to leave in 5
15:55:36 dansmith mriedem: on the quotas thing, I think it's risky, but I also think it's more likely that anyone else will be able to fix bugs in the counting stuff, so if you want to push, I'll dig into that last one
15:56:02 sfinucan cdent: Aha - thank you. That did seem like a peculiar oversight
15:56:06 dansmith mriedem: and I think there's probably truth to the argument that it's no worse than what we have now, but it is more obvious than what we have now
15:56:11 mdbooth pkoniszewski pkoniszewski_ (irc is the worst): Are you able to determine what I'm talking about through gerrit's formatting?
15:56:16 dansmith mriedem: but also, we're merging other stuff with high risk, so...
15:56:26 cdent sfinucan: it's because 409 is overloaded for at least two different types of conflict
15:56:31 mriedem dansmith: heh, so while we're playing with house money...
15:56:42 mriedem dansmith: feel free to push, i just won't be able to get to it
15:56:59 pkoniszewski_ mdbooth: but the point is that there is no such race
15:57:08 dansmith mriedem: I meant "maybe we shouldn't take out another loan" but okay
15:57:25 mdbooth pkoniszewski_: Explain
15:57:29 cdent it's called leverage
15:57:41 mriedem dansmith: oh i thought you wanted to go balls out
15:57:56 mdbooth pkoniszewski_: I described the race. Can you point out the step I got wrong?
15:58:13 dansmith mriedem: I meant the last statement was a hedge, not a "we've already got a second mortgage, why not go for a third"
15:58:37 dansmith mriedem: let me look through it and see how I feel after that
15:58:43 mriedem hey, the dow was over 20K so i think that's a safe bet right now
15:58:43 mdbooth pkoniszewski_: I think cfriesen(?) said they'd hit it in practise, too.
15:58:46 mriedem what could possibly go wrong
15:58:48 dansmith heh
15:58:58 mfeoktistov mriedem: thanks for discussion in mailing list
15:59:13 pkoniszewski_ mdbooth: live migration will always be set to 'completed', there is no chance we will end up with 'failed' or 'finished' state
15:59:26 dansmith johnthetubaguy: are you still around?
15:59:28 pkoniszewski_ mdbooth: the RPC has been changed to call
15:59:31 pkoniszewski_ mdbooth: https://review.openstack.org/#/c/389687/
15:59:35 johnthetubaguy dansmith: I am
15:59:48 bauzas there it is
16:00:02 dansmith johnthetubaguy: how are you feeling about the counting quotas stuff?
16:00:06 openstackgerrit Sylvain Bauza proposed openstack/nova: Scheduler calling the Placement API https://review.openstack.org/417961
16:00:40 mdbooth pkoniszewski_: So it has, I must have been looking at an old version when looking at the old commit.
16:00:54 mdbooth Well... for the reasons stated I also think that's a bad idea :)
16:01:02 mdbooth But yeah, that means there's no race.
16:01:15 pkoniszewski_ mdbooth: but there is still an issue with rollback, thats a very good point

Earlier   Later