| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2017-01-25 | |||
| 21:47:50 | dansmith | https://review.openstack.org/#/c/410945/ | |
| 21:48:20 | dansmith | actually can we go ahead and merge the bottom two? | |
| 21:49:39 | mriedem | i thought we weren't going to merge those unless the counting resources one was good | |
| 21:49:44 | mriedem | i've removed the -2 btw | |
| 21:50:17 | mriedem | b/c we don't have reservations in the api db in the bottom changes i thought | |
| 21:50:26 | dansmith | ah | |
| 21:51:19 | dansmith | the counting patch is massive | |
| 21:51:24 | dansmith | which I guess is why it's still WIP | |
| 21:51:41 | mriedem | yeah, and probably too risky at this point | |
| 21:52:00 | mriedem | i.e. i think we need more burn in time with testing for a change like that | |
| 21:52:33 | dansmith | so you're calling it? | |
| 21:52:34 | mriedem | so does that automatically mean the bottom two changes can't get in? i believe they will just fallback to the main db for reservations/usages since those won't be in the api db | |
| 21:52:37 | mriedem | well, | |
| 21:52:44 | mriedem | seems pretty damn risky at this point | |
| 21:52:53 | mriedem | is melwitt around? | |
| 21:53:23 | dansmith | from what I saw of the first two, it doesn't really change anything so I would expect the bottom ones are okay, but.. I forgot about reservations | |
| 21:53:50 | mriedem | and usages | |
| 21:53:56 | mriedem | i think those were the 2 tables that weren't being ported | |
| 21:54:27 | dansmith | aye | |
| 21:54:49 | dansmith | well, john and I have been hitting that hard in the last day expecting to get it in, but I dunno. I guess we'll wait for melwitt to get back and advise | |
| 22:09:05 | bauzas | if someone could tell me how we can raise keystoneclient.Unauthorized exceptions when calling https://github.com/openstack/keystoneauth/blob/master/keystoneauth1/session.py#L616 ... | |
| 22:09:24 | bauzas | I'm puzzled | |
| 22:09:51 | bauzas | mmmmmpf nvm https://github.com/openstack/keystoneauth/blob/master/keystoneauth1/session.py#L652 | |
| 22:14:39 | bauzas | mriedem: still around? | |
| 22:15:16 | bauzas | mriedem: I'd love more context about https://review.openstack.org/#/c/416810/ | |
| 22:20:07 | mriedem | bauzas: context how? | |
| 22:20:09 | mriedem | did you read the bug report? | |
| 22:20:37 | mriedem | or the related change - nova.conf was misconfigured for how to connect to placement for awhile with keystone v3 | |
| 22:20:41 | mriedem | so you'd get 401 | |
| 22:21:11 | bauzas | mriedem: yup, saw the change in devstack lib/placement | |
| 22:21:33 | bauzas | but I'm hitting the same 401 in grenade job | |
| 22:22:19 | bauzas | AFAICS, the value is still "Default" https://github.com/openstack-dev/devstack/blob/7a1e6f042f00ac94ec30bb8c6bf5d05b34623832/lib/keystone#L107 | |
| 22:24:21 | mriedem | not sure, would have to see that everything is configured the same and if not, what's different and what's missing | |
| 22:24:26 | mriedem | but i'm taking maya to the pool so back in a few hours | |
| 22:25:08 | bauzas | no worries | |
| 23:15:59 | bauzas | dansmith: still around? | |
| 23:16:23 | bauzas | dansmith: I wonder if we don't run init_placement() method within grenade | |
| 23:16:58 | bauzas | just verifying the grenade log, but in case you know... | |
| 23:17:00 | dansmith | bauzas: if you don't see it, then we don't | |
| 23:17:16 | dansmith | bauzas: if we don't in neutron devstack, and you don't see it in grenade then, we don't | |
| 23:17:42 | bauzas | sec, verifying the grenade deployment | |
| 23:18:52 | bauzas | dansmith: confirmed | |
| 23:19:03 | bauzas | dansmith: can't find it in http://logs.openstack.org/30/424730/6/check/gate-grenade-dsvm-neutron-ubuntu-xenial/16175d7/logs/grenade.sh.txt.gz | |
| 23:19:29 | bauzas | lemme fix that quickly | |
| 23:20:47 | bauzas | dansmith: do you think we should do that in the from_newton script or in upgrade.sh ? | |
| 23:21:26 | dansmith | from-newton | |
| 23:22:25 | bauzas | ok | |
| 23:23:51 | bauzas | dansmith: done editing | |
| 23:24:11 | bauzas | dansmith: I'll have to bail out soon, I need to wake up early | |
| 23:24:18 | dansmith | okay | |
| 23:24:30 | bauzas | but in case it works, could you please look at the change ? | |
| 23:24:49 | bauzas | I'll review your own change tomorrow morning | |
| 23:25:34 | dansmith | grr | |
| 23:25:34 | dansmith | cripes I keep failing this one test, but nothing has changed since it was passing | |
| 23:26:00 | bauzas | which one ? | |
| 23:27:03 | openstackgerrit | OpenStack Proposal Bot proposed openstack/nova: Updated from global requirements https://review.openstack.org/424828 | |
| 23:28:30 | dansmith | bauzas: go to sleep | |
| 23:28:37 | openstackgerrit | Sylvain Bauza proposed openstack/nova: Fix server group functional test by using all filters https://review.openstack.org/425185 | |
| 23:28:37 | openstackgerrit | Sylvain Bauza proposed openstack/nova: Scheduler calling the Placement API https://review.openstack.org/417961 | |
| 23:28:48 | bauzas | voila... all the changes are now rebased | |
| 23:29:34 | bauzas | dansmith: I'll at least wait a few mins to see if we have at least one grenade job done | |
| 23:32:18 | dansmith | oh jeez | |
| 23:36:22 | openstackgerrit | Dan Smith proposed openstack/nova: Move instance creation to conductor https://review.openstack.org/319379 | |
| #openstack-nova - 2017-01-26 | |||
| 00:44:36 | openstackgerrit | Takashi NATSUME proposed openstack/nova: Enable cold migration with target host(1/2) https://review.openstack.org/408955 | |
| 00:44:49 | openstackgerrit | Takashi NATSUME proposed openstack/nova: Enable cold migration with target host(1/2) https://review.openstack.org/408955 | |
| 00:45:59 | openstackgerrit | Takashi NATSUME proposed openstack/nova: Enable cold migration with target host(2/2) https://review.openstack.org/408964 | |
| 00:46:58 | openstackgerrit | Takashi NATSUME proposed openstack/nova: api-ref: Add parameters in cold migrate action https://review.openstack.org/410042 | |
| 00:47:26 | openstackgerrit | Takashi NATSUME proposed openstack/python-novaclient: Microversion 2.42 - Enable cold migration with target host https://review.openstack.org/406707 | |
| 00:47:54 | openstackgerrit | Takashi NATSUME proposed openstack/nova: Add functional tests for cold migration to same host https://review.openstack.org/414926 | |
| 00:58:08 | alex_xu | gmann: johnthetubaguy if we think 403 is behaviour change. Then this is a behaviour change https://review.openstack.org/#/c/415142/33/nova/api/openstack/compute/servers.py@1230 ? | |
| 00:58:15 | alex_xu | Kevin_Zheng: ^ | |
| 00:59:57 | alex_xu | gmann: johnthetubaguy but expose host and node to the user is kind of bug fix. it isn't same case with all_tenants which is filter we support it public | |
| 01:00:09 | alex_xu | s/bug fix/bug/ | |
| 01:05:01 | dansmith | melwitt: this is good again: https://review.openstack.org/#/c/319379/ | |
| 01:05:17 | dansmith | melwitt: I broke it in a very subtle way when fixing johnthetubaguy's comment, but it's good now | |
| 01:13:09 | mriedem | did bauzas get the grenade thing figured out? | |
| 01:13:47 | mriedem | dansmith: simple change needed in https://review.openstack.org/#/c/424243/ and then i'm +2 | |
| 01:14:08 | dansmith | mriedem: we're waiting for a run I think | |
| 01:16:07 | gmann | alex_xu: | |
| 01:16:15 | gmann | alex_xu: humm, | |
| 01:17:22 | dansmith | mriedem: | |
| 01:17:34 | dansmith | gah | |
| 01:17:53 | mriedem | _LW _MFER | |
| 01:18:13 | openstackgerrit | Dan Smith proposed openstack/nova: Only warn about hostmappings during ocata upgrade https://review.openstack.org/424243 | |
| 01:18:18 | dansmith | there | |
| 01:21:05 | gmann | alex_xu: IMO, that as bug fix makes it valid | |
| 01:24:10 | oomichi | alex_xu: Does it mean the patch changes 403 to 400 ? | |
| 01:26:13 | oomichi | alex_xu: we are discussing error status code changes on https://review.openstack.org/#/c/421846 . I am ok to allow error status code changes anyways | |
| 01:26:30 | openstackgerrit | Dan Smith proposed openstack/nova: Only warn about hostmappings during ocata upgrade https://review.openstack.org/424243 | |
| 01:29:33 | gmann | oomichi: policy change for all_tenant will change 403->200 | |
| 01:29:53 | gmann | oomichi: so its kinnda behavior change | |
| 01:30:37 | gmann | oomichi: and on sort key change it is bug fix (not expose host and node to non admin user) and 200->400 | |
| 01:31:02 | gmann | alex_xu: correct me if am wrong on sort key which used to me 200 now? | |
| 01:32:54 | oomichi | gmann: humm, 200->400 seems against on changing policy: "The following types of changes are generally **not** considered acceptable:" | |
| 01:33:18 | oomichi | "A change such that a request which was successful before now results in an error response" | |
| 01:33:49 | oomichi | if that is not security bug | |
| 01:34:56 | oomichi | gmann: "not expose host and node to non admin user" seems a little bit security thing, which means abstraction doesn't work correctly for non-admin users | |
| 01:35:08 | mriedem | melwitt: this is an easy one https://review.openstack.org/#/c/424243/ | |
| 01:35:09 | oomichi | but I am not sure at this time | |
| 01:37:52 | gmann | oomichi: yea that seems security bug for me too. but johnthetubaguy alex_xu mriedem can give better feedback on this - last paragraph in https://specs.openstack.org/openstack/nova-specs/specs/ocata/approved/add-whitelist-for-server-list-filter-sort-parameters.html#proposed-change | |