| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2017-01-25 | |||
| 11:09:49 | ildikov | johnthetubaguy: great, thank you! | |
| 11:10:31 | ildikov | johnthetubaguy: I will harass a few Cinder folks and it seems we will most prolly switch back to Thursdays for a bit, will announce this week I hope | |
| 11:16:40 | bauzas | cdent: mmm, there is a bug with https://github.com/openstack/nova/blob/master/nova/scheduler/client/report.py#L129-L131 | |
| 11:16:48 | bauzas | cdent: swap is counted in MB | |
| 11:16:57 | bauzas | cdent: https://github.com/openstack/nova/blob/master/nova/scheduler/filters/disk_filter.py#L36-L38 | |
| 11:17:14 | bauzas | so we don't report correctly the right size | |
| 11:17:20 | cdent | whoops | |
| 11:17:30 | bauzas | just creating a bug report | |
| 11:17:44 | cdent | nice find | |
| 11:20:45 | mdbooth | bauzas: I've hit that a bunch of times, btw. In general, I'd prefer to see a coding style guideline that all storage sizes are in bytes. | |
| 11:21:06 | mdbooth | We variously use B, MB and GB throughout the code, and it's super-easy to make mistakes. | |
| 11:21:34 | cdent | it's good ux for it be other things for humans, but yeah, as soon as the data passes into internal code it ought to be all the same | |
| 11:22:06 | bauzas | mdbooth: sure but changing the Flavors attributes seems a bit long to do | |
| 11:22:08 | mdbooth | Yep | |
| 11:22:31 | mdbooth | bauzas: Oh, yeah. I think we need to live with our existing mistakes :) Just not make new ones. | |
| 11:23:26 | mdbooth | i.e. Any new code which represents a storage size should use bytes exclusively. | |
| 11:27:27 | openstackgerrit | Matthew Booth proposed openstack/nova: libvirt: Mock is_job_complete in test_driver https://review.openstack.org/425140 | |
| 11:27:29 | mdbooth | lyarwood: ^^^ | |
| 11:28:04 | mdbooth | lyarwood: Could you take a quick look at the above change. If you approve, I would rebase your mirror attribute fix on top of it and remove all the changes in test_driver.py | |
| 11:29:46 | bauzas | mdbooth: agreed | |
| 11:29:55 | bauzas | mdbooth: it should count on bytes | |
| 11:30:00 | bauzas | cdent: FYI https://bugs.launchpad.net/nova/+bug/1659266 | |
| 11:30:01 | openstack | Launchpad bug 1659266 in OpenStack Compute (nova) "Disk allocation for instance is not good with swap" [High,Confirmed] | |
| 11:30:08 | cdent | ✔ | |
| 11:30:26 | lyarwood | mdbooth: thanks, yeah that looks good if people are happy for us to mix mox and mock, I assumed there was an unwritten rule stopping us from doing this | |
| 11:31:05 | mdbooth | lyarwood: I think we don't write new mox. Partial mox->mock is acceptable, I believe? | |
| 11:31:08 | bauzas | cdent: in theory, we would need to data migrate the existing allocations | |
| 11:31:39 | mdbooth | I mean going the whole hog is great. The main change is from functional->unity there, rather than mox->mock | |
| 11:31:42 | bauzas | cdent: are we wiping off the existing allocations somewhere when we auto-heal ? | |
| 11:32:16 | lyarwood | mdbooth: yeah, I might stash what I have and follow up with the full move to mock after this | |
| 11:32:17 | mdbooth | lyarwood: As I mention in the commit, we should either have a test library for this, or mock at the function boundary. | |
| 11:33:07 | mdbooth | The real change is mocking is_job_complete, rather than modelling the corresponding behaviour of the libvirt daemon. | |
| 11:33:25 | mdbooth | I prefer the latter, but we don't have that in place, and doing it piecemeal isn't maintainable. | |
| 11:33:53 | cdent | bauzas: we update allocations when is_new_instance or is_removed_instance | |
| 11:34:09 | mdbooth | lyarwood: Anyway, would you mind if I rebased your mirror tag change on to it? | |
| 11:34:24 | mdbooth | It would make your change a lot smaller. No changes required in test_driver.py. | |
| 11:34:26 | cdent | bauzas: we update inventory frequently | |
| 11:34:30 | lyarwood | mdbooth: not at all if you have the time to work on it | |
| 11:34:38 | mdbooth | Yeah, it'll only take me a second. | |
| 11:34:44 | lyarwood | mdbooth: awesome thanks | |
| 11:35:40 | bauzas | cdent: my concerns are if we have wrong allocations when a new instance comes in | |
| 11:36:16 | cdent | bauzas: yeah. I haven't looked closely enough. Is the bug such that the allocations will be over or under where they should be? | |
| 11:36:38 | bauzas | yup | |
| 11:36:50 | bauzas | but I need to bail out for lunch | |
| 11:37:04 | bauzas | if I have a swap of 1MB | |
| 11:37:23 | bauzas | root to 1GB and eph to 0 | |
| 11:37:46 | bauzas | then I'll express an allocation of 2GB with that bug instead of 1.001 | |
| 11:38:38 | cdent | When nova-compute restarts does it rewrite all allocations? | |
| 11:39:19 | openstackgerrit | Matthew Booth proposed openstack/nova: libvirt: Use the mirror element to detect job completion https://review.openstack.org/399735 | |
| 11:39:22 | mdbooth | lyarwood: ^^^ | |
| 11:39:37 | mdbooth | 75 insertions(+), 9 deletions(-) Much smaller :) | |
| 11:39:47 | cdent | bauzas: I'll do some experimenting in devstack today (because I was planning to do that anyway) | |
| 11:40:31 | lyarwood | mdbooth: nice! | |
| 11:41:00 | mdbooth | lyarwood: It's identical to your change, just test_driver changes removed | |
| 11:41:10 | bhagyashris | johnthetubaguy: i am new to placement api feature, Does it mean, the placement api only needs to be enabled on controller node ? | |
| 11:41:54 | johnthetubaguy | bhagyashris: I think so | |
| 11:44:12 | lyarwood | mdbooth: that's great, I would say thanks but my LOC changed stats just took a hit :D | |
| 11:44:21 | cdent | bhagyashris: yes, it goes on a controller and needs to be in the service catalog | |
| 11:44:35 | mdbooth | lyarwood: lol | |
| 11:45:17 | cdent | mdbooth++ | |
| 11:45:21 | lyarwood | mdbooth: I agree https://review.openstack.org/#/c/391597/ | |
| 11:45:30 | lyarwood | ^_^ | |
| 11:47:43 | mdbooth | lyarwood: Oh, wow | |
| 11:47:55 | mdbooth | That's fantastic :) | |
| 11:51:49 | mdbooth | Gerrit is a bit 500-y this morning | |
| 11:53:31 | bhagyashris | cdent: thank you for information, however if I am having two node setup then how many resource_providers will be created? two or one? In my case it is creating single resource_provider only | |
| 11:54:00 | cdent | bhagyashris: you should get as many resource providers as you have compute nodes | |
| 11:54:38 | cdent | if you have two compute nodes but are only seeing one, then it may be that one of the compute nodes does not have the right stuff in the [placement] section of nova.conf | |
| 11:56:18 | bhagyashris | cdent: ok, so in both compute nodes I need to add placement section in nova.conf? actually I am using devstack for multinode setup so one one node it does not create placement section | |
| 11:56:33 | bhagyashris | cdent: thank you for useful information | |
| 11:56:56 | bhagyashris | cdent: i will check accordingly | |
| 11:57:33 | cdent | the [placement] section is used by the resource tracker (and eventually nova-scheduler) so needs to be where those things are running | |
| 11:58:48 | bhagyashris | cdent: ok. Thank you for information. :) | |
| 12:06:27 | gmann | Kevin_Zheng: left few comments on https://review.openstack.org/#/c/415330/23 | |
| 12:07:04 | gmann | Kevin_Zheng: more tests for new rule i mean, without old rule so that we can tests the way new deployer ll use | |
| 12:14:27 | stevemar | o/ | |
| 12:15:04 | stevemar | can we get a review of https://review.openstack.org/#/c/418190/ if possible, thanks already mriedem and andreykurilin | |
| 12:34:47 | lyarwood | Any additional core reviews on the following would be appreciated - https://review.openstack.org/#/c/420146/ - libvirt: workaround findmnt behaviour change | |
| 12:42:11 | Kevin_Zheng | gmann: will add one, but I think thats what we should add when we remove the old rule, because for the new users using Ocata, old rule is still there, just not checking them | |
| 12:43:28 | gmann | Kevin_Zheng: yea but after this change, user can also have only new rule in their policy.json | |
| 12:43:57 | Kevin_Zheng | yeah, but the old rule still exist in code | |
| 12:44:32 | Kevin_Zheng | it will make not difference than the current test | |
| 12:45:07 | gmann | Kevin_Zheng: ah, you mean code still have those. | |
| 12:45:14 | Kevin_Zheng | yeah | |
| 12:45:17 | gmann | Kevin_Zheng: got it, thanks. | |
| 12:45:32 | gmann | Kevin_Zheng: and while removing the old rule those tests will be with new rule only | |
| 12:45:42 | Kevin_Zheng | so, I will just update the comments then | |
| 12:46:01 | Kevin_Zheng | yeah, we will change the test then | |
| 12:46:09 | alex_xu | nova api meeting is in 15 mins at #openstack-meeting-4 | |
| 12:46:59 | gmann | Kevin_Zheng: cool thanks | |
| 12:50:02 | alex_xu | gmann: thanks for the review! | |
| 12:50:36 | gmann | alex_xu: np! | |
| 12:52:25 | openstackgerrit | Zhenyu Zheng proposed openstack/nova: Add new policy for server list/detail with all_tenants https://review.openstack.org/415330 | |
| 12:59:22 | Kevin_Zheng | https://review.openstack.org/#/c/421760/ | |
| 12:59:41 | Kevin_Zheng | ^ please also review the doc patch? | |
| 13:01:50 | openstackgerrit | Balazs Gibizer proposed openstack/nova: Fix race condition in instance.update sample test https://review.openstack.org/424574 | |
| 13:02:58 | alex_xu | nova api meeting is running | |
| 13:41:19 | bauzas | cdent: have you seen our discussion with matt yesterday and the conclusion email ? | |
| 13:41:42 | bauzas | cdent: we agreed on rather asking to modify the allocation ratios | |
| 13:42:01 | bauzas | cdent: so I needed to modify a functional test for server_groups | |