| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2017-01-25 | |||
| 03:33:42 | duonghq | sfinucan, are you there? due to you reviewed all others my ps about remove-mox of test_shelve, can you review the last one: https://review.openstack.org/#/c/342593/ | |
| 03:47:12 | Kevin_Zheng | mriedem: could you have a look on https://review.openstack.org/415142 and https://review.openstack.org/#/c/415330/ ? | |
| 03:47:55 | mriedem | Kevin_Zheng: yeah i have the first open right now | |
| 03:48:29 | Kevin_Zheng | Yeah, thanks, it's the last day before alex on holiday, so kind hope it can be merged today | |
| 03:49:17 | Kevin_Zheng | go for launch, will address any comment at that, thanks alot' | |
| 04:14:52 | gmann | Kevin_Zheng: alex_xu policy one looks fine to me | |
| 04:15:49 | gmann | Kevin_Zheng: alex_xu my concern for overriding with default value is fine now as we will honor those in same way as they are overridden. means no affect on old deployer | |
| 04:19:51 | mriedem | dansmith: i guess we need to remove the WIP on this https://review.openstack.org/#/c/424730/ | |
| 04:20:30 | mriedem | i think sdague is going to ask that the commit message point to a nova change with a release note saying why we need the from-newton step, which would be bauzas' filter scheduler change | |
| 04:21:14 | mriedem | i'll just leave a comment on there, but jenkins is happy with it which is good | |
| 04:24:07 | mriedem | Kevin_Zheng: left a question in https://review.openstack.org/#/c/415142/ | |
| 04:29:52 | alex_xu | mriedem: thanks, looks like we just miss that key. | |
| 04:30:05 | mriedem | do we want to be able to filter on instance_type_id? | |
| 04:30:09 | mriedem | s/filter/sort/ | |
| 04:30:28 | alex_xu | there should be alias for that, it called flavor I remember | |
| 04:30:36 | mriedem | ok | |
| 04:30:44 | mriedem | yeah i know we leak the flavor.id out of the REST API | |
| 04:31:31 | alex_xu | in the filter, that is flavor.flavor_id | |
| 04:31:38 | mriedem | ok | |
| 04:31:43 | mriedem | i'll check back on it tomorrow | |
| 04:31:48 | mriedem | i've got to go to bed | |
| 04:31:59 | alex_xu | mriedem: thanks, have good sleep | |
| 04:32:19 | mriedem | other than that it's looking good so shouldn't be a problem to get it in tomorrow | |
| 04:32:25 | mriedem | alex_xu: just +2 when you're happy with it | |
| 04:35:51 | alex_xu | gmann: thanks for the review | |
| 04:38:22 | alex_xu | gmann: re: https://review.openstack.org/#/c/415330/21/nova/tests/unit/api/openstack/compute/test_serversV21.py, are you looking for cases for the new rule is overriden? | |
| 04:39:04 | alex_xu | if you are looking for the cases for old rule is overriden, it is already there. | |
| 04:46:58 | gmann | alex_xu: yea, old rule is there. i was thinking we can have tests only with new rule(overridden and not overridden) which are nothing but new deployer | |
| 05:11:30 | openstackgerrit | Zhenyu Zheng proposed openstack/nova: Add sort_key white list for server list/detail https://review.openstack.org/415142 | |
| 06:18:48 | openstackgerrit | Zhenyu Zheng proposed openstack/nova: Add sort_key white list for server list/detail https://review.openstack.org/415142 | |
| 06:25:26 | openstackgerrit | Sreeram Vancheeswaran proposed openstack/nova: [WIP] Driver function call to enable attach volume for nova-dpm https://review.openstack.org/424996 | |
| 06:48:12 | openstackgerrit | Zhenyu Zheng proposed openstack/nova: Add new policy for server list/detail with all_tenants https://review.openstack.org/415330 | |
| 07:17:09 | openstackgerrit | Zhenyu Zheng proposed openstack/nova: Add release note and docs for filter/sort whitelist https://review.openstack.org/421760 | |
| 07:45:01 | openstackgerrit | Ghanshyam Mann proposed openstack/nova: Add "supports_device_tagging" in fake driver for tests https://review.openstack.org/425030 | |
| 07:48:20 | gmann | alex_xu: Kevin_Zheng this was causing issue on tag fix patch - https://review.openstack.org/#/c/425030/1 | |
| 07:49:17 | Kevin_Zheng | gmann: AH, thanks | |
| 07:52:44 | alex_xu | gmann: cool | |
| 08:45:53 | openstackgerrit | Hironori Shiina proposed openstack/nova: Ironic: Add soft power off support to Ironic driver. https://review.openstack.org/407977 | |
| 08:54:23 | openstackgerrit | Zhenyu Zheng proposed openstack/nova: Add new policy for server list/detail with all_tenants https://review.openstack.org/415330 | |
| 09:01:55 | claudiub|2 | moshele: hi. I've replied to your comments on https://review.openstack.org/#/c/420614/ . Regarding PF/VF passthrough, I *might* be able to get a compute node with such capabilities today, so I check that out as well. | |
| 09:02:26 | openstackgerrit | Rikimaru Honjo proposed openstack/nova: Add checks for preventing unexpected detaching volume https://review.openstack.org/354617 | |
| 09:06:15 | sfinucan | duonghq: Here now (Irish time). I'll take a look | |
| 09:13:29 | moshele | claudiub|2: cool | |
| 09:13:40 | moshele | claudiub: cool | |
| 09:13:54 | sahid | johnthetubaguy: any chance you ack that one https://review.openstack.org/#/c/400874/, jaypipes already +2 it but i holidays now | |
| 09:16:45 | openstackgerrit | Moshe Levi proposed openstack/nova: PCI: Check pci_requests object is empty before passing to support_requests https://review.openstack.org/423608 | |
| 09:20:18 | lyarwood | https://review.openstack.org/#/c/420146/ looking for a final core +2 +W on this findmnt workaround if anyone has time this morning | |
| 09:20:42 | openstackgerrit | Guillaume Espanel proposed openstack/nova: Reduce time and memory usage of tenant usage. https://review.openstack.org/343734 | |
| 09:26:06 | lyarwood | johnthetubaguy, mikal, tonyb, claudiub ; I'm also looking to land https://review.openstack.org/#/c/412201/ on stable/newton today if anyone has the time to review this. | |
| 09:26:59 | openstackgerrit | Zhenyu Zheng proposed openstack/nova: Disallow assgined floating IP that already assigned to other ports. https://review.openstack.org/425077 | |
| 09:31:16 | duonghq | sfinucan, thank you | |
| 09:36:57 | gcb | sfinucan: I think we can merge another python 3 enable patch now :) https://review.openstack.org/#/c/414420/ | |
| 09:37:26 | sfinucan | gcb: I think the same :) | |
| 09:39:14 | gcb | sfinucan, cool, thanks | |
| 09:42:39 | lyarwood | johnthetubaguy, claudiub ; thanks! :) | |
| 09:47:06 | sfinucan | lyarwood: Backporting is simply 'cherry-pick -x', right? | |
| 09:48:20 | lyarwood | sfinucan: yeah, there's better docs here http://docs.openstack.org/project-team-guide/stable-branches.html | |
| 09:48:22 | sfinucan | Actually, do we still bother with those 'backport' lines? I figured every bug should be backported, if it applied to the stable code too and didn't introduce a functional change | |
| 09:48:29 | sfinucan | lyarwood: (y) | |
| 09:48:33 | lyarwood | sfinucan: http://docs.openstack.org/project-team-guide/stable-branches.html#proposing-fixes for the actual workflow | |
| 09:48:36 | openstackgerrit | Duong Ha-Quang proposed openstack/nova: Remove mox in nova/tests/unit/compute/test_shelve.py (3) https://review.openstack.org/342648 | |
| 09:49:52 | sfinucan | lyarwood: Excellent. Thank you. Think I've done it now (https://review.openstack.org/425087) | |
| 09:50:10 | sfinucan | Hmm, commits to stable branches don't appear in IRC. Interesting... | |
| 09:51:38 | sfinucan | duonghq: Thanks for respinning that. Appreciate it :) | |
| 09:52:00 | duonghq | sfinucan, thank you very much | |
| 10:23:13 | openstackgerrit | Stephen Finucane proposed openstack/nova: adding debug info for pinning calculation https://review.openstack.org/355150 | |
| 10:36:56 | openstackgerrit | Stephen Finucane proposed openstack/nova: Add PCIWeigher https://review.openstack.org/379524 | |
| 10:37:53 | openstackgerrit | Stephen Finucane proposed openstack/nova-specs: Remove templates from approved/implemented specs https://review.openstack.org/405550 | |
| 10:44:30 | openstackgerrit | Huan Xie proposed openstack/nova: Fix live migrate with XenServer https://review.openstack.org/424428 | |
| 10:58:09 | bhagyashris | Hi all, I have one question, In the multinode environment , Is there a need to enable the placement api service on compute node also? | |
| 10:58:35 | openstackgerrit | Vasyl Saienko proposed openstack/nova: Implement interface attach/detach in ironic virt driver https://review.openstack.org/419975 | |
| 10:59:11 | johnthetubaguy | bhagyashris: everything talks to a single placement API endpoint (as defined in the keystone service catalog), over HTTP, if that helps. | |
| 11:01:06 | BobBall | johnthetubaguy: Regarding https://review.openstack.org/#/c/424428/3/nova/objects/migrate_data.py is the "legacy dictionary" used anywhere now? i.e. should the to_legacy_dict method care about new fields added to the object? | |
| 11:01:42 | johnthetubaguy | BobBall: I suspect now both old a new nodes are sending objects, we can drop all that code | |
| 11:02:11 | BobBall | Rather than dropping in this patch I was assuming not bothering updating the legacy dict? | |
| 11:02:13 | johnthetubaguy | BobBall: although technically speaking, we should bump the compute API major version to make that explicit | |
| 11:02:42 | BobBall | I presume there should be a more global legacy-dictionary cleanup effort? rather than a per-object piecemeal approach? | |
| 11:03:27 | BobBall | bah, you know what, the easiest path is just to update the dict anyway. Makes sure that if there is any dodgy code anywhere that it'll all work... | |
| 11:03:33 | johnthetubaguy | BobBall: I like being consistent and updating that, if I am honest, but I have no functional reason, just prettyness | |
| 11:04:52 | ildikov | johnthetubaguy: hi. can you look into this Doodle poll please: http://doodle.com/poll/9per237agrdy7rqz ? | |
| 11:06:00 | ildikov | johnthetubaguy: I know you have collisions around the time slot I hope to keep on other days, but Monday is unfortunately not working for a few Cinder guys :( | |
| 11:07:34 | johnthetubaguy | ildikov: so its not too bad until we high daylight savings, when many of the other days are tricky | |
| 11:07:58 | johnthetubaguy | ildikov: but hopefully we will have complete all our work by then :) | |
| 11:08:02 | ildikov | johnthetubaguy: we can reconsider when we switch again | |
| 11:08:09 | johnthetubaguy | that too | |
| 11:08:17 | ildikov | johnthetubaguy: hehe, I like your optimism! :) | |
| 11:08:35 | ildikov | johnthetubaguy: I just would like to have a slot that works for most so we can prep for the PTG | |
| 11:09:12 | ildikov | johnthetubaguy: so that we can complete all our work before the next daylight savings switch ;) | |
| 11:09:49 | ildikov | johnthetubaguy: great, thank you! | |
| 11:10:31 | ildikov | johnthetubaguy: I will harass a few Cinder folks and it seems we will most prolly switch back to Thursdays for a bit, will announce this week I hope | |
| 11:16:40 | bauzas | cdent: mmm, there is a bug with https://github.com/openstack/nova/blob/master/nova/scheduler/client/report.py#L129-L131 | |
| 11:16:48 | bauzas | cdent: swap is counted in MB | |
| 11:16:57 | bauzas | cdent: https://github.com/openstack/nova/blob/master/nova/scheduler/filters/disk_filter.py#L36-L38 | |
| 11:17:14 | bauzas | so we don't report correctly the right size | |
| 11:17:20 | cdent | whoops | |
| 11:17:30 | bauzas | just creating a bug report | |
| 11:17:44 | cdent | nice find | |
| 11:20:45 | mdbooth | bauzas: I've hit that a bunch of times, btw. In general, I'd prefer to see a coding style guideline that all storage sizes are in bytes. | |
| 11:21:06 | mdbooth | We variously use B, MB and GB throughout the code, and it's super-easy to make mistakes. | |
| 11:21:34 | cdent | it's good ux for it be other things for humans, but yeah, as soon as the data passes into internal code it ought to be all the same | |