Posted	Nick	Remark
#openstack-nova - 2017-01-25
02:11:12	openstackgerrit	Takashi NATSUME proposed openstack/nova: Enable cold migration with target host(2/2) https://review.openstack.org/408964
02:11:36	openstackgerrit	Takashi NATSUME proposed openstack/nova: Add functional tests for cold migration to same host https://review.openstack.org/414926
02:11:53	openstackgerrit	Takashi NATSUME proposed openstack/nova: api-ref: Add parameters in cold migrate action https://review.openstack.org/410042
02:12:01	openstackgerrit	Takashi NATSUME proposed openstack/python-novaclient: Microversion 2.42 - Enable cold migration with target host https://review.openstack.org/406707
02:12:56	openstackgerrit	Takashi NATSUME proposed openstack/nova: api-ref: Fix path parameters in os-hypervisors.inc https://review.openstack.org/416911
02:13:01	openstackgerrit	Takashi NATSUME proposed openstack/nova: Avoid forcing translation on logging calls https://review.openstack.org/413876
02:13:04	openstackgerrit	Takashi NATSUME proposed openstack/nova: api-ref: Fix keypair API parameters https://review.openstack.org/420626
02:13:09	openstackgerrit	Takashi NATSUME proposed openstack/nova: Refactor a test method including 3 test cases https://review.openstack.org/394738
02:13:14	openstackgerrit	Takashi NATSUME proposed openstack/nova: Refactor a test method including 7 test cases https://review.openstack.org/395436
02:13:17	openstackgerrit	Takashi NATSUME proposed openstack/nova: api-ref: Fix parameters in os-hosts.inc https://review.openstack.org/416444
02:13:21	openstackgerrit	Takashi NATSUME proposed openstack/nova: api-ref: Fix deprecated proxy API parameters https://review.openstack.org/416882
02:16:21	openstackgerrit	Zhenguo Niu proposed openstack/nova: Fix breaking out of nested loops https://review.openstack.org/424931
03:07:28	openstackgerrit	Zhenyu Zheng proposed openstack/nova: Add sort_key white list for server list/detail https://review.openstack.org/415142
03:17:55	duonghq	Hello, have we close "remove-mox" for Ocata cycle?
03:27:26	mriedem	duonghq: those can still go in until thursday
03:27:43	mriedem	duonghq: but i suspect those aren't getting much review attention right now as we try to close other higher priority things out
03:28:13	mriedem	duonghq: anything that does not make it in ocata will just be deferred to pike
03:28:32	duonghq	mriedem, thank you
03:28:59	duonghq	hope that somebody can give me review on https://review.openstack.org/#/c/342648/
03:29:11	duonghq	due to this is last commit of the chain for test_shelve
03:29:12	duonghq	:)
03:33:17	openstackgerrit	liusheng proposed openstack/nova: Trivial-fix: replace "json" with "yaml" in policy README https://review.openstack.org/424961
03:33:42	duonghq	sfinucan, are you there? due to you reviewed all others my ps about remove-mox of test_shelve, can you review the last one: https://review.openstack.org/#/c/342593/
03:47:12	Kevin_Zheng	mriedem: could you have a look on https://review.openstack.org/415142 and https://review.openstack.org/#/c/415330/ ?
03:47:55	mriedem	Kevin_Zheng: yeah i have the first open right now
03:48:29	Kevin_Zheng	Yeah, thanks, it's the last day before alex on holiday, so kind hope it can be merged today
03:49:17	Kevin_Zheng	go for launch, will address any comment at that, thanks alot'
04:14:52	gmann	Kevin_Zheng: alex_xu policy one looks fine to me
04:15:49	gmann	Kevin_Zheng: alex_xu my concern for overriding with default value is fine now as we will honor those in same way as they are overridden. means no affect on old deployer
04:19:51	mriedem	dansmith: i guess we need to remove the WIP on this https://review.openstack.org/#/c/424730/
04:20:30	mriedem	i think sdague is going to ask that the commit message point to a nova change with a release note saying why we need the from-newton step, which would be bauzas' filter scheduler change
04:21:14	mriedem	i'll just leave a comment on there, but jenkins is happy with it which is good
04:24:07	mriedem	Kevin_Zheng: left a question in https://review.openstack.org/#/c/415142/
04:29:52	alex_xu	mriedem: thanks, looks like we just miss that key.
04:30:05	mriedem	do we want to be able to filter on instance_type_id?
04:30:09	mriedem	s/filter/sort/
04:30:28	alex_xu	there should be alias for that, it called flavor I remember
04:30:36	mriedem	ok
04:30:44	mriedem	yeah i know we leak the flavor.id out of the REST API
04:31:31	alex_xu	in the filter, that is flavor.flavor_id
04:31:38	mriedem	ok
04:31:43	mriedem	i'll check back on it tomorrow
04:31:48	mriedem	i've got to go to bed
04:31:59	alex_xu	mriedem: thanks, have good sleep
04:32:19	mriedem	other than that it's looking good so shouldn't be a problem to get it in tomorrow
04:32:25	mriedem	alex_xu: just +2 when you're happy with it
04:35:51	alex_xu	gmann: thanks for the review
04:38:22	alex_xu	gmann: re: https://review.openstack.org/#/c/415330/21/nova/tests/unit/api/openstack/compute/test_serversV21.py, are you looking for cases for the new rule is overriden?
04:39:04	alex_xu	if you are looking for the cases for old rule is overriden, it is already there.
04:46:58	gmann	alex_xu: yea, old rule is there. i was thinking we can have tests only with new rule(overridden and not overridden) which are nothing but new deployer
05:11:30	openstackgerrit	Zhenyu Zheng proposed openstack/nova: Add sort_key white list for server list/detail https://review.openstack.org/415142
06:18:48	openstackgerrit	Zhenyu Zheng proposed openstack/nova: Add sort_key white list for server list/detail https://review.openstack.org/415142
06:25:26	openstackgerrit	Sreeram Vancheeswaran proposed openstack/nova: [WIP] Driver function call to enable attach volume for nova-dpm https://review.openstack.org/424996
06:48:12	openstackgerrit	Zhenyu Zheng proposed openstack/nova: Add new policy for server list/detail with all_tenants https://review.openstack.org/415330
07:17:09	openstackgerrit	Zhenyu Zheng proposed openstack/nova: Add release note and docs for filter/sort whitelist https://review.openstack.org/421760
07:45:01	openstackgerrit	Ghanshyam Mann proposed openstack/nova: Add "supports_device_tagging" in fake driver for tests https://review.openstack.org/425030
07:48:20	gmann	alex_xu: Kevin_Zheng this was causing issue on tag fix patch - https://review.openstack.org/#/c/425030/1
07:49:17	Kevin_Zheng	gmann: AH, thanks
07:52:44	alex_xu	gmann: cool
08:45:53	openstackgerrit	Hironori Shiina proposed openstack/nova: Ironic: Add soft power off support to Ironic driver. https://review.openstack.org/407977
08:54:23	openstackgerrit	Zhenyu Zheng proposed openstack/nova: Add new policy for server list/detail with all_tenants https://review.openstack.org/415330
09:01:55	claudiub|2	moshele: hi. I've replied to your comments on https://review.openstack.org/#/c/420614/ . Regarding PF/VF passthrough, I *might* be able to get a compute node with such capabilities today, so I check that out as well.
09:02:26	openstackgerrit	Rikimaru Honjo proposed openstack/nova: Add checks for preventing unexpected detaching volume https://review.openstack.org/354617
09:06:15	sfinucan	duonghq: Here now (Irish time). I'll take a look
09:13:29	moshele	claudiub|2: cool
09:13:40	moshele	claudiub: cool
09:13:54	sahid	johnthetubaguy: any chance you ack that one https://review.openstack.org/#/c/400874/, jaypipes already +2 it but i holidays now
09:16:45	openstackgerrit	Moshe Levi proposed openstack/nova: PCI: Check pci_requests object is empty before passing to support_requests https://review.openstack.org/423608
09:20:18	lyarwood	https://review.openstack.org/#/c/420146/ looking for a final core +2 +W on this findmnt workaround if anyone has time this morning
09:20:42	openstackgerrit	Guillaume Espanel proposed openstack/nova: Reduce time and memory usage of tenant usage. https://review.openstack.org/343734
09:26:06	lyarwood	johnthetubaguy, mikal, tonyb, claudiub ; I'm also looking to land https://review.openstack.org/#/c/412201/ on stable/newton today if anyone has the time to review this.
09:26:59	openstackgerrit	Zhenyu Zheng proposed openstack/nova: Disallow assgined floating IP that already assigned to other ports. https://review.openstack.org/425077
09:31:16	duonghq	sfinucan, thank you
09:36:57	gcb	sfinucan: I think we can merge another python 3 enable patch now :) https://review.openstack.org/#/c/414420/
09:37:26	sfinucan	gcb: I think the same :)
09:39:14	gcb	sfinucan, cool, thanks
09:42:39	lyarwood	johnthetubaguy, claudiub ; thanks! :)
09:47:06	sfinucan	lyarwood: Backporting is simply 'cherry-pick -x', right?
09:48:20	lyarwood	sfinucan: yeah, there's better docs here http://docs.openstack.org/project-team-guide/stable-branches.html
09:48:22	sfinucan	Actually, do we still bother with those 'backport' lines? I figured every bug should be backported, if it applied to the stable code too and didn't introduce a functional change
09:48:29	sfinucan	lyarwood: (y)
09:48:33	lyarwood	sfinucan: http://docs.openstack.org/project-team-guide/stable-branches.html#proposing-fixes for the actual workflow
09:48:36	openstackgerrit	Duong Ha-Quang proposed openstack/nova: Remove mox in nova/tests/unit/compute/test_shelve.py (3) https://review.openstack.org/342648
09:49:52	sfinucan	lyarwood: Excellent. Thank you. Think I've done it now (https://review.openstack.org/425087)
09:50:10	sfinucan	Hmm, commits to stable branches don't appear in IRC. Interesting...
09:51:38	sfinucan	duonghq: Thanks for respinning that. Appreciate it :)
09:52:00	duonghq	sfinucan, thank you very much
10:23:13	openstackgerrit	Stephen Finucane proposed openstack/nova: adding debug info for pinning calculation https://review.openstack.org/355150
10:36:56	openstackgerrit	Stephen Finucane proposed openstack/nova: Add PCIWeigher https://review.openstack.org/379524
10:37:53	openstackgerrit	Stephen Finucane proposed openstack/nova-specs: Remove templates from approved/implemented specs https://review.openstack.org/405550
10:44:30	openstackgerrit	Huan Xie proposed openstack/nova: Fix live migrate with XenServer https://review.openstack.org/424428
10:58:09	bhagyashris	Hi all, I have one question, In the multinode environment , Is there a need to enable the placement api service on compute node also?
10:58:35	openstackgerrit	Vasyl Saienko proposed openstack/nova: Implement interface attach/detach in ironic virt driver https://review.openstack.org/419975
10:59:11	johnthetubaguy	bhagyashris: everything talks to a single placement API endpoint (as defined in the keystone service catalog), over HTTP, if that helps.
11:01:06	BobBall	johnthetubaguy: Regarding https://review.openstack.org/#/c/424428/3/nova/objects/migrate_data.py is the "legacy dictionary" used anywhere now? i.e. should the to_legacy_dict method care about new fields added to the object?
11:01:42	johnthetubaguy	BobBall: I suspect now both old a new nodes are sending objects, we can drop all that code
11:02:11	BobBall	Rather than dropping in this patch I was assuming not bothering updating the legacy dict?
11:02:13	johnthetubaguy	BobBall: although technically speaking, we should bump the compute API major version to make that explicit
11:02:42	BobBall	I presume there should be a more global legacy-dictionary cleanup effort? rather than a per-object piecemeal approach?
11:03:27	BobBall	bah, you know what, the easiest path is just to update the dict anyway. Makes sure that if there is any dodgy code anywhere that it'll all work...

Earlier   Later