Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2017-01-24
17:35:08 sfinucan mdbooth: and +2'd
17:35:14 johnthetubaguy dansmith: thinking about: https://review.openstack.org/#/c/319379/73/nova/compute/api.py@1227
17:35:31 dansmith johnthetubaguy: see the comments in there. we previously figured out that we do need to do that, but we don't remember why. so I've stacked a patch on the end we can experiment with
17:35:43 melwitt johnthetubaguy: I pointed that out too, and I remember dansmith, mriedem and I all dug into once on a different review. but I can't remember what review it was so we can look at it
17:36:06 johnthetubaguy dansmith: melwitt: ah, gotcha, sorry, didn't check the history around that bit
17:36:37 openstackgerrit Dan Smith proposed openstack/nova: WIP: Remove duplicate BDM validation https://review.openstack.org/424719
17:36:37 openstackgerrit Dan Smith proposed openstack/nova: WIP: Collected release notes for Ocata CellsV2 https://review.openstack.org/424737
17:36:38 openstackgerrit Dan Smith proposed openstack/nova: Move instance creation to conductor https://review.openstack.org/319379
17:36:38 openstackgerrit Dan Smith proposed openstack/nova: Make api_samples tests use simple cell environment https://review.openstack.org/410473
17:36:43 dansmith johnthetubaguy: np, good eye :)
17:36:53 mriedem wasn't it the object copy thing?
17:36:57 dansmith melwitt: johnthetubaguy: comment added on the first, and that hack removed from the second ^
17:37:04 melwitt mriedem to the rescue
17:37:09 mriedem it was avolkov's patch
17:37:44 dansmith mriedem: yeah, but we must have discussed on irc
17:38:05 mriedem i thought we had captured the conversation in the review too
17:38:45 mriedem i don't remember the context on the object copy thing now either
17:39:03 johnthetubaguy its odd how we update the BDM, after the initial validate, duno if thats related: https://github.com/openstack/nova/blob/065cd6a8d69c1ec862e5b402a3150131f35b2420/nova/compute/api.py#L1302
17:39:14 melwitt I thought we discussed on the review too
17:40:04 mriedem https://review.openstack.org/#/c/374267/ is the patch i'm thinking of fwiw
17:40:33 melwitt yep that's the one
17:40:47 melwitt let's see if we recorded the detail of what's going on there
17:41:21 openstackgerrit Andrey Kurilin proposed openstack/python-novaclient: [CLI] Fix token auth type https://review.openstack.org/424256
17:41:26 mriedem https://review.openstack.org/#/c/374267/21/nova/compute/api.py@1197
17:43:47 melwitt nice
17:46:23 sfinucan dansmith: Yeah, that comment WFM too. Re-reviewing now
17:46:31 dansmith sfinucan: cool
17:47:02 paw Hi, how do you specify a microversion for nova/api? I'm trying to test some interoperability issue. Thanks.
17:49:01 artom paw, in the client? --os-compute-api-version=2.40
17:49:39 paw as in the python-novaclient?
17:50:29 paw aries: confirmed. thanks
17:50:43 artom paw, that option I gave is for the client, yes - both novaclient and openstackclient accept I think
17:51:19 paw artom: thanks
17:51:39 artom paw, you're welcome :)
17:52:43 openstackgerrit Dan Smith proposed openstack/nova: WIP: Remove duplicate BDM validation https://review.openstack.org/424719
17:52:43 dansmith johnthetubaguy: gdi.
17:52:43 openstackgerrit Dan Smith proposed openstack/nova: WIP: Collected release notes for Ocata CellsV2 https://review.openstack.org/424737
17:52:44 openstackgerrit Dan Smith proposed openstack/nova: Move instance creation to conductor https://review.openstack.org/319379
17:52:44 openstackgerrit Dan Smith proposed openstack/nova: Make api_samples tests use simple cell environment https://review.openstack.org/410473
17:52:58 dansmith johnthetubaguy: I don't know what to do in a world where _you_ are finding _my_ typos :P
17:55:42 johnthetubaguy dansmith: its a very crazy day!
17:55:48 dansmith heh
17:56:01 cburgess mdbooth Yes correct. An in general do anything we can to make sure the VM comes up.
17:56:18 cburgess mdbooth Think of it as a check list of what can we do to attempt to fix *anything* that might be wrong.
17:57:32 melwitt from what I can tell, I don't see why we would need the second _validate_bdm call. it doesn't seem to do anything except check things
17:58:05 melwitt in that other patch where we discussed the double validation, it was more than that, it was two calls of the self._bdm_validate_set_size_and_instance function, which does more
18:00:30 dansmith melwitt: well, lets see if we get a full run of the wip patch
18:01:16 mriedem well i'm going to call it a morning and head out for awhile, i'm already in trouble
18:01:41 melwitt o/
18:02:13 dansmith mriedem: thanks
18:02:59 openstackgerrit Sarafraj Singh proposed openstack/nova: Adopts keystoneauth with glance client. https://review.openstack.org/412634
18:05:38 openstackgerrit Sarafraj Singh proposed openstack/nova: Adopts keystoneauth with glance client. https://review.openstack.org/412634
18:22:24 openstackgerrit Artom Lifshitz proposed openstack/nova: Plumbing for tagged nic attachment https://review.openstack.org/415622
18:22:25 openstackgerrit Artom Lifshitz proposed openstack/nova: Libvirt support for tagged volume attachment https://review.openstack.org/418100
18:22:26 openstackgerrit Artom Lifshitz proposed openstack/nova: Plumbing for tagged volume attachment https://review.openstack.org/391941
18:22:27 openstackgerrit Artom Lifshitz proposed openstack/nova: API support for tagged device attachment https://review.openstack.org/376021
18:22:28 openstackgerrit Artom Lifshitz proposed openstack/nova: Libvirt support for tagged nic attachment https://review.openstack.org/415520
18:28:58 openstackgerrit STEW TY proposed openstack/nova: Transform instance.resize_confirm notification https://review.openstack.org/390654
18:29:42 openstackgerrit Gábor Antal proposed openstack/nova: Remove mox in unit/cells/test_cells_manager.py https://review.openstack.org/399036
18:36:34 openstackgerrit Artom Lifshitz proposed openstack/nova: Fix tag attribute disappearing in 2.32 and 2.37 https://review.openstack.org/424759
19:17:11 cdent bauzas: in your (not so) copious free time, you might find this bug fix to the resource tracker interesting: https://review.openstack.org/#/c/424305/
19:20:46 openstackgerrit Dan Smith proposed openstack/nova: WIP: Collected release notes for Ocata CellsV2 https://review.openstack.org/424737
19:20:47 openstackgerrit Dan Smith proposed openstack/nova: Move instance creation to conductor https://review.openstack.org/319379
19:22:43 dansmith melwitt: johnthetubaguy: okay I think I can just nuke the extra validate, so I did ^
19:24:48 openstackgerrit Andrey Kurilin proposed openstack/python-novaclient: DO NOT MERGE: experiment https://review.openstack.org/424809
19:34:50 artom Well crap, how does a vif in network_info end up with a vlan? I'm working on the tempest test for https://review.openstack.org/#/c/405951/ and the only way I've found to set a vlan on a Neutron network is to use provider:segmentation_id, but that required provider:network_type to be vxlan and for me to be an admin
19:38:02 openstackgerrit Stephen Finucane proposed openstack/nova: objects: add new field cpuset_reserved in NUMACell https://review.openstack.org/400874
19:42:09 dansmith johnthetubaguy I think this is good to go now: https://review.openstack.org/#/c/410473/
19:54:24 openstackgerrit Vladik Romanovsky proposed openstack/nova: Adding vlans filed to Device tagging metadata https://review.openstack.org/405951
19:55:30 openstackgerrit STEW TY proposed openstack/nova: Transform instance.resize_revert notification https://review.openstack.org/396811
20:02:48 bauzas dansmith: cdent: I could probably need some help for my grenade change
20:02:58 bauzas http://logs.openstack.org/30/424730/1/check/gate-grenade-dsvm-neutron-ubuntu-xenial/15ad17c/logs/grenade.sh.txt.gz#_2017-01-24_17_11_42_862
20:03:53 bauzas cdent: we need to deploy the placement engine by grenade
20:04:10 bauzas given the newton devstack doesn't deploy yet the placement service
20:05:17 dansmith bauzas: you're not sourcing something that brings in the base variable I imagine
20:05:24 cdent $FILES is not defined, looks like it is usually defined by stack.sh
20:05:38 bauzas mmm ok
20:06:43 dansmith looks like in stack.sh
20:06:50 dansmith so define it in there before you call those methods
20:06:54 dansmith $TOP_DIR/files
20:08:16 cdent bauzas: see upgrade-tempest for an example
20:08:45 cdent bauzas: and/or projects/30_swift/upgrade.sh
20:08:52 bauzas cdent: roger
20:09:18 cdent looks like those use $TARGET_DEVSTACK_DIR/files
20:11:12 bauzas dansmith: I guess I can deploy grenade on my local devstack for testing ?
20:11:28 dansmith if you're really really lucky :)
20:11:29 openstackgerrit OpenStack Proposal Bot proposed openstack/nova: Updated from global requirements https://review.openstack.org/424828
20:12:25 bauzas dansmith: you mean it's difficult?
20:13:10 dansmith bauzas: I mean I often have issues
20:14:02 cdent bauzas: I agree with dansmith: I often have issues, and in addition it takes forever to reach those issues, at which point you throw your hands up in the air
20:14:18 dansmith yeah
20:14:34 bauzas okay, so let's hit the gate...
20:37:40 amrith andreykurilin, the patch to requirements repo has come down to trove via the req bot. I've dep'ed your change on that. Hope that's what you intended.
20:42:15 andreykurilin amrith: everything should work now in trove
20:42:19 andreykurilin without my patch
20:45:15 openstackgerrit Andrey Kurilin proposed openstack/python-novaclient: [CLI] Fix token auth type https://review.openstack.org/424256
20:45:56 amrith andreykurilin, cool. in that case I'm going to announce my retirement and move to a beach somewhere where it is warm.
20:46:09 andreykurilin heh
20:46:09 amrith :)
20:46:21 amrith thanks andreykurilin I very much appreciate your help with this set of changes.

Earlier   Later