Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2017-01-24
16:33:30 dansmith mriedem: I could also just start a reno patch that we can keep augmenting for a while
16:33:39 mriedem that works too
16:33:55 dansmith lemme do that while I'm waiting
16:33:56 andreykurilin mriedem: About your reply to "Device tag in the API breaks in the old microversion". If the fix should be done via new microversion, should we wait a bit for adding it to new novaclient's release ?
16:34:02 openstackgerrit Balazs Gibizer proposed openstack/nova: handle uninited fields in notification payload https://review.openstack.org/415857
16:34:26 mriedem andreykurilin: we're going to have to bug fix it in novaclient
16:34:45 mriedem andreykurilin: e.g. --nic tag won't work in 2.37+
16:34:49 melwitt dansmith: this block is still commented out. I don't quite understand the comment, does it need to be moved to the conductor tests or? https://review.openstack.org/#/c/319379/72/nova/tests/unit/compute/test_compute.py@7937
16:34:51 mriedem so the client will probably need to handle that
16:34:59 dansmith melwitt: I moved it
16:35:09 dansmith oh, did I forgetto remove?
16:35:17 andreykurilin mriedem: sure, but should we wait for that bug fix to release it with 7.1.0 ?
16:35:24 dansmith melwitt: https://review.openstack.org/#/c/319379/72/nova/tests/unit/conductor/test_conductor.py
16:35:27 dansmith I forgot to remove, sorry
16:35:32 mriedem andreykurilin: i don't think we'll probably have time, unless someone fixes it today
16:35:54 melwitt dansmith: okay, I see
16:36:05 andreykurilin mriedem: nobody can do it until fix is not merged in nova's at first :)
16:36:10 mriedem alex_xu: cdent: Kevin_Zheng: do we have a bug to track the device tags issue?
16:36:25 mriedem andreykurilin: we already have a bug in novaclient
16:36:30 dansmith melwitt: thanks for catching those, I'm blind to this at this point
16:36:48 mriedem andreykurilin: i.e. if you try to create a server with the latest microversion and specify bdm or nic tags, it won't work
16:36:48 openstackgerrit Dan Smith proposed openstack/nova: WIP: Remove duplicate BDM validation https://review.openstack.org/424719
16:36:49 openstackgerrit Dan Smith proposed openstack/nova: Move instance creation to conductor https://review.openstack.org/319379
16:37:00 mriedem andreykurilin: i'm guessing you'd get a 400 for the schema validation error
16:37:23 openstack Launchpad bug 1658571 in OpenStack Compute (nova) "Microversion 2.37 break 2.32 usage" [High,In progress] - Assigned to Zhenyu Zheng (zhengzhenyu)
16:37:23 cdent mriedem: https://bugs.launchpad.net/nova/+bug/1658571 ?
16:37:42 cdent or do we need an additional one
16:37:47 mriedem cdent: looks right
16:37:47 openstackgerrit Stephen Finucane proposed openstack/nova: Assign mac address to vf netdevice when using macvtap port https://review.openstack.org/424639
16:37:51 mriedem we'll use one
16:38:10 mriedem added novaclient to it
16:38:23 cdent ✔
16:39:25 openstackgerrit Sylvain Bauza proposed openstack/nova: WIP: Scheduler calling the Placement API https://review.openstack.org/417961
16:39:27 openstackgerrit Dan Smith proposed openstack/nova: WIP: Collected release notes for Ocata CellsV2 https://review.openstack.org/424737
16:40:10 andreykurilin mriedem:as far as I understand nothing special should be done at novaclient's side
16:40:17 andreykurilin mriedem: just bumping max version
16:40:30 andreykurilin since it is just validation step at API side
16:40:53 mriedem andreykurilin: at a minimum, the help text on the nova boot command will need to be updated
16:41:14 mriedem to say that bdm tags only work with 2.32, and nic tags only work with 2.32->2.36
16:41:59 mriedem otherwise someone will be wondering why they can't create a server with device tags and microversion 2.40, for example
16:42:02 andreykurilin mriedem: can we reserve next microversion for that bug-fix, so it will be possible to release novaclient with support of that microversion today and than merge patch to API side?
16:42:17 melwitt dansmith: I pointed out on PS71 but didn't notice it's still there (sorry). did you want this logging here? https://review.openstack.org/#/c/319379/73/nova/compute/api.py@2517
16:42:20 andreykurilin *next microversion number
16:42:26 mriedem andreykurilin: i'd rather not try to reserve a microversion
16:42:51 mriedem andreykurilin: since there are some patches still up for review for nova before FF that bump microversions
16:43:03 dansmith melwitt: yeah I was going to keep that and the related ones as it helped me debug and only runs once
16:43:12 openstackgerrit Roman Podoliaka proposed openstack/nova: neutron: re-raise 401 for a non-admin client https://review.openstack.org/422696
16:43:12 melwitt okay, cool
16:43:29 andreykurilin mriedem: but it sounds like only possible solution to release novaclient with fixed bug
16:44:00 mdbooth lyarwood: Have the test changes in that patch gotten mixed up with one of the other patches?
16:44:10 mriedem andreykurilin: it's already broken in older versions of novaclient,
16:44:15 mdbooth lyarwood: https://review.openstack.org/#/c/399735/18/nova/tests/unit/virt/libvirt/test_driver.py
16:44:21 mriedem andreykurilin: so i'm less worried about rushing a fix in on the client side for a new microversion,
16:44:39 mriedem andreykurilin: i think it's good to just get a change into novaclient for ocata that updates the help to note the limitation on usage
16:44:58 mriedem andreykurilin: we can get the novaclient fix with the new microversion released in pike
16:47:15 lyarwood mdbooth: I don't think so, it was easier to rewrite some of the snapshot tests in mock that have increased the size if that's an issue
16:47:46 mdbooth lyarwood: Couldn't really see what was changing, tbh.
16:48:22 mdbooth However, if it's just my lack of understanding...
16:48:55 mdbooth lyarwood: Personally I'd have called that out in the commit message, or ideally do the test rewriting in the patch before.
16:48:59 lyarwood mdbooth: so we shouldn't really change anything aside from mocking out the additional XMLDesc calls
16:49:26 openstackgerrit Andrey Kurilin proposed openstack/python-novaclient: Clarify description for tags https://review.openstack.org/424745
16:49:45 andreykurilin mriedem: do you mean something like this - https://review.openstack.org/424745 ?
16:49:46 mdbooth It's just a surprising amount of churn. If it's necessary then ok, I'll just look harder.
16:50:19 lyarwood mdbooth: yeah, maybe I'm missing a smaller change we can make to the original mox tests tbh
16:50:34 lyarwood mdbooth: and if I am please feel free to call it out and I'll go over this again
16:51:20 mdbooth lyarwood: I'll keep looking. I thought you'd just made a mistake so I didn't look all that hard.
16:53:59 sfinucan vladikr: I don't know why mriedem removed his -2 on this https://review.openstack.org/#/c/405951 - doesn't it still require a version bump?
16:54:20 vladikr sfinucan, looking
16:54:23 sfinucan Actually, wait - you did bump the version. nvm :) What about a reno?
16:54:53 mriedem sfinucan: i had a -2 on it when the series was much longer and i wanted to make sure the tempest testing was done and testing that API change first
16:55:12 mriedem vladikr: you should link to the tempest change in the commit message
16:55:37 sfinucan mriedem: Gotcha
16:55:49 sfinucan mriedem: Also, aren't you supposed to be drinking cocktails on a beach somewhere? :)
16:56:14 vladikr mriedem, ok, got it. so I need a new tempest test written for this right?
16:56:31 mriedem vladikr: i thought you already had one started
16:56:44 vladikr mriedem, no, but will do now
16:57:19 vladikr sfinucan, do I need a reno for that change? I thought we wanted to update the user guide
16:57:56 openstackgerrit Roman Podoliaka proposed openstack/nova: block_device: fix propagation of instance AZ to Cinder https://review.openstack.org/366724
16:57:58 mriedem i'd have a feature reno for it and the metadata API version change
16:58:03 sfinucan vladikr: if it introduces a new, user-visible change then I would assume so?
16:58:23 vladikr sfinucan, mriedem, will add now
16:59:10 sfinucan (y)
16:59:31 johnthetubaguy melwitt: I had a sudden memory of how the flavor stuff avoid duplicates earlier, I added a comment on that quota patch
17:00:22 melwitt johnthetubaguy: I saw and replied. thanks :) I will go that route. working through all of the changes on the series now
17:00:38 johnthetubaguy melwitt: cool
17:01:27 mriedem vladikr: will this change work for config drive too?
17:02:44 vladikr mriedem, yes, sure
17:03:23 vladikr mriedem, config drive uses InstanceMetadata to build
17:03:23 mriedem vladikr: i'm not so sure, because that's done separately in the libvirt driver https://github.com/openstack/nova/blob/45e79583cea3a87df931c7333bf3c82de2979105/nova/virt/libvirt/driver.py#L3180
17:03:28 mriedem yes i know,
17:03:33 vladikr looking
17:03:44 mriedem but what you're changing in the metadata is the route from an API request to get the metadata
17:04:34 mriedem artom: have you noticed that we build the device metadata for an instance (which hits the db) even if we don't build the config drive? https://github.com/openstack/nova/blob/45e79583cea3a87df931c7333bf3c82de2979105/nova/virt/libvirt/driver.py#L3180
17:05:08 openstackgerrit Gábor Antal proposed openstack/nova: Remove mox in unit/cells/test_cells_manager.py https://review.openstack.org/399036
17:05:13 dansmith johnthetubaguy: see if those explanations make sense
17:05:31 johnthetubaguy dansmith: will take a peak, was just looking at next one
17:05:31 dansmith johnthetubaguy: sorry for saying this was simple. I've factored out all the complexity of "why" in my head I guess :)
17:05:49 johnthetubaguy dansmith: heh, no worries
17:06:17 johnthetubaguy dansmith: in that follow up, I saw a comment about 404 if nova-api service minimum version < 15, can't we avoid that?
17:07:01 dansmith johnthetubaguy: let me refresh my memory but I don't think we can

Earlier   Later