| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2017-01-24 | |||
| 16:05:46 | mriedem | andreykurilin: yes | |
| 16:05:52 | andreykurilin | nice | |
| 16:06:57 | mriedem | sfinucan: dansmith: ok +W | |
| 16:07:02 | sfinucan | mriedem: Aye, we've a downstream only workaround to handle that long running "nova doesn't recalculate CPU topologies on live migration" bug | |
| 16:07:05 | mriedem | thanks for not ramming that in all red hat cores | |
| 16:07:43 | andreykurilin | johnthetubaguy: your comment about transmitting --os-user-id in case of token auth made gates to fail :( it requires more changes in novaclient's code. will recent a fix soon | |
| 16:08:45 | sfinucan | We check for CPU pinning info in the topology and compare it against the free host cores. The pinning info should only exist in a live migrate case, but that bug broke the assumption and broke scheduling :) | |
| 16:09:00 | sfinucan | mriedem: Thanks for the review. I can go sleep now, heh | |
| 16:09:01 | dansmith | yea, it's pretty nasty | |
| 16:13:02 | mdbooth | lyarwood: I've still got a -1 on its parent, right? | |
| 16:13:53 | mdbooth | Or is it direct on master now? Gerrit doesn't make this clear. | |
| 16:14:02 | mdbooth | At a glance, anyway. | |
| 16:14:46 | lyarwood | mdbooth: yeah it really doesn't, it's direct on master now | |
| 16:14:54 | mdbooth | k | |
| 16:15:06 | lyarwood | mdbooth: there's an additional workaround in there so it can be btw | |
| 16:15:10 | openstackgerrit | Andrey Kurilin proposed openstack/python-novaclient: [CLI] Fix token auth type https://review.openstack.org/424256 | |
| 16:15:37 | lyarwood | mdbooth: https://review.openstack.org/#/c/399735/18/nova/virt/libvirt/guest.py | |
| 16:16:11 | mdbooth | lyarwood: How's your xpath-fu? | |
| 16:16:38 | lyarwood | mdbooth: not great but that's a copy paste from the original | |
| 16:16:41 | mdbooth | and xslt | |
| 16:17:10 | mdbooth | You can do the source/target thing in a single query :) | |
| 16:17:21 | mdbooth | I won't inflict that on anybody, though. | |
| 16:17:29 | mdbooth | (Well, I probably would if I'd written it ;)) | |
| 16:17:52 | lyarwood | even with a different attribute for both? | |
| 16:17:54 | lyarwood | nice | |
| 16:18:00 | mdbooth | Yeah | |
| 16:18:15 | mriedem | dansmith: so what do you want me to look at for cells v2? | |
| 16:18:43 | dansmith | mriedem: this and the following: https://review.openstack.org/#/c/410473/13 | |
| 16:18:45 | mriedem | keeping in mind i've got a 5 year old girl asking me when i'm going to take a shower so i can go swimming | |
| 16:18:58 | dansmith | mriedem: I had to recheck the d-g patch, let me go check that again | |
| 16:19:09 | mriedem | i just rechecked it | |
| 16:19:15 | dansmith | okay it's +1 | |
| 16:19:40 | dansmith | I emailed sdague about it yesterday but don't see that he looked at it | |
| 16:19:42 | mriedem | on https://review.openstack.org/#/c/396775/ and the stable sort limitation, | |
| 16:19:44 | dansmith | I'll poke clarkb | |
| 16:20:04 | mriedem | are we going to just doc that in a reno? or will we just say in release notes that multiple cells aren't supported in ocata? | |
| 16:21:13 | dansmith | mriedem: yeah, I've been kinda waiting to see how far I get, but a release note with the status of things was my plan | |
| 16:22:43 | EmilienM | mriedem: hi! quick question, do we wait https://review.openstack.org/#/c/424256/ to release the next novaclient? | |
| 16:23:39 | openstackgerrit | Pushkar Umaranikar proposed openstack/nova: Remove unused columns from BuildRequest table in nova_api db https://review.openstack.org/422259 | |
| 16:24:49 | sfinucan | dansmith: (Best effort) comments left on https://review.openstack.org/#/c/410473 | |
| 16:27:02 | dansmith | sfinucan: thanks, I'll explain in there | |
| 16:27:10 | sfinucan | (y) | |
| 16:27:57 | mriedem | EmilienM: yes, andrey has a patch up in reqs repo to blacklist 7.0 | |
| 16:28:48 | EmilienM | mriedem: ok, thank you ! | |
| 16:29:42 | openstackgerrit | Andrey Kurilin proposed openstack/python-novaclient: [CLI] Fix token auth type https://review.openstack.org/424256 | |
| 16:30:42 | dansmith | sfinucan: I tried to re-state the commit message.. let me know if that makes any more sense and if you think I should tweak what I have in some way | |
| 16:30:59 | dansmith | sfinucan: it is a pretty complicated problem that took a long time to figure out, although the actual change is rather small | |
| 16:31:09 | sfinucan | dansmith: Cheers. Will do | |
| 16:32:38 | mriedem | dansmith: i'll start keeping a tally of things we need to reno in the cells v2 wiki | |
| 16:33:14 | dansmith | mriedem: okay | |
| 16:33:30 | dansmith | mriedem: I could also just start a reno patch that we can keep augmenting for a while | |
| 16:33:39 | mriedem | that works too | |
| 16:33:55 | dansmith | lemme do that while I'm waiting | |
| 16:33:56 | andreykurilin | mriedem: About your reply to "Device tag in the API breaks in the old microversion". If the fix should be done via new microversion, should we wait a bit for adding it to new novaclient's release ? | |
| 16:34:02 | openstackgerrit | Balazs Gibizer proposed openstack/nova: handle uninited fields in notification payload https://review.openstack.org/415857 | |
| 16:34:26 | mriedem | andreykurilin: we're going to have to bug fix it in novaclient | |
| 16:34:45 | mriedem | andreykurilin: e.g. --nic tag won't work in 2.37+ | |
| 16:34:49 | melwitt | dansmith: this block is still commented out. I don't quite understand the comment, does it need to be moved to the conductor tests or? https://review.openstack.org/#/c/319379/72/nova/tests/unit/compute/test_compute.py@7937 | |
| 16:34:51 | mriedem | so the client will probably need to handle that | |
| 16:34:59 | dansmith | melwitt: I moved it | |
| 16:35:09 | dansmith | oh, did I forgetto remove? | |
| 16:35:17 | andreykurilin | mriedem: sure, but should we wait for that bug fix to release it with 7.1.0 ? | |
| 16:35:24 | dansmith | melwitt: https://review.openstack.org/#/c/319379/72/nova/tests/unit/conductor/test_conductor.py | |
| 16:35:27 | dansmith | I forgot to remove, sorry | |
| 16:35:32 | mriedem | andreykurilin: i don't think we'll probably have time, unless someone fixes it today | |
| 16:35:54 | melwitt | dansmith: okay, I see | |
| 16:36:05 | andreykurilin | mriedem: nobody can do it until fix is not merged in nova's at first :) | |
| 16:36:10 | mriedem | alex_xu: cdent: Kevin_Zheng: do we have a bug to track the device tags issue? | |
| 16:36:25 | mriedem | andreykurilin: we already have a bug in novaclient | |
| 16:36:30 | dansmith | melwitt: thanks for catching those, I'm blind to this at this point | |
| 16:36:48 | mriedem | andreykurilin: i.e. if you try to create a server with the latest microversion and specify bdm or nic tags, it won't work | |
| 16:36:48 | openstackgerrit | Dan Smith proposed openstack/nova: WIP: Remove duplicate BDM validation https://review.openstack.org/424719 | |
| 16:36:49 | openstackgerrit | Dan Smith proposed openstack/nova: Move instance creation to conductor https://review.openstack.org/319379 | |
| 16:37:00 | mriedem | andreykurilin: i'm guessing you'd get a 400 for the schema validation error | |
| 16:37:23 | openstack | Launchpad bug 1658571 in OpenStack Compute (nova) "Microversion 2.37 break 2.32 usage" [High,In progress] - Assigned to Zhenyu Zheng (zhengzhenyu) | |
| 16:37:23 | cdent | mriedem: https://bugs.launchpad.net/nova/+bug/1658571 ? | |
| 16:37:42 | cdent | or do we need an additional one | |
| 16:37:47 | mriedem | cdent: looks right | |
| 16:37:47 | openstackgerrit | Stephen Finucane proposed openstack/nova: Assign mac address to vf netdevice when using macvtap port https://review.openstack.org/424639 | |
| 16:37:51 | mriedem | we'll use one | |
| 16:38:10 | mriedem | added novaclient to it | |
| 16:38:23 | cdent | ✔ | |
| 16:39:25 | openstackgerrit | Sylvain Bauza proposed openstack/nova: WIP: Scheduler calling the Placement API https://review.openstack.org/417961 | |
| 16:39:27 | openstackgerrit | Dan Smith proposed openstack/nova: WIP: Collected release notes for Ocata CellsV2 https://review.openstack.org/424737 | |
| 16:40:10 | andreykurilin | mriedem:as far as I understand nothing special should be done at novaclient's side | |
| 16:40:17 | andreykurilin | mriedem: just bumping max version | |
| 16:40:30 | andreykurilin | since it is just validation step at API side | |
| 16:40:53 | mriedem | andreykurilin: at a minimum, the help text on the nova boot command will need to be updated | |
| 16:41:14 | mriedem | to say that bdm tags only work with 2.32, and nic tags only work with 2.32->2.36 | |
| 16:41:59 | mriedem | otherwise someone will be wondering why they can't create a server with device tags and microversion 2.40, for example | |
| 16:42:02 | andreykurilin | mriedem: can we reserve next microversion for that bug-fix, so it will be possible to release novaclient with support of that microversion today and than merge patch to API side? | |
| 16:42:17 | melwitt | dansmith: I pointed out on PS71 but didn't notice it's still there (sorry). did you want this logging here? https://review.openstack.org/#/c/319379/73/nova/compute/api.py@2517 | |
| 16:42:20 | andreykurilin | *next microversion number | |
| 16:42:26 | mriedem | andreykurilin: i'd rather not try to reserve a microversion | |
| 16:42:51 | mriedem | andreykurilin: since there are some patches still up for review for nova before FF that bump microversions | |
| 16:43:03 | dansmith | melwitt: yeah I was going to keep that and the related ones as it helped me debug and only runs once | |
| 16:43:12 | openstackgerrit | Roman Podoliaka proposed openstack/nova: neutron: re-raise 401 for a non-admin client https://review.openstack.org/422696 | |
| 16:43:12 | melwitt | okay, cool | |
| 16:43:29 | andreykurilin | mriedem: but it sounds like only possible solution to release novaclient with fixed bug | |
| 16:44:00 | mdbooth | lyarwood: Have the test changes in that patch gotten mixed up with one of the other patches? | |