| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2017-01-24 | |||
| 10:49:30 | johnthetubaguy | BobBall: why did it work before without the vif mappings there? | |
| 10:50:07 | openstackgerrit | Matthew Booth proposed openstack/nova: libvirt: Fix races in glusterfs mount/umount https://review.openstack.org/423402 | |
| 10:51:05 | BobBall | johnthetubaguy: The addition of the interim network to fix the neutron vlan tagging on vif/tap bug (and also to support neutron security groups) introduces a per-VIF network. The per-VIF network doesn't exist (by name) on the destination and therefore XAPI can no longer make a good guess for what the vif mapping should be. | |
| 10:51:43 | johnthetubaguy | BobBall: that would totally do it | |
| 10:52:09 | BobBall | johnthetubaguy: Indeed :( | |
| 10:53:20 | johnthetubaguy | BobBall: this isn't backportable, because of the object version stuff | |
| 10:53:29 | johnthetubaguy | as a heads up | |
| 10:54:02 | BobBall | Understood. I am trying to also understand whether we actually need to pass the mapping back; if we create a network with the same name on the target wouldn't XAPI just do the right thing(tm)? | |
| 10:54:21 | BobBall | Anyway - I'll put review comments in the code. Just wanted to highlight it for you as a heads up. | |
| 10:57:23 | johnthetubaguy | BobBall: why is the vif thing only used for VM.migrate_send? | |
| 10:57:36 | johnthetubaguy | BobBall: is it not accepted by the other call? | |
| 10:58:19 | BobBall | johnthetubaguy: Not needed for sure - it would probably be ignored if it was present. | |
| 10:58:32 | BobBall | johnthetubaguy: Good comment though, we can check the API to be sure. | |
| 11:01:20 | openstackgerrit | Gábor Antal proposed openstack/nova: Transform instance.trigger_crash_dump notification https://review.openstack.org/396225 | |
| 11:05:03 | openstackgerrit | Gábor Antal proposed openstack/nova: Transform instance.trigger_crash_dump notification https://review.openstack.org/396225 | |
| 11:07:39 | dims | sean-k-mooney : around? | |
| 11:07:56 | dims | sean-k-mooney : https://review.openstack.org/#/c/423718/ is ready. got the linuxbridge thing working | |
| 11:20:13 | openstackgerrit | Sylvain Bauza proposed openstack/nova: WIP: Scheduler calling the Placement API https://review.openstack.org/417961 | |
| 11:20:57 | bauzas | johnthetubaguy: new iteration, comments welcome $ | |
| 11:37:33 | mdbooth | pkoniszewski: Hey, I'm just looking at https://review.openstack.org/#/c/244489/ | |
| 11:38:00 | mdbooth | Inevitably looking at live migration flow | |
| 11:39:29 | mdbooth | So, source does a call to destination.check_can_live_migrate_destination(), which itself does a call back to source.check_can_live_migrate_source(), and then the destination returns the result of the call to the source back to the source over rpc | |
| 11:39:57 | mdbooth | So we're calling check_can_live_migrate_source() on the source, sending the results to the destanation, which then sends them back to the source | |
| 11:40:08 | mdbooth | That seems a little inefficient :) | |
| 11:40:19 | mdbooth | Anyway, that's a problem for another day | |
| 11:41:08 | mdbooth | More immediately, I think there might be a deadlock if there's an exception in _do_check_can_live_migrate_destination, but I'd very much like a second opinion | |
| 11:42:12 | mdbooth | Although... I think I may just have provided my own :) | |
| 11:42:21 | pkoniszewski | mdbooth: its not source that calls check_can_live_migrate_destination | |
| 11:42:27 | pkoniszewski | but conductor | |
| 11:42:35 | mdbooth | Ah, es | |
| 11:42:43 | mdbooth | Ok | |
| 11:43:24 | mdbooth | It just seems like an additional source of potential failure | |
| 11:45:05 | mdbooth | Re the deadlock, I was thinking that the lock held by live_migration_claim would be held for the duration of the claim context, but of course it's only held whilst generating the claim | |
| 11:45:10 | mdbooth | There's no deadlock | |
| 12:01:29 | johnthetubaguy | mdbooth: its only partially implemented, compute <-> compute RPC traffic shouldn't be allowed, from a security point of view, so ideally you have the conductor own the task, and send messages to the two compute nodes as required, and monitor progress. But naturally we don't have any of that, just the bad bits | |
| 12:16:18 | openstackgerrit | Gábor Antal proposed openstack/nova: Transform instance.reboot notifications https://review.openstack.org/382959 | |
| 12:18:35 | openstackgerrit | OpenStack Proposal Bot proposed openstack/os-vif: Updated from global requirements https://review.openstack.org/395347 | |
| 12:21:30 | openstackgerrit | Gábor Antal proposed openstack/nova: Transform instance.reboot notifications https://review.openstack.org/382959 | |
| 12:41:33 | openstackgerrit | Moshe Levi proposed openstack/nova: Assign mac address to vf netdevice when using macvtap port https://review.openstack.org/424639 | |
| 12:50:27 | openstackgerrit | Alex Xu proposed openstack/nova: Add new policy for server list/detail with all_tenants https://review.openstack.org/415330 | |
| 12:51:07 | openstackgerrit | Neil Jerram proposed openstack/nova: libvirt: avoid generating script with empty path https://review.openstack.org/411936 | |
| 12:51:23 | openstackgerrit | Alex Xu proposed openstack/nova: Add new policy for server list/detail with all_tenants https://review.openstack.org/415330 | |
| 12:51:37 | alex_xu | johnthetubaguy: gmann ^ just done the policy one | |
| 12:53:10 | openstackgerrit | Alex Xu proposed openstack/nova: Add sort_key white list for server list/detail https://review.openstack.org/415142 | |
| 12:57:01 | openstackgerrit | Andrey Kurilin proposed openstack/python-novaclient: [CLI] Fix token auth type https://review.openstack.org/424256 | |
| 12:57:40 | openstackgerrit | Stephen Finucane proposed openstack/nova: WIP: libvirt: Always enable firewall https://review.openstack.org/424647 | |
| 12:57:40 | openstackgerrit | Stephen Finucane proposed openstack/nova: conf: Deprecate two more nova-net options https://review.openstack.org/412390 | |
| 12:59:10 | andreykurilin | hi folks! there are several blocked projects(horizon, trove, cinder?!, murano-dashboard...) due to bug with token auth method. Here is a fix https://review.openstack.org/#/c/419441 . Functional tests are also attached there. | |
| 12:59:18 | andreykurilin | Please review as soon as possible | |
| 12:59:49 | andreykurilin | alex_xu johnthetubaguy sdague ^ | |
| 13:00:43 | macsz | danpb ping | |
| 13:00:45 | andreykurilin | Also, I found that token auth method via CLI was broken for a long time(for several novaclient's releases). Fix is the next patch in the chain | |
| 13:01:30 | openstackgerrit | Stephen Finucane proposed openstack/nova: conf: Deprecate 'console_driver' https://review.openstack.org/408193 | |
| 13:01:30 | openstackgerrit | Stephen Finucane proposed openstack/nova: console: Move proxies to 'console/proxy' https://review.openstack.org/408192 | |
| 13:01:33 | kashyap | macsz: He's not on the channel | |
| 13:01:58 | andreykurilin | amrith: several folks verified that fix to novaclient helped with horizon (it uses token auth too). It should help in your case too. let's merge it, make new novaclient's release and recheck trove's code | |
| 13:02:00 | macsz | kashyap do you know where can i find him? | |
| 13:02:02 | kashyap | macsz: Maybe email him or, if it's a public Nova issue, write to upstream openstack-dev list, and CC him | |
| 13:02:12 | johnthetubaguy | andreykurilin: I am running to lunch, but do we know which patch caused the problem? | |
| 13:02:16 | macsz | kashyap: thanks | |
| 13:02:37 | andreykurilin | johnthetubaguy: bon appetit! | |
| 13:03:49 | sfinucan | johnthetubaguy: An easy, post-merge conflict +2/+W for you (for after lunch :)) https://review.openstack.org/408193 | |
| 13:03:52 | andreykurilin | johnthetubaguy: for python-api - my patch which removes custome implementation of HTTPClient made it. there were a bunch of patches with + from keystone cores, but we missed to transmit several variables to keystone Token class | |
| 13:04:18 | openstackgerrit | Steven Webster proposed openstack/nova: Release PCI devices on drop_move_claim() https://review.openstack.org/370374 | |
| 13:04:57 | andreykurilin | johnthetubaguy: as for CLI, imo, https://github.com/openstack/python-novaclient/commit/1f11840dd84f3570330d1fcd53d1e8eea5ff7922 broke it. more than a year ago.. | |
| 13:05:22 | takashin | bauzas: Are you around? | |
| 13:06:45 | mdbooth | Do we currently recalculate numa topology on live migration? | |
| 13:07:01 | andreykurilin | johnthetubaguy: in case of python-API: previously, Token auth method worked only via our custom HTTPClient implementation. It means that only Keystone V2 was supported. Switch to SessionClient for 100% cases was done here - https://review.openstack.org/#/c/304035/ | |
| 13:08:13 | sfinucan | mdbooth: Narp | |
| 13:08:24 | sfinucan | mdbooth: Isn't that the patch you were reviewing last night? | |
| 13:08:28 | mdbooth | sfinucan: Ok, cool. | |
| 13:08:40 | mdbooth | sfinucan: I'm reviewing it now, but I was wondering if it clashed with anything :) | |
| 13:09:27 | sfinucan | Aha, no - you're good. None of that stuff is recalculated at present, leading to a host of bugs around CPU pinning, hugepages and anything else NUMA-affinitized | |
| 13:09:50 | mdbooth | sfinucan: Have you reviewed this, btw? | |
| 13:10:47 | sfinucan | Aye, multiple times. I never made it to the end though before it got respun :) | |
| 13:11:50 | mdbooth | I'm assuming that means that, priority list or not, it's not making it into Ocata. | |
| 13:12:00 | mdbooth | It's 'one of those' | |
| 13:13:05 | mdbooth | sfinucan: Incidentally, how do guests feel about having their instance topologies changed? | |
| 13:13:24 | mdbooth | sahid: Do you know the answer to ^^^ ? | |
| 13:13:51 | sfinucan | mdbooth: idk - it really needs to get in but we keep finding corner cases (race conditions, etc.) | |
| 13:14:06 | sfinucan | ...and it's so damn big that reviewing it turns into a chore each time | |
| 13:14:10 | mdbooth | Where have the races been? | |
| 13:14:19 | mdbooth | There's one in there now, btw. I already commented on that. | |
| 13:14:34 | mdbooth | It's trivial to fix, though, just a missing sync context manager | |
| 13:14:48 | sfinucan | cfriesen pointed out a few some time back. I don't know if they were addressed | |
| 13:15:48 | sfinucan | mdbooth: As for the instance topology, I don't think the actual topologies change | |
| 13:15:59 | sfinucan | i.e. how many sockets/cores/threads everything has | |
| 13:16:09 | sfinucan | rather, how these are aligned under the hood | |
| 13:16:15 | sfinucan | on the host, that is | |
| 13:19:28 | sfinucan | I could be wrong there though. The scheduler is still mostly black magic to me :( | |
| 13:20:30 | sfinucan | mdbooth: numa_fit_instance_to_host takes an already defined instance_topology and shouldn't change anything about that (besides pinning information, which is the bug I'm sidestepping here https://review.openstack.org/#/c/419479/) | |
| 13:20:50 | mdbooth | sfinucan: Cool. | |
| 13:23:14 | openstackgerrit | Stephen Finucane proposed openstack/nova: pci: Validate behavior of empty devname https://review.openstack.org/396130 | |
| 13:32:32 | openstackgerrit | Radomir Dopieralski proposed openstack/python-novaclient: Pass relevant parameters to Token based authentication https://review.openstack.org/419441 | |
| 13:44:01 | openstackgerrit | Gábor Antal proposed openstack/nova: Added instance.reboot.error to the legacy notifications https://review.openstack.org/411816 | |
| 13:50:07 | bauzas | johnthetubaguy: not sure I see which points in particular you want to change for https://review.openstack.org/#/c/417961/20 ? | |
| 13:50:32 | bauzas | johnthetubaguy: just a naming thing, or more about how to not return a NoValidHosts in case we don't have the placement service ready yet ? | |
| 13:50:50 | johnthetubaguy | bauzas: the naming thing was my main worry | |
| 13:50:57 | bauzas | the latter needs discussion because I think the general agreement was against that | |
| 13:51:05 | bauzas | but that's tied to the grenade issue | |