Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2017-01-23
16:33:57 mriedem is it the resource tracker that's setting it to hypervisor_hostname?
16:33:57 bauzas cdent: giving you a sense of what I call "a shit ton of assumptions"
16:34:04 bauzas mriedem: it is indeed
16:34:20 mriedem so how about we name it hypervisor_hostname + nodename?
16:34:25 mriedem surely those would be unique in the real world
16:34:47 mriedem for our fixtures and tests, we probably have those copied all over the place, but we could just fix that
16:34:50 bauzas mriedem: hypervisor_hostname == nodename but I get your idea
16:34:50 mriedem with uuids or something
16:35:06 bauzas mriedem: you mean service hostname + hypervisor_hostname
16:35:24 bauzas lemme try this
16:35:29 openstackgerrit Dan Smith proposed openstack/nova: Make api_samples tests use simple cell environment https://review.openstack.org/410473
16:35:29 openstackgerrit Dan Smith proposed openstack/nova: Multicell support for instance listing https://review.openstack.org/396775
16:35:30 openstackgerrit Dan Smith proposed openstack/nova: WIP Move instance creation to conductor https://review.openstack.org/319379
16:35:33 dansmith sfinucan: thanks for catching that, fixed here ^
16:36:11 BobBall jroll: What do you know - it looks like it works! Many thanks
16:36:13 openstackgerrit Claudiu Belu proposed openstack/nova: hyper-v: Adds support for VMs with nested virtualization https://review.openstack.org/398509
16:36:14 openstackgerrit Claudiu Belu proposed openstack/nova: Adds CPUFeaturesField to ImageMetaProps https://review.openstack.org/420960
16:36:30 cdent mriedem, bauzas: wait, are we saying that hypervisor hostname is not unique? is it not an FQDN?
16:36:51 bauzas cdent: not with the FakeDriver at least
16:37:00 cdent bauzas: the fake driver is _fake_
16:37:04 cdent and can be changed
16:37:09 cdent so isn't really a true issue
16:37:13 bauzas cdent: sure, what I did
16:37:21 cdent I'm trying to figure out if there is a real issue
16:37:25 bauzas cdent: I changed that to being defaulted to the service hostname
16:37:32 bauzas cdent: but kaboom
16:37:46 cdent hypervisor hostname is unique, job done
16:37:53 bauzas because in lots of places, we litterally say hypervisor_hostname == 'fake-mini'
16:37:55 cdent that's because in a test context service hostname is not unique, right?
16:38:05 jroll BobBall: \o/
16:38:13 cdent so we just fix that, right?
16:38:56 bauzas cdent: that's because we stupidely get the value from the first CONF.host value which is set to 'fake-mini' (because of the ConfFixture)
16:39:29 bauzas so we wrote around 500 tests saying "cool, let's just assume it's fake-mini whatever the compute node name is"
16:39:56 bauzas honestly, mriedem's proposal seems the less boring approach
16:40:41 cdent that means changing the names of existing resource providers out there in a deployed world?
16:40:42 mriedem bauzas: i also agree with cdent,
16:40:54 mriedem in that if the hostname is just fqdn, and we have a bunch of dumb tests, we just fix the tests that need fixing,
16:41:02 mriedem i doubt it's 500 that we need to fix 'right now'
16:41:28 bauzas mriedem: sure, we can do that, I leave others fix that then
16:41:42 bauzas https://review.openstack.org/#/c/424110/1 is just red tomato
16:42:24 cdent bauzas: If it helps, I can do that.
16:42:37 cdent As it has to be done, right?
16:43:02 bauzas cdent: if we agree on that being a necessary prereq for merging the scheduler change, I'm fine
16:43:07 openstackgerrit Bob Ball proposed openstack/nova: XenAPI: fix memory usage miscalculation https://review.openstack.org/394857
16:43:25 bauzas cdent: yup, lemme show you why it's important
16:43:28 cdent bauzas, fine with me doing it, or fine you'll take care of it?
16:43:34 cdent I know why it is important
16:44:09 bauzas cdent: http://paste.openstack.org/show/595821/ L62
16:45:42 mriedem bauzas: so let's just focus on fixing the tests that need fixing right now to move you along
16:45:56 bauzas okay
16:47:06 cdent bauzas: If there's some task or chunk of a task that you can split off to me, let me know.
16:47:11 bauzas mriedem: cdent: so we all agree with the fact that the FakeDriver should stop reporting the same hypervisor hostname?
16:47:26 mriedem sure
16:47:35 mriedem i mean yeah probably
16:47:44 mriedem it depends on context
16:47:46 cdent At least in the context of the scheduler related tests
16:47:52 mriedem jinx
16:47:56 cdent buy me a coke
16:48:23 bauzas mriedem: cdent: we could compare with other drivers
16:48:26 cdent Perhaps a UniqueHostnameFakeDriver subclass could help?
16:48:41 mriedem yeah that's not a bad idea
16:48:42 bauzas cdent: interesting idea
16:48:53 bauzas that would prevent us to fix the world
16:48:55 mriedem then just override the config with that in setUp for the tests that care
16:49:11 bauzas mriedem: cdent: I like that idea, I can spin a patch easily then
16:49:12 mriedem well, you could TODO it in ocata,
16:49:23 mriedem TODO(bauzas): this is temporary until we can fix all of the tests
16:49:39 bauzas mriedem: agreed
16:49:44 cdent \o/
16:49:52 bauzas mriedem: I also need to verify the other drives
16:49:53 cdent we have just experienced successful collaboration
16:50:00 gabor_antal I'd like to notice, that we also have this hostname problem when we want to test live migration notification (e.g. https://review.openstack.org/#/c/402124/)
16:50:03 cdent achievement unlocked!
16:50:06 bauzas I'm pretty sure for libvirt that the nodename is equal to the service name
16:50:26 bauzas for ironic, it's easy : it's the ironic node uuid
16:50:39 bauzas but I leave the question open for other drivers
16:53:48 openstackgerrit Bob Ball proposed openstack/nova: XenAPI: fix memory usage miscalculation https://review.openstack.org/394857
16:58:39 andreykurilin mriedem: it looks like "token" auth is compitely broken in novaclient. It doesn't work for CLI where keystoneauth creates session object itself(I do not know how many releases it was broken) and in python API (my patch broke it). I'll try to fix is asap and we need to cut new release
17:03:45 mriedem andreykurilin: https://review.openstack.org/#/c/419441/ right?
17:03:50 openstackgerrit STEW TY proposed openstack/nova: Transform instance.unrescue notifications https://review.openstack.org/388275
17:04:23 andreykurilin mriedem: 1) it contains a bug. It fixes only python api
17:04:45 andreykurilin I'll re-submit it to pass gates
17:06:59 openstackgerrit Andrey Kurilin proposed openstack/python-novaclient: Pass relevant parameters to Token based authentication https://review.openstack.org/419441
17:07:20 openstackgerrit Dan Smith proposed openstack/nova: Only warn about hostmappings during ocata upgrade https://review.openstack.org/424243
17:08:28 dims mriedem : notice the gate-tempest-dsvm-py35-ubuntu-xenial-nv in check queue? (example https://review.openstack.org/#/c/323250/)
17:09:51 mdbooth bauzas: When doing a migration with an explicit destination, would it make sense to do make a scheduler call anyway restricted to just that destination to see if it succeeds?
17:10:05 mdbooth For all I know we already do this somewhere, just thinking...
17:10:16 bauzas mdbooth: for a live migration, we do that already
17:10:32 mdbooth I'm looking here: https://review.openstack.org/#/c/244489/58/nova/conductor/tasks/live_migrate.py
17:10:32 bauzas mdbooth: for cold ones, there is a BP from takashi
17:10:54 mdbooth explicit destination doesn't call _find_destination() there
17:11:13 mdbooth But perhaps it's called elsewhere.
17:11:38 mdbooth Well, not _find_destination, but some other scheduler call.
17:11:56 mriedem dims: notice what?
17:12:06 mriedem dims: if it's non-voting i'm not noticing it right now
17:14:42 bauzas mriedem: https://github.com/openstack/nova/blob/c9eb9530314d047f5013941ebcfd5ef0192a9dc3/nova/compute/api.py#L3773
17:16:08 dims mriedem : ack. it's green that's all :)
17:16:35 mriedem dims: oh you were looking for some back patting, i see
17:16:51 mriedem #success dims got gate-tempest-dsvm-py35-ubuntu-xenial-nv green
17:16:53 openstackstatus mriedem: Added success to Success page

Earlier   Later