Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2017-01-18
02:57:38 openstackgerrit Yoshihiko Atsumi proposed openstack/nova: Add revert resized server functional negative tests https://review.openstack.org/421639
02:58:23 huanxie Hi jaypipes I've added a new unit test to cover all scenario in my VM rescue/unrescue patch https://review.openstack.org/413469, could you help review again, thanks a lot
02:58:34 jaypipes huanxie: you're up late :)
02:59:27 jaypipes huanxie: +2 from me.
02:59:29 huanxie haha :)
02:59:36 huanxie Thanks
02:59:44 jaypipes np, thx for your patience!
03:00:51 huanxie jaypipes: your comments are reasonable, I should fix it:)
03:23:28 EmilienM mriedem: not 100% sure but I think I found another problem with placement api, where nova compute doesn't refresh the resource provider record correctly. It used to work a few days ago but not anymroe
03:23:36 EmilienM http://logs.openstack.org/66/421366/1/check/gate-puppet-openstack-integration-4-scenario004-tempest-centos-7/f138bcc/logs/nova/nova-compute.txt.gz#_2017-01-17_17_45_52_920
03:27:09 openstackgerrit ChangBo Guo(gcb) proposed openstack/nova: Port compute.test_user_data.ServersControllerCreateTest to Python 3 https://review.openstack.org/406435
03:27:09 openstackgerrit ChangBo Guo(gcb) proposed openstack/nova: Enable virt.test_virt_drivers.AbstractDriverTestCase on Python 3 https://review.openstack.org/414419
03:27:10 openstackgerrit ChangBo Guo(gcb) proposed openstack/nova: Enable virt.vmwareapi test cases on Python https://review.openstack.org/414420
03:27:10 openstackgerrit ChangBo Guo(gcb) proposed openstack/nova: Enable more virt.xenapi tests on Python 3 https://review.openstack.org/414421
04:15:45 openstackgerrit Hieu LE proposed openstack/nova: Remove mox from unit/virt/libvirt/test_imagebackend.py (5) https://review.openstack.org/335921
04:28:56 openstackgerrit Hieu LE proposed openstack/nova: Completely remove mox from objects/test_instance.py https://review.openstack.org/343465
05:16:40 gmann alex_xu: filter values we cannot restrict/correct with schema without version bump right? on this - https://review.openstack.org/#/c/418880/
05:17:16 alex_xu gmann: yea, we can't do that now.
05:17:53 alex_xu gmann: this series looks like very close https://review.openstack.org/#/q/status:open+project:openstack/nova+branch:master+topic:bp/add-whitelist-for-server-list-filter-sort-parameters
05:18:14 gmann alex_xu: on that only :).
06:00:41 openstackgerrit Cao Xuan Hoang proposed openstack/nova: Add python 3 classifiers https://review.openstack.org/421677
06:06:00 openstackgerrit Hieu LE proposed openstack/nova: Completely remove mox from objects/test_instance.py https://review.openstack.org/343465
07:07:08 archies @hi auggy
07:39:26 sahid jaypipes: hello, any chance you have a look at https://review.openstack.org/#/c/400875/ ?
07:48:03 openstackgerrit melanie witt proposed openstack/nova: Make Quotas object favor the API database https://review.openstack.org/410945
07:48:03 openstackgerrit melanie witt proposed openstack/nova: WIP Count resources to check quota for cells https://review.openstack.org/416521
07:48:04 openstackgerrit melanie witt proposed openstack/nova: Add online migration to move quotas to API database https://review.openstack.org/410946
07:52:18 openstackgerrit Sivasathurappan Radhakrishnan proposed openstack/nova: Use mask_dict_password from oslo.utils https://review.openstack.org/388345
07:55:47 openstackgerrit Sivasathurappan Radhakrishnan proposed openstack/nova: Add image_meta when unshelving volume backend vm https://review.openstack.org/347063
08:01:17 openstackgerrit Tovin Seven proposed openstack/nova: Integrate OSProfiler and Nova https://review.openstack.org/254703
08:01:19 gmann alex_xu: can you check my comments on this- https://review.openstack.org/#/c/415142/21
08:01:41 gmann alex_xu: i did not get sort_dir filter things till i am not missing anything
08:05:17 gmann alex_xu: API says "If you omit the sort direction in a pair, the API uses the natural sorting direction of the direction of the server sort_key attribute." it means we should prepare the sort_dir with 'desc' if not passed with sort_key but common.get_sort_params(req.params) does not seems to do ?
08:06:33 Kevin_Zheng gmann
08:06:59 Kevin_Zheng I already notice the problem about key and dir while coding
08:07:11 Kevin_Zheng I think it is a bug
08:07:19 gmann Kevin_Zheng: oh, it mean it never working?
08:07:41 Kevin_Zheng I mean
08:08:13 Kevin_Zheng if we don't strict the user to provide both key and dir
08:08:22 gmann Kevin_Zheng: actually now in this BP it might be issue as we are removing the sort_dir and endup with removal of sor_dir of other sort_key
08:08:30 Kevin_Zheng it will be a mess when we do the deleting
08:08:31 Kevin_Zheng yes
08:08:35 gmann Kevin_Zheng: true but we says they can omit the sort_dir
08:10:02 Kevin_Zheng I think it is already wrong when doing key=key1&key=key2&dir=dir2&key=key3&dir=dir3
08:10:26 Kevin_Zheng it will be [key1,key2,key3]and [dir2,dir3] in api
08:10:30 Kevin_Zheng already broken
08:10:54 Kevin_Zheng key1 is already using dir2
08:11:01 Kevin_Zheng no matter we are deleting or not
08:11:15 Kevin_Zheng it is already a bug IMO
08:11:34 Kevin_Zheng neutron strict the user to provide both key and dir
08:12:03 Kevin_Zheng If I remembered correctly
08:12:32 gmann Kevin_Zheng: yea, thats true. did we force to use both ?
08:12:42 Kevin_Zheng In nova it is impossible to decide which dir belongs to which key
08:13:14 Kevin_Zheng well I think it needs further discussion and maybe a BP for next cycle
08:13:47 Kevin_Zheng but the current implementation of whitelist bp is just kept current behaviour
08:14:01 Kevin_Zheng since it is already broken IMO
08:15:18 alex_xu gmann: the db layer done that https://github.com/openstack/nova/blob/master/nova/db/sqlalchemy/api.py#L2111
08:17:17 Kevin_Zheng Yeah, but as we discussed before, the key could be messed, because I was putting asc for key2 and key1 should be with defalt desc but the acutal response will be asc for key1 and defult desc for key2
08:17:30 Kevin_Zheng IMO it is a bug
08:17:51 Kevin_Zheng Still, out of the scope of the BP, I thinks
08:18:04 gmann alex_xu: but it append at end and all sort_dir are being mixed if not provided for any key in between
08:18:48 Kevin_Zheng I think we should strict user to provide both, just my opinion
08:19:00 gmann hummm
08:19:52 Kevin_Zheng or it should be handeled in a different way
08:20:01 Kevin_Zheng like key value pairs
08:20:16 Kevin_Zheng two list is imposible to handle
08:20:54 gmann i think we can do while fetching them from req
08:21:53 gmann but yea its out of scope of this BP, ll not block on this
08:22:04 gmann something we can fix later
08:22:10 Kevin_Zheng yeah
08:22:32 gmann alex_xu: Kevin_Zheng about whitelist for sort_key, its not matching with spec one ?
08:23:14 Kevin_Zheng I will check, too many fields and possible to miss one or two :)
08:24:54 alex_xu yea, we didn'i miss anyone
08:25:07 alex_xu oops, hope we didn't miss anyone
08:25:57 gmann alex_xu: Kevin_Zheng i thin we missed in spec seems: created_at', 'updated_at',
08:26:39 gmann but those seems very valid one so should be ok to add in code
08:27:06 Kevin_Zheng yeah will do after writing the doc
08:27:11 alex_xu gmann: created_at and updated_at are in the line 271 and 272
08:27:44 gmann alex_xu: yea in code its there but not in spec :)
08:27:58 alex_xu gmann: oops, I guess we miss that
08:28:17 gmann Kevin_Zheng: can just put those in spec but may be later no big deal as there will not be any objection on those
08:28:33 alex_xu gmann: +1 for update spec
08:29:01 Kevin_Zheng yeah, might be a cleanup after code done
08:29:57 openstackgerrit Vladik Romanovsky proposed openstack/nova: libvirt: expose virtual interfaces with vlans to metadata https://review.openstack.org/405954
08:29:57 openstackgerrit Vladik Romanovsky proposed openstack/nova: Adding vlans filed to Device tagging metadata https://review.openstack.org/405951
08:30:12 gmann 'updated_at' should be fine right ? i remember some discussion we had on this when this will be null at initial time
08:30:34 gmann i hope we do not default it to created_at
08:32:39 alex_xu gmann: updated_at and created_at looks like fine to me, that are in the API representation.
08:32:55 gmann ok
08:52:18 openstack Launchpad bug 1657366 in OpenStack Compute (nova) "sort_key and sort_dir combination are not being honored in correct way" [Undecided,New] - Assigned to Ghanshyam Mann (ghanshyammann)
08:52:18 gmann alex_xu: Kevin_Zheng just logged that as bug in case we forget - https://bugs.launchpad.net/nova/+bug/1657366
08:52:36 alex_xu gmann: cool
08:52:43 Kevin_Zheng Thanks
09:18:28 openstackgerrit Zhenyu Zheng proposed openstack/nova: Add release note and docs for filter/sort whitelist https://review.openstack.org/421760
09:21:13 openstackgerrit sahid proposed openstack/nova: libvirt: update the active migrations DS to support migration result https://review.openstack.org/409260
09:21:14 openstackgerrit sahid proposed openstack/nova: libvirt: ensure live-migration success https://review.openstack.org/409261
09:27:47 openstackgerrit sahid proposed openstack/nova: objects: remove related pining from __init__ of InstanceNUMATopology https://review.openstack.org/408242
09:27:48 openstackgerrit sahid proposed openstack/nova: objects: remove cpu_topology from __init__ of InstanceNUMATopology https://review.openstack.org/408240
09:27:48 openstackgerrit sahid proposed openstack/nova: objects: remove pagesize from __init__ of InstanceNUMATopology https://review.openstack.org/408241
09:33:32 Kevin_Zheng alex_xu: should we strict sort_dir now?

Earlier   Later