Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2017-01-17
21:42:06 openstackgerrit Ed Leafe proposed openstack/nova: Add check for invalid allocation amounts https://review.openstack.org/416752
21:42:06 openstackgerrit Ed Leafe proposed openstack/nova: Remove the Allocation.create() method. https://review.openstack.org/416751
21:42:45 edleafe bauzas: found a bug in your recent merge: https://review.openstack.org/#/c/392569/27/nova/tests/functional/api/openstack/placement/fixtures.py@106 (and line 112)
21:43:11 edleafe bauzas: there is a step_size of 10, but an allocation of 512, which should fail, but doesn't
21:43:33 edleafe bauzas: the change to AllocationList.create_all() caught it
21:50:52 openstackgerrit Jiri Suchomel proposed openstack/nova: Retry few times when creating the initial connection to libvirtd. https://review.openstack.org/416928
21:54:43 bauzas edleafe: not sure it's due to my bug but okay:)
21:57:51 edleafe bauzas: when you added the step_size, min_unit, and max_unit, the subsequent allocation should have failed, since 512 isn't a multiple of 10
21:58:07 edleafe The old code happily created the allocation
21:58:13 edleafe The new code won't
21:59:09 siva_krishnan tdurakov ?
22:00:36 tdurakov siva_krishnan: hi, what's up?
22:01:09 openstack Launchpad bug 1647451 in OpenStack Compute (nova) "duplicate for #1599057 Post live migration step could fail due to auth errors" [Medium,Fix released] - Assigned to Timofey Durakov (tdurakov)
22:01:09 siva_krishnan this is regarding bug https://bugs.launchpad.net/nova/+bug/1599057
22:01:47 bauzas edleafe: but I haven't provided the allocation API, right?
22:02:00 tdurakov Yes
22:02:05 bauzas unless I misunderstand
22:02:40 siva_krishnan tdurakov: my intent of putting up patch for that bug is to do rollback on exception which occurs prior to live migration
22:03:21 slaweq oomichi: hello
22:03:51 slaweq oomichi: can You maybe look at https://review.openstack.org/#/c/420176/ ?
22:04:01 slaweq oomichi: I answered to Your comment there
22:04:16 siva_krishnan as you mentioned the bug description says the timeout happened during post live migration
22:04:19 slaweq oomichi: and I want to know what You think a about it
22:05:06 tdurakov siva_krishnan: yes, I understand that, the thing is that trying to call rollback here could be very tricky
22:05:26 edleafe bauzas: nothing to do with the API
22:05:53 tdurakov E.g. Exception is raised during roll-back itself
22:06:01 edleafe bauzas: In the change I referenced you added constraints to the inventory in the fixture that should have made the subsequent allocations invalid
22:06:26 bauzas ah right
22:06:37 edleafe When I rebased on master these tests started failing, since my code removes Allocation.create()
22:06:52 bauzas sorry then
22:06:57 edleafe bauzas: Oh, don't be
22:07:02 bauzas so only the gabbits are failing
22:07:22 edleafe bauzas: I was just saying that the placement code is getting more accurate
22:07:36 siva_krishnan tdurakov: ah ok you are right but I do see that pre_live_migration failure does the rollback as well
22:08:42 bauzas edleafe: unfortunately, that modification was done by jay, but I didn't reviewed it
22:08:43 tdurakov I'll leave a comment on the patch trying to explain details, pre-step is way more specific, that's why it's safe
22:08:50 bauzas edleafe: thanks for that
22:10:24 siva_krishnan tdurakov: that helps :).
22:37:41 openstackgerrit Sylvain Bauza proposed openstack/nova: WIP: Scheduler calling the Placement API https://review.openstack.org/417961
22:37:41 openstackgerrit Sylvain Bauza proposed openstack/nova: Add ComputeNodeList.get_all_by_uuids method https://review.openstack.org/418134
23:09:54 openstackgerrit Anusha Unnam proposed openstack/nova: Add keypairs field to InstancePayload https://review.openstack.org/419730
#openstack-nova - 2017-01-18
00:06:54 openstackgerrit Davanum Srinivas (dims) proposed openstack/nova: [WIP] ignore me - trying experimental jobs https://review.openstack.org/421209
00:34:24 openstackgerrit Joshua Harlow proposed openstack/nova: Handle oslo.serialization type error and binascii error https://review.openstack.org/421482
01:37:19 openstackgerrit huangtianhua proposed openstack/python-novaclient: Make _console() public https://review.openstack.org/414364
01:48:08 openstackgerrit Huan Xie proposed openstack/nova: XenAPI: Fix vif plug problem during VM rescue/unrescue https://review.openstack.org/413469
01:55:34 mriedem1 jroll: i think we have an ironic job in the nova experimental queue that's running neutron with some tenant networking glitz,
01:55:50 mriedem1 i was wondering if that would be able to run the attach/detach interfaces test in tempest for https://review.openstack.org/#/c/364413/22/nova/virt/ironic/driver.py
01:56:00 mriedem i can poke into that later
01:56:23 openstackgerrit Wang Qing wu proposed openstack/nova: Introduce base PowerVM driver https://review.openstack.org/391288
02:16:58 openstackgerrit Davanum Srinivas (dims) proposed openstack/nova: [WIP] ignore me - trying experimental jobs https://review.openstack.org/421209
02:21:58 alex_xu oomichi: johnthetubaguy the whole series looks like close https://review.openstack.org/#/q/status:open+project:openstack/nova+branch:master+topic:bp/add-whitelist-for-server-list-filter-sort-parameters at least LGTM now
02:47:52 openstackgerrit Zhenyu Zheng proposed openstack/nova: Strict pattern match query parameters https://review.openstack.org/420494
02:50:02 openstackgerrit Zhenyu Zheng proposed openstack/nova: Strict pattern match query parameters https://review.openstack.org/420494
02:52:19 openstackgerrit Matt Riedemann proposed openstack/nova: DNM: Test interface attahc/detach for Ironic https://review.openstack.org/421638
02:52:20 mriedem jroll: fyi ^
02:56:24 openstackgerrit Huan Xie proposed openstack/nova: XenAPI: Fix vif plug problem during VM rescue/unrescue https://review.openstack.org/413469
02:57:38 openstackgerrit Yoshihiko Atsumi proposed openstack/nova: Add revert resized server functional negative tests https://review.openstack.org/421639
02:58:23 huanxie Hi jaypipes I've added a new unit test to cover all scenario in my VM rescue/unrescue patch https://review.openstack.org/413469, could you help review again, thanks a lot
02:58:34 jaypipes huanxie: you're up late :)
02:59:27 jaypipes huanxie: +2 from me.
02:59:29 huanxie haha :)
02:59:36 huanxie Thanks
02:59:44 jaypipes np, thx for your patience!
03:00:51 huanxie jaypipes: your comments are reasonable, I should fix it:)
03:23:28 EmilienM mriedem: not 100% sure but I think I found another problem with placement api, where nova compute doesn't refresh the resource provider record correctly. It used to work a few days ago but not anymroe
03:23:36 EmilienM http://logs.openstack.org/66/421366/1/check/gate-puppet-openstack-integration-4-scenario004-tempest-centos-7/f138bcc/logs/nova/nova-compute.txt.gz#_2017-01-17_17_45_52_920
03:27:09 openstackgerrit ChangBo Guo(gcb) proposed openstack/nova: Port compute.test_user_data.ServersControllerCreateTest to Python 3 https://review.openstack.org/406435
03:27:09 openstackgerrit ChangBo Guo(gcb) proposed openstack/nova: Enable virt.test_virt_drivers.AbstractDriverTestCase on Python 3 https://review.openstack.org/414419
03:27:10 openstackgerrit ChangBo Guo(gcb) proposed openstack/nova: Enable virt.vmwareapi test cases on Python https://review.openstack.org/414420
03:27:10 openstackgerrit ChangBo Guo(gcb) proposed openstack/nova: Enable more virt.xenapi tests on Python 3 https://review.openstack.org/414421
04:15:45 openstackgerrit Hieu LE proposed openstack/nova: Remove mox from unit/virt/libvirt/test_imagebackend.py (5) https://review.openstack.org/335921
04:28:56 openstackgerrit Hieu LE proposed openstack/nova: Completely remove mox from objects/test_instance.py https://review.openstack.org/343465
05:16:40 gmann alex_xu: filter values we cannot restrict/correct with schema without version bump right? on this - https://review.openstack.org/#/c/418880/
05:17:16 alex_xu gmann: yea, we can't do that now.
05:17:53 alex_xu gmann: this series looks like very close https://review.openstack.org/#/q/status:open+project:openstack/nova+branch:master+topic:bp/add-whitelist-for-server-list-filter-sort-parameters
05:18:14 gmann alex_xu: on that only :).
06:00:41 openstackgerrit Cao Xuan Hoang proposed openstack/nova: Add python 3 classifiers https://review.openstack.org/421677
06:06:00 openstackgerrit Hieu LE proposed openstack/nova: Completely remove mox from objects/test_instance.py https://review.openstack.org/343465
07:07:08 archies @hi auggy
07:39:26 sahid jaypipes: hello, any chance you have a look at https://review.openstack.org/#/c/400875/ ?
07:48:03 openstackgerrit melanie witt proposed openstack/nova: Make Quotas object favor the API database https://review.openstack.org/410945
07:48:03 openstackgerrit melanie witt proposed openstack/nova: WIP Count resources to check quota for cells https://review.openstack.org/416521
07:48:04 openstackgerrit melanie witt proposed openstack/nova: Add online migration to move quotas to API database https://review.openstack.org/410946
07:52:18 openstackgerrit Sivasathurappan Radhakrishnan proposed openstack/nova: Use mask_dict_password from oslo.utils https://review.openstack.org/388345
07:55:47 openstackgerrit Sivasathurappan Radhakrishnan proposed openstack/nova: Add image_meta when unshelving volume backend vm https://review.openstack.org/347063
08:01:17 openstackgerrit Tovin Seven proposed openstack/nova: Integrate OSProfiler and Nova https://review.openstack.org/254703
08:01:19 gmann alex_xu: can you check my comments on this- https://review.openstack.org/#/c/415142/21
08:01:41 gmann alex_xu: i did not get sort_dir filter things till i am not missing anything
08:05:17 gmann alex_xu: API says "If you omit the sort direction in a pair, the API uses the natural sorting direction of the direction of the server sort_key attribute." it means we should prepare the sort_dir with 'desc' if not passed with sort_key but common.get_sort_params(req.params) does not seems to do ?
08:06:33 Kevin_Zheng gmann
08:06:59 Kevin_Zheng I already notice the problem about key and dir while coding
08:07:11 Kevin_Zheng I think it is a bug
08:07:19 gmann Kevin_Zheng: oh, it mean it never working?
08:07:41 Kevin_Zheng I mean
08:08:13 Kevin_Zheng if we don't strict the user to provide both key and dir
08:08:22 gmann Kevin_Zheng: actually now in this BP it might be issue as we are removing the sort_dir and endup with removal of sor_dir of other sort_key
08:08:30 Kevin_Zheng it will be a mess when we do the deleting
08:08:31 Kevin_Zheng yes
08:08:35 gmann Kevin_Zheng: true but we says they can omit the sort_dir
08:10:02 Kevin_Zheng I think it is already wrong when doing key=key1&key=key2&dir=dir2&key=key3&dir=dir3

Earlier   Later