| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2017-01-16 | |||
| 19:22:52 | dansmith | I hand-checked that one | |
| 19:23:23 | mriedem | i know | |
| 19:23:45 | mriedem | my detector has been honed over years of bullshit | |
| 19:33:56 | oomichi_ | mriedem: why not "nova-manage cell_v2 list" ? The other resources' commands are just "list" without resource name in sub commands | |
| 19:34:55 | mriedem | oomichi_: because we could have things like list_host_mappings or something, idk | |
| 19:35:07 | mriedem | oomichi_: and that's what we named it like for create_cell | |
| 19:35:58 | dansmith | I commented to that effect | |
| 19:36:09 | oomichi_ | mriedem: ah, I see "create_cell". I got it. | |
| 19:36:33 | oomichi_ | dansmith: Thanks, I see. it is nice to keep current one for consistent command line | |
| 19:37:49 | openstackgerrit | Jay Pipes proposed openstack/nova: placement: RT now adds proper Ironic inventory https://review.openstack.org/404472 | |
| 19:37:52 | openstackgerrit | Jay Pipes proposed openstack/nova: rt: use a single ResourceTracker object instance https://review.openstack.org/398473 | |
| 19:40:41 | melwitt | omg fixing unit tests is finding my bugs -_- | |
| 19:57:55 | melwitt | dansmith: are there any common mistakes/reasons why a lazy-load of flavor would try to occur even after specifying expected_attrs=['flavor']? | |
| 19:58:48 | dansmith | melwitt: hmm, not that I can think of | |
| 20:00:24 | slaweq | mriedem: hello | |
| 20:00:44 | openstack | Launchpad bug 1640502 in OpenStack Compute (nova) "Empty /etc/machine-id causes failure in unit tests" [Medium,In progress] - Assigned to Slawek Kaplonski (slaweq) | |
| 20:00:44 | slaweq | mriedem: I made small patch https://review.openstack.org/#/c/420176/ to fix https://bugs.launchpad.net/nova/+bug/1640502 | |
| 20:01:02 | slaweq | mriedem: can You take a look on it if You will have a while? thx in advance | |
| 20:01:13 | melwitt | dansmith: thanks, will keep digging | |
| 20:10:32 | dansmith | mriedem: I bet we need to discover hosts somewhere after the subnode runs, which is why I'm getting this: http://logs.openstack.org/79/319379/58/check/gate-tempest-dsvm-multinode-live-migration-ubuntu-xenial/c25f7d1/logs/testr_results.html.gz | |
| 20:12:29 | melwitt | oh, duh. this unit test is creating instances that don't have flavors as part of the setup and the old code used to look at inst['vcpus'] apparently | |
| 20:13:22 | melwitt | so my instance get was getting some instances with None flavors | |
| 20:20:02 | bauzas | jaypipes: hey, about https://review.openstack.org/#/c/417961/5/nova/scheduler/host_manager.py@362 | |
| 20:20:07 | bauzas | jaypipes: sec to discuss ? | |
| 20:20:17 | jaypipes | bauzas: just finishing on phone call. gimme 10. | |
| 20:20:22 | bauzas | jaypipes: fair | |
| 20:20:40 | bauzas | jaypipes: leaving notes meanwhile | |
| 20:21:23 | openstackgerrit | OpenStack Proposal Bot proposed openstack/nova: Updated from global requirements https://review.openstack.org/420844 | |
| 20:30:33 | jaypipes | bauzas: k, done. | |
| 20:30:50 | bauzas | jaypipes: see my comment for context in gerrit | |
| 20:33:17 | mriedem | whew | |
| 20:33:44 | mriedem | dansmith: yeah probably, which is actually what i started working on | |
| 20:33:50 | mriedem | before the call i just got off of happened | |
| 20:34:40 | bauzas | jaypipes: thoughts on that ? | |
| 20:35:13 | dansmith | mriedem: okay | |
| 20:35:29 | bauzas | jaypipes: I honestly totally agree with you that using a reportclient is somehow sad | |
| 20:35:44 | bauzas | jaypipes: but I wanted to be pragmatic | |
| 20:38:41 | openstackgerrit | Andrey Kurilin proposed openstack/python-novaclient: DO NOT MERGE: check OSC https://review.openstack.org/420941 | |
| 20:43:41 | mriedem | ok on the api node i create nova_subnode_cell db, and then create subnode-cell cell with the db connection to the nova_subnode_cell db and transport_url to the primary node's same mq | |
| 20:43:48 | mriedem | transport-url is going to be the same for all of these | |
| 20:44:00 | mriedem | then on the subnode setup after n-cpu is running i need to run discover_hosts | |
| 20:45:31 | mriedem | now i need to remember how to awk stuff, damn | |
| 21:01:26 | jaypipes | bauzas: sorry, reading now. got pulled away | |
| 21:01:32 | bauzas | np | |
| 21:07:36 | comstud | mriedem: well, there's your problem | |
| 21:08:28 | jaypipes | comstud: blast from the past! howdy. | |
| 21:08:36 | comstud | yo :) | |
| 21:08:41 | jaypipes | bauzas: ok, fair point on the reporting client thing. I can go along with that. | |
| 21:08:56 | jaypipes | bauzas: with a promise to clean up ex post facto. | |
| 21:09:05 | bauzas | jaypipes: my change is still there | |
| 21:09:15 | jaypipes | bauzas: I still would need to see a ComputeNodeList.get_all_by_uuids() though. | |
| 21:09:18 | bauzas | jaypipes: I mean the placementclient one | |
| 21:09:29 | bauzas | jaypipes: sure, I'll redo it | |
| 21:09:29 | jaypipes | bauzas: understood. | |
| 21:09:49 | openstackgerrit | Claudiu Belu proposed openstack/nova: hyper-v: Adds support for VMs with nested virtualization https://review.openstack.org/398509 | |
| 21:09:50 | openstackgerrit | Claudiu Belu proposed openstack/nova: Adds CPUFeaturesField to ImageMetaProps https://review.openstack.org/420960 | |
| 21:10:10 | bauzas | jaypipes: the question I was wondering about the placementclient is that it would be reasonable to only provide CRUD ops in it | |
| 21:10:33 | bauzas | jaypipes: or if I'd rather work on objectifying that client | |
| 21:10:52 | bauzas | cutting by just the CRUD ops could possible be merged sooner | |
| 21:11:05 | mriedem | comstud: it's ok, mrodden stopped by just at the right time and gave me the awk i needed | |
| 21:11:05 | jaypipes | bauzas: no, I think just pulling get/put/post/safe_connect into a class is correct. | |
| 21:11:18 | bauzas | but I'd tend to prefer having a placementclient that would have resources in it | |
| 21:11:36 | bauzas | jaypipes: okay, then I'll continue to keep my change up-to-date then | |
| 21:11:58 | bauzas | it'll just be a top change, not a dependent one | |
| 21:12:04 | jaypipes | bauzas: I'd prefer composition over inheritance as I mentioned before, and keep state in separate objects (i.e. not the PlacementClient class itself but the object that contains a PlacementClient object) | |
| 21:12:39 | bauzas | jaypipes: composition is already in the last PS | |
| 21:12:42 | bauzas | AFAIR | |
| 21:12:49 | bauzas | unless I forgot to upload it | |
| 21:14:46 | bauzas | jaypipes: state of what? it's mostly stateless if you except the disabled thing | |
| 21:15:08 | jaypipes | bauzas: I mean the _resource_providers dict. | |
| 21:15:22 | bauzas | jaypipes: in that case, it's fine, I left that | |
| 21:15:29 | jaypipes | bauzas: I would prefer that not be in the PlacementClient. That should be in the ReportingClient, yes? | |
| 21:15:40 | bauzas | correct | |
| 21:15:43 | jaypipes | cool | |
| 21:15:51 | bauzas | jaypipes: https://review.openstack.org/#/c/417111/7/nova/scheduler/client/report.py is pretty seamless | |
| 21:16:26 | jaypipes | bauzas: oui. absolument. | |
| 21:16:49 | jaypipes | bauzas: though I'd change SafeConnectDecorator to @client.safe_connect :) | |
| 21:18:12 | bauzas | jaypipes: but I need to keep a state, hence the deco object :) | |
| 21:19:47 | jaypipes | bauzas: you could just look for a consistently-named attribute, no? | |
| 21:20:38 | bauzas | jaypipes: I could use a global var | |
| 21:21:35 | jaypipes | bauzas: or a consistently-named attr :) | |
| 21:22:22 | jaypipes | bauzas: else you could require classes to implement a get_placement_client() method. | |
| 21:22:27 | jaypipes | bauzas: or something like that. | |
| 21:22:29 | mriedem | dansmith: hmm, should create_cell sync the db schema for that cell? | |
| 21:23:00 | bauzas | jaypipes: I thought of the latter | |
| 21:23:16 | bauzas | jaypipes: anyway, I'll see | |
| 21:24:28 | openstackgerrit | Dan Smith proposed openstack/nova: WIP Move instance creation to conductor https://review.openstack.org/319379 | |
| 21:24:46 | dansmith | mriedem: hmm, I dunno.. | |
| 21:24:54 | dansmith | maybe optional? --sync-that-mofo-too? | |
| 21:25:44 | mriedem | yeah because the problem is running nova-manage db sync on my subnode cell | |
| 21:27:59 | mriedem | dansmith: fuck i've been doffm'ed https://github.com/openstack/nova/blob/7cb416546a2c6d8eb36cbf9acfde776d54a26811/nova/cmd/manage.py#L630 | |
| 21:28:20 | dansmith | mriedem: um, congrats? | |
| 21:28:32 | mriedem | just looks like we thought about this before | |
| 21:28:51 | mriedem | so to sync this db i have to hack the nova.conf | |
| 21:29:06 | mriedem | otherwise it's going to be pointing at the nova db connection on the primary node | |
| 21:29:40 | dansmith | mriedem: you could make that work for other cells easily, right? | |
| 21:29:53 | mriedem | yeah we just get all the cell mappings and sync them | |
| 21:29:53 | dansmith | just list all the mappings and target them before sync like cell0 does | |
| 21:31:17 | mriedem | the note here seems wrong https://github.com/openstack-dev/devstack/blob/master/lib/nova#L687 | |
| 21:31:46 | mriedem | nova-manage db sync is just going to sync the local main db, or whatever is in CONF.database.connection | |