Earlier  
Posted Nick Remark
#openstack-nova - 2017-01-16
11:20:19 lyarwood mdbooth: what else could we possibly do?
11:20:31 mdbooth Yeah, I wonder if the exception was raise by something else
11:20:38 mdbooth Checking now, shouldn't take too long
11:20:53 lyarwood kk
11:20:56 lyarwood thanks again
11:25:27 mdbooth lyarwood: The previous code returned True, and didn't handle the os.stat() error in the test
11:25:54 mdbooth It returned true because of fake_execute
11:26:01 lyarwood ahhhh
11:26:37 mdbooth The os.stat() error is handled by the surrounding code
11:27:29 mdbooth Yup, the os.stat() mock can just be removed
11:27:39 mdbooth It remains a terrible test
11:30:05 mdbooth lyarwood: You never did add anything to openstack-dev-hacks, btw
11:31:11 lyarwood mdbooth: yeah sorry keep meaning to
11:31:25 lyarwood mdbooth: I'll try to get around to it this morning
11:31:43 mdbooth Don't both spending time cleaning it up, btw, just chuck it in there
11:31:56 mdbooth We can cleanup later if required
11:32:10 lyarwood yeah I wanted to remove the grep foo | grep bar crap etc ;)
11:32:49 mdbooth Meh, just drop it in there ;)
11:32:59 openstackgerrit Matthew Booth proposed openstack/nova: libvirt: workaround findmnt behaviour change https://review.openstack.org/420146
11:46:23 lyarwood mdbooth: pushed, also dumped my current crop of git aliases in there, not sure it's that useful so feel free to rm
11:47:36 markus_z Would someone please review a tempest test for l-m: https://review.openstack.org/#/c/346815/22 ?
11:51:38 openstack bug 1455252 in OpenStack Compute (nova) "enabling serial console breaks live migration" [High,Fix released] https://launchpad.net/bugs/1455252 - Assigned to Markus Zoeller (markus_z) (mzoeller)
11:51:38 markus_z tonyb: Would you have a look at the newton backports for bug 1455252 please? https://review.openstack.org/#/q/status:open+project:openstack/nova+branch:stable/newton+topic:%22bug+1455252%22
11:52:18 lyarwood markus_z: I can take a look this afternoon
11:52:42 markus_z lyarwood: Thanks, that would be awesome.
11:57:33 mdbooth lyarwood: Thanks!
11:59:06 sahid johnthetubaguy: hello
11:59:25 sahid i remember that you were kind of interested about the feature emulator threads
11:59:58 sahid and unfortunatly even if the code has been pushed 2 months ago I did not had a lot of reviews
12:00:14 sahid would you be interested on helping jay pipes to review it ?
12:13:44 openstackgerrit Chris Dent proposed openstack/nova: Add rudimentary CORS support to placement API https://review.openstack.org/392891
12:57:38 lyarwood sfinucan: would you mind taking a look at https://review.openstack.org/#/c/420146/ if you have a chance this afternoon
13:21:36 openstackgerrit Mikhail Feoktistov proposed openstack/nova: libvirt: ephemeral disk support for virtuozzo containers https://review.openstack.org/312488
13:25:06 openstackgerrit Mikhail Feoktistov proposed openstack/nova: libvirt: ephemeral disk support for virtuozzo containers https://review.openstack.org/312488
13:26:27 dims sdague : bauzas : Got some time for a review that enable *all* functional tests in py35 (except 1) https://review.openstack.org/#/c/419968/ ? please let me know
13:27:23 dims cdent : the lone hold out is the snowman/gabbi test (unicode_get_a_raw_snowman_unicode.test_request) fails as the snowman char is not ascii, so never reaches the server side
13:29:03 dikonoor alex_xu: sdague: Hi..I have some queries around quotas..who would be the right person to contact ?
13:30:34 cdent dims: odd. i wonder which part of the stack is messing with that, because python3 tests in gabbi itself are pretty okay with that sort of thing, can you link me to a failing trace?
13:31:28 dims one sec, digging up
13:32:43 dims cdent : http://logs.openstack.org/68/419968/9/check/gate-nova-tox-db-functional-py35-ubuntu-xenial/dd20ee5/testr_results.html.gz
13:32:53 cdent thanks
13:33:14 sdague dims: lgtm, maybe once this is all done some of those conditional utf8 encode functions could get an oslo safe_encode wrapper or the like
13:33:26 sdague just to get the if PY2 flags out of the code
13:33:53 cdent dims: that's bizarre, I need to compare with a similar test in gabbi itself
13:34:02 dims cdent : ++
13:40:07 cdent dims: actually that test is bogus on python3 and the error is essentially saying "yo, you've made a bad url"
13:40:43 cdent gabbi is not responsible for url encoding and while python2 is okay with that badly formed url, python3 is not
13:41:07 cdent dims: so I would say: okay to remove that one test as it is bogus
13:47:58 dims cdent : ++
13:55:07 openstackgerrit sahid proposed openstack/nova: numa: add numa constraints for emulator threads policy https://review.openstack.org/385023
13:55:10 openstackgerrit sahid proposed openstack/nova: objects: add new field cpus_reserved in NUMACell https://review.openstack.org/400874
13:55:10 openstackgerrit sahid proposed openstack/nova: libvirt: return a CPU overhead if isolate emulator threads requested https://review.openstack.org/385364
13:55:11 openstackgerrit sahid proposed openstack/nova: virt: update overhead to take into account vCPUs https://review.openstack.org/385024
13:55:11 openstackgerrit sahid proposed openstack/nova: numa: fit instance topology with cpus reserved onto cores https://review.openstack.org/400875
13:55:14 openstackgerrit sahid proposed openstack/nova: numa: take into account cpus reserved https://review.openstack.org/400876
13:55:14 openstackgerrit sahid proposed openstack/nova: libvirt: make emulator threads to run on the reserved pCPU https://review.openstack.org/400878
13:55:15 openstackgerrit sahid proposed openstack/nova: numa: update numa usage incording the cpu reserved https://review.openstack.org/400877
13:55:21 lyarwood sdague: Morning, https://review.openstack.org/#/c/374373/ is +W but I'm still working on the Nova change it depends on, rechecking this isn't going to cause any issues correct?
13:57:48 openstackgerrit Vladyslav Drok proposed openstack/nova: Generate necessary network metadata for ironic port groups https://review.openstack.org/388756
13:59:29 sahid_ jaypipes: hello, btw i have addressed your comments here https://review.openstack.org/#/c/400875/18, not sure if you noticed that
13:59:48 diga jaypipes: Hi
13:59:53 diga Hi
14:00:17 jaypipes sahid_: no, I hadn't noticed (was in CA all last week and spent yesterday getting my own patch series rebased) :)
14:00:30 jaypipes sahid_: will review yours later today after scheduler meeting.
14:00:39 jaypipes diga: heya
14:00:47 diga jaypipes: Hi
14:01:20 diga jaypipes: ohh, meeting is started I guess
14:01:20 sahid_ jaypipes: i see no problem, thanks a lot
14:04:19 sdague lyarwood: correct
14:10:44 lyarwood sdague: thanks, just wanted to check
14:26:19 hachi Hello
14:26:49 hachi Can you please confirm whether the following nova blueprint works with Nova API 2.1:
14:26:59 hachi https://blueprints.launchpad.net/nova/+spec/user-id-based-policy-enforcement
14:27:02 hachi ?
14:29:33 dims jaypipes : can you please peek at this? https://review.openstack.org/#/c/419968/ (enables all the functional tests for py3, has +2 from sdague)
14:30:48 dims jaypipes : welcome back :)
14:30:57 jaypipes dims: thx :)
14:31:06 jaypipes dims: reviewing shortly. just wrapping up scheduler meeting.
14:31:12 dims ack thanks
14:39:23 mriedem o/
15:05:24 jaypipes dims: done
15:05:33 dims thanks jaypipes !
15:05:39 jaypipes any time! :)
15:11:10 jaypipes cdent: k, I have read your email about can_host.
15:11:25 jaypipes cdent: you want me to respond or should we discuss in hangout?
15:11:32 jaypipes cdent: or both? :)
15:11:39 cdent both would be awesome
15:11:42 jaypipes k.
15:11:52 cdent because in the hangout it will just be whoever is there
15:12:09 cdent although, if your answer is sufficiently informative in writing I'm not sure we need the hangout. that was mriedem's idea
15:12:36 bauzas cdent: jaypipes: just a question, should we need to wait for edleafe since he's on PTO ?
15:12:56 mriedem we're not going to wait no
15:13:01 mriedem jay and i are both out next week
15:14:15 cdent mriedem: can you (re-)share the hangout link
15:14:27 bauzas okay
15:14:39 bauzas I'm fine with that, just asking
15:14:45 mriedem alaski: happy birthday :)
15:15:02 mriedem MLK steals your thunder
15:15:22 mriedem cdent: https://hangouts.google.com/hangouts/_/calendar/bWF0dHJpZWQyMkBnbWFpbC5jb20.uve66g1e93k1ooj42jr29g1bug?authuser=0
15:15:27 cdent thanks

Earlier   Later