| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2017-01-13 | |||
| 11:40:53 | mdbooth | The purpose of this change and the previous one seems to be to move away from using disk_path, but I don't get why yet. | |
| 11:42:28 | lyarwood | mdbooth: so off the top of my head I think this was to allow us to swap rbd volumes etc | |
| 11:42:51 | lyarwood | mdbooth: basically anytime we don't have an actual path | |
| 11:42:57 | lyarwood | mdbooth: let me go over this again quickly | |
| 11:43:13 | mdbooth | lyarwood: Ah.... | |
| 11:43:22 | mdbooth | RBD has no path | |
| 11:44:16 | mdbooth | Although, libvirt has its own representation of rbd 'paths' iirc | |
| 11:44:56 | openstackgerrit | jichenjc proposed openstack/nova: Allow -1 as limit value to pager https://review.openstack.org/419893 | |
| 11:46:30 | lyarwood | mdbooth: ah and the main reason for doing this was that we would end up stashing either a disk_path or target_dev in BlockDevice._disk that was really confusing | |
| 11:47:02 | lyarwood | mdbooth: so I thnk i just went with target_dev as we should always have it and it's going to work when we don't have a file path | |
| 11:47:23 | cdent | dims, left a comment, what's there is probably fine, but I also offered an alternative plan which I can do (but not today) if you think it is better. | |
| 11:47:43 | lyarwood | mdbooth: sorry I should really get all of this context back in my head before asking for a review ;) | |
| 11:47:54 | cdent | dims I gotta go to lunch now, but will check back with you and/or the review later in the day | |
| 11:56:48 | mdbooth | lyarwood: FYI, in terms of merging, I think I'd split your change to Guest.get_disk into a separate patch, and merge the rest of the patch into the previous patch. | |
| 11:57:07 | mdbooth | I think that makes it a little more obvious what's going on. | |
| 12:01:28 | lyarwood | mdbooth: ack thanks | |
| 12:01:38 | mdbooth | lyarwood: I'm still going, btw. | |
| 12:01:57 | mdbooth | I don't like the change to BlockDevice, just writing why. | |
| 12:02:45 | alex_xu | johnthetubaguy: Kevin_Zheng i'm good with refactor the code later | |
| 12:03:46 | johnthetubaguy | alex_xu: one thing, do we reject with 400 the bad ones in that patch? | |
| 12:03:51 | mdbooth | lyarwood: Hmm, potentially scratch that. | |
| 12:04:57 | alex_xu | johnthetubaguy: you mean for joinedtable and internal attrs? | |
| 12:05:09 | johnthetubaguy | alex_xu: the joinedtable ones | |
| 12:05:18 | alex_xu | johnthetubaguy: yea, the current patch return 400 | |
| 12:05:19 | openstackgerrit | Mikhail Feoktistov proposed openstack/nova: libvirt: ephemeral disk support for virtuozzo containers https://review.openstack.org/312488 | |
| 12:05:29 | johnthetubaguy | alex_xu: I think the behaviour is the key thing | |
| 12:05:39 | johnthetubaguy | alex_xu: so we should be good | |
| 12:05:54 | alex_xu | johnthetubaguy: ++, the behaviour is everyone expected | |
| 12:07:37 | openstackgerrit | sahid proposed openstack/nova: libvirt: ensure live-migration success https://review.openstack.org/409261 | |
| 12:07:37 | openstackgerrit | sahid proposed openstack/nova: libvirt: update the active migrations DS to support migration result https://review.openstack.org/409260 | |
| 12:13:48 | openstackgerrit | jichenjc proposed openstack/nova: make limit=0 means query 0 data https://review.openstack.org/419913 | |
| 12:17:45 | mdbooth | lyarwood: Any reason for https://review.openstack.org/#/c/399735/ to depend on the previous 2 patches? | |
| 12:18:04 | mdbooth | Seems the middle 2 are about fixing something Rbd related? | |
| 12:18:44 | lyarwood | mdbooth: other than using self._guest.get_disk_by_target_device no I don't think so | |
| 12:32:04 | openstackgerrit | Stephen Finucane proposed openstack/nova: scheduler: Don't modify RequestSpec in filtering https://review.openstack.org/419479 | |
| 12:36:47 | openstackgerrit | Emilien Macchi proposed openstack/nova: CI test - never merge https://review.openstack.org/419926 | |
| 12:39:47 | openstack | Launchpad bug 1656276 in tripleo "Error running nova-manage cell_v2 simple_cell_setup when configuring nova with puppet-nova" [Critical,Triaged] | |
| 12:39:47 | openstackgerrit | Emilien Macchi proposed openstack/nova: Debug https://bugs.launchpad.net/tripleo/+bug/1656276 https://review.openstack.org/419926 | |
| 12:41:45 | openstack | Launchpad bug 1656276 in tripleo "Error running nova-manage cell_v2 simple_cell_setup when configuring nova with puppet-nova" [Critical,Triaged] | |
| 12:41:45 | EmilienM | hey nova folks, we're having a new issue with a patch merged in Nova yesterday, https://review.openstack.org/#/c/409890/ - details are reported here: https://bugs.launchpad.net/tripleo/+bug/1656276 - any feedback is welcome | |
| 12:43:51 | openstackgerrit | Sergey Nikitin proposed openstack/nova: Standardization of VM diagnostics info API. https://review.openstack.org/355540 | |
| 12:55:04 | dtp | good morning. are quotas enforced in the database? | |
| 12:56:16 | openstackgerrit | Vasyl Saienko proposed openstack/nova: Support Ironic interface attach/detach in nova virt https://review.openstack.org/364413 | |
| 13:13:19 | openstackgerrit | Vasyl Saienko proposed openstack/nova: Support Ironic interface attach/detach in nova virt https://review.openstack.org/364413 | |
| 13:27:31 | sahid | JayF: | |
| 13:45:48 | openstackgerrit | Davanum Srinivas (dims) proposed openstack/nova: [WIP] try py35 functional with a clean slate https://review.openstack.org/419968 | |
| 13:45:51 | openstackgerrit | Vladyslav Drok proposed openstack/nova: Generate necessary network metadata for portgroups https://review.openstack.org/388756 | |
| 13:48:34 | cdent | i'm back dims, in case that's of any use | |
| 13:50:10 | dims | cdent : hehe, sorry i had gotten distracted with some shiny stuff. so yes, "EncodeUTF8 middleware" sounds awesome. we could do it as a 2 step tango too, let this change in and then do the middleware. right? | |
| 13:50:49 | dims | cdent : i'am currently poking at what functional tests start working with this change | |
| 13:53:23 | cdent | dims: yeah two step tango would work well | |
| 13:54:30 | dims | cool thanks cdent. let me un-black list stuff some tests and get it ready later today. | |
| 13:54:44 | cdent | \o/ | |
| 13:57:29 | openstackgerrit | Ed Leafe proposed openstack/nova: Fix missing RP generation update https://review.openstack.org/419137 | |
| 13:59:10 | openstackgerrit | Vasyl Saienko proposed openstack/nova: WIP implement interface attach/detach in ironic virt driver https://review.openstack.org/419975 | |
| 13:59:31 | openstackgerrit | Mikhail Feoktistov proposed openstack/nova: libvirt: ephemeral disk support for virtuozzo containers https://review.openstack.org/312488 | |
| 14:06:42 | openstackgerrit | sahid proposed openstack/nova: libvirt: update the active migrations DS to support migration result https://review.openstack.org/409260 | |
| 14:06:43 | openstackgerrit | sahid proposed openstack/nova: libvirt: ensure live-migration success https://review.openstack.org/409261 | |
| 14:08:44 | openstackgerrit | John Garbutt proposed openstack/nova: WIP: Call preallocate_for_instance before scheduler https://review.openstack.org/413124 | |
| 14:08:45 | openstackgerrit | John Garbutt proposed openstack/nova: Tidy up preallocate_for_instance https://review.openstack.org/419978 | |
| 14:08:45 | openstackgerrit | John Garbutt proposed openstack/nova: WIP: introduce preallocate_for_instance method. https://review.openstack.org/418881 | |
| 14:08:46 | openstackgerrit | John Garbutt proposed openstack/nova: Fix no networks preallocate_for_instance return https://review.openstack.org/419979 | |
| 14:10:42 | lyarwood | mdbooth: just looking at the swap volume fix again, I think we do need the previous 2 patches still. _swap_volume only provides a file path so we can't lookup the disk in the domain using guest.get_disk. I'll squash these down now for review. | |
| 14:11:37 | openstack | Launchpad bug 1656276 in tripleo "Error running nova-manage cell_v2 simple_cell_setup when configuring nova with puppet-nova" [Critical,Triaged] | |
| 14:11:37 | EmilienM | bauzas: have you looked https://bugs.launchpad.net/nova/+bug/1656276 ? | |
| 14:24:00 | openstackgerrit | garyk proposed openstack/nova: VMware: retry network lookup if network not ready https://review.openstack.org/391778 | |
| 14:25:26 | openstackgerrit | Vasyl Saienko proposed openstack/nova: Support Ironic interface attach/detach in nova virt https://review.openstack.org/364413 | |
| 14:30:45 | bauzas | EmilienM: hola, sorry was afk due to 10cm of snow and my frontyark needing cleanup :) | |
| 14:30:51 | bauzas | frontyard* even | |
| 14:30:58 | bauzas | EmilienM: owalsh pointed me the issue | |
| 14:31:03 | EmilienM | bauzas: 10 cm only? :-P | |
| 14:31:22 | bauzas | we're in France, and you know how 10cm of snow can be terrible for us :p | |
| 14:31:29 | bauzas | (even living in the French alps) | |
| 14:31:39 | bauzas | anyway | |
| 14:31:40 | EmilienM | bauzas: ok cool, let me know if there is something we need to change in the tripleo workflow or if you spot something in nova itself | |
| 14:31:52 | bauzas | so, owalsh pointed me the sequence that puppet does | |
| 14:32:13 | bauzas | https://github.com/openstack/puppet-nova/blob/master/manifests/db/sync_cell_v2.pp#L41 means that it runs after API DB sync, right? | |
| 14:32:23 | bauzas | EmilienM: ^ | |
| 14:32:24 | lyarwood | mdbooth: correction, we need them still thanks to _live_snapshot, I've updated the review with a comment. | |
| 14:32:35 | EmilienM | bauzas: right | |
| 14:32:53 | bauzas | EmilienM: okay, so you populated the DB, which is good | |
| 14:33:25 | bauzas | EmilienM: but you haven't started the compute nodes, right? | |
| 14:33:35 | bauzas | EmilienM: so they aren't registered in the Nova DB, correct? | |
| 14:33:39 | EmilienM | bauzas: that is true | |
| 14:33:41 | bauzas | okay | |
| 14:33:43 | openstackgerrit | Vasyl Saienko proposed openstack/nova: WIP implement interface attach/detach in ironic virt driver https://review.openstack.org/419975 | |
| 14:33:56 | bauzas | EmilienM: in theory, that shouldn't be a problem | |
| 14:34:34 | EmilienM | bauzas: that was 2 weeks ago, wanna help? https://twitter.com/EmilienMacchi/status/814838163654975488 | |
| 14:34:54 | bauzas | heh | |
| 14:36:38 | bauzas | EmilienM: the error occurs on a fresh new install, not an upgrade ? | |
| 14:36:44 | openstackgerrit | Vladyslav Drok proposed openstack/nova: Generate necessary network metadata for portgroups https://review.openstack.org/388756 | |
| 14:36:47 | EmilienM | bauzas: fresh | |
| 14:36:56 | bauzas | ok | |
| 14:36:59 | EmilienM | bauzas: we haven't the CI job in place for upgrade yet (it's WIP) | |
| 14:37:08 | bauzas | ack | |
| 14:37:13 | EmilienM | actually, we have but it fails because of this cellv2 thing | |
| 14:37:18 | EmilienM | and mwhahaha is working on it | |
| 14:37:39 | EmilienM | https://review.openstack.org/#/q/topic:bug/1649341 | |
| 14:39:16 | bauzas | EmilienM: so, the goal of that simple_cells command is to populate your cellsv2 database with the necessary mappings for the compute nodes being in cells | |
| 14:39:37 | bauzas | EmilienM: if you don't have nodes already, then you have no cell mapping AFAICT | |