| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2017-01-12 | |||
| 18:36:58 | sean-k-mooney | that is strange. does it only get added if it is used? | |
| 18:37:24 | sean-k-mooney | we are not currently using the vif_name field as we havent gone to 1.4 yet | |
| 18:37:31 | mriedem | sean-k-mooney: ah yeah | |
| 18:37:40 | mriedem | getattr(self, name)) | |
| 18:37:40 | mriedem | primitive[name] = field.to_primitive(self, name, | |
| 18:37:40 | mriedem | if self.obj_attr_is_set(name): | |
| 18:39:49 | sean-k-mooney | mriedem: the issue is even with the version bump in nova in that change the upperconstrains is downgrading to 1.3.0 | |
| 18:39:51 | sean-k-mooney | http://logs.openstack.org/61/385061/7/check/gate-nova-python27-db-ubuntu-xenial/3f6ab1c/console.html.gz#_2016-12-29_09_57_59_936076 | |
| 18:40:11 | sean-k-mooney | so untill the upper-constraints patch merges the tests wont pass | |
| 18:40:39 | sean-k-mooney | the upper-constratins is downgrading below the minium set in nova's requirements.txt | |
| 18:41:22 | sean-k-mooney | if we merge teh upperconstraints change the test should pass then we can raise the minium in the global requirements | |
| 18:41:36 | mriedem | sean-k-mooney: i really thought the u-c and g-r changes would be in the same patch | |
| 18:41:50 | sean-k-mooney | the were in my patch | |
| 18:42:26 | sean-k-mooney | but i abandoned it becase francesco had one open too | |
| 18:42:50 | sean-k-mooney | his just raised the gloabl requirements patch and there was a seperate patch for upper constraints | |
| 18:44:01 | sean-k-mooney | mriedem: global reques https://review.openstack.org/#/c/415660/ upper constraitns https://review.openstack.org/#/c/418421/ | |
| 18:44:23 | mriedem | yeah i know, which now depends on the nova fix | |
| 18:44:32 | mriedem | which fails http://logs.openstack.org/21/418421/5/check/gate-cross-nova-python27-db-ubuntu-xenial/5b2478f/console.html#_2017-01-12_17_50_19_015480 | |
| 18:44:40 | mriedem | oslo_versionedobjects.exception.ObjectActionError: Object action obj_make_compatible failed because: No rule for port_profile | |
| 18:45:46 | mriedem | i'm not sure where ^ is coming from | |
| 18:45:52 | mriedem | i assume it's VIFBase | |
| 18:46:20 | sean-k-mooney | neither am i i dont recall any changes related to the port_profile | |
| 18:46:44 | mriedem | i could just be i need to pass a manifest in for the backport conversion | |
| 18:46:55 | sean-k-mooney | i still think merging https://review.openstack.org/#/c/418421/ would resolve the conflict but ill dig a little deeper | |
| 18:46:58 | dansmith | mriedem: see that test example I pointed you to? | |
| 18:47:06 | mriedem | dansmith: i couldn't really make heads or tails of that | |
| 18:47:16 | dansmith | mriedem: it passes in a manifest of what it wants the system to think the remote looks like | |
| 18:47:24 | mriedem | sean-k-mooney: it's a chicken and egg, we can't merge https://review.openstack.org/#/c/418421/ | |
| 18:47:30 | mriedem | because the nova unit tests are failing in that chnage | |
| 18:47:44 | dansmith | mriedem: in that test it mocks get_versions or whatever, but there are others in there that just pass a manifest with one or two object versions | |
| 18:49:53 | sean-k-mooney | your right hum ok im just trying to figure out what is different between them. | |
| 18:50:24 | sean-k-mooney | ah the 'vif_name': u'nicdc065497-3c' | |
| 18:50:29 | mriedem | sean-k-mooney: yeah :) | |
| 18:50:49 | mriedem | it's in the expected object from the nova test, but not in the actual object from the os-vif side | |
| 18:50:57 | mriedem | which is weird because it's version on the object is 1.1 | |
| 18:51:02 | mriedem | which was the version when vif_name was added to VIFHostUser | |
| 18:51:09 | mriedem | oh but you said, | |
| 18:51:13 | sean-k-mooney | the expect result is incorrect as before os-vif 1.4 that field did not exist | |
| 18:51:15 | mriedem | we don't use that yet? | |
| 18:51:23 | mriedem | sean-k-mooney: yeah that's another thing i noted earlier | |
| 18:51:26 | mriedem | and removed in my fix patch, | |
| 18:51:29 | mriedem | but maybe that's just the fix? | |
| 18:52:05 | mriedem | i'll try that out as i have a recreate locally | |
| 18:52:15 | sean-k-mooney | https://review.openstack.org/#/c/410737/2 is the change that should add the vif_name to the unit test | |
| 18:52:35 | mriedem | farq | |
| 18:52:40 | mriedem | ok, well just removing vif_name makes it work | |
| 18:52:44 | sean-k-mooney | yes | |
| 18:52:44 | mriedem | so i'll cleanup my patch | |
| 18:53:17 | sean-k-mooney | so if you remove it now it can be reintoduce in https://review.openstack.org/#/c/410737/2 when the filed actully exists in the os-vif object | |
| 18:54:51 | sean-k-mooney | this is related to a previous conversation i had with danile berange about the fact that oslo versioned objects allows you to set filds in objecst that are not in the defined set of fields | |
| 18:56:25 | mriedem | yeah...i remember that | |
| 18:56:32 | mriedem | we use it to our advantage at times in nova, | |
| 18:56:51 | mriedem | for fields we want to set in the nova-net layer for example and then those are used in the nova-api layer, but aren't persisted in the nova db | |
| 18:57:14 | mriedem | i think i had mentioned at some point about changing ovo to add a flag to be strict about which attributes can be set | |
| 18:57:43 | openstackgerrit | Matt Riedemann proposed openstack/nova: Make unit tests work with os-vif 1.4.0 https://review.openstack.org/419558 | |
| 18:57:52 | sean-k-mooney | yes you had. by the way i just book my ptg flights/hotel. one thing i would like to add to os-vif is a dsvm gate to increase the level of testing. | |
| 18:58:20 | mriedem | want to throw that in https://etherpad.openstack.org/p/nova-ptg-pike ? | |
| 18:58:29 | sean-k-mooney | im not sure it would have caught this but it would be better to have some intergration testing of os-vif | |
| 18:59:08 | sean-k-mooney | am sure. should i add a generic os-vif section or just os-vif gateing | |
| 18:59:23 | sean-k-mooney | there is also the topic of neutron intergration | |
| 18:59:33 | sean-k-mooney | i would like to complete that in pike also | |
| 19:00:14 | mriedem | sean-k-mooney: i think there is a job in the nova experimental queue that already does that | |
| 19:00:59 | mriedem | sean-k-mooney: https://github.com/openstack-infra/project-config/blob/master/zuul/layout.yaml#L12513 | |
| 19:01:14 | sean-k-mooney | mriedem: perhaps. i would like to add a job to os-vif though that tested with the head of nova/neutron master too with the os-vif change | |
| 19:01:28 | mriedem | i think that's what that job does | |
| 19:02:00 | mriedem | https://github.com/openstack-infra/project-config/blob/master/jenkins/jobs/devstack-gate.yaml#L462 | |
| 19:02:11 | mriedem | export PROJECTS="openstack/os-vif $PROJECTS" export DEVSTACK_LOCAL_CONFIG+=$'\n'"LIBS_FROM_GIT=os-vif" | |
| 19:02:14 | sean-k-mooney | yes but that only runs on chnage to nova | |
| 19:02:35 | mriedem | sean-k-mooney: you just have to add that job to the os-vif template in layouts.yaml then | |
| 19:02:37 | sean-k-mooney | i would like to basically add that jobe to the check pipeline for os-vif | |
| 19:02:38 | mriedem | if you want to run that job on os-vif | |
| 19:02:43 | mriedem | then make it so :) | |
| 19:02:44 | sean-k-mooney | yep | |
| 19:02:54 | mriedem | honestly i don't know why danpb didn't do that originally | |
| 19:03:16 | mriedem | you can cancel your PTG flight and hotel now, problem solved :) | |
| 19:03:36 | sean-k-mooney | ok i will, should i add it to check experimental first to make sure it works. | |
| 19:03:52 | mriedem | in os-vif? that's probably not a bad idea | |
| 19:03:58 | sean-k-mooney | mriedem: i have some other things to adress too :) but that is one less item | |
| 19:04:16 | mriedem | goes in here somewhere https://github.com/openstack-infra/project-config/blob/master/zuul/layout.yaml#L13748 | |
| 19:04:39 | sean-k-mooney | mriedem: ok ill submit a patch to add it to check experimental and then do some testing. if it works ill move it to the main check pipeline for os-vif | |
| 19:04:49 | mriedem | cool | |
| 19:06:44 | mriedem | jroll: i just remembered https://review.openstack.org/#/c/247904/ | |
| 19:06:59 | mriedem | you might want to get that in before you request an ironicclient release, or just know you'll have to do two | |
| 19:07:44 | jroll | mriedem: yep, it's on my list | |
| 19:07:59 | mriedem | sean-k-mooney: http://logs.openstack.org/21/418421/5/check/gate-cross-nova-python27-db-ubuntu-xenial/a12bd2b/ is happy now | |
| 19:08:02 | mriedem | so u-c should be good soon | |
| 19:08:37 | sean-k-mooney | cool glad the solution was found before any of the requirements go bumped. | |
| 19:11:56 | mriedem | melwitt: i'm +2 on dan's bottom change now for cells v1 glory https://review.openstack.org/#/c/418141/ | |
| 19:12:14 | EmilienM | dansmith, mriedem: I have a good news | |
| 19:12:15 | mriedem | there is a nit in one of the code comments that could be addressed on top of that change | |
| 19:12:30 | EmilienM | the patch in nova that fixed the placement retry thing, works very well | |
| 19:12:34 | mriedem | 0 days without a TripleO incident?! | |
| 19:12:36 | EmilienM | you can see it in the logs | |
| 19:12:41 | EmilienM | first it fails http://logs.openstack.org/04/419604/1/check/gate-puppet-openstack-integration-4-scenario004-tempest-centos-7/5d95a8c/logs/nova/nova-compute.txt.gz#_2017-01-12_18_54_42_715 | |
| 19:12:51 | EmilienM | then it works http://logs.openstack.org/04/419604/1/check/gate-puppet-openstack-integration-4-scenario004-tempest-centos-7/5d95a8c/logs/nova/nova-compute.txt.gz#_2017-01-12_18_55_46_155 | |
| 19:12:57 | EmilienM | (thx again) | |
| 19:13:42 | mriedem | cool | |
| 19:13:50 | mriedem | on a side note, http://logs.openstack.org/04/419604/1/check/gate-puppet-openstack-integration-4-scenario004-tempest-centos-7/5d95a8c/logs/nova/nova-compute.txt.gz#_2017-01-12_18_53_43_459 | |
| 19:15:42 | EmilienM | mriedem: mhh, is it placement endpoint not reachable from creds in [placement] ? | |
| 19:15:53 | EmilienM | oh no I know | |