| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2017-01-12 | |||
| 00:39:20 | mriedem | is there an easy way to get my membership back or i just need to do the initial sign up stuff all over again? | |
| 00:41:11 | mriedem | can i be ptl if i'm not a foundation member? i'm pretty sure i'm breaking some laws right now. | |
| 00:48:58 | mriedem | ooo i'm back in | |
| 00:49:08 | mriedem | EmilienM: https://review.openstack.org/419217 | |
| 01:36:20 | openstackgerrit | Ken'ichi Ohmichi proposed openstack/nova: Deny invalid flavor extraspec for cpu_policy https://review.openstack.org/406377 | |
| 01:55:10 | openstackgerrit | Matt Riedemann proposed openstack/nova: Hyper-V: Adds vNUMA implementation https://review.openstack.org/282407 | |
| 01:59:10 | tovin07 | johnthetubaguy, mriedem, could you review this one https://review.openstack.org/#/c/254703/ ? patch in novaclient is OK now. Thank you! | |
| 02:03:12 | EmilienM | mriedem: thanks! | |
| 02:13:49 | mriedem | tovin07: probably not tonight | |
| 02:13:56 | mriedem | but it's on the list | |
| 02:14:20 | mriedem | dansmith: looks like my series of backports for the scheduler report client in newton are going to be needed after all for ironic https://review.openstack.org/#/c/416734/ | |
| 02:14:26 | tovin07 | mriedem, thanks! | |
| 02:14:26 | mriedem | ^ was failing before the depends-on | |
| 02:14:40 | mriedem | which pulls in this whole series https://review.openstack.org/#/c/416762/ | |
| 03:14:35 | alex_xu | diana_clarke: yea, agree with you , we need better error message. At least the "query parameter 0" confuse user. I guess "0" due to the input are array type. | |
| 03:25:49 | openstackgerrit | Davanum Srinivas (dims) proposed openstack/nova: Better black list for py35 tests https://review.openstack.org/419250 | |
| 03:32:36 | mriedem | dansmith: we should talk to vladikr about this tomorrow https://review.openstack.org/#/c/405948/ | |
| 03:32:41 | mriedem | i don't want to forget about that one | |
| 03:35:23 | vladikr | mriedem, I'm here - I'm try to re-implement it all with storing the vlan in info_cache - having some issues with that though.. that's why I didn't update yet | |
| 03:35:48 | mriedem | vladikr: ok yeah i assumed you'd need to see how that change makes the rest of the series behave | |
| 04:01:49 | openstackgerrit | Zhenyu Zheng proposed openstack/nova: [poc] add a decorator to reject know bad filters. https://review.openstack.org/419256 | |
| 04:39:41 | openstackgerrit | zhangyujun proposed openstack/nova: Use JSON-Schema to validate bdm https://review.openstack.org/418654 | |
| 04:43:10 | openstackgerrit | zhangyujun proposed openstack/nova: Use JSON-Schema to validate bdm https://review.openstack.org/418654 | |
| 04:49:36 | openstackgerrit | zhangyujun proposed openstack/nova: Use JSON-Schema to validate bdm https://review.openstack.org/418654 | |
| 06:07:26 | khushbu | Hi | |
| 06:08:21 | openstack | Launchpad bug 1630575 in oslo.concurrency "python3 memoryview error" [Undecided,New] - Assigned to Khushbuparakh (khushbuparakh) | |
| 06:08:21 | khushbu | Hi! I am working on this https://bugs.launchpad.net/oslo.concurrency/+bug/1630575 trying to recreate the issue can ayone send the doc link to run tests for oslo.concurrency | |
| 06:08:42 | khushbu | https://launchpadlibrarian.net/288351147/nova-py34-fail.log these are log file | |
| 06:28:24 | openstackgerrit | Hussain Chachuliya proposed openstack/nova: Deny volume swapping with non-bootable volume https://review.openstack.org/407346 | |
| 06:48:22 | openstackgerrit | Zhihai Song proposed openstack/nova: Enable functional.test_servers on Python 3 https://review.openstack.org/419299 | |
| 06:51:16 | gokhan | hi team, I have a question about nova-lxd . I have openstack mitaka installation. I created container with lxd. it is running but network is unreacheable. I am using linux bridge . These are logs http://paste.openstack.org/show/594656/. what can be reason of this. Which settings must be done with lxdbridge ? | |
| 06:51:42 | openstackgerrit | zhangyujun proposed openstack/nova: Update JSON Schema for flavor access https://review.openstack.org/418683 | |
| 07:02:34 | openstackgerrit | zhangyujun proposed openstack/nova: Use JSON-Schema to validate bdm https://review.openstack.org/418654 | |
| 07:02:37 | openstackgerrit | Huan Xie proposed openstack/nova: XenAPI: Fix vif plug problem during VM rescue/unrescue https://review.openstack.org/413469 | |
| 07:12:41 | openstackgerrit | Huan Xie proposed openstack/nova: Fix class type error in attach_interface() function https://review.openstack.org/419308 | |
| 07:38:31 | openstackgerrit | Wang Qing wu proposed openstack/nova: WIP(3): Introduce base PowerVM driver (console) https://review.openstack.org/409402 | |
| 08:36:10 | mfeoktistov | And I have a question. How to use it? | |
| 08:36:10 | mfeoktistov | I can see that we use oslo.privsep now. | |
| 08:36:10 | mfeoktistov | string like "ploop: RegExpFilter, ploop, root, ploop, init, -s, .*, .*" | |
| 08:36:10 | mfeoktistov | Hello! I would like to add a new filter to etc/nova/rootwrap.d/compute.filters | |
| 08:39:37 | openstackgerrit | zhangyujun proposed openstack/nova: Query parameter validation for hosts API https://review.openstack.org/418880 | |
| 08:51:45 | openstackgerrit | Zhenyu Zheng proposed openstack/nova: [poc] add a decorator to reject know bad filters. https://review.openstack.org/419256 | |
| 09:33:58 | openstackgerrit | Takashi NATSUME proposed openstack/nova: api-ref: Fix a parameter in os-availability-zone.inc https://review.openstack.org/417233 | |
| 09:35:20 | gibi | jo | |
| 09:35:22 | gibi | sorry | |
| 09:41:22 | openstackgerrit | OpenStack Proposal Bot proposed openstack/nova: Updated from global requirements https://review.openstack.org/415978 | |
| 10:00:13 | alex_xu | gmann: johnthetubaguy Kevin_Zheng, another idea, we write a new formatter which always reject the validation. Then the schema may looks like this {"system_metadata": {"type": "string", "format": "reject_always"}}, then when user input system_metadata in the query, 400 returned. And we have a way to custom the error message returned from formatter. | |
| 10:10:26 | gmann | alex_xu: i see. | |
| 10:11:13 | gmann | alex_xu: i like to idea but worrying if it make json schema confusing but format name is conveying that anyways | |
| 10:12:28 | alex_xu | gmann: yea, benefits are we needn't python code to raise badrequest, less hacky in other places, no need one more decorator | |
| 10:12:47 | gmann | alex_xu: but one issue, format will not work if it is not string | |
| 10:13:03 | alex_xu | gmann: the query string in the url, always string :) | |
| 10:13:10 | gmann | alex_xu: yea better than python code doing that | |
| 10:13:22 | gmann | alex_xu: ah yea | |
| 10:15:27 | alex_xu | Kevin_Zheng will give a try, to see how that looks like | |
| 10:16:27 | gmann | alex_xu: but when it comes to schema it will be list of values right | |
| 10:18:12 | alex_xu | gmann: yea | |
| 10:18:57 | gmann | so "system_metadata" value will be in list while doing validation | |
| 10:18:59 | alex_xu | gmann: I think the key reason for this trouble was there is no way to express "I want to some specific properties, but I don't want some specific properites, and others just ignore" in the jsonschema | |
| 10:19:19 | alex_xu | gmann: yes | |
| 10:19:55 | alex_xu | gmann: and we still need to use patternProperties for internal attributes, the regex is "^_" | |
| 10:20:01 | gmann | alex_xu: yea, that is missing in json schema lib, they should provide any way to restrict few known properties | |
| 10:20:44 | gmann | alex_xu: true | |
| 10:21:12 | johnthetubaguy | alex_xu: I quite like that | |
| 10:21:27 | alex_xu | johnthetubaguy: cool \o/ | |
| 10:21:35 | johnthetubaguy | alex_xu: but yeah, I guess you still have to keep the regex thing | |
| 10:22:00 | johnthetubaguy | alex_xu: what about type: "reject_always"? | |
| 10:22:05 | johnthetubaguy | or is that not allowed | |
| 10:22:24 | gmann | alex_xu: johnthetubaguy but will it work as values will not be string | |
| 10:22:30 | alex_xu | probably "patternProperties": {"^_": {"type": "string", "format": reject_always"}} | |
| 10:23:14 | gmann | https://github.com/openstack/nova/blob/master/nova/api/validation/__init__.py#L160 | |
| 10:23:57 | alex_xu | johnthetubaguy: i'm not sure json-schema have a way to extend the type, I need to check that | |
| 10:24:39 | johnthetubaguy | I mean they are all strings in query string params anyways | |
| 10:25:55 | gmann | but we do convert those into list of values for validation, so they are array for schema | |
| 10:26:26 | johnthetubaguy | well, I guess I mean everything is a list of strings | |
| 10:27:36 | gmann | yea but json schema just ignore format validation and pass if instance is not string | |
| 10:28:52 | alex_xu | johnthetubaguy: gmann we can add new type. but I guess there is no way to change the error message. User will get a message about "this isn't a type of reject_always" | |
| 10:29:02 | johnthetubaguy | doh | |
| 10:29:05 | johnthetubaguy | good point | |
| 10:29:17 | johnthetubaguy | why are we moving away from the decorator approach? | |
| 10:30:38 | alex_xu | johnthetubaguy: probably avoid one more decorator, and we put all the info into the schema: it is not part of in the schema and part of in the decorator | |
| 10:30:56 | alex_xu | johnthetubaguy: and Kevin_Zheng show me this https://review.openstack.org/#/c/419256/2/nova/api/validation/__init__.py, I feel the change is bigger than I thought | |
| 10:31:20 | alex_xu | But I guess there can be some code sharing, but another worry is another refactor for the code | |
| 10:31:25 | johnthetubaguy | we don't really need min and max though | |
| 10:31:29 | johnthetubaguy | I thought | |
| 10:31:36 | johnthetubaguy | not yet anyways | |
| 10:32:15 | alex_xu | it needs a version control | |
| 10:32:42 | alex_xu | in the future we may add new filter before we reject all? | |
| 10:32:51 | gmann | yea version things we can avoid as of not and do when microversion bump | |
| 10:32:56 | alex_xu | oops, sorry, that isn't the case | |
| 10:32:57 | Kevin_Zheng | yeah, otherwise we can just do it in schema with additional=false | |
| 10:32:58 | gmann | not->now | |
| 10:34:57 | openstackgerrit | zhangyujun proposed openstack/nova: Query parameter validation for hosts API https://review.openstack.org/418880 | |
| 10:37:07 | alex_xu | when we reject all, that decorator still can be there. | |
| 10:39:38 | alex_xu | emm...so, yes, sounds like no version is ok | |
| 10:43:12 | alex_xu | johnthetubaguy: gmann Kevin_Zheng I guess the only different is we want to put all the info together, or just split that special case out of schema? is that question we should answer? | |
| 10:48:15 | gmann | alex_xu: you mean in case we add in schema with new formatter ? | |
| 10:48:57 | alex_xu | gmann: yes | |
| 10:49:12 | gmann | alex_xu: but 'format' only work if instance going to be validated is string and in our case it is list of values right | |
| 10:49:43 | alex_xu | gmann: we have macro function 'multi_params', that works for list | |