| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2017-01-11 | |||
| 21:14:08 | mdrabe | because the instance has to be built to a specific cell | |
| 21:14:55 | dansmith | yes | |
| 21:16:25 | openstackgerrit | Ed Leafe proposed openstack/nova: Fix missing RP generation update https://review.openstack.org/419137 | |
| 21:16:44 | edleafe | jaypipes: The fix ^^ | |
| 21:17:21 | jaypipes | edleafe: cheers man | |
| 21:17:28 | jaypipes | mriedem: I'm good with https://review.openstack.org/#/c/140045/ now. | |
| 21:17:34 | jaypipes | feel free to wallaby. | |
| 21:19:00 | jaypipes | edleafe, reviewed. | |
| 21:20:23 | edleafe | jaypipes: the functional test that was failing was in the later patch that removed Allocation.create() | |
| 21:20:34 | openstackgerrit | Vasyl Saienko proposed openstack/nova: Support Ironic interface attach/detach in nova virt https://review.openstack.org/364413 | |
| 21:21:03 | edleafe | jaypipes: I'll see what I can add that would be close | |
| 21:21:51 | jaypipes | edleafe: cool, thanks Ed. | |
| 21:21:58 | cdent | more stuff borked? | |
| 21:22:38 | edleafe | cdent: one effect of removing Allocation.create() is that AllocationList.create_all() is much more stringent in its checking | |
| 21:23:15 | edleafe | cdent: and that uncovered a slew of ResourceProvider references that were stale as far as their generation was concerned | |
| 21:23:55 | cdent | in? | |
| 21:24:34 | edleafe | cdent: see https://review.openstack.org/419137 for what I fixed | |
| 21:24:41 | cdent | cool thanks | |
| 21:25:51 | edleafe | cdent: the tests in nova/tests/functional/db/test_resource_provider.py were creating allocations before there was any inventory | |
| 21:26:13 | edleafe | cdent: Allocation.create() allowed that. AllocationList.create_all() doesn't. | |
| 21:29:46 | cdent | gyres with gyres or something | |
| 21:34:32 | openstackgerrit | Jay Pipes proposed openstack/nova: pci: add uuid field to PciDevice object https://review.openstack.org/414768 | |
| 21:34:33 | openstackgerrit | Jay Pipes proposed openstack/nova: placement: SRIOV PF devices as child providers https://review.openstack.org/414769 | |
| 21:36:00 | openstackgerrit | Claudiu Belu proposed openstack/nova: Hyper-V: Adds vNUMA implementation https://review.openstack.org/282407 | |
| 21:42:47 | mriedem | claudiub|2: i was just about done commenting on that one :) | |
| 21:43:17 | dansmith | mriedem: melwitt: don't mind me, just bragging: https://review.openstack.org/#/c/418141/ | |
| 21:43:45 | claudiub|2 | ha, oups. :D | |
| 21:44:47 | openstackgerrit | Ed Leafe proposed openstack/nova: Fix missing RP generation update https://review.openstack.org/419137 | |
| 21:44:50 | mriedem | claudiub|2: comments posted | |
| 21:44:58 | mriedem | dansmith: nice | |
| 21:45:10 | mriedem | dansmith: i can see your nippies from here | |
| 21:45:11 | melwitt | hah, yay | |
| 21:45:29 | mriedem | i guess that should have been in a PM | |
| 21:45:42 | dansmith | haha | |
| 21:46:11 | openstackgerrit | Vasyl Saienko proposed openstack/nova: Support Ironic interface attach/detach in nova virt https://review.openstack.org/364413 | |
| 21:51:55 | bauzas | mriedem: jaypipes: could you maybe look at https://review.openstack.org/#/c/392569/ soon ? | |
| 21:52:33 | bauzas | given it's adding a microversion, I'd make sure that this change could be quickly merged | |
| 21:52:57 | bauzas | edleafe had some comments, but I could follow-up the change | |
| 21:54:23 | bauzas | mriedem: do you know if we have a problem with the Xen 3rd party CI? | |
| 21:54:26 | bauzas | wrt https://review.openstack.org/#/c/365505/ | |
| 21:54:42 | bauzas | I'm waiting to see it there | |
| 21:54:56 | mriedem | bauzas: it was good before | |
| 21:55:22 | mriedem | bauzas: i've rechecked https://review.openstack.org/#/c/416797/ which runs the attach/detach interfaces tests on that patch | |
| 21:55:47 | mriedem | bauzas: and yeah on the placement API change, i'm trying to wrap up some of the hyperv patches and then can move on | |
| 21:56:11 | mriedem | bauzas: we should also get alex_xu and sdague to help review https://review.openstack.org/#/c/392569/ | |
| 21:56:19 | bauzas | mriedem: cool by me | |
| 21:56:59 | bauzas | mriedem: last run of XenServer for the above change was -1 with http://dd6b71949550285df7dc-dda4e480e005aaa13ec303551d2d8155.r49.cf1.rackcdn.com/05/365505/22/check/dsvm-tempest-neutron-network/e2bfe3d/ | |
| 21:57:15 | bauzas | for PS22 | |
| 21:57:42 | mriedem | bauzas: that was some devstack setup issue http://dd6b71949550285df7dc-dda4e480e005aaa13ec303551d2d8155.r49.cf1.rackcdn.com/05/365505/22/check/dsvm-tempest-neutron-network/e2bfe3d/logs/devstacklog.txt.gz | |
| 21:57:59 | bauzas | oh right | |
| 21:58:06 | bauzas | meh | |
| 21:58:21 | mriedem | http://dd6b71949550285df7dc-dda4e480e005aaa13ec303551d2d8155.r49.cf1.rackcdn.com/97/416797/3/check/dsvm-tempest-neutron-network/d75b62d/run_tests.log was happy on 1/9 | |
| 21:58:53 | mriedem | bauzas: if you want to +2 and leave the +W to me that's fine too | |
| 21:59:08 | mriedem | given time of day i mean | |
| 21:59:13 | bauzas | mriedem: just looking at the XenServer change | |
| 21:59:26 | bauzas | I mean the tempest test removal | |
| 21:59:40 | bauzas | well, the exception removal rather | |
| 22:00:41 | bauzas | mriedem: how can we be sure that https://review.openstack.org/#/c/416797/ is run by XenServer CI ? | |
| 22:00:58 | bauzas | I'm verifying that | |
| 22:01:44 | bauzas | actually looking at the regex here http://dd6b71949550285df7dc-dda4e480e005aaa13ec303551d2d8155.r49.cf1.rackcdn.com/97/416797/3/check/dsvm-tempest-neutron-network/d75b62d/run_tests.log | |
| 22:02:19 | bauzas | awesome {2} tempest.api.compute.servers.test_attach_interfaces.AttachInterfacesTestJSON.test_create_list_show_delete_interfaces [349.753425s] ... ok | |
| 22:02:25 | bauzas | mriedem: okay, +Wing it | |
| 22:02:31 | bauzas | because of ^ | |
| 22:02:58 | mriedem | http://dd6b71949550285df7dc-dda4e480e005aaa13ec303551d2d8155.r49.cf1.rackcdn.com/97/416797/3/check/dsvm-tempest-neutron-network/d75b62d/logs/devstacklog.txt.gz | |
| 22:03:06 | mriedem | 2017-01-10 03:15:31.180 | + functions-common:git_clone:566 : git show --oneline 2017-01-10 03:15:31.194 | 823b053 xenapi: support the hotplug of a neutron port | |
| 22:03:10 | mriedem | tells you which nova change it's testing | |
| 22:03:17 | mriedem | which is our happy friend the vif hotplug patch | |
| 22:04:44 | mriedem | btw, easy tangential patch to the flavor notification series https://review.openstack.org/#/c/419086/ | |
| 22:04:53 | mriedem | but i'm going to mark that bp complete since the update patch is merged | |
| 22:11:06 | openstackgerrit | OpenStack Proposal Bot proposed openstack/nova: Updated from global requirements https://review.openstack.org/415978 | |
| 22:13:18 | mriedem | claudiub|2: tweak needed here :) https://review.openstack.org/#/c/140045/ | |
| 22:13:43 | mriedem | or i'll just do it if you're trying to end your day | |
| 22:14:42 | dansmith | "end your day" .. sounds ominous | |
| 22:16:35 | claudiub|2 | mriedem: i'm not trying to end my days. :D | |
| 22:16:42 | mriedem | if you're trying to rest your weary head | |
| 22:17:07 | mriedem | the plurality is significant | |
| 22:17:35 | claudiub|2 | still, VirtualInterfaceUnplugException does have a reason formatting argument, while the VirtualInterfacePlugException doesn't. | |
| 22:18:14 | claudiub|2 | i was expecting both of them to have a reason argument. | |
| 22:18:56 | claudiub|2 | https://github.com/openstack/nova/blob/f55815b2f90b934801a88e10bf750876b0587328/nova/exception.py#L132 | |
| 22:20:04 | zzzeek | mriedem: dumb Q as I am clueless. does the nova.task_log table grow unbounded and if so is that part of truncate/cleanup | |
| 22:20:29 | mriedem | claudiub|2: yeah i just noticed the same and left a comment to correct that unplug type | |
| 22:20:43 | mriedem | zzzeek: let me look | |
| 22:23:45 | mriedem | zzzeek: so it's going to be unbounded, | |
| 22:23:55 | mriedem | runs in a periodic task as long as CONF.instance_usage_audit is True | |
| 22:24:11 | openstackgerrit | Claudiu Belu proposed openstack/nova: Adds Hyper-V OVS ViF driver https://review.openstack.org/140045 | |
| 22:24:17 | mriedem | zzzeek: the archive command should move it from the nova.task_log table to the nova.shadow_task_log table | |
| 22:24:29 | mriedem | zzzeek: but nothing deletes those records as far as i know | |
| 22:24:50 | zzzeek | mriedem: OK so on a highly used nova DB i might have 30-40M rows in this thing, at least in the shadow table | |
| 22:25:17 | mriedem | sure | |
| 22:25:33 | mriedem | my understanding of this thing is it's for the REST API to pull these audit logs which ceilometer consumes | |
| 22:25:57 | zzzeek | mriedem: right, but the DB size is never mitigated | |
| 22:25:59 | mriedem | http://developer.openstack.org/api-ref/compute/#server-usage-audit-log-os-instance-usage-audit-log | |
| 22:26:02 | mriedem | zzzeek: nope | |
| 22:26:21 | mriedem | neither is...anything except for nova.tags and anything in the nova_api db | |
| 22:26:34 | zzzeek | mriedem: and...not anytime soon, but people might someday like that DB tables like these don't grow to be billions of rows? or that's how they want it | |
| 22:26:36 | mriedem | all of the old tables in the nova db use the soft delete mixin | |
| 22:27:09 | zzzeek | mriedem: right but task_log seems to be, accumulate rows just for doing things, so it's a fast grower | |
| 22:27:11 | mriedem | zzzeek: i think most operators have their own purge scripts, i know there are some in the osops tooling repos | |
| 22:27:16 | zzzeek | mriedem: OK | |
| 22:27:32 | mriedem | there was a bp at one point to add a purge cli to nova | |