| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2017-01-11 | |||
| 16:54:47 | gibi | mriedem: checking.. | |
| 16:57:48 | gibi | mriedem: as far as I see all the api sample tests are using flavors that has the extra_specs set to someting. This is possible because flavor.extra_specs are returned by a different api resource than the normal flavor object | |
| 16:58:07 | gibi | mriedem: so in a normal GET os-flavors there is no extra_specs ever | |
| 17:01:53 | gibi | mriedem: and the GET os-flavor-extra-specs will call objects.Flavor.get_by_flavor_id | |
| 17:02:24 | melwitt | dansmith, mriedem: I was just doing like the gate to run locally, just have to put the regex in single quotes: tempest run --regex '<regex stuff>' | |
| 17:02:55 | gibi | mriedem: so that works the same way as the code that emits the instance.<action> notifications | |
| 17:03:36 | openstack | Launchpad bug 1655710 in OpenStack Compute (nova) "Query parameter validation using json schema - error messages" [Undecided,New] | |
| 17:03:36 | diana_clarke | mriedem, sdague, alex_xu: https://bugs.launchpad.net/nova/+bug/1655710 | |
| 17:05:08 | mriedem | thanks | |
| 17:05:39 | mriedem | diana_clarke: so do you get a 400 or a 500 now? | |
| 17:05:56 | mriedem | i assume you still get a 400 response | |
| 17:06:04 | diana_clarke | mriedem: not sure off the top of my head, but I can check | |
| 17:06:26 | gibi | mriedem: we can fix flavor.create by adding the extra_specs in the expected_attr here https://github.com/openstack/nova/blob/master/nova/objects/flavor.py#L494 | |
| 17:07:11 | mriedem | gibi: wouldn't that already be done because of this? https://github.com/openstack/nova/blob/master/nova/objects/flavor.py#L490 | |
| 17:07:17 | openstackgerrit | avnish proposed openstack/python-novaclient: Removed unnecessary utf-8 encoding https://review.openstack.org/418839 | |
| 17:07:20 | mriedem | extra_specs is in OPTIONAL_FIELDS | |
| 17:07:54 | gibi | mriedem: I think not because extra_specs is not in updates at https://github.com/openstack/nova/blob/master/nova/objects/flavor.py#L491 | |
| 17:08:54 | mriedem | oh right i missed the in updates check | |
| 17:10:27 | gibi | mriedem: Is it OK for you if I just fix this as part of the bugfix https://review.openstack.org/#/c/415857/ | |
| 17:11:29 | mriedem | gibi: that's dealing with aggregates, so i'd think it'd be part of a separate change in that series? i guess it's hard for me to say without knowing in detail what the actual change is going to be - i don't have the context in my head right now | |
| 17:12:12 | mriedem | raj_singh: fyi i updated the devstack series that's testing the service user token stuff | |
| 17:12:26 | mriedem | i want to see how that runs before i +2 the bottom change in the nova series | |
| 17:12:48 | gibi | mriedem: right, that patch getting mixed up with different object fixes due to the same root cause | |
| 17:12:59 | gibi | mriedem: I can split it into a series of patches | |
| 17:13:18 | raj_singh_ | mriedem: I am using https://review.openstack.org/#/c/413232/ to test the series, which is dependent on the devstack patch as well. BTW it works | |
| 17:13:35 | raj_singh_ | mriedem: http://logs.openstack.org/32/413232/4/check/gate-tempest-dsvm-neutron-multinode-full-ubuntu-xenial-nv/fcaf67a/console.html | |
| 17:13:52 | raj_singh_ | tempest.api.compute.admin.test_live_migration.LiveBlockMigrationTestJSON.test_live_block_migration [412.934140s] ... ok | |
| 17:14:35 | raj_singh_ | I put a sleep of 400 and this test took more than 400 with service token enabled. I will upadate the commit msg on DNM patches to avoid confusion | |
| 17:17:12 | diana_clarke | mriedem: yup, 400 b/c exceptions.ValidationError inherits from exceptions.Invalid which has 400 for code | |
| 17:17:47 | mriedem | diana_clarke: ok | |
| 17:17:51 | mriedem | raj_singh: yup cool | |
| 17:19:11 | dansmith | melwitt: okay, running with the config as the gate does, I now get fewer tests, and many more fails | |
| 17:20:44 | mriedem | raj_singh: actually that's kind of odd that it's passing in your test patch, | |
| 17:20:57 | mriedem | raj_singh: because we don't currently run volume-backed live migration tests in the live migration job | |
| 17:21:04 | mriedem | those are skipped for now due to bugs | |
| 17:21:40 | openstackgerrit | Sujitha proposed openstack/nova: Add post hook script to run tempest with old n-api https://review.openstack.org/401395 | |
| 17:21:41 | raj_singh_ | :) | |
| 17:24:15 | openstackgerrit | Balazs Gibizer proposed openstack/nova: Refactor InstancePayload creation https://review.openstack.org/418488 | |
| 17:24:16 | openstackgerrit | Balazs Gibizer proposed openstack/nova: Remove **kwargs passing in payload __init__ https://review.openstack.org/418489 | |
| 17:25:13 | openstackgerrit | Sujitha proposed openstack/nova: Add post hook script to run tempest with old n-api https://review.openstack.org/401395 | |
| 17:28:04 | openstackgerrit | Dan Smith proposed openstack/nova: WIP: Test cellsv1 https://review.openstack.org/418141 | |
| 17:31:50 | melwitt | dansmith: hm, odd. I guess I didn't make note of how many total tests vs gate when I was running it | |
| 17:33:45 | dansmith | melwitt: a lot of my fails are keystone and cinder, so maybe it's not as bad | |
| 17:33:53 | dansmith | but the total is still different | |
| 17:35:12 | openstackgerrit | Sujitha proposed openstack/nova: Do not merge: Test newly introduced zero-downtime-upgrade gate job https://review.openstack.org/419066 | |
| 17:35:12 | openstackgerrit | Sujitha proposed openstack/nova: Add post hook script to run tempest with old n-api https://review.openstack.org/401395 | |
| 17:36:58 | openstackgerrit | Matt Riedemann proposed openstack/nova: DNM: Test service token https://review.openstack.org/413232 | |
| 17:37:52 | openstackgerrit | Sujitha proposed openstack/nova: Do not merge: Test newly introduced zero-downtime-upgrade gate job https://review.openstack.org/419066 | |
| 17:38:05 | openstackgerrit | Matt Riedemann proposed openstack/nova: xenapi: support the hotplug of a neutron port https://review.openstack.org/365505 | |
| 17:42:55 | mriedem | GET jaypipes returns a 404 | |
| 17:42:56 | mriedem | :( | |
| 17:43:22 | mriedem | GET/nova-core/jaypipes I guess i should say | |
| 17:43:30 | diana_clarke | I've been working on adding microversion 2.40 support to the python-openstack client, but it currently doesn't do anything special for any of the compute microversions... | |
| 17:43:42 | mriedem | diana_clarke: yeah that's kind of a losing battle right now i think | |
| 17:43:50 | mriedem | diana_clarke: we don't have any microversion support in osc yet | |
| 17:43:57 | cdent | mriedem: ZOMG YOU ARE DOING IT COMPLETELY WRONG, HOW COULD YOU, DIE IN A FIRE | |
| 17:44:16 | diana_clarke | mriedem: okay, so perhaps I'll just abort that mission. Or it could be my new baby ;) | |
| 17:44:16 | edleafe | cdent: +1 | |
| 17:44:43 | mriedem | diana_clarke: raising your human baby might be easier than getting that done :) | |
| 17:44:49 | diana_clarke | LOL | |
| 17:44:58 | mriedem | far less crying | |
| 17:45:30 | openstackgerrit | Sujitha proposed openstack/nova: Add post hook script to run tempest with old n-api https://review.openstack.org/401395 | |
| 17:46:19 | mriedem | to be fair at some point we really need someone to actually dig into making microversions work in osc, | |
| 17:46:24 | mriedem | i just haven't given it the attention it needs | |
| 17:48:05 | openstackgerrit | Sarafraj Singh proposed openstack/nova: DNM: Test service token https://review.openstack.org/413232 | |
| 17:50:54 | mriedem | diana_clarke: i added something to https://etherpad.openstack.org/p/nova-ptg-pike for compute microversions in osc | |
| 17:52:10 | openstackgerrit | Sujitha proposed openstack/nova: Adding tags field to InstancePayload https://review.openstack.org/407228 | |
| 17:54:31 | diana_clarke | mriedem: thx! | |
| 17:58:34 | diana_clarke | mriedem: I added a bit of additional info. I won't be traveling to trumpland for the PTG, but I'll follow along via the etherpads. | |
| 18:04:15 | openstackgerrit | Jiri Suchomel proposed openstack/nova: Retry few times when creating the initial connection to libvirtd. https://review.openstack.org/416928 | |
| 18:09:15 | openstackgerrit | Sarafraj Singh proposed openstack/nova: Add service_token for nova-neutron interaction https://review.openstack.org/410394 | |
| 18:18:39 | openstackgerrit | Claudiu Belu proposed openstack/nova: hyper-v: Adds support for VMs with nested virtualization https://review.openstack.org/398509 | |
| 18:24:04 | openstackgerrit | Sarafraj Singh proposed openstack/nova: DNM: Test service token https://review.openstack.org/413232 | |
| 18:45:01 | openstackgerrit | John Garbutt proposed openstack/nova: Extract preallocate_for_instance https://review.openstack.org/418876 | |
| 18:45:02 | openstackgerrit | John Garbutt proposed openstack/nova: Pass objects into _update_ports_for_instance https://review.openstack.org/418513 | |
| 18:45:02 | openstackgerrit | John Garbutt proposed openstack/nova: Pass objects into _create_ports_for_instance https://review.openstack.org/418512 | |
| 18:46:17 | artom | claudiub|2, around? Can you take a look at https://review.openstack.org/#/c/415520/ and https://review.openstack.org/#/c/418100/? It's the virt driver patches for the continuation of device tagging, tagged attachment of nics and volumes | |
| 18:46:53 | artom | I'm not sure I have a specific ask as of yet, as their shape could change in response to reviews, but would something like that be doable for hyper-v? | |
| 18:50:37 | claudiub|2 | looking | |
| 18:50:54 | claudiub|2 | meanwhile, happy new year. :D | |
| 18:51:21 | artom | claudiub|2, thanks, same to you :) And happy orthodox christmas, if you're into that stuff ^_^ | |
| 18:52:06 | claudiub|2 | hm, i am orthodox, but my christmas was in 25th dec. :D | |
| 18:52:47 | claudiub|2 | artom: question: shouldn't the configdrive be regenerated, to also include the new tag? | |
| 18:53:12 | artom | claudiub|2, yeah, but that's trickier, since we need to wait for the instance to be off | |
| 18:53:27 | artom | We can't just yank it from underneath the guest while it's running | |
| 18:53:36 | artom | It may be mounted, etc | |
| 18:55:11 | claudiub|2 | hm, how about regenerating it on interface_attach, but don't attach it yet, and then attach the new one on power_on? | |
| 18:56:12 | openstackgerrit | Balazs Gibizer proposed openstack/nova: Improve flavor sample in notification sample tests https://review.openstack.org/419086 | |
| 18:56:19 | claudiub|2 | artom: also, i suppose you will want to merge this before the feature-freeze, right? | |
| 18:56:44 | artom | claudiub|2, in my wildest dreams, yeah :) | |
| 18:56:59 | artom | But I'm aware this is pretty last minute | |
| 18:58:28 | gibi | mriedem: I improved the flavor extra_specs part of the instance. |
|
| 18:58:28 | claudiub|2 | anyways. it is doable for hyper-v | |
| 18:58:32 | openstackgerrit | Dan Smith proposed openstack/nova: Don't bypass cellsv1 replication if cellsv2 maps are in place https://review.openstack.org/418141 | |
| 18:58:45 | claudiub|2 | i'll have to send up a patch for it then. :) | |
| 18:59:26 | claudiub|2 | doesn't seem like much to be done, imo. only that configdrive regeneration is a bit trickier | |
| 19:00:06 | claudiub|2 | artom: also, regarding device tagging, are pci devices tagged as well? | |
| 19:00:29 | artom | claudiub|2, don't think so... | |
| 19:00:47 | artom | There's no API for it | |
| 19:01:51 | mriedem | gibi: ok | |