Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2017-01-11
15:51:37 mriedem would have to go back through the conversation on that review to get the answer
15:51:38 cdent heh :)
15:52:40 cdent the gist appears to be: we never had good info there in the first place, and making it could be expensive, so we'll get rid of it for now
15:52:43 mriedem cdent: https://review.openstack.org/#/c/357884/9/specs/ocata/approved/restore-vm-diagnostics.rst@142
15:52:53 cdent sort-of-jinx
15:53:50 mriedem i'm pretty sure we also asked if/how people were using it in the ops list and didn't get much of a response
15:53:54 mriedem so we're kind of flying blind
15:54:53 mriedem there was some response i guess http://lists.openstack.org/pipermail/openstack-operators/2016-October/011793.html
15:55:02 openstackgerrit Sarafraj Singh proposed openstack/nova: WIP: Add service_token for nova-glance interaction https://review.openstack.org/412634
15:55:30 mriedem cdent: so i guess people use it as a poor mans way of bypassing ceilometer?
15:55:43 mriedem even though it's entire existence in the first place is for ceilometer i believe
15:55:44 cdent apparently ceilometer is now going to be using something to bypass nova ;)
15:55:47 mriedem dragon added it way back when
15:55:52 mriedem nice
15:56:13 cdent yeah, chaos everywhere, cats and dogs, etc
16:01:42 openstackgerrit Pawel Koniszewski proposed openstack/nova: Add new configuration option live_migration_scheme https://review.openstack.org/410817
16:12:11 openstackgerrit Dan Smith proposed openstack/nova: WIP: Test cellsv1 https://review.openstack.org/418141
16:15:57 mriedem wow, sudafed + 2 cups of coffee and i feel like a changed man
16:16:00 mriedem thanks drugs!
16:16:52 dansmith sudafed ftw
16:16:58 openstackgerrit Matt Riedemann proposed openstack/nova: Update notification for flavor https://review.openstack.org/413846
16:21:04 artom Breaking news: open source project leader secretly a drug addict.
16:21:49 cdent I think we'd be more surprised about an open source project leader that wasn't a drug addict
16:23:57 bauzas I need to be AFK for a few hours but will be back around 2000UTC
16:24:40 gibi mriedem: regarding https://review.openstack.org/#/c/413846/ not only flavor.project but flavor.extra_specs is also missing from the emitted payload
16:25:01 gibi mriedem: but it is expected to be solved by the same bug fix
16:25:19 bauzas in the meatime, I'd appreciate some reviews for https://review.openstack.org/#/c/392569/25
16:25:30 bauzas ^ placement API microversion for RP get
16:25:37 bauzas folks , \o
16:26:11 markus_z mriedem: Hand on heart, the newton backports for fixing live-migration with serial console won't make it, right? https://review.openstack.org/#/q/status:open+project:openstack/nova+branch:stable/newton+topic:%22bug+1455252%22
16:26:49 markus_z I will only cry a little if you say "yes"
16:26:54 mriedem gibi: you forgot that flavor.extra_specs is loaded up by default when we pull the flavor from the database https://github.com/openstack/nova/blob/fd91a25324b7b7fed1f3f10c5b56668b20a170f4/nova/objects/flavor.py#L402
16:27:00 mriedem gibi: that one is the special snowflake
16:27:31 mriedem markus_z: hand on whose heart? mine or yours?
16:27:52 markus_z mine of course ;P (probably I got the idiom wrong)
16:28:57 gibi mriedem: but it is still not shows up in the flavor.create payload
16:29:07 gibi mriedem: which seems contradicting to me
16:29:16 mriedem markus_z: i just have reservations about that one given the size of the series, the conflicts, and all of the kerfuffle around that stuff in newton, like i thought there were other things going on related to that series in newton, - it was just really hard to sort out at the time
16:29:38 mriedem markus_z: so i'd need someone that was much closer to how all of that went down in newton to vouch for it, like pkoniszewski
16:29:57 mriedem gibi: well flavor create is different
16:30:03 mriedem the known issue in that reno is talking about the instance payload
16:30:06 mriedem not flavor.create
16:30:20 mriedem instance payload will have the flavor sub-object based on Flavor.get_by_*
16:30:25 mriedem which loads extra_specs
16:31:28 mriedem hmm, why are we running a functional py35 job when it's just going to always fail/
16:31:33 mriedem seems like a waste of resources
16:31:41 mriedem dims: ^? since gcb isn't around.
16:32:21 gibi mriedem: sorry I still not get it. neither flavor.create nor instance.<action> samples shows the flavor.extra_specs but your reference points out that it is loaded. This seems a bug to me
16:32:49 markus_z pkoniszewski: Do you see a chance to have a look at those patches for stable newton? https://review.openstack.org/#/q/status:open+project:openstack/nova+branch:stable/newton+topic:%22bug+1455252%22 When there are concerns about the risks, I'm fully OK with abandoning them.
16:33:22 mriedem gibi: https://review.openstack.org/#/c/413846/10/doc/notification_samples/instance-create-end.json
16:33:28 mriedem that has the extra_specs key in the payload
16:33:41 mriedem it's just empty, because the fake flavor used in those tests don't have any extra specs :)
16:33:59 nik__ cdent, thank you for review! I fixed you comments
16:34:32 cdent cool, will go back and have a look
16:35:12 gibi mriedem: you are right my eyes ticked me
16:35:17 mriedem gibi: https://github.com/openstack/nova/blob/fd91a25324b7b7fed1f3f10c5b56668b20a170f4/nova/tests/functional/notification_sample_tests/notification_sample_base.py#L138
16:35:22 gibi mriedem: instance.<action> has the extra spec
16:35:35 mriedem yeah, so if we added an extra spec to that fake flavor those instance samples would have it
16:35:55 mriedem it might be a nice clarification to add that in a separate change
16:36:05 mriedem hw:watchdog_action=disable or something
16:37:22 artom mriedem, I guess you missed my question earlier about 2 rpc versions bumps but smaller patches vs 1 bump but bigger patch in the tagged attachment series. Any opinions, or shall I plow on with what I think is best and let code review sort it out later?
16:37:44 gibi mriedem: I agree, let's add that in a separate patch
16:39:08 gibi mriedem: so what is left over the existing reno limitation is that the flavor.create doesn't have the projects and the extra_specs field but I assume that the lazy-load bugfix will solve that as well
16:40:13 mriedem gibi: do you feel the need to update that release note to get into that amount of detail?
16:40:31 mriedem gibi: on flavor create i don't think we have access or extra specs anyway, as those are different APIs to update an existing flavor
16:41:06 gibi mriedem: I think the current patch can go in, worst case we add another reno if the bug fix does not solve the flavor.create
16:41:35 mriedem gibi: ok but like i said, flavor.create won't have access or extra specs,
16:41:40 mriedem those aren't available when the flavor is created
16:41:47 pkoniszewski markus_z: yeah, added series to my TODO list for tomorrow
16:41:47 mriedem those are later POST actions on an existing flavor
16:41:50 mriedem so those would be update notifications
16:42:06 mriedem artom: i think i'd prefer separate
16:42:24 mriedem artom: that series is easier to review when we're dealing with bdms and vifs separately
16:42:44 mriedem but that's just me
16:43:06 artom mriedem, I think I agree
16:43:10 gibi mriedem: I agree that the flavor.extra_spec is empty at flavor.create but that empty dict still should be in the emited flavor.create payload
16:43:12 artom mriedem, human time > computer time
16:43:21 artom Or in this case, computer complexity
16:43:41 markus_z pkoniszewski: Thanks
16:44:34 diana_clarke mriedem, sdague, alex_xu: I'm not sure if you saw my last comment here, but I'm not sure this should be shipped as-is. Thoughts? https://review.openstack.org/#/c/398755/
16:45:43 sdague diana_clarke: it would be nice to make that a better error message
16:46:03 dansmith mriedem: sdague: do you know what tox target I should run in tempest to be like what the cells job gets in the gate? if I do -efull I get ~100 more tests than we run
16:46:30 mriedem diana_clarke: hmm, i hadn't seen that
16:46:47 mriedem dansmith: you need to use the rc file in the nova tree
16:47:04 mriedem dansmith: https://github.com/openstack/nova/blob/master/devstack/tempest-dsvm-cells-rc
16:47:05 mriedem sec,
16:48:34 mriedem that is sourced here https://github.com/openstack-infra/devstack-gate/blob/master/devstack-vm-gate-wrap.sh#L601
16:49:07 mriedem dansmith: and then used here https://github.com/openstack-infra/devstack-gate/blob/master/devstack-vm-gate.sh#L789
16:49:16 dansmith mriedem: do I need to re-run devstack for that or can I just run tempest and point it at the regex?
16:49:23 dansmith ah
16:49:34 gibi mriedem: I just cherry-picked the bugfix top of the flavor update patch and the notificaion sample test blows up that the extra_spec field of the flavore in None and the extra_specs field of the falvor payload cannot be none. So I think we have an issue here
16:49:42 mriedem dansmith: are you talking local runs?
16:49:47 dansmith mriedem: yeah
16:49:57 mriedem dansmith: then i think you just source that rc file to get the env variable exported,
16:50:09 mriedem and then tox -eall $DEVSTACK_GATE_TEMPEST_REGEX
16:50:18 mriedem well: tox -e all -- $DEVSTACK_GATE_TEMPEST_REGEX
16:50:27 dansmith oh okay
16:50:30 dansmith confusing
16:51:05 gibi mriedem: worst case I have to bump the version of the falvor payload to make the extra_specs nullable
16:51:24 gibi mriedem: is it still OK as a bugfix?

Earlier   Later