Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2017-01-06
00:52:39 openstackgerrit Matt Riedemann proposed openstack/nova: Fix ksa mocking in test_cinderclient_unsupported_v1 https://review.openstack.org/417206
01:05:28 mriedem easy +W https://review.openstack.org/#/c/415776/2
01:17:13 openstackgerrit Dan Peschman proposed openstack/nova: No API cell up-call to delete consoleauth tokens https://review.openstack.org/415922
02:06:49 openstackgerrit int32bit proposed openstack/python-novaclient: Allow multiple tag add/delete from cli https://review.openstack.org/414635
02:12:07 openstackgerrit huangtianhua proposed openstack/python-novaclient: Make _console() public https://review.openstack.org/414364
02:35:56 openstackgerrit Zhenyu Zheng proposed openstack/python-novaclient: Fix "Message object do not support addition". https://review.openstack.org/414529
02:44:55 openstackgerrit Dan Peschman proposed openstack/nova: No API cell up-call to delete consoleauth tokens https://review.openstack.org/415922
02:59:52 openstackgerrit Zhenyu Zheng proposed openstack/nova: Add query parameters white list for server list/detail https://review.openstack.org/408571
03:06:25 openstackgerrit Matt Riedemann proposed openstack/python-novaclient: Add support for showing aggregate UUIDs (v2.41) https://review.openstack.org/417265
03:11:31 openstackgerrit Matt Riedemann proposed openstack/python-novaclient: Add support for showing aggregate UUIDs (v2.41) https://review.openstack.org/417265
03:38:27 openstackgerrit Takashi NATSUME proposed openstack/nova: Enable cold migration with target host(1/2) https://review.openstack.org/408955
04:17:01 openstackgerrit Takashi NATSUME proposed openstack/nova: Enable cold migration with target host(2/2) https://review.openstack.org/408964
04:17:32 openstackgerrit Zhenyu Zheng proposed openstack/python-novaclient: Fix "Message object do not support addition". https://review.openstack.org/414529
04:17:48 openstackgerrit Takashi NATSUME proposed openstack/nova: api-ref: Add parameters in cold migrate action https://review.openstack.org/410042
04:17:59 openstackgerrit Takashi NATSUME proposed openstack/nova: Add functional tests for cold migration to same host https://review.openstack.org/414926
04:18:39 openstackgerrit Takashi NATSUME proposed openstack/python-novaclient: Microversion 2.41 - Enable cold migration with target host https://review.openstack.org/406707
05:24:43 openstackgerrit Alex Xu proposed openstack/nova: [POC][placement] Add set/get_traits method to ResourceProvder object https://review.openstack.org/376201
05:24:44 openstackgerrit Alex Xu proposed openstack/nova: [POC][placement] Caches and synchronizes the traits from os_traits https://review.openstack.org/416007
05:24:44 openstackgerrit Alex Xu proposed openstack/nova: [POC][placement] Add Traits API to placement service https://review.openstack.org/376200
05:24:45 openstackgerrit Alex Xu proposed openstack/nova: [POC][placement] Add Trait and TraitList objects https://review.openstack.org/376199
05:24:45 openstackgerrit Alex Xu proposed openstack/nova: [POC][placement] Add resource provider traits API https://review.openstack.org/376202
05:24:46 openstackgerrit Alex Xu proposed openstack/nova: [POC][placement] Add Traits related table to the api database https://review.openstack.org/376198
05:24:46 openstackgerrit Alex Xu proposed openstack/nova: [POC][placement] Import os_traits library https://review.openstack.org/377381
05:24:47 openstackgerrit Alex Xu proposed openstack/nova: [POC][placement] Report cpu features to placement Traits API https://review.openstack.org/417288
06:05:30 openstackgerrit Tao Li proposed openstack/nova: When using ceph storage in nova, the libvirt driver should not cleanup the root disk except booting scenario such as evacuating instance failed. If the root disk is removed, maybe some user datas in it lost. https://review.openstack.org/417291
06:21:28 openstackgerrit Alex Xu proposed openstack/nova: [POC][placement] Report cpu features to placement Traits API https://review.openstack.org/417288
06:21:29 openstackgerrit Alex Xu proposed openstack/nova: [POC][placement] Add resource provider traits API https://review.openstack.org/376202
06:35:52 openstackgerrit Zhenyu Zheng proposed openstack/python-novaclient: Fix "Message object do not support addition". https://review.openstack.org/414529
06:37:03 openstackgerrit Pooja Jadhav proposed openstack/nova: Don't translate exceptions w/ no message https://review.openstack.org/417295
07:53:17 openstackgerrit Wang Qing wu proposed openstack/nova: WIP(4): Introduce base PowerVM driver (cfg drv) https://review.openstack.org/409404
07:55:38 openstackgerrit Radoslav Gerganov proposed openstack/nova: Add connection pool size to vSphere settings https://review.openstack.org/414085
10:28:24 openstackgerrit Gábor Antal proposed openstack/nova: Transform instance.reboot notifications https://review.openstack.org/382959
10:36:37 openstackgerrit Gábor Antal proposed openstack/nova: Transform instance.reboot.error notification https://review.openstack.org/411791
10:37:44 bauzas cdent: morning
10:37:53 cdent morning bauzas
10:37:57 bauzas cdent: saw your comment on https://review.openstack.org/#/c/392569/22/nova/api/openstack/placement/handlers/resource_provider.py@61
10:38:31 bauzas cdent: if I'm not adding member_of, we wouldn't accept it by my change, right?
10:38:51 bauzas cdent: but we're already accepting it, right?
10:39:59 cdent we're accepting it by accident and when we do it will result in an error, and the intention is to merge the api code that handles it asap: https://review.openstack.org/#/c/407742/
10:42:11 bauzas cdent: okay, so I'll remove it from the schema then
10:42:36 cdent stuff near hear in the logs: http://p.anticdent.org/48rX
10:43:37 cdent sigh: here
10:43:46 bauzas cdent: okay, what I understand is that we contracted on member_of but without having the right API
10:43:55 bauzas cdent: so, stopping to accept it is good to me
10:44:32 bauzas cdent: when you'll add the API version for it, it'll be clear that now we explicitly accept member_of by the schema you'll add
10:44:33 cdent I think what we're doing is simply fixing a bug
10:44:38 cdent yes
10:44:52 bauzas cdent: okay, putting a new PS
11:04:20 bauzas cdent: mmm, trying to find a good pattern for the decorator using something related to the PlacementClient now that we agreed that it's just a member of SchedulerClient and not an inherited
11:04:49 bauzas cdent: the disabled field that the decorator looks at means that we should review it like self.placement_client._disabled but I don't like it
11:12:43 cdent bauzas: that suggests either some functionlity needs to move from scheduler client to placement client or vice versa?
11:13:04 bauzas cdent: I think I have an idea
11:13:06 cdent It seems like only doing the http methods in the placement client is perhaps a bit limited
11:18:00 openstackgerrit sahid proposed openstack/nova: numa: add numa constraints for emulator threads policy https://review.openstack.org/385023
11:18:02 openstackgerrit sahid proposed openstack/nova: libvirt: return a CPU overhead if isolate emulator threads requested https://review.openstack.org/385364
11:18:03 openstackgerrit sahid proposed openstack/nova: numa: fit instance toplogy with cpus reserved onto cores https://review.openstack.org/400875
11:18:03 openstackgerrit sahid proposed openstack/nova: objects: add new field cpus_reserved in NUMACell https://review.openstack.org/400874
11:18:04 openstackgerrit sahid proposed openstack/nova: virt: update overhead to take into account vCPUs https://review.openstack.org/385024
11:18:06 openstackgerrit sahid proposed openstack/nova: libvirt: make emulator threads to run on the reserved pCPU https://review.openstack.org/400878
11:18:07 openstackgerrit sahid proposed openstack/nova: numa: update numa usage incording the cpu reserved https://review.openstack.org/400877
11:18:07 openstackgerrit sahid proposed openstack/nova: numa: take into account cpus reserved https://review.openstack.org/400876
11:33:24 mdbooth I have a python3 problem: I have some code which maps over a list of tuples. In python2 I do:
11:33:41 mdbooth map(lambda (x, y): x, mylist)
11:33:58 mdbooth i.e. the output is a new list containing only the first element of each tuple
11:34:04 mdbooth In python3 this is a syntax error
11:35:10 mdbooth I've mashed the keyboard a bit, but I can't find a solution, and I haven't yet worked out what to google
11:42:13 cdent mdbooth: will a list comp work for you: [a for a, b in x]
11:42:26 mdbooth Yeah, list comp is the way to go, thanks cdent
11:43:20 cdent you can do a generator comprehension instead if you want
11:43:20 mdbooth The original original code actually constructed an iterator, not a list
11:46:08 bauzas yeah that's the problem I'd see with a list comprehension
11:51:22 bauzas mdbooth: so, map in py2 returns a list
11:51:24 bauzas https://docs.python.org/2/library/functions.html#map
11:51:37 mdbooth bauzas: original original code was itertools.imap
11:51:40 bauzas mdbooth: while in py3, it's an iterable https://docs.python.org/3/library/functions.html#map
11:51:51 bauzas like most of the changes for the list stuff
11:51:56 openstackgerrit sahid proposed openstack/nova: libvirt: ensure live-migration success https://review.openstack.org/409261
11:51:56 openstackgerrit sahid proposed openstack/nova: libvirt: update the active migrations DS to support migration result https://review.openstack.org/409260
11:52:06 mdbooth which I'd already simplified to share
11:52:13 bauzas mdbooth: oh okaty
11:52:15 mdbooth As it's also not in py3
11:52:36 bauzas because it's in stdlib :)
11:52:55 mdbooth Also, because we hate users
11:54:12 bauzas mdbooth: six has a 'map' rename
11:55:07 mdbooth bauzas: Yeah, had already found that. Concentrating on the renaming and syntax is probably why I didn't think of using a comprehension instead :)
11:58:46 bauzas mdbooth: an alternative could be using zip
11:58:50 bauzas lemme test
11:59:39 mdbooth bauzas: comprehension is the right solution. It's actually much neater that what I'd originally written.
12:00:41 bauzas mdbooth: but you're no longer creating an iterator, right?N
12:00:55 mdbooth There's also a generator comprehension
12:01:26 mdbooth (x for (x, y) in foo)
12:01:57 bauzas agreed
12:03:33 bauzas cdent: given the effort it requires to properly seam all the client stuff within a proper module (given how we intrisected the use in the report client), do you agree with me leaving some kind of ugly but necessary inheritance aspect for a PlacementClient?
12:03:58 bauzas cdent: ideally, we would have different objects per resource
12:04:09 bauzas like we do for most of our clientcode
12:04:57 cdent bauzas: I think if the base class is just put(), post(), etc, then I'm not sure I would bother?
12:05:19 cdent But if it makes sense, then sure, if it makes things more clear or clean.
12:05:40 bauzas cdent: the problem is I'm beginning to include all the resource-related methods for inventories and allocations
12:05:48 cdent I think we intentionally chose _not_ to use different objects per resource in the client as that was felt to be overkill given the types of interactions being done
12:05:54 bauzas cdent: and that's an hard work to do so

Earlier   Later