| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2017-01-05 | |||
| 20:11:00 | sdague | mordred: yeh, you can do that now | |
| 20:11:16 | sdague | we've been testing that way for about a year | |
| 20:12:09 | mordred | sdague: cool - so lack of project_id in the url just means "use the project from the currently scoped user" ? | |
| 20:12:14 | mordred | s/user/token/ | |
| 20:12:30 | mriedem | cdent: that's what i was thinking | |
| 20:12:33 | sdague | mordred: yes | |
| 20:12:42 | sdague | mordred: which is actually the way the code always worked | |
| 20:12:45 | cdent | ✔ | |
| 20:12:48 | mriedem | cdent: we could also ask zzzeek but to be safe it's probably safest to just always make it a list | |
| 20:13:21 | sdague | the project id in the url was nothing more than belt and suspenders since I've been on the project | |
| 20:13:21 | mriedem | did i mention that safety is very important :) | |
| 20:13:21 | openstackgerrit | Sarafraj Singh proposed openstack/nova: WIP: Add service_token for nova-cinder interaction https://review.openstack.org/397399 | |
| 20:14:00 | sdague | mriedem / dims - something just seems to have started melting down on python3 unit tests for nova - http://status.openstack.org/zuul/ | |
| 20:14:05 | sdague | on gate queue | |
| 20:14:44 | sdague | http://logs.openstack.org/23/403423/9/gate/gate-nova-python35-db/60675e6/console.html#_2017-01-05_19_02_54_521661 | |
| 20:16:06 | mordred | sdague: ah! neat. good to know | |
| 20:16:44 | mordred | sdague: if I am an admin with access rights and I add a project id to the url, that should show me things in that project? | |
| 20:17:57 | sdague | no | |
| 20:18:24 | sdague | it's... weird, and we all had to read that code a bunch to convince ourselves that wasn't working that way | |
| 20:19:11 | sdague | but basically if project_id is in the url, it is checked against token project_id, if they aren't the same, 403 | |
| 20:19:28 | sdague | the token project_id is always used | |
| 20:19:57 | sdague | some resources also let you specify project_id as a param or all_tenants, and then if you are in the policy to have access to those things (i.e. is_admin) you do | |
| 20:22:35 | mordred | sdague: thanks. super helpful. SO - I'm asking all this because I'm reviewing a change to add support for reading limits which means I'm learning about it and stuff ... and the API docs do not mention /limits taking any parameters - but python-novaclient (which I just now looked at) seems to be able to pass tenant_id and restricted as parameters | |
| 20:22:47 | mordred | sdague: should I just assume that's a docs bug I shoudl file? | |
| 20:23:11 | mriedem | sdague: we removed cinder v1 support from nova | |
| 20:23:23 | mriedem | sdague: are you sure that wasn't just a gate hiccup | |
| 20:23:24 | mriedem | ? | |
| 20:23:32 | mriedem | like that change sliding in before some other things | |
| 20:23:45 | mriedem | sdague: https://review.openstack.org/#/c/409904/ | |
| 20:23:46 | sdague | mriedem: 2 changes in a row bounced like that | |
| 20:24:14 | sdague | mordred: that's probably a docs bug | |
| 20:24:21 | mordred | sdague: cool. thanks! | |
| 20:24:31 | mriedem | sdague: oh it's a new test as part of that change https://review.openstack.org/#/c/409904/2/nova/tests/unit/test_cinder.py@124 | |
| 20:25:08 | mriedem | so probably a busted global mock or something? | |
| 20:26:11 | sdague | mordred: https://github.com/openstack/nova/blob/1ccdfa4240d67d8f91273ec36ad8d7292aecd0f2/nova/api/openstack/wsgi.py#L644-L652 | |
| 20:27:17 | openstackgerrit | Chris Dent proposed openstack/nova: HTTP interface for resource providers by aggregates https://review.openstack.org/407742 | |
| 20:27:25 | openstackgerrit | OpenStack Proposal Bot proposed openstack/nova: Updated from global requirements https://review.openstack.org/415978 | |
| 20:28:50 | mordred | sdague: awesome | |
| 20:31:17 | cdent | macsz: I've responded to your question on that review about the typo. We should fix that pretty much now | |
| 20:31:56 | cdent | macsz: I guess I never saw that because it didn't have the placement tag, thanks for adding it | |
| 20:32:07 | cdent | I'll go ahead and fix it right now. | |
| 20:32:12 | macsz | cdent: np | |
| 20:32:20 | macsz | cdent: ok | |
| 20:33:20 | mriedem | cdent: looks good, just waiting on test results | |
| 20:38:15 | openstackgerrit | Chris Dent proposed openstack/nova: [placement] fix typo in call to create auth middleware https://review.openstack.org/417178 | |
| 20:53:09 | mriedem | nova meeting in 7 minutes | |
| 20:53:12 | mriedem | bauzas: ^ fyi just for you | |
| 20:53:32 | openstackgerrit | Ed Leafe proposed openstack/nova: Add check for invalid allocation amounts https://review.openstack.org/416752 | |
| 20:53:32 | openstackgerrit | Ed Leafe proposed openstack/nova: Remove the Allocation.create() method. https://review.openstack.org/416751 | |
| 20:53:57 | mriedem | sdague: yeah damn i just had something fail in check http://logs.openstack.org/18/417118/1/check/gate-nova-python27-db-ubuntu-xenial/0c0c8c1/console.html#_2017-01-05_17_52_16_199447 | |
| 20:53:59 | mriedem | that test must be busted | |
| 20:54:54 | dansmith | I think I had that fail earlier today too | |
| 20:55:39 | mriedem | yeah opening a bug | |
| 20:55:40 | mriedem | damn | |
| 20:56:23 | dansmith | we should probably make the nova meeting short so you can get back to looking at that | |
| 20:57:09 | mriedem | gonna make it extra long | |
| 20:57:11 | mriedem | just for you | |
| 20:57:27 | dansmith | >:| | |
| 20:57:34 | openstack | Launchpad bug 1654393 in OpenStack Compute (nova) ""keystoneauth1.exceptions.catalog.EmptyCatalog: The service catalog is empty." in test_cinderclient_unsupported_v1" [High,Confirmed] | |
| 20:57:34 | mriedem | https://bugs.launchpad.net/nova/+bug/1654393 | |
| 21:01:18 | bauzas | mriedem: <3 | |
| 21:01:32 | mriedem | ok e-r query patch is up | |
| 21:01:39 | bauzas | but this time, my google agenda worked :) | |
| 21:29:52 | openstackgerrit | Sujitha proposed openstack/nova: Add post hook script to run tempest with old n-api https://review.openstack.org/401395 | |
| 21:36:56 | bauzas | cdent: bonus point for the HAS-A vs. IS-A comment | |
| 21:37:05 | bauzas | very good point | |
| 21:37:11 | bauzas | I was just lazy | |
| 21:37:50 | cdent | it's not a deal breaker or anything, just seemed...tidier? | |
| 21:37:55 | openstackgerrit | Balazs Gibizer proposed openstack/nova: add availability_zone field in service.update https://review.openstack.org/415857 | |
| 21:39:07 | bauzas | cdent: well, I think it's better to have a self.placement_client instead of a super().__init__() | |
| 21:43:15 | cdent | I think my eyes are going to fall out, time to leave the puter. | |
| 21:43:23 | mriedem | o/ | |
| 21:51:45 | dtp | what are the valid cell_types for cells v2? | |
| 21:55:39 | mriedem | dtp: that doesn't apply for cells v2 | |
| 21:55:48 | mriedem | well, it's not used i don't think | |
| 21:55:56 | mriedem | e.g. api vs compute | |
| 21:58:25 | openstackgerrit | Matt Riedemann proposed openstack/nova: Fix ksa mocking in test_cinderclient_unsupported_v1 https://review.openstack.org/417206 | |
| 21:58:26 | mriedem | sdague: here's to hoping this fixes the unit test race bug ^ | |
| 22:01:57 | dansmith | mriedem: dtp right, no cell types in v2 | |
| 22:02:03 | dansmith | any reference to a cell type is cellsv1 code | |
| 22:03:06 | melwitt | mriedem, dtp: yeah, it's not used in cells v2. it's just that we're trying to determine how to avoid cells v1 running a piece of code in compute cells. and there's no way to tell that from the cell_type option because it defaults to 'compute' | |
| 22:03:58 | melwitt | if we say "cell_type != compute" then it would prevent the code running in cells v2 also | |
| 22:04:33 | dtp | i was confused as to what code path would lead to https://github.com/openstack/nova/blob/master/nova/compute/api.py#L1815 being executed in a cell vs the top level | |
| 22:04:40 | melwitt | we want it to run 1) always in cells v2 2) only for the api cell in cells v1 | |
| 22:05:01 | mriedem | so, if CONF.cells.enable and CONF.cells.cell_type == 'api' ? | |
| 22:05:19 | mriedem | cells.enable will only be True for cells v1 | |
| 22:05:30 | melwitt | mriedem: oooh, that sounds like it would work | |
| 22:05:39 | openstackgerrit | Matt Riedemann proposed openstack/nova: Fix ksa mocking in test_cinderclient_unsupported_v1 https://review.openstack.org/417206 | |
| 22:05:40 | mriedem | ok i think *that* ^ fixes that mock issue | |
| 22:05:44 | mriedem | based on https://docs.python.org/3/library/unittest.mock.html#id5 | |
| 22:05:51 | melwitt | dtp: yeah, it's complicated. and one of many reasons we are doing cells v2 and will get rid of cells v1 | |
| 22:05:54 | mriedem | mocking statics from imported libraries is a mess | |
| 22:07:03 | smcginnis | mriedem: I seem to remember puzzling over that as well at some point. | |
| 22:07:33 | smcginnis | mriedem: Looks "more correct" now. | |
| 22:07:44 | mriedem | i just 'feels' right | |
| 22:07:49 | smcginnis | :) | |
| 22:07:55 | mriedem | i code like trump governs | |
| 22:07:56 | mriedem | with the gut | |
| 22:08:10 | mriedem | well, or just not at all | |
| 22:08:12 | smcginnis | It'll be huuge. | |