| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2017-01-03 | |||
| 16:07:24 | dansmith | right | |
| 16:13:14 | mriedem | dansmith: do you want to make a comment on https://review.openstack.org/#/c/405948/ about using the network_info for this instead of a new column? | |
| 16:13:35 | dansmith | sure | |
| 16:21:07 | openstackgerrit | Neil Jerram proposed openstack/nova: libvirt: avoid generating script with empty path https://review.openstack.org/411936 | |
| 16:30:05 | cdent | rfolco: I'm back now, you get things working like you want? | |
| 16:38:32 | rfolco | cdent, not yet, was stuck on a call, then I had to restore my environment, so running tox -e for the first time takes forever | |
| 16:39:07 | cdent | rfolco: heh, yeah, that can be painful | |
| 16:39:19 | rfolco | cdent, I am adding sys.stderr.write as you suggested.... | |
| 16:40:06 | cdent | Are you having issues with getting gabbi to behave like you want, or is that the handler code you're writing isn't doing what you expect? | |
| 16:41:31 | rfolco | cdent, both. I added trhe DELETE method to call set_inventories, just like PUT does. I created a delete_all in gabbits, but I am getting HTTP 500 response... | |
| 16:43:22 | cdent | when you get the 500 you'll get two different tracebacks: one from gabbi saying the test failed (this is the client side of the wsgi-intercept), and then a bit further up, the one from the wsgi app itself (the server side). Usually the latter is the one that will actually be useful and point out where things have actually gone wrong | |
| 16:45:28 | rfolco | cdent, I assume the gabbits should run in sequence so the delete works only if you create a resource and inventory first for example. | |
| 16:46:13 | cdent | rfolco: yes, that's right: each file is one sequence. even if you ask for just one test, the one's before it in the same file will be run, to make sure those prereqs are done | |
| 16:46:35 | cdent | If you want to push your code to gerrit as a wip I can look at it too? | |
| 16:47:18 | rfolco | cdent, let me do my homework, won't bother you much at this point. It's been a nice learning process. | |
| 16:47:54 | cdent | sure, but if you get to a point where it is no fun, feel free to ping me. Is no bother at all. | |
| 16:48:11 | rfolco | cdent, thanks for the support | |
| 16:57:12 | openstackgerrit | Stephen Finucane proposed openstack/nova: Stop handling differences in registerCloseCallback https://review.openstack.org/416297 | |
| 17:05:08 | mriedem | sfinucan: see my reply in https://review.openstack.org/#/c/415707/ ? | |
| 17:06:08 | sfinucan | mriedem: I did not. Checking | |
| 17:06:56 | mriedem | sfinucan: basically i'd rather not subclass and duplicate the non-network-specific tests | |
| 17:07:15 | sfinucan | mriedem: gotcha | |
| 17:07:17 | mriedem | those quota tests are hittin the nova-net floating IP manager code, | |
| 17:07:32 | sfinucan | just those two, right? | |
| 17:07:37 | mriedem | yeah i think so, | |
| 17:08:06 | mriedem | so i think what you were suggesting was the base class handles the non-network quota stuff, and that runs with either nova-net or neutron config, and then sublcass that to just run the nova-net specific tests | |
| 17:08:15 | mriedem | but that also duplicates the network agnostic quota tests | |
| 17:08:38 | mriedem | it could be a separate test class altogether, idk, doesn't really seem worth the churn | |
| 17:08:46 | sfinucan | yeah, exactly | |
| 17:08:47 | sfinucan | but | |
| 17:08:57 | sfinucan | I didn't realise the other tests were actually network agnostic | |
| 17:09:39 | sfinucan | I thought they were executing different (but duplicated) code paths for some reason | |
| 17:10:29 | sfinucan | Lemme take a second look at it. Defo not worth the churn if what you say is correct | |
| 17:24:31 | mriedem | dansmith: while you're looking at newton-y things :) https://review.openstack.org/#/c/408727/ | |
| 17:24:50 | dansmith | ack | |
| 17:24:55 | openstackgerrit | Chris Dent proposed openstack/nova: Add an "Adding a Handler" section to placement_dev https://review.openstack.org/416304 | |
| 17:24:58 | mriedem | ^ is something i'd like to get in and backported to newton so we can release it as it's an upgrade issue | |
| 17:27:30 | openstackgerrit | Chris Dent proposed openstack/nova: [placement] Add an "Adding a Handler" section to placement_dev https://review.openstack.org/416304 | |
| 17:38:02 | sfinucan | mriedem: Saw the error of my ways | |
| 17:48:19 | openstackgerrit | Claudiu Belu proposed openstack/nova: Add support for setting boot order in Hyper-V https://review.openstack.org/248029 | |
| 18:00:30 | openstackgerrit | Diana Clarke proposed openstack/nova: api-ref: use the examples with paging links https://review.openstack.org/416312 | |
| 18:17:01 | stewie925 | happy new year everyone | |
| 18:17:52 | stewie925 | hey I was trying to rebase a merge conflict - fixed the conflict but ran into a test issue - http://paste.openstack.org/show/593804/ | |
| 18:21:27 | jaypipes | stewie925: source .tox/epy27/bin/activate && pip install -r test-requirements | |
| 18:21:54 | stewie925 | jaypipes: thank you so much | |
| 18:22:02 | jaypipes | stewie925: any time :) | |
| 18:22:40 | jaypipes | stewie925: sorry, that should be: | |
| 18:22:43 | jaypipes | stewie925: source .tox/py27/bin/activate && pip install -r test-requirements | |
| 18:22:53 | jaypipes | (no e in the tox env...) | |
| 18:23:05 | stewie925 | ahh hehe :) | |
| 18:26:56 | stewie925 | jaypipes: it erroed with "Could not open requirements file: [Errno 2] No such file or directory: 'test-requirements' " | |
| 18:27:29 | jaypipes | stewie925: you running this from the root of your nova development tree? | |
| 18:27:54 | stewie925 | jaypipes: yes I am ... its in the ~/nova | |
| 18:28:03 | stewie925 | am pointing to ~/nova I mean | |
| 18:28:08 | frickler | test-requirements.txt ? | |
| 18:28:12 | jaypipes | stewie925: lol, sorry... should be a ".txt" on the end of the test-requirements | |
| 18:28:17 | stewie925 | ahhh hehehe no worries | |
| 18:28:28 | jaypipes | yeah, sorry stewie925.. relying too much on my TAB memory :) | |
| 18:28:34 | stewie925 | yeah I was gonna mention the *.txt file too | |
| 18:28:48 | stewie925 | jaypipes: frickler: thank you :) | |
| 18:28:52 | jaypipes | np | |
| 18:30:26 | stewie925 | ahhh it now installed ddt :) | |
| 18:30:35 | stewie925 | ddt = pesticide? heh | |
| 18:35:07 | jaypipes | stewie925: data-driven testing -- it's testing scenarios library... | |
| 18:40:01 | stewie925 | jaypipes: oh thanks much again, and tests have passed now | |
| 18:40:08 | jaypipes | stewie925: rock on! :) | |
| 19:00:03 | mriedem | sfinucan: thanks | |
| 19:01:23 | _gryf | jaypipes, i'm wondering what is required for getting this patch done right: https://review.openstack.org/#/c/404990/ | |
| 19:02:08 | _gryf | jaypipes, means - blueprint, bug or another patch with bumping microversion for inventories? | |
| 19:02:20 | jaypipes | _gryf: not sure there is currently a way. basically, we need to add support to the placement REST API for returning an error *code* along with the HTTP status code. | |
| 19:02:45 | jaypipes | _gryf: and doing that with a microversion to the placement REST API of course. | |
| 19:03:12 | _gryf | jaypipes, does that requires new blueprint? | |
| 19:04:18 | jaypipes | _gryf: yup... anything that touches the REST API needs a blueprint. | |
| 19:05:01 | _gryf | I can cook it up really quickly if that makes sense for ocata | |
| 19:13:01 | jaypipes | _gryf: sure thing, please do! | |
| 19:13:30 | _gryf | ok :) | |
| 19:13:39 | mriedem | jaypipes: on https://review.openstack.org/#/c/414214/ | |
| 19:13:55 | mriedem | http://logs.openstack.org/14/414214/10/check/gate-tempest-dsvm-ironic-ipa-wholedisk-agent_ipmitool-tinyipa-ubuntu-xenial-nv/4188484/logs/screen-n-cpu.txt.gz?level=TRACE doesn't show the conflicts because the placement-api isn't enabled in the ironic CI job | |
| 19:14:14 | mriedem | that's what https://review.openstack.org/#/c/415523/ is for | |
| 19:15:18 | jaypipes | mriedem: ah sorry my mistake. | |
| 19:15:25 | mriedem | np | |
| 19:15:31 | jaypipes | mriedem: looking through the placement api logs on that patch now. | |
| 19:19:01 | jaypipes | mriedem: I see the problem... | |
| 19:19:52 | mriedem | whew | |
| 19:41:04 | openstackgerrit | Dan Smith proposed openstack/nova: Multicell support for instance listing https://review.openstack.org/396775 | |
| 19:41:04 | openstackgerrit | Dan Smith proposed openstack/nova: Make servers api view load instance fault from proper cell https://review.openstack.org/407238 | |
| 19:41:05 | openstackgerrit | Dan Smith proposed openstack/nova: Make the SingleCellSimple fixture a little more comprehensive https://review.openstack.org/410472 | |
| 19:41:05 | openstackgerrit | Dan Smith proposed openstack/nova: Fix non-parameterized service id in hypervisors sample tests https://review.openstack.org/410471 | |
| 19:41:06 | openstackgerrit | Dan Smith proposed openstack/nova: WIP: Make api_samples tests use simple cell environment https://review.openstack.org/410473 | |
| 19:41:07 | openstackgerrit | Dan Smith proposed openstack/nova: WIP Move instance creation to conductor https://review.openstack.org/319379 | |
| 19:46:28 | jaypipes | mriedem: the default detail parameter value is True... | |
| 19:47:17 | openstackgerrit | Jay Pipes proposed openstack/nova: placement: Do not save 0-valued inventory https://review.openstack.org/414214 | |
| 19:47:31 | mriedem | jaypipes: yeah i know, | |
| 19:47:31 | jaypipes | mriedem: awrighy, let's see if ^ does the trick. | |
| 19:47:46 | mriedem | jaypipes: maybe all of the tests are passing detail=False :) | |
| 19:47:51 | mriedem | otherwise it's a crazy mystery | |
| 19:48:18 | jaypipes | mriedem: I looked through the _wait_for_server_status() stuff and get_servers() never passed detail=False :( | |
| 19:48:40 | jaypipes | mriedem: but I agree it's a crazy mystery thus my original review comment to dansmith :) | |
| 19:51:39 | mriedem | jaypipes: well, are we sure that fill_faults() isn't called, or just that there are no faults for any of the servers being tested? | |
| 19:52:15 | mriedem | as noted in the patch i had pulled it down and raised some exceptions from that code (in _get_fault() in the view class) and the functional tests hit failures in there | |