| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-cyborg - 2026-07-02 | |||
| 20:31:29 | sean-k-mooney | but i am not a fan of that in general | |
| 20:31:47 | sean-k-mooney | melwitt: the atributes api is pretty new | |
| 20:31:57 | sean-k-mooney | as in 2023? maybe | |
| 20:32:08 | sean-k-mooney | perhsp 2021 | |
| 20:32:22 | sean-k-mooney | i dont think ti was fully implemented properly | |
| 20:32:39 | sean-k-mooney | so im not surpsied that there are bugs like that | |
| 20:32:49 | sean-k-mooney | i.e. that it need the db id instead of uuid | |
| 20:33:13 | melwitt | yeah. it's interesting because how did they get the db id assuming someone used this | |
| 20:33:56 | sean-k-mooney | so i think there is a way | |
| 20:34:20 | sean-k-mooney | the placement resouce class i think is alwasy reported as an atribute | |
| 20:34:34 | sean-k-mooney | so fi you do a `GET /v2/attributes` | |
| 20:34:50 | sean-k-mooney | that return the deployable_id as an int | |
| 20:35:19 | sean-k-mooney | hum no | |
| 20:35:55 | sean-k-mooney | that dill does nto allow you to corrlate back to the deployable | |
| 20:37:07 | sean-k-mooney | melwitt: so genera question how do we fix that. | |
| 20:37:26 | sean-k-mooney | because we are fixing a 500 we are technially allwoed to do it without a microverion | |
| 20:37:43 | melwitt | yeah ... there isn't an obvious answer how bc it's so strange | |
| 20:37:46 | sean-k-mooney | i woudl be included to make it only work iwth the uuid if im being honest | |
| 20:38:03 | sean-k-mooney | since the db primary key is inteded to be internal | |
| 20:38:08 | melwitt | yeah | |
| 20:38:31 | sean-k-mooney | i guess we dont need to answer that now | |
| 20:38:52 | melwitt | yeah I put a skip on that test and reference the bug | |
| 20:38:54 | sean-k-mooney | we coudl accpet either and hten stop accapting the id in a future microverion | |
| 20:40:07 | melwitt | I think one could argue to just switch it over bc there seems no realistic way an API caller could get the DB primary key but I might be missing something | |
| 20:40:28 | sean-k-mooney | https://review.opendev.org/c/openstack/cyborg/+/869150 no tests :) | |
| 20:40:46 | sean-k-mooney | melwitt: ya we just need to make sure we also swap it in the responce | |
| 20:40:59 | sean-k-mooney | so the responce shoudl also reuttin the uuid for the deployable | |
| 20:41:34 | melwitt | yeah | |
| 20:43:26 | sean-k-mooney | https://specs.openstack.org/openstack/cyborg-specs/specs/2023.2/implemented/attribute-api-support.html | |
| 20:43:33 | sean-k-mooney | so the spec was only partly implemited | |
| 20:43:54 | sean-k-mooney | you are ment to be abel to acces the atributs vai /v2/deployable/{uuid}/attribute | |
| 20:44:19 | sean-k-mooney | and that is how you are ment to add/remove them | |
| 20:44:43 | sean-k-mooney | that actully alot clsoer wo how i wanted to evolve the api | |
| 20:45:56 | sean-k-mooney | melwitt: im almost tempeted to revert out the current atribtues api and implemnt it properly since it does not work and it does not match the spec | |
| 20:48:38 | melwitt | I guess if that's how it was meant to be implemented ... could flesh that out and then maybe deprecate /attributes potentially? | |
| 20:48:54 | sean-k-mooney | yep | |
| 20:49:06 | sean-k-mooney | atribtue wer enot inteded to be a top level resouce | |
| 20:49:11 | melwitt | or I guess maybe only allow listing or getting. I dunno | |
| 20:49:16 | melwitt | ok | |
| 20:49:20 | sean-k-mooney | they were emnt to be a sub resocue to allow you to add and remove placment trait form dpeloyables | |
| 20:50:11 | sean-k-mooney | ok dinner is ready so im going to go | |
| 20:50:22 | melwitt | ok, ttyl | |
| 20:51:23 | sean-k-mooney | i think in advacce for the next ptg im going to spend some time prepareing a spec for all of the api techinial debt so we can have a singel microversion ot correct all of this | |
| 20:51:36 | sean-k-mooney | unless you end up doing it first :) | |
| 20:52:00 | sean-k-mooney | melwitt: i think we actully came across this issue a few weeks ago by the way | |
| 20:52:11 | sean-k-mooney | right around 2026.1 FF | |
| 20:52:18 | melwitt | a-ha :) | |
| 20:52:26 | sean-k-mooney | i just didnt get around to writing this down | |
| 20:53:13 | sean-k-mooney | o/ | |
| 20:53:29 | melwitt | o/ | |
| 22:16:33 | melwitt | sean-k-mooney: I think https://review.opendev.org/c/openstack/openstacksdk/+/995851 is ready for review now and I have https://review.opendev.org/c/openstack/python-cyborgclient/+/995877 depends-on it to run the job on the client | |
| 22:17:43 | sean-k-mooney[m] | Cool I'll probably get to it on monday | |
| 22:18:16 | sean-k-mooney[m] | Can you add me to them in gerrit | |
| 22:18:46 | melwitt | sure | |
| 22:19:02 | melwitt | (sorry that was meant to be a async message) | |
| 22:21:11 | sean-k-mooney[m] | I'm just walking home | |
| 22:21:33 | sean-k-mooney[m] | So your not interrupting | |
| 22:21:49 | melwitt | ok good | |
| 22:38:51 | opendevreview | sean mooney proposed openstack/cyborg master: Adapt Cyborg to always-enforced policy scope https://review.opendev.org/c/openstack/cyborg/+/995867 | |
| #openstack-cyborg - 2026-07-03 | |||
| 08:09:45 | opendevreview | Ronelle Landy proposed openstack/python-cyborgclient master: Remove deprecated v1 API and fix Python 3.12+ SSL compatibility https://review.opendev.org/c/openstack/python-cyborgclient/+/995789 | |
| 08:45:17 | opendevreview | Ronelle Landy proposed openstack/python-cyborgclient master: Remove deprecated v1 API and fix Python 3.12+ SSL compatibility https://review.opendev.org/c/openstack/python-cyborgclient/+/995789 | |
| 08:55:35 | opendevreview | Ronelle Landy proposed openstack/python-cyborgclient master: Remove deprecated v1 API and fix Python 3.12+ SSL compatibility https://review.opendev.org/c/openstack/python-cyborgclient/+/995789 | |
| 11:06:22 | opendevreview | chandan kumar proposed openstack/cyborg master: [WIP] pci-sim: Add CentOS Stream 10 support https://review.opendev.org/c/openstack/cyborg/+/995935 | |
| 11:36:21 | opendevreview | chandan kumar proposed openstack/cyborg master: [WIP] pci-sim: Add CentOS Stream 10 support https://review.opendev.org/c/openstack/cyborg/+/995935 | |
| 11:55:04 | rlandy | chandankumar, melwitt, wrt https://review.opendev.org/c/openstack/python-cyborgclient/+/995789, I'd like to fix two issues before continuing ... | |
| 11:55:08 | rlandy | 1. https://review.opendev.org/c/openstack/python-cyborgclient/+/995789/5/cyborgclient/tests/unit/utils.py | |
| 11:55:42 | rlandy | two options. think the second is better ie: "migrate test_utils.py to use tests/base.py" | |
| 11:56:20 | rlandy | 2. OpenStack SDK exampke idk the code base well enough ... pls advise here | |
| 11:56:27 | rlandy | then I can continue | |
| 11:59:01 | sean-k-mooney | rlandy: 1 yes that waht i would do as well | |
| 11:59:29 | sean-k-mooney | rlandy: for 2 just delete the example | |
| 11:59:59 | sean-k-mooney | and the python api section | |
| 12:00:11 | sean-k-mooney | we do not want to supprot this repo as a python lib going forward | |
| 12:00:35 | sean-k-mooney | if you want a lib to take to cyborg you shoudl just use the sdk | |
| 12:01:36 | rlandy | sean-k-mooney: thank you - fixing the above | |
| 12:02:03 | sean-k-mooney | https://codesearch.opendev.org/?q=python-cyborgclient&i=nope&literal=nope&files=&excludeFiles=&repos= | |
| 12:02:24 | sean-k-mooney | python-cyborgclient is not currently used by any other project programaticly | |
| 12:02:43 | sean-k-mooney | so we dont need to worry about supproting that or having a deprecation period | |
| 12:03:48 | sean-k-mooney | if we can port the osc plugin funcitonaltiy into osc this/next release im hoping we can just delete this repo in 2027.2 after we deprecate it in 2027.1 | |
| 12:04:03 | opendevreview | Ronelle Landy proposed openstack/python-cyborgclient master: Remove deprecated v1 API and fix Python 3.12+ SSL compatibility https://review.opendev.org/c/openstack/python-cyborgclient/+/995789 | |
| 12:09:19 | opendevreview | Ronelle Landy proposed openstack/python-cyborgclient master: Remove deprecated v1 API and fix Python 3.12+ SSL compatibility https://review.opendev.org/c/openstack/python-cyborgclient/+/995789 | |
| 13:06:38 | opendevreview | Joan Gilabert proposed openstack/cyborg-specs master: Add 2027.1 spec structure https://review.opendev.org/c/openstack/cyborg-specs/+/995946 | |
| 13:21:54 | opendevreview | chandan kumar proposed openstack/cyborg master: [WIP] pci-sim: Add CentOS Stream 10 support https://review.opendev.org/c/openstack/cyborg/+/995935 | |
| 13:36:17 | opendevreview | Ronelle Landy proposed openstack/python-cyborgclient master: Remove deprecated v1 API and fix Python 3.12+ SSL compatibility https://review.opendev.org/c/openstack/python-cyborgclient/+/995789 | |
| 13:38:31 | rlandy | chandankumar: ^^ should include all the clean up you listed | |
| 13:38:42 | rlandy | pls review when you have a chance | |
| 13:43:14 | chandankumar | rlandy: thank you, will add it to my list! | |
| 13:45:14 | rlandy | still checking test output | |
| #openstack-cyborg - 2026-07-05 | |||
| 16:04:39 | opendevreview | Ronelle Landy proposed openstack/python-cyborgclient master: Remove deprecated v1 API and fix Python 3.12+ SSL compatibility https://review.opendev.org/c/openstack/python-cyborgclient/+/995789 | |
| #openstack-cyborg - 2026-07-06 | |||
| 04:48:05 | opendevreview | chandan kumar proposed openstack/cyborg master: [WIP] pci-sim: Add CentOS Stream 10 support https://review.opendev.org/c/openstack/cyborg/+/995935 | |
| 05:27:45 | opendevreview | Ronelle Landy proposed openstack/python-cyborgclient master: Remove deprecated v1 API and fix Python 3.12+ SSL compatibility https://review.opendev.org/c/openstack/python-cyborgclient/+/995789 | |
| 05:34:23 | opendevreview | chandan kumar proposed openstack/cyborg master: pci-sim: Add CentOS Stream 10 support https://review.opendev.org/c/openstack/cyborg/+/995935 | |
| 07:38:01 | opendevreview | Ronelle Landy proposed openstack/python-cyborgclient master: Remove deprecated v1 API and fix Python 3.12+ SSL compatibility https://review.opendev.org/c/openstack/python-cyborgclient/+/995789 | |
| 07:38:46 | rlandy | ^^ based patch back to master for review | |
| 07:39:27 | rlandy | removed melwitt rebase for merge consideration | |
| 12:24:38 | opendevreview | Merged openstack/python-cyborgclient master: Bump hacking https://review.opendev.org/c/openstack/python-cyborgclient/+/989548 | |
| 12:24:40 | opendevreview | Merged openstack/python-cyborgclient master: Update supported python versions https://review.opendev.org/c/openstack/python-cyborgclient/+/989556 | |
| 12:24:41 | opendevreview | Merged openstack/python-cyborgclient master: Use update_deployable for deployable program OSC command https://review.opendev.org/c/openstack/python-cyborgclient/+/988610 | |
| 12:30:46 | sean-k-mooney | rlandy: sorry some of those ^ conflcited with your patch but also fixed most of the remaining nits | |
| 12:31:07 | sean-k-mooney | rlandy: would you mind droping oslo.utils when you fix the merge conflict then ill approve it | |