Earlier  
Posted Nick Remark
#openstack-cyborg - 2026-06-30
14:36:07 jgilaber #topic Open discussion
14:36:16 jgilaber any last minute topic to raise?
14:36:42 sean-k-mooney maybe we coudl chat abouy https://github.com/adamchainz/flake8-logging/pull/187 quickly
14:36:50 jgilaber looking
14:37:08 sean-k-mooney melwitt: so we have moved away form using flake8 in general to using ruff for linting
14:37:22 sean-k-mooney we coudl run that check via the hacking env
14:37:30 sean-k-mooney since it uses flake internally
14:37:34 melwitt ok that's good to know
14:37:44 sean-k-mooney but woudl it be better to just have a local hacking check instead
14:38:24 melwitt I don't know a lot about it so I wasn't aware we could make local checks. if that's an option then seems like a nice idea?
14:39:03 sean-k-mooney so there are 2 ways we coudl do this
14:39:13 melwitt I'm skeptical my PR will go anywhere but I tried it anyway
14:39:14 sean-k-mooney a pre-commit hook or a local hackign check
14:39:19 sean-k-mooney the later is proably simpler
14:39:37 sean-k-mooney this might be genericlly usefully enough to put in hacking propper as well
14:40:54 melwitt ok, I will look into that then, thanks
14:41:47 sean-k-mooney ah right
14:41:49 sean-k-mooney https://github.com/openstack/cyborg/commit/8eb3a5a4b2a8fa0fc969290ceace9f574715d027
14:42:16 sean-k-mooney i delete our hacking plugin
14:42:20 sean-k-mooney but we can add one back
14:42:25 melwitt :)
14:42:42 sean-k-mooney i deleted it because i didnt like the preior rules it used in general
14:43:05 sean-k-mooney well or the were duplicats of other checks
14:43:10 melwitt oh ok
14:43:51 sean-k-mooney nova has a bunch of hackign plugin examples too for what its worth
14:44:14 sean-k-mooney anyway i think we can chat about that outside the meeting
14:44:23 sean-k-mooney any other topics or questions on this topic?
14:44:28 melwitt sure. I will put something together. thanks for the info
14:45:10 sean-k-mooney ... https://github.com/openstack/cyborg/blob/master/cyborg/__init__.py sorry got distracted
14:45:19 sean-k-mooney we need to fix ^
14:45:35 sean-k-mooney i nocied that lookign at the old commit
14:45:52 sean-k-mooney but we have been asked to remove any runtim usage of pbr by the pbr maintianers
14:46:04 melwitt ok good to know
14:46:07 sean-k-mooney ill file a bug for that later
14:46:23 sean-k-mooney we are emnt to use import lib metadta or soemthign instead
14:46:35 sean-k-mooney or just stop providing __version__
14:46:50 sean-k-mooney there was a mail thread about it a month ago or there abouts
14:47:11 jgilaber ack thanks sean-k-mooney we can look at the bug in the next meeting
14:47:23 jgilaber I think I missed this email
14:47:26 sean-k-mooney https://lists.openstack.org/archives/list/openstack-discuss@lists.openstack.org/thread/V7JFTBRA3CHHIWCZM5CM2LE27ESDJHO7/#V7JFTBRA3CHHIWCZM5CM2LE27ESDJHO7
14:48:06 sean-k-mooney https://review.opendev.org/c/openstack/python-openstackclient/+/987782/2/openstackclient/__init__.py
14:48:14 sean-k-mooney so that the exampel fo what we shoudl do instead
14:48:45 jgilaber seems simple enough
14:48:51 sean-k-mooney ok ill file a bug for that and create a patch later
14:49:02 sean-k-mooney ya pretty much
14:49:27 sean-k-mooney they just would prefer to keep pbr as a build time only tool going forward to limit the maintance
14:51:17 jgilaber thanks for bringing it up sean-k-mooney, anything else on this topic or any other?
14:53:00 jgilaber last thing for today
14:53:04 jgilaber #topic Volunteers to chair next meeting
14:53:08 jgilaber any volunteer?
14:53:59 rlandy I can do it
14:54:06 jgilaber thanks rlandy
14:54:16 jgilaber that is all for today, thanks everyone!
14:54:19 opendevmeet Log: https://meetings.opendev.org/meetings/cyborg/2026/cyborg.2026-06-30-14.00.log.html
14:54:19 opendevmeet Minutes (text): https://meetings.opendev.org/meetings/cyborg/2026/cyborg.2026-06-30-14.00.txt
14:54:19 opendevmeet Minutes: https://meetings.opendev.org/meetings/cyborg/2026/cyborg.2026-06-30-14.00.html
14:54:19 opendevmeet Meeting ended Tue Jun 30 14:54:19 2026 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4)
14:54:19 jgilaber #endmeeting
14:54:23 morenod thanks!!
14:54:28 rlandy jgilaber++ thank you
15:11:25 melwitt sean-k-mooney: a primer for the API samples testing patch ... I used claude and gave a goal for something much lighter weight than the usual .tpl model. if you hate it let me know and I can try something else
15:12:54 sean-k-mooney i hate our normal model so im sure ill like it :)
15:13:17 melwitt haha well, I have left the hate door open if you need it :)
15:13:55 sean-k-mooney so long term (in like 6-12 months time) i woudl love to not need this because we fully impleitne the OPENAPI schema goal for cybrog
15:14:15 melwitt next in the "plan" is gabbi API tests
15:14:29 melwitt yeah, good point, that takes some of the pressure off
15:14:41 sean-k-mooney i.e. it woudl be nice if the schmea was validate speratly form the sampels which jsut woudl help with docuemtion
15:15:16 sean-k-mooney i need ot start a wider converation on evovling the api
15:15:22 melwitt so openapi does both request and response schemas right?
15:15:28 sean-k-mooney yes
15:15:33 sean-k-mooney if you implemnt both of course
15:15:44 melwitt I mean, should I instead be starting with that?
15:16:00 sean-k-mooney no i think this is low haning fruit
15:16:08 sean-k-mooney and its good to get this in place to have any coverage
15:16:10 melwitt ok cool
15:16:21 melwitt yeah. it found some minor errors
15:16:41 sean-k-mooney but if you wanted to start on that after sure. we should ahve that converstaion about the other api issues that i was hopign to look at next cycle
15:16:43 melwitt well, I guess define "minor" but some parameters that should not have been in the samples and some missing
15:17:05 melwitt nah just wanted to make sure I stay aligned with the wanted plans
15:17:26 sean-k-mooney nope your totally aligned now worries on that front
15:17:40 sean-k-mooney so tempst ahas only ever had scemeas for nova and cindier i belive
15:17:56 sean-k-mooney i woudl perfer to avodi addig them for cybrog and jsut do the openapi feature isntead
15:18:00 melwitt the tempest schemas are so painful in my experience
15:18:09 sean-k-mooney espcially since cybnorg api is small
15:18:42 sean-k-mooney by the way i think one fo the api routes is missing form the api ref
15:19:19 melwitt oh hm
15:19:25 sean-k-mooney https://docs.openstack.org/api-ref/accelerator/#deployables or https://docs.openstack.org/api-ref/accelerator/#devices
15:19:33 sean-k-mooney has a update/program endpoint
15:19:40 sean-k-mooney for programign fpgas
15:19:50 sean-k-mooney i belive it sdeployables via a patch or put
15:20:21 melwitt ok I'll check on it
15:21:23 sean-k-mooney looking at my srbac serise its deployables https://review.opendev.org/c/openstack/cyborg/+/992295/5/cyborg/policies/deployables.py#41
15:21:46 sean-k-mooney ah and yes PATCH
15:22:32 sean-k-mooney chandan has a chagne up to test that with the fake driver via tempest
15:23:17 sean-k-mooney long term im not conviced that api shoudl exsit but that a sperate matter
15:23:18 melwitt so speaking of the tempest test stuff ... is your pci kernel module thing what we can use to do proper lifecycle coverage?
15:23:28 sean-k-mooney yep
15:23:36 melwitt ok great
15:23:45 sean-k-mooney the emulated device can be passed to the qemu isntance and actully work
15:23:52 melwitt super

Earlier   Later