| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-cyborg - 2020-07-16 | |||
| 03:21:01 | Yumeng | xinranwang__: cool. just saw the update. will review again.^ | |
| 03:21:15 | xinranwang__ | lol | |
| 03:22:53 | Yumeng | ok. I nothing more important than review to mention today. | |
| 03:23:00 | Yumeng | I have | |
| 03:23:29 | swp20 | Yumeng , should we add api for cleaning devices as there may be some inconsistent data in db? | |
| 03:23:30 | brinzhang | Yumeng, swp20: the project_id in some interface is make sense, agree to add | |
| 03:24:37 | Yumeng | can you share more info? what's the inconsistent data in db? | |
| 03:24:51 | swp20 | brinzhang: ok, i will fix the tempest for the project_idpatch. | |
| 03:25:19 | brinzhang | swap20: cool, thanks | |
| 03:25:48 | Yumeng | swp20: but not in a hurry. you can also ping me in wechat once convenient. | |
| 03:25:50 | swp20 | Yumeng, such as we discuss at PTG, Cyborg db data is inconsistent with Placement db | |
| 03:26:00 | Yumeng | aha. | |
| 03:27:19 | swp20 | or maybe device table is inconsistent with deployables/attributes adn so on.. | |
| 03:28:32 | swp20 | cool. i will contact with u in wechat. | |
| 03:28:34 | Yumeng | from my understanding, if the goal is to solve the inconsistent data in db, it doesn't need to add an api, maybe just some data check, and cleaning by involing current API will make sense | |
| 03:28:55 | Yumeng | involking | |
| 03:29:49 | Yumeng | anyway, that's a case to case thing. we might need to discuss more details to decide if we need an API | |
| 03:30:11 | Yumeng | let's continue in wechat.:) | |
| 03:30:12 | swp20 | ok, got it. thanks. | |
| 03:30:37 | Yumeng | so that's all for today. Thank you guys! | |
| 03:30:45 | Yumeng | let's wrap up this meeting and I'll see you all again next week. | |
| 03:30:51 | Yumeng | Bye. | |
| 03:30:58 | Yumeng | #endmeeting | |
| 03:31:00 | openstack | Meeting ended Thu Jul 16 03:30:58 2020 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) | |
| 03:31:01 | swp20 | Bye | |
| 03:31:02 | openstack | Minutes: http://eavesdrop.openstack.org/meetings/openstack_cyborg/2020/openstack_cyborg.2020-07-16-03.04.html | |
| 03:31:03 | openstack | Minutes (text): http://eavesdrop.openstack.org/meetings/openstack_cyborg/2020/openstack_cyborg.2020-07-16-03.04.txt | |
| 03:31:04 | openstack | Log: http://eavesdrop.openstack.org/meetings/openstack_cyborg/2020/openstack_cyborg.2020-07-16-03.04.log.html | |
| 09:28:20 | openstackgerrit | Brin Zhang proposed openstack/python-cyborgclient master: Enable openstackdocs config to storyboard https://review.opendev.org/734403 | |
| 11:09:38 | openstackgerrit | YumengBao proposed openstack/cyborg master: P0: Refresh cyborg basic_policies and device_profile_policies https://review.opendev.org/740542 | |
| 11:23:02 | openstackgerrit | YumengBao proposed openstack/cyborg master: P0: Refresh cyborg basic_policies and device_profile_policies https://review.opendev.org/740542 | |
| 11:52:40 | openstackgerrit | YumengBao proposed openstack/cyborg master: P0: Refresh cyborg basic_policies and device_profile_policies https://review.opendev.org/740542 | |
| 11:54:36 | openstackgerrit | YumengBao proposed openstack/cyborg master: P0: Refresh cyborg basic_policies and device_profile_policies https://review.opendev.org/740542 | |
| #openstack-cyborg - 2020-07-17 | |||
| 08:39:13 | openstackgerrit | Wenping Song proposed openstack/cyborg-specs master: Add Inspur FPGA driver specification. https://review.opendev.org/730760 | |
| #openstack-cyborg - 2020-07-20 | |||
| 01:42:27 | openstackgerrit | Shogo Saito proposed openstack/cyborg master: Programming support (v2 Deployable API) https://review.opendev.org/698190 | |
| #openstack-cyborg - 2020-07-23 | |||
| 01:50:35 | openstackgerrit | YumengBao proposed openstack/cyborg master: P0: Refresh cyborg basic_policies and device_profile_policies https://review.opendev.org/740542 | |
| 01:52:08 | openstackgerrit | YumengBao proposed openstack/cyborg master: P0: Refresh cyborg basic_policies and device_profile_policies https://review.opendev.org/740542 | |
| 02:02:58 | openstackgerrit | YumengBao proposed openstack/cyborg master: P0: Refresh cyborg basic_policies and device_profile_policies https://review.opendev.org/740542 | |
| 03:02:12 | songwenping__ | Hi Yumeng, morning. | |
| 03:02:34 | Yumeng | hi songwenping__, brinzhang_ | |
| 03:02:56 | brinzhang_ | hi Yuemng, songwenping__ | |
| 03:03:21 | brinzhang_ | Yumeng: sorry, spelling error | |
| 03:03:44 | Yumeng | haha, no worries | |
| 03:03:56 | Yumeng | hi chenke | |
| 03:04:27 | Yumeng | seems not much people today | |
| 03:04:36 | chenke | hi yumeng. hi all. | |
| 03:04:45 | songwenping__ | hi chenke | |
| 03:04:52 | chenke | hi songwenping. | |
| 03:05:13 | Yumeng | shall we just kick off the meeting now or wait a few minutes? | |
| 03:05:44 | Yumeng | hi xinranwang__ | |
| 03:05:48 | xinranwang__ | Hi Yumeng | |
| 03:06:21 | Yumeng | great. let's getting start! | |
| 03:06:39 | Yumeng | #startmeeting openstack-cyborg | |
| 03:06:40 | openstack | Meeting started Thu Jul 23 03:06:39 2020 UTC and is due to finish in 60 minutes. The chair is Yumeng. Information about MeetBot at http://wiki.debian.org/MeetBot. | |
| 03:06:41 | openstack | Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. | |
| 03:06:43 | openstack | The meeting name has been set to 'openstack_cyborg' | |
| 03:06:45 | Yumeng | #topic Roll call | |
| 03:06:52 | Yumeng | #info Yumeng | |
| 03:07:00 | xinranwang__ | #info xinranwang__ | |
| 03:07:01 | brinzhang_ | #info brinzhang_ | |
| 03:07:05 | chenke | #info chenke | |
| 03:07:19 | Yumeng | #topic Agenda | |
| 03:07:32 | songwenping__ | #info songwenping__ | |
| 03:07:49 | Yumeng | #topic policy default refresh | |
| 03:08:27 | Yumeng | I updated this morning https://review.opendev.org/#/c/740542/ | |
| 03:08:59 | Yumeng | now this patch submmited the basic policies and device_profile policies, and basic framwork | |
| 03:10:18 | brinzhang_ | Yumeng: I was reviewed just now, but I am sorry not looked into. in general, LGTM, but that need to add the UT, I left comment inline. | |
| 03:11:05 | Yumeng | both the old and new policies will both work during development process | |
| 03:11:20 | brinzhang_ | Yumeng: after I compeleted thing in my hands, I will check again about the implemention details. | |
| 03:11:51 | brinzhang_ | sound good. | |
| 03:12:42 | brinzhang_ | we should keep old policies and new policies are all run good, thanks | |
| 03:12:46 | Yumeng | brinzhang_: yes we need test. but not as easy as a unit test update in current API tests. that should be another tests for only policies, we should add new policy test framwork, that would be a big work. | |
| 03:13:34 | brinzhang_ | Yumeng: I know, but in the patch if you dont add the UT, I dont think it's good to go. | |
| 03:13:39 | Yumeng | I will submit the policy test in another patch, I just don't want to make the first patch too big. | |
| 03:14:24 | brinzhang_ | you can splite the UT for add new policies, another patch is to add the new policies to the interface | |
| 03:15:04 | Yumeng | for this patch, I have tested the function by current unit test, the test_create case of device_profile, I have pasted the detailed debug info to the commit message: http://paste.openstack.org/show/796229/ | |
| 03:15:09 | xinranwang__ | Policy test framework is a big work. We can just add test in API test first | |
| 03:16:21 | xinranwang__ | For example, add test in device_profile API, test create dp by non admin user, and it fails | |
| 03:16:32 | brinzhang_ | xinranwang__: yeah, we can. But the better way is add as the same time. | |
| 03:16:39 | xinranwang__ | Do you think this make sense | |
| 03:17:17 | brinzhang_ | It make sense to me. But I also hope that it is not a TODO. | |
| 03:18:32 | xinranwang__ | We can add api test in this patch. Policy test framwork can be in a new patch. | |
| 03:18:42 | xinranwang__ | What do you think Yumeng | |
| 03:19:50 | Yumeng | xinranwang__: yes! agree, current API tests will go through the policy check in each test. I will start in the next patch very soon to submit policy test for device_profile | |
| 03:20:49 | brinzhang_ | thanks | |
| 03:21:44 | Yumeng | but for this patch, I think the detailed debug info has shown the policy check process, which can show that this patch basically works, so we can start review. | |
| 03:23:26 | Yumeng | this patch can be merged after the next policy test patch is passed and submitted, but can start review now. what do you think? | |
| 03:24:05 | brinzhang_ | Yumeng, do you test the older policies? I saw you deprecated the old policies, I am not sure it's ok for all apis | |
| 03:24:06 | brinzhang_ | https://review.opendev.org/#/c/740542/10/cyborg/policies/base.py@95 | |
| 03:25:20 | brinzhang_ | Yumeng: this patch I think we (xinranwang__) dont reviewed into, after checked again, we can decide whether let it to go, do you think so? | |
| 03:25:48 | brinzhang_ | is there a milestone? | |
| 03:27:10 | Yumeng | the old policies are "not actually" deprecated, they won't actually deprecated until we set [oslo_policy] enforce_policy=True in cyborg.conf | |
| 03:27:53 | Yumeng | the old policies work for now, they just marked as deprecated, not actually deprecated. | |
| 03:28:54 | Yumeng | emmm. I think we should add tests for new policies, for the old policies, we will deprecate them after all the new policies are implemented | |
| 03:29:36 | brinzhang_ | agree, so I think this change should have UT to cover the old policies and the new policies, and checked the enforce_policy config (of course you can do in another patch, but it will be not easy to review). | |
| 03:30:15 | brinzhang_ | no, after you completed the new policies, we also need to keep the old policies run until W or X release | |
| 03:30:46 | brinzhang_ | To ensure backward compatibility, we should not remove it so quickly. | |
| 03:31:05 | brinzhang_ | What do you think? Yumeng, xinranwang__, songwenping__ | |
| 03:31:20 | songwenping__ | Yumeng: you can fix the ut and pep8 first, ths. | |
| 03:32:05 | Yumeng | brinzhang_: yes, that's what I planed. I have NOTE them in the code. deprecate_since W | |