| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-cyborg - 2020-03-19 | |||
| 03:40:18 | brinzhang_ | thanks xinranwang and all | |
| 03:40:23 | brinzhang_ | Sundar, pls do next agenda | |
| 03:40:41 | xinranwang | There are other projects naming with release name. If you guys prefer other ways like ADD_X_PARAM, I will update it. It is flexible. | |
| 03:41:24 | xinranwang | btw, please review deployabel API patch when you got time, I think it is almost ready. | |
| 03:41:49 | chenke | +1 | |
| 03:41:50 | Sundar | I don't have any specific next agenda item. | |
| 03:42:03 | chenke | how about your nova patches? | |
| 03:42:08 | chenke | Sundar | |
| 03:42:31 | brinzhang_ | xinranwang: just need change _MIN_VERSION_STRING to _MIN_API_VERSION, and use current_api_version or thers you thinks instead of "Version.sting" | |
| 03:42:51 | Sundar | xinranwang: Could you add a pointer to those projects's code that uses release names? If there is any precedent code that I can look at, for microversions in general, that would be useful. | |
| 03:43:29 | xinranwang | sure, let me find it. | |
| 03:43:37 | Sundar | chenke: I have got some review comments on Novapatches. I was off for a few days but will resume again. | |
| 03:44:30 | chenke | Okay. | |
| 03:45:32 | Sundar | xinranwang: You can provide those references in Gerrit. | |
| 03:45:41 | Sundar | Anything else, folks? | |
| 03:45:46 | s_shogo | Mere Reporting , the client topic mentioned in the last IRC : the cyborg client from pip doesn't include sdk implementation now.(That doesn't be released yet.) | |
| 03:45:47 | brinzhang_ | https://review.opendev.org/#/q/status:open+project:openstack/cyborg+branch:master+topic:story/2007397 | |
| 03:46:02 | brinzhang_ | pls review this change, I think it's ready to go | |
| 03:47:36 | xinranwang | Sundar: ok | |
| 03:47:53 | brinzhang_ | s_shogo: so cyborgclinet can support "pip install" and the "SDK" doesnot, right? | |
| 03:48:31 | brinzhang_ | I have used pip install to install the cyborgclient, but not try to test SDK yet | |
| 03:48:56 | s_shogo | brinzhang_ sdk is ok , but client is not yet. | |
| 03:49:22 | s_shogo | (by pip) | |
| 03:50:10 | brinzhang_ | s_shogo: get it, but I can install python-cyborgclinet to my local env (devstack). I will check the client version again | |
| 03:51:41 | s_shogo | brinzhang_ thanks .The client installed pip is probably old one,without sdk version. | |
| 03:51:43 | brinzhang_ | root@ubuntu-OpenStack:~# cyborg --version | |
| 03:51:44 | brinzhang_ | 1.0.0 | |
| 03:52:04 | brinzhang_ | Ah, 1.0.0 | |
| 03:52:22 | Sundar | brinzhang_: I think https://review.opendev.org/#/q/status:open+project:openstack/cyborg+branch:master+topic:story/2007397 needs to be updated, because the top patches are based on PS 4/6 of the bottom patch, instead of the latest 6/6. | |
| 03:53:08 | brinzhang_ | Sundar, it's not any impact | |
| 03:53:48 | brinzhang_ | the base patch just update the json data | |
| 03:54:00 | Sundar | ok | |
| 03:55:37 | brinzhang_ | Sundar: Thanks | |
| 03:56:40 | Sundar | Any thoughts or reviews of https://review.opendev.org/#/c/712231/ ? | |
| 03:57:24 | Sundar | Oh, I see some comments, but no -1. WIll respond to the comments | |
| 03:57:29 | brinzhang_ | Sundar I left some comments inline^^ | |
| 03:57:50 | Sundar | ok | |
| 03:58:03 | Yumeng | I was reviewing it yesterday. but not finished. | |
| 03:58:05 | Sundar | Thanks, brinzhang_ | |
| 03:58:13 | Yumeng | I will review it today. | |
| 03:58:24 | Sundar | Yumeng, I'll wait, no rush | |
| 03:58:31 | Yumeng | ^^ ok | |
| 03:58:37 | Sundar | Anything else, folks? | |
| 03:58:56 | openstackgerrit | Brin Zhang proposed openstack/cyborg master: Add description column to device_profiles db https://review.opendev.org/703285 | |
| 03:59:24 | Yumeng | nope from my side. | |
| 03:59:36 | openstackgerrit | Brin Zhang proposed openstack/cyborg master: Add 'description' field to the device profile object https://review.opendev.org/703293 | |
| 03:59:55 | Yumeng | ops. https://review.opendev.org/#/c/709433/ need final review. | |
| 03:59:58 | Yumeng | thanks! | |
| 04:00:10 | brinzhang_ | Sundar: About https://review.opendev.org/#/c/703293/, I was rebased on the latest change, pls see again | |
| 04:00:18 | brinzhang_ | nothing else | |
| 04:01:06 | brinzhang_ | Yumeng: Will review at afternoon | |
| 04:01:20 | Sundar | Ok | |
| 04:01:32 | Yumeng | Thank you Brin. | |
| 04:01:33 | Sundar | Thanks everybody. Have a good week. | |
| 04:01:38 | Sundar | #endmeeting | |
| 04:01:39 | openstack | Meeting ended Thu Mar 19 04:01:37 2020 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) | |
| 04:01:40 | openstack | Minutes: http://eavesdrop.openstack.org/meetings/openstack_cyborg/2020/openstack_cyborg.2020-03-19-03.02.html | |
| 04:01:41 | openstack | Minutes (text): http://eavesdrop.openstack.org/meetings/openstack_cyborg/2020/openstack_cyborg.2020-03-19-03.02.txt | |
| 04:01:42 | openstack | Log: http://eavesdrop.openstack.org/meetings/openstack_cyborg/2020/openstack_cyborg.2020-03-19-03.02.log.html | |
| 04:01:45 | Yumeng | bye. | |
| 04:01:47 | xinranwang | Yumeng: LGTM | |
| 04:01:54 | xinranwang | bye | |
| 04:02:04 | s_shogo | bye | |
| 04:02:11 | brinzhang_ | Sundar: pls see the base patch, the latest patch depend on the base patch ^ | |
| 04:02:21 | brinzhang_ | bye~ | |
| 04:02:43 | openstackgerrit | Brin Zhang proposed openstack/cyborg master: Add Cyborg API Reference to Cyborg index https://review.opendev.org/711869 | |
| 06:02:11 | chenke | why brin still not have +2 ? | |
| 06:02:30 | chenke | brinzhang_ | |
| 06:03:56 | brinzhang_ | chenke, maybe tomorrow? We can go to wechat ask Sundar ^^ | |
| 06:04:12 | brinzhang_ | he seems not in irc | |
| 06:04:28 | chenke | oh. I think he need to add you to core group | |
| 06:04:43 | brinzhang_ | chenke, thanks | |
| 06:05:01 | chenke | I remind him in wechat. | |
| 06:05:21 | brinzhang_ | chenke: yeah, thanks again :) | |
| 06:06:15 | chenke | np | |
| 06:42:06 | openstackgerrit | Merged openstack/cyborg master: Fix GPU's improper cpid_type allowed value and attach_handle_type value https://review.opendev.org/709433 | |
| 07:48:39 | openstackgerrit | Brin Zhang proposed openstack/cyborg master: Add Cyborg API Reference to Cyborg index page https://review.opendev.org/711869 | |
| 16:35:15 | Sundar | dansmith, sean-k-moone, gibi: I've been away for a few days. Starting today, I intend to make one final push to get the Cyborg series done. I have roughly a week to wrap things up in my current role and move on. It is good to see that every patch got some review. | |
| 16:35:33 | dansmith | Sundar: great thanks | |
| 16:37:13 | Sundar | dansmith: Thanks for your reviews. I am looking to include most of them. | |
| 16:37:43 | Sundar | Regarding your comment about not including a comment :): https://review.opendev.org/#/c/673735/45/nova/compute/api.py@2454 | |
| 16:38:35 | Sundar | first: ithe comment serves to explain what the term ARQ stands for, which will point the reader towards Cyborg. | |
| 16:39:17 | Sundar | second: I see that comments will less info have been approved :) https://review.opendev.org/gitweb?p=openstack/nova.git;f=nova/compute/api.py;hb=refs/changes/35/673735/45#l1193 | |
| 16:39:26 | Sundar | *s/will/with/ | |
| 16:39:47 | dansmith | Sundar: I figured you'd know by now, but that argument holds no weight with me | |
| 16:40:15 | Sundar | Even if you are the one that did the approving? :) | |
| 16:40:46 | dansmith | totally | |
| 16:40:59 | Sundar | Anyways, I think it is worth retaining some comments that expand the term ARQ, at least one in each major code path | |
| 16:46:21 | Sundar | Re. the IRC discussion http://eavesdrop.openstack.org/irclogs/%23openstack-nova/%23openstack-nova.2020-03-16.log.html#t2020-03-16T15:57:20, yes, I have tested the XML generated with real devices. Not only by looking at the xml, but also by running a sample application within the VM that interacts with the FPGA. | |
| 16:47:03 | Sundar | dansmith, sean-k-mooney: ^ | |
| 16:47:10 | dansmith | ack | |
| 16:48:09 | sean-k-mooney | Sundar: do you have any write up on how to do that | |
| 16:48:16 | sean-k-mooney | or where to get the sample code | |
| 16:48:53 | sean-k-mooney | there is a host that i should be able to get acess too if needed. | |
| 16:49:22 | sean-k-mooney | if i need to take over some of the nova work from you or someone else does knowing how to test it with real hardware would be useful | |
| 16:49:52 | sean-k-mooney | we have some openvino sampel applciation but i was hoping there was a simpelr hello world | |
| 16:54:21 | sean-k-mooney | Sundar: by the way does the nivida pgpu driver work. because i also have nvida gpus at home so i can also try testign with that. i dont have ones that support ther vgpu/nvida grid feature but this is just for standard physical gpu passhtough anyway | |
| 16:55:36 | sean-k-mooney | if i can test with real hardware while also not needing to deal with fpga programming that might be a win win since from a nova point of view it will be exactly the same | |
| 17:10:38 | Sundar | sean-k-mooney: The OPAE SDK comes with some sample bitstreams (they are under the hw/ dir, IIRC, which can be a bit confusing). They are the Native Loopback (nlb) apps, so they are named like nlb-0.gbs and nlb-3.gbs. There are corresponding testing apps named nlb0 and nlb3, On the host, the nlb-N.gbs needs to be programmed into the device, either | |
| 17:10:39 | Sundar | with Cyborg or by hand. The OPAE stack also needs to be installed in the VM. Then you can the testing apps like nlbN inside the VM. | |