| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-cyborg - 2020-03-19 | |||
| 03:26:41 | brinzhang_ | My mainly concern is https://review.opendev.org/#/c/696860/5/cyborg/api/controllers/v2/versions.py@24, I think we should use completed version nubmer to help Cyborg control the microversion change | |
| 03:28:49 | openstackgerrit | Brin Zhang proposed openstack/cyborg master: Add Cyborg API Reference to Cyborg index https://review.opendev.org/711869 | |
| 03:29:04 | Sundar | I suggest we follow the precedent of placement or nova. Should we get cdent or somebody to review this? | |
| 03:29:05 | xinranwang | yes, Cyborg also use completed version number | |
| 03:29:28 | xinranwang | which locate L29 L30 in version.py | |
| 03:29:33 | xinranwang | brinzhang_: | |
| 03:30:17 | xinranwang | It is not the same framework, maybe ironic and watcher is more similiar | |
| 03:30:19 | brinzhang_ | xinranwang: yeah, for my comments, do we need L24 and L26? | |
| 03:30:53 | xinranwang | brinzhang_: it is easy for recording every microversion history | |
| 03:30:54 | brinzhang_ | xinranwang: And I think we need to change the _MIN_VERSION_STRING to _MIN_API_VERSION | |
| 03:31:20 | xinranwang | brinzhang_: how | |
| 03:32:16 | brinzhang_ | xinranwang: If we will change microversion to 3.0, this way seems not easy to convert, right? | |
| 03:32:44 | brinzhang_ | xinranwag: maybe it will be have a long time | |
| 03:32:49 | xinranwang | the version 3 will be implemented in v3 repo, not here | |
| 03:33:09 | xinranwang | and in controller/v3 repo, it will has its own versions.py file | |
| 03:33:58 | brinzhang_ | xinranwang: Ok, if so, threre is just some nits inline for me, just the defined parameters ^^ | |
| 03:34:56 | xinranwang | Ok | |
| 03:35:16 | xinranwang | This is pecan specific, which is diffirent from nova ;) | |
| 03:35:48 | brinzhang_ | I know, just want to have a good way to maintain ^^ | |
| 03:36:26 | xinranwang | Yes, so do we all agree to maintain like this? | |
| 03:37:13 | brinzhang_ | aree, but I would like you can change the defined parameter name (also just a nit) | |
| 03:37:26 | brinzhang_ | xinranwang:s/aree/agree | |
| 03:38:01 | xinranwang | Ok, thanks | |
| 03:38:44 | brinzhang_ | Sundar, chenke, Yumeng, s_shogo, do you all have some idea of this ? | |
| 03:38:52 | Sundar | For me too, it is just those minor points about variable names. | |
| 03:39:02 | chenke | @xinran Overall LGTM. I will. review it again. | |
| 03:39:15 | chenke | Yes | |
| 03:40:04 | Yumeng | yes. features are good enough. | |
| 03:40:18 | brinzhang_ | thanks xinranwang and all | |
| 03:40:23 | brinzhang_ | Sundar, pls do next agenda | |
| 03:40:41 | xinranwang | There are other projects naming with release name. If you guys prefer other ways like ADD_X_PARAM, I will update it. It is flexible. | |
| 03:41:24 | xinranwang | btw, please review deployabel API patch when you got time, I think it is almost ready. | |
| 03:41:49 | chenke | +1 | |
| 03:41:50 | Sundar | I don't have any specific next agenda item. | |
| 03:42:03 | chenke | how about your nova patches? | |
| 03:42:08 | chenke | Sundar | |
| 03:42:31 | brinzhang_ | xinranwang: just need change _MIN_VERSION_STRING to _MIN_API_VERSION, and use current_api_version or thers you thinks instead of "Version.sting" | |
| 03:42:51 | Sundar | xinranwang: Could you add a pointer to those projects's code that uses release names? If there is any precedent code that I can look at, for microversions in general, that would be useful. | |
| 03:43:29 | xinranwang | sure, let me find it. | |
| 03:43:37 | Sundar | chenke: I have got some review comments on Novapatches. I was off for a few days but will resume again. | |
| 03:44:30 | chenke | Okay. | |
| 03:45:32 | Sundar | xinranwang: You can provide those references in Gerrit. | |
| 03:45:41 | Sundar | Anything else, folks? | |
| 03:45:46 | s_shogo | Mere Reporting , the client topic mentioned in the last IRC : the cyborg client from pip doesn't include sdk implementation now.(That doesn't be released yet.) | |
| 03:45:47 | brinzhang_ | https://review.opendev.org/#/q/status:open+project:openstack/cyborg+branch:master+topic:story/2007397 | |
| 03:46:02 | brinzhang_ | pls review this change, I think it's ready to go | |
| 03:47:36 | xinranwang | Sundar: ok | |
| 03:47:53 | brinzhang_ | s_shogo: so cyborgclinet can support "pip install" and the "SDK" doesnot, right? | |
| 03:48:31 | brinzhang_ | I have used pip install to install the cyborgclient, but not try to test SDK yet | |
| 03:48:56 | s_shogo | brinzhang_ sdk is ok , but client is not yet. | |
| 03:49:22 | s_shogo | (by pip) | |
| 03:50:10 | brinzhang_ | s_shogo: get it, but I can install python-cyborgclinet to my local env (devstack). I will check the client version again | |
| 03:51:41 | s_shogo | brinzhang_ thanks .The client installed pip is probably old one,without sdk version. | |
| 03:51:43 | brinzhang_ | root@ubuntu-OpenStack:~# cyborg --version | |
| 03:51:44 | brinzhang_ | 1.0.0 | |
| 03:52:04 | brinzhang_ | Ah, 1.0.0 | |
| 03:52:22 | Sundar | brinzhang_: I think https://review.opendev.org/#/q/status:open+project:openstack/cyborg+branch:master+topic:story/2007397 needs to be updated, because the top patches are based on PS 4/6 of the bottom patch, instead of the latest 6/6. | |
| 03:53:08 | brinzhang_ | Sundar, it's not any impact | |
| 03:53:48 | brinzhang_ | the base patch just update the json data | |
| 03:54:00 | Sundar | ok | |
| 03:55:37 | brinzhang_ | Sundar: Thanks | |
| 03:56:40 | Sundar | Any thoughts or reviews of https://review.opendev.org/#/c/712231/ ? | |
| 03:57:24 | Sundar | Oh, I see some comments, but no -1. WIll respond to the comments | |
| 03:57:29 | brinzhang_ | Sundar I left some comments inline^^ | |
| 03:57:50 | Sundar | ok | |
| 03:58:03 | Yumeng | I was reviewing it yesterday. but not finished. | |
| 03:58:05 | Sundar | Thanks, brinzhang_ | |
| 03:58:13 | Yumeng | I will review it today. | |
| 03:58:24 | Sundar | Yumeng, I'll wait, no rush | |
| 03:58:31 | Yumeng | ^^ ok | |
| 03:58:37 | Sundar | Anything else, folks? | |
| 03:58:56 | openstackgerrit | Brin Zhang proposed openstack/cyborg master: Add description column to device_profiles db https://review.opendev.org/703285 | |
| 03:59:24 | Yumeng | nope from my side. | |
| 03:59:36 | openstackgerrit | Brin Zhang proposed openstack/cyborg master: Add 'description' field to the device profile object https://review.opendev.org/703293 | |
| 03:59:55 | Yumeng | ops. https://review.opendev.org/#/c/709433/ need final review. | |
| 03:59:58 | Yumeng | thanks! | |
| 04:00:10 | brinzhang_ | Sundar: About https://review.opendev.org/#/c/703293/, I was rebased on the latest change, pls see again | |
| 04:00:18 | brinzhang_ | nothing else | |
| 04:01:06 | brinzhang_ | Yumeng: Will review at afternoon | |
| 04:01:20 | Sundar | Ok | |
| 04:01:32 | Yumeng | Thank you Brin. | |
| 04:01:33 | Sundar | Thanks everybody. Have a good week. | |
| 04:01:38 | Sundar | #endmeeting | |
| 04:01:39 | openstack | Meeting ended Thu Mar 19 04:01:37 2020 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) | |
| 04:01:40 | openstack | Minutes: http://eavesdrop.openstack.org/meetings/openstack_cyborg/2020/openstack_cyborg.2020-03-19-03.02.html | |
| 04:01:41 | openstack | Minutes (text): http://eavesdrop.openstack.org/meetings/openstack_cyborg/2020/openstack_cyborg.2020-03-19-03.02.txt | |
| 04:01:42 | openstack | Log: http://eavesdrop.openstack.org/meetings/openstack_cyborg/2020/openstack_cyborg.2020-03-19-03.02.log.html | |
| 04:01:45 | Yumeng | bye. | |
| 04:01:47 | xinranwang | Yumeng: LGTM | |
| 04:01:54 | xinranwang | bye | |
| 04:02:04 | s_shogo | bye | |
| 04:02:11 | brinzhang_ | Sundar: pls see the base patch, the latest patch depend on the base patch ^ | |
| 04:02:21 | brinzhang_ | bye~ | |
| 04:02:43 | openstackgerrit | Brin Zhang proposed openstack/cyborg master: Add Cyborg API Reference to Cyborg index https://review.opendev.org/711869 | |
| 06:02:11 | chenke | why brin still not have +2 ? | |
| 06:02:30 | chenke | brinzhang_ | |
| 06:03:56 | brinzhang_ | chenke, maybe tomorrow? We can go to wechat ask Sundar ^^ | |
| 06:04:12 | brinzhang_ | he seems not in irc | |
| 06:04:28 | chenke | oh. I think he need to add you to core group | |
| 06:04:43 | brinzhang_ | chenke, thanks | |