| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-cyborg - 2020-01-16 | |||
| 03:27:27 | Sundar | brinzhang: yes, microversions are necessary to add features and evolve the APis sommothly, which is important for a young project like Cyborg | |
| 03:27:28 | brinzhang | When a new feature changed in Cyborg, we can record this with a microversion | |
| 03:27:56 | chenke | Agree | |
| 03:28:26 | brinzhang | So about this spec, what are you worry about? Sundar | |
| 03:29:34 | Sundar | notes, as you pointed out in the Nova patch review | |
| 03:29:34 | Sundar | brinzhang: I think we all agree on the need for microversions. The questions would be, are we following the best practices etc. I invited Chris Dent etc. to review it. If you see any gaps, please bring it up. It is better to take the time and do this properly to avoid gaps. For example, adopting conventions like docmetning APi changes in release | |
| 03:29:52 | Sundar | *documenting | |
| 03:30:19 | brinzhang | I'm not sure if the existing Cyborg feature will be implemented after this SPEC merger, or in parallel with it? | |
| 03:31:21 | Sundar | The way I see it, we released v2.0 of APis in Train. Whatever comes out of Ussuri will/should be microversion-enabled and will probably be v2.1. After that, we have incremental changes. | |
| 03:31:24 | brinzhang | yes, we should consider more, such as the unit tests, documenting, functional test etc. | |
| 03:32:36 | Sundar | Until we get Nova integration done, any version bump in Cyborg is not of great significance as people are not yet putting it in production. | |
| 03:32:59 | brinzhang | Sundar, so while someone pushed a spec for Cyborg, we should require he/she to add a new microversion for that api (if the api changes) | |
| 03:33:32 | Sundar | Sure | |
| 03:34:14 | brinzhang | Sundar, Even so, we also need to maintain microversion step by step | |
| 03:34:56 | Sundar | The device v2 APis would be 2.0, because they are totally new. But existing APIs like device profiles and ARQs would get a bump if they are changed. | |
| 03:35:38 | brinzhang | This is my opion for this spec, I will review it again while I free, and refer the experience I was in Nova | |
| 03:35:54 | Sundar | Great, sounds good | |
| 03:36:03 | Sundar | #topic Spec for instance ops for accelerators | |
| 03:36:14 | brinzhang | agree "The device v2 APis would be 2.0" | |
| 03:36:29 | Sundar | https://review.opendev.org/#/c/605237/ | |
| 03:37:14 | brinzhang | I was reviewed this spec, I agree with matt, this spec mostly seem description the documents?is right? | |
| 03:37:25 | Sundar | I wrote this last year as a way to get agreement between Nova and Cyborg sides. Some people did not see it as a spec per se, because it is not specifying any changes. It is only documented behavior. | |
| 03:37:27 | brinzhang | some operators are in nova | |
| 03:38:03 | Sundar | Yes, all these are instance ops in Nova, and the doc addresses what should happen if the instance has accelerators | |
| 03:38:06 | brinzhang | Sundar, yeah, it's document | |
| 03:38:27 | Sundar | It may make sense to retire it as a spec and make it a document | |
| 03:38:39 | brinzhang | yeah, it make sense | |
| 03:39:10 | Sundar | Ok, I'll take an action item for that | |
| 03:39:14 | brinzhang | I think we should ensure the accuracy of the description | |
| 03:39:58 | Sundar | Is something not accurate? | |
| 03:40:10 | brinzhang | So we need more nova core to review this, such as erifed, stephenfin, alex_xu, sean-k-moony to review it, make it better and better | |
| 03:40:39 | brinzhang | See my comment in PS4 | |
| 03:41:02 | Sundar | They have all reviewed it to some extent or the other in Train. If it is recast as a Cyborg doc, it will be tougher to get their review, but we can try. | |
| 03:41:07 | brinzhang | about the rebuild action, I think you should re-word | |
| 03:41:54 | Sundar | ok, will go by the review | |
| 03:42:02 | brinzhang | Maybe we can send this to the nova meeting | |
| 03:42:34 | brinzhang | Next, i will review again, and check all instance ops | |
| 03:42:45 | Sundar | I'll ask the Nova PTL if that is feasible, after I recast it as a doc | |
| 03:43:06 | brinzhang | Sundar Above is my opinion on this | |
| 03:43:59 | Sundar | Sure, anything else on this subject? | |
| 03:44:03 | brinzhang | another way, it may be possible to add this to Nova's document library as an auxiliary document using Cyborg as an instance | |
| 03:44:39 | Sundar | 'Using Cyborg as an instance' -- what does that mean? | |
| 03:45:18 | brinzhang | put this doc in the Nova's library, while some want to use Cyborg, they can read this | |
| 03:45:48 | brinzhang | of course, we also need put this in Cyborg's document library | |
| 03:46:05 | brinzhang | just an idea | |
| 03:46:19 | Sundar | Nova's handling of instance ops varies with Neutron ports, Cinder volumes, etc. I doubt that Nova will agree to put a project-specific doc in their list. In fact, it may make sense to keep it in Cyborg, because different Cyborg drivers may potentially support different ops . | |
| 03:47:15 | Sundar | For example, hypothetically, if there is a problem with doing instance rebuilds with GPU drivers, that caveat should be in Cyborg docs, right? | |
| 03:48:18 | brinzhang | Yeah, but I think nova also need this | |
| 03:48:55 | Sundar | Ok, no harm in asking them if they can do it. | |
| 03:49:04 | brinzhang | maybe, put it in Cyborg is appropriate | |
| 03:49:13 | brinzhang | more appropriate | |
| 03:49:20 | chenke | I think cyborg is the main one and Nova can briefly introduce it. | |
| 03:49:33 | Sundar | Sure | |
| 03:51:02 | Sundar | #topic Other topics | |
| 03:51:41 | Sundar | The next PTG will be in Vancouver, June 8-11 | |
| 03:51:51 | chenke | About this patch. https://review.opendev.org/#/c/702578/ | |
| 03:52:03 | Sundar | Early Bird Full Access costs $299 and lasts till Mar 2, 2020. | |
| 03:52:31 | Sundar | chenke: I started looking at your patch. It is highly needed. Thanks | |
| 03:52:49 | s_shogo | I'm considering a gap between cyborg API spec and sdk's premise(mainly arq delete API,with multi choice of argument), | |
| 03:52:49 | chenke | Ok. Thanks. | |
| 03:52:50 | brinzhang | Sundar I need to follow the company's decision whether to participate in this PTG | |
| 03:53:16 | Sundar | brinzhang: Sure, just mentioning it for awareness | |
| 03:53:29 | brinzhang | Just need have a topic, also a candidate speeker | |
| 03:54:00 | Sundar | Would you like to collaborate with one of us for a speech or a project update? | |
| 03:54:28 | Sundar | Anyways, we can discuss it offline | |
| 03:54:42 | Sundar | s_shogo: Yes | |
| 03:55:08 | Sundar | I think we had a brief discussion. The HTTP DELETE's query parameters can be used to unify both forms, right? | |
| 03:55:17 | brinzhang | about chenke's patch, i have a doubt, consistency of interface parameters, separated from rpcapi | |
| 03:55:31 | brinzhang | sundar, while you review this, please take a care | |
| 03:55:52 | Sundar | brinzhang: ok | |
| 03:55:53 | brinzhang | mianly about the 'context' parameter | |
| 03:56:31 | chenke | context is useless for create db device profile | |
| 03:57:00 | chenke | I removed it . https://review.opendev.org/#/c/702578/2/cyborg/db/sqlalchemy/api.py | |
| 03:57:22 | chenke | What are your thoughts | |
| 03:57:36 | Sundar | chenke: I think brinzhang is saying that, when we remove context as a parameter for db api, it may be good to remove it from other places which use it only for dbapi, such as the main API | |
| 03:57:43 | brinzhang | chenke, we can wait for Sundar reviewed this, then talk about | |
| 03:57:44 | s_shogo | Sundar: That depends on sdk's delete function, I'll clarify the gap and ask this again. | |
| 03:58:13 | Sundar | s_shogo: ok | |
| 03:58:27 | chenke | brinzhang ok. | |
| 03:58:58 | Sundar | brinzhang: Welcome again to Cyborg. Could you give us some background about yourself? Do you use accelerators like FPGAs in your company? | |
| 03:59:15 | chenke | I have to go for lunch. bye~ | |
| 03:59:30 | brinzhang | We are use GPU in Cyborg, FPGA in plan~ | |
| 04:00:19 | brinzhang | Now we are applying the fpga device :) | |
| 04:00:39 | brinzhang | chenke, bye | |
| 04:00:51 | Sundar | chenke: Bye | |
| 04:01:00 | Sundar | brinzhang: Cool. What important things are missing from Cyborg, apart from nova integ? | |
| 04:01:52 | Sundar | And could I ask if they are Intel FPGAs? ;) | |
| 04:01:55 | brinzhang | Sundar, I was gurduate from Zhengzhou Unviersity, now I am working in Inspur, mainly work in OpenStack (Community) | |
| 04:02:48 | brinzhang | Yes, in theory, Intel's fpga | |
| 04:03:26 | Sundar | brinzhang: Good to know that. Happy to have you in OpenStack and Cyborg. | |
| 04:03:38 | brinzhang | Sundar, thanks | |
| 04:03:51 | s_shogo | Welcome brinzhang (again) | |
| 04:04:08 | Sundar | Please feel free to reach out to me in WeChat or IRC if you need anything | |
| 04:04:17 | brinzhang | s_shogo thanks~ | |
| 04:04:21 | Sundar | Anything else, folks? | |
| 04:04:34 | brinzhang | Nothing for me today | |
| 04:04:53 | Sundar | I think the Chinese New year is coming up soon? | |
| 04:05:14 | Sundar | Should we hold a meeting next week? | |
| 04:05:51 | brinzhang | Yeah, next Thursday, next meeting I will not join, on the way (go home) | |
| 04:06:25 | Sundar | Ah ok. Advance wishes -- Shenyun Kwai le :) | |