| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-cyborg - 2019-09-26 | |||
| 03:35:42 | shaohe_feng | pros and cons? | |
| 03:36:16 | Sundar | You can ask Eric in that patch. Nova has some requirements and considerable interest in this area. | |
| 03:36:33 | shaohe_feng | OK. | |
| 03:37:16 | Sundar | Are there any other patches that are potential RC blockers, i.e, have security or critical implications, so we should hold up the release? | |
| 03:37:29 | shaohe_feng | maybe we can do more investigation on it. but not now | |
| 03:37:37 | shaohe_feng | now we have more things to do. | |
| 03:39:10 | Sundar | Sure. If nothing else, let us please focus on reviewing the ones above first, and as much of the rest as we can. It is possible that there may be future RCs, so they may still make it | |
| 03:40:00 | Sundar | Any other comments or thoughts? | |
| 03:40:01 | Yumeng | https://review.opendev.org/#/c/679406/ this one please | |
| 03:40:15 | Yumeng | conductor writes device_profile | |
| 03:40:33 | Sundar | Yumeng: sure. IMHO, it is mostly there. I'll try it out tonight and review it | |
| 03:40:46 | Yumeng | just updated. | |
| 03:40:55 | Yumeng | thanks! | |
| 03:41:33 | Sundar | Shaohe, have you tried your patch with the Nova patches? | |
| 03:41:49 | shaohe_feng | yes. | |
| 03:41:55 | Sundar | Great | |
| 03:41:59 | shaohe_feng | xinranwang also help to do it. | |
| 03:42:09 | Sundar | Thanks to both of you | |
| 03:42:28 | Sundar | Anything else, folks? | |
| 03:42:35 | shaohe_feng | actually, I did not change your code logical | |
| 03:42:51 | shaohe_feng | just put them in thread pool as async job. :) | |
| 03:43:10 | Sundar | Cool, np even if you changed it, as long as it works :) | |
| 03:43:23 | xinranwang | This patch is almost good for me | |
| 03:44:01 | Sundar | almost? | |
| 03:44:43 | Sundar | Anyway, we can continue the review in Gerrit. | |
| 03:44:55 | xinranwang | “Almost”means need other’s review as well | |
| 03:45:17 | chenke | About this patch:https://review.opendev.org/#/c/684193/ | |
| 03:45:33 | chenke | I agree with xinran's idea. | |
| 03:45:53 | Sundar | Do you want to see 6 endpoints with devstack? :) | |
| 03:46:05 | Sundar | v1 is end-of-life. | |
| 03:46:06 | chenke | no | |
| 03:46:11 | chenke | We don't need to enable v1. | |
| 03:46:14 | Sundar | After Train, we can remove it early in U | |
| 03:47:37 | Sundar | Can you explain further, chenke? v1 is deprecated but supported in this release. So, we do the bare minimum to keep it alive, but don't bother develoeprs with legacy endpoints | |
| 03:48:20 | Sundar | We can remove v1 altogether early in U, and even these devstack comments will go away | |
| 03:49:16 | chenke | Sorry, I misunderstood this meaning. | |
| 03:49:16 | Sundar | Anybody disagree? | |
| 03:49:24 | chenke | just go on. | |
| 03:49:35 | Sundar | You are ok with that patch as is? | |
| 03:50:34 | Sundar | Anyway, let's continue the review in Gerrit | |
| 03:50:39 | chenke | +1 | |
| 03:50:55 | Sundar | If nothing else, we can call it a day (or night or afternoon) | |
| 03:51:36 | Sundar | Have a good day, everyone! Bye for now. (I'll bother you on WeChat after this -- JK) | |
| 03:51:42 | Sundar | #endmeeting | |
| 03:51:44 | openstack | Meeting ended Thu Sep 26 03:51:42 2019 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) | |
| 03:51:45 | openstack | Minutes: http://eavesdrop.openstack.org/meetings/openstack_cyborg/2019/openstack_cyborg.2019-09-26-03.01.html | |
| 03:51:46 | openstack | Minutes (text): http://eavesdrop.openstack.org/meetings/openstack_cyborg/2019/openstack_cyborg.2019-09-26-03.01.txt | |
| 03:51:47 | openstack | Log: http://eavesdrop.openstack.org/meetings/openstack_cyborg/2019/openstack_cyborg.2019-09-26-03.01.log.html | |
| 03:52:37 | chenke | Bye~ all | |
| 03:54:20 | Sundar | chenke -- the latest tempest run failed too | |
| 03:54:36 | chenke | could you give me the address | |
| 03:54:47 | chenke | detail log address. | |
| 03:54:51 | Sundar | https://openstack.fortnebula.com:13808/v1/AUTH_e8fd161dc34c421a979a9e6421f823e9/zuul_opendev_logs_c00/670999/12/check/cyborg-tempest/c00ce63/controller/logs/screen-cyborg-api.txt.gz | |
| 03:55:28 | Sundar | Sep 25 14:33:08.765936 --- Server-side error: "Failed to create a working proxy for service compute: No valid endpoint was discoverable." | |
| 03:56:26 | chenke | Now time is ? | |
| 03:57:01 | chenke | I want to confirm if it is the latest log. | |
| 03:57:08 | Sundar | It is in UTC | |
| 03:57:32 | Sundar | I see, it could be old? | |
| 03:57:54 | chenke | I am not sure. | |
| 03:58:08 | Sundar | Seems like old one -- never mind, false alarm ;) | |
| 03:58:15 | chenke | Ok~ | |
| 03:58:24 | Sundar | I need to leave now, will be back in 30 min or so | |
| 03:58:31 | chenke | https://zuul.opendev.org/t/openstack/stream/fa3f4faccb0744cb9e019cae42b1102d?logfile=console.log | |
| 03:58:36 | chenke | this is new. | |
| 03:58:42 | chenke | Ok. the same to me. | |
| 03:58:52 | chenke | I will back after 90min. | |
| 06:12:03 | openstackgerrit | Sundar Nadathur proposed openstack/cyborg master: Program FPGAs with oslo.privsep. https://review.opendev.org/683733 | |
| 06:27:19 | openstackgerrit | zhurong proposed openstack/cyborg master: Fix delete arq 403 failed https://review.opendev.org/684947 | |
| 07:28:06 | openstackgerrit | Merged openstack/cyborg master: Enable fake_driver by default https://review.opendev.org/684712 | |
| 08:28:46 | openstackgerrit | chenker proposed openstack/cyborg master: Fix delete arq 403 failed https://review.opendev.org/684947 | |
| 09:00:31 | openstackgerrit | Merged openstack/cyborg master: Implement privsep boilerplate in cyborg. https://review.opendev.org/673957 | |
| 10:42:28 | openstackgerrit | Merged openstack/cyborg master: conductor writes device_profile update to db https://review.opendev.org/679406 | |
| 11:08:04 | Sundar | Hi zhurong | |
| 11:12:11 | zhurong | Hi Sundar | |
| 11:12:38 | Sundar | Hi zhurong, thanks for all your contribution and reviews. | |
| 11:12:53 | Sundar | I'd like to talk about https://review.opendev.org/#/c/684193/3 | |
| 11:13:22 | Sundar | OpenStack has a bacwards compat requirement. We have been releasing CYborg since Queens cycle. | |
| 11:13:44 | Sundar | We have had v1 API for some time, developed it in Stein but also marked it as deprecated | |
| 11:14:26 | zhurong | yeah, I think we should give people more clearly message, when will remove the V | |
| 11:14:29 | Sundar | We cannot remove it right away in Train. We must keep it for 1 release. | |
| 11:14:41 | zhurong | yeah, I think we should give people more clearly message, when will remove the V1 API | |
| 11:14:50 | Sundar | So, we are keeping it in Train and will remove it in U | |
| 11:16:05 | Sundar | Meanwhile we don't see anybody using it given its current state. So, we are doing the minimum to keep it alive. If anybody wrote scripts to play with it, they will return some meaningful value like [] or None, but not crash | |
| 11:16:19 | Sundar | Early in U, we can remove it | |
| 11:16:38 | zhurong | Now the message only said we deprecated v1 api, but don't give the time clearly. | |
| 11:16:54 | Sundar | Others gave -1 and retracted after explanation. | |
| 11:17:16 | Sundar | Ok, I believe the standard practice is 1 cycle | |
| 11:17:32 | Sundar | We don't have to keep it longer | |
| 11:18:43 | zhurong | sorry for the later rely, I have a meeting this afternoon, so I didn't have time to watch the review process | |
| 11:18:45 | Sundar | Not sure we can just remove it just like that, unless you know of some exception | |
| 11:19:28 | Sundar | NP. Do you agree with the explanation for the v1 API? | |
| 11:21:54 | zhurong | I agree with you. In my comment, I said if we don't remove in this cycle, we should make the deprecated message more cleary, tell usr and developer when we will remove the v1 API. just edit the deprecated message add the we will remove in U cycle. | |
| 11:23:51 | Sundar | Ah I see, sure | |
| 11:24:03 | Sundar | We have to update all the docs | |
| 11:31:54 | zhurong | that's my point, Sundar, I will remove the -1 | |
| 11:33:32 | Sundar | Thanks, zhurong. | |
| 11:42:22 | donnyd | Could we get some reviews of https://review.opendev.org/#/c/677715/2 | |
| 11:44:02 | Sundar | donnyd: Yes, I'll ask for reviews and do it myself too. Trying to find the deadline for docs | |
| 11:44:37 | donnyd | Sundar: you are either up really early or really late | |
| 11:45:15 | Sundar | Both :) | |