| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-cyborg - 2019-09-05 | |||
| 03:29:13 | wangzhh | No. Just check if it is admin or not before program. As I replied. | |
| 03:30:18 | Sundar | Hmm, it could be owner or admin, right? Whoever created the ARQ should be allowed to bind it, otherwise they should not be able to create it. | |
| 03:32:23 | wangzhh | Yep. Owner or admin should be allowed to Bind and Unbind. But when involve programming, we should check if it is admin or not. | |
| 03:32:50 | wangzhh | Only admin can program? Right? | |
| 03:33:54 | Sundar | Binding involves programming for FPGAs. A tenant who has the privilege to create ARQs for an FPGA should also be able to program it, right? That's why I raised the question about 'create' privileges. | |
| 03:34:04 | shaohe_feng | program had better have sudo privilege no node | |
| 03:34:28 | shaohe_feng | s/no/on | |
| 03:34:28 | Sundar | Yes, we do sudo fpgaconf today, and have a patch to move to oslo privsep. | |
| 03:34:55 | shaohe_feng | yes. let's from simple | |
| 03:35:05 | shaohe_feng | Firstly it can work. | |
| 03:35:17 | shaohe_feng | and let nova can call cyborg | |
| 03:35:21 | shaohe_feng | then improve cyborg | |
| 03:35:28 | Sundar | wangzhh: I understand your concern. However, if only admins can create/bind ARQs for FPGAs, that will be very restrictive, right? | |
| 03:35:35 | chenke | Yes. Firstly make it work. | |
| 03:36:21 | wangzhh | Yep. Sundar. | |
| 03:36:44 | wangzhh | So, Just make it work first. | |
| 03:37:17 | Sundar | Ok, I agree with wangzhh that security is important and with others that we should first get it to work by Train-3. I'll bring RBAC on the agenda for the next IRC meeting. Hopefully, other things will be working by then. :) | |
| 03:37:35 | wangzhh | Cool. | |
| 03:37:36 | chenke | Agreee. | |
| 03:37:54 | Sundar | #topic Python 3 | |
| 03:38:29 | shaohe_feng | the admin or tenant own the bit steam image, can download the image and to do program. | |
| 03:38:42 | Sundar | There is a Train goal to enable Py3 by Train-3 milestone, which is next week. Thanks to s_shogo (and Ikuo) for the patch. Hope we can merge that too by next week. | |
| 03:39:00 | shaohe_feng | we should challenge the tenant | |
| 03:39:46 | Sundar | shaohe_feng: Sure, let's take it up next week. | |
| 03:39:56 | s_shogo | I'll check again that soon, after P5-P9 merged. (latest patch seems to be no problem) | |
| 03:40:20 | Sundar | Thanks, s_shogo. | |
| 03:40:49 | Sundar | #topic AoB | |
| 03:41:08 | s_shogo | About cyborg client. | |
| 03:41:38 | xinranwang | Hi all, I have to drop now. Thanks for your reviews for placement patch, it is merged finally :) And please review https://review.opendev.org/#/c/667231/ tempest code and notify patch https://review.opendev.org/#/c/674520/ too. | |
| 03:41:41 | Sundar | Outside of patches and Py3, I don't have much for today. As i said, I think I have a way to avoid the race in Nova, and will work on getting it out. Anything else for today? | |
| 03:41:55 | Sundar | s_shogo: Yes | |
| 03:42:05 | Sundar | I saw your patch -- thanks. | |
| 03:42:09 | s_shogo | I have posted a patch for OpenStack SDK, and request review to SDK team. https://review.opendev.org/#/c/679914/ | |
| 03:42:37 | s_shogo | Subsequently ,I'll post cyborg-python client patch ,please review that > All | |
| 03:42:56 | chenke | Cool. | |
| 03:42:59 | Sundar | Great, sure, will do. | |
| 03:43:24 | shaohe_feng | one thing. | |
| 03:43:36 | shaohe_feng | we may start several asyn jobs | |
| 03:44:03 | shaohe_feng | only all jobs are finished, the bind is successful | |
| 03:44:18 | shaohe_feng | one of the jobs failed, then the bind should be failed | |
| 03:44:24 | shaohe_feng | right? | |
| 03:45:10 | Sundar | Yes. | |
| 03:45:44 | shaohe_feng | so how to sync all the state of jobs? | |
| 03:46:20 | Sundar | Wait for all of them to finish. I think eventlet has a wait() method, IIUC | |
| 03:46:35 | shaohe_feng | yes. | |
| 03:46:53 | shaohe_feng | but wait is block | |
| 03:47:04 | shaohe_feng | so it can not in main thread. | |
| 03:47:18 | shaohe_feng | also another, if one jobs failed, we should cancel others, right? | |
| 03:47:28 | shaohe_feng | where should we put the wait? | |
| 03:48:18 | Sundar | It can't be in main thread, I agree. We don't need to cancel the rest if one fails, at least in Train. As we discussed, if the job has already started flashing the card, we shouldn't cancel it then | |
| 03:49:03 | Sundar | Just a thought: May be we have one eventlet whichis a master and it launches other eventlets, and the master does the wait. | |
| 03:50:00 | shaohe_feng | yes, we need a such mechanism | |
| 03:50:14 | shaohe_feng | I'm thinking it. | |
| 03:50:44 | shaohe_feng | the master thread should not be from a thread pool, right? | |
| 03:50:58 | shaohe_feng | for example, there a 2 pools. | |
| 03:51:01 | Sundar | Sure. My suggestion is to do something super-simple for Train-3 milestone -- may be just one eventlet for all ARQs, because we won't have too many ARQs anyway | |
| 03:51:45 | shaohe_feng | we create 2 jobs, so no pool for the master thread to monitor these 2 jobs. | |
| 03:51:59 | Sundar | Simplcity and reliability are more important, IMHO. It will also reduce your work :) | |
| 03:52:20 | shaohe_feng | yes, agree. | |
| 03:52:34 | shaohe_feng | async is more complex than sync. | |
| 03:53:26 | Sundar | Yes. IMHO, we can even leave unbind as sync in the worst case, for now, because we don't do anything there today | |
| 03:53:46 | shaohe_feng | yes. agree | |
| 03:53:58 | Sundar | We just want some patch in the works by Sep 3, so that we can kickstart the review | |
| 03:54:18 | Sundar | I mean, Sep 9 | |
| 03:55:43 | Sundar | Anything else, anybody? | |
| 03:55:59 | chenke | No | |
| 03:56:37 | Sundar | Cool. Thank you, all. Please review the patches. Have a good day! Bye. | |
| 03:56:41 | Sundar | #endmeeting | |
| 03:56:43 | openstack | Meeting ended Thu Sep 5 03:56:41 2019 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) | |
| 03:56:44 | openstack | Minutes: http://eavesdrop.openstack.org/meetings/openstack_cyborg/2019/openstack_cyborg.2019-09-05-03.01.html | |
| 03:56:45 | openstack | Minutes (text): http://eavesdrop.openstack.org/meetings/openstack_cyborg/2019/openstack_cyborg.2019-09-05-03.01.txt | |
| 03:56:46 | openstack | Log: http://eavesdrop.openstack.org/meetings/openstack_cyborg/2019/openstack_cyborg.2019-09-05-03.01.log.html | |
| 03:56:52 | wangzhh | Bye everyone. | |
| 03:57:32 | s_shogo | Bye | |
| 04:21:03 | chenke | bye~ | |
| 08:20:42 | openstackgerrit | pengyuesheng proposed openstack/cyborg master: Blacklist eventlet 0.25.0 https://review.opendev.org/680320 | |
| 09:17:13 | openstackgerrit | zhurong proposed openstack/cyborg master: Fix placement report error in python3 https://review.opendev.org/680347 | |
| 09:26:41 | openstackgerrit | pengyuesheng proposed openstack/cyborg master: Blacklist eventlet 0.23.0,0.25.0 https://review.opendev.org/680320 | |
| 19:14:14 | openstackgerrit | Sundar Nadathur proposed openstack/cyborg master: P5: Basic changes for API layer. https://review.opendev.org/670466 | |
| 19:14:15 | openstackgerrit | Sundar Nadathur proposed openstack/cyborg master: P6: Changes for device profiles. https://review.opendev.org/670467 | |
| 19:14:15 | openstackgerrit | Sundar Nadathur proposed openstack/cyborg master: P5.5: Additional changes to db layer. https://review.opendev.org/677115 | |
| 19:14:16 | openstackgerrit | Sundar Nadathur proposed openstack/cyborg master: P8: Changes for programming. https://review.opendev.org/670469 | |
| 19:14:16 | openstackgerrit | Sundar Nadathur proposed openstack/cyborg master: P7: Changes for ARQs and ExtARQs. https://review.opendev.org/670468 | |
| 19:14:17 | openstackgerrit | Sundar Nadathur proposed openstack/cyborg master: Notify Nova when binding finished https://review.opendev.org/674520 | |
| 19:14:17 | openstackgerrit | Sundar Nadathur proposed openstack/cyborg master: P9: Enable v2 API in devstack. https://review.opendev.org/670470 | |
| 22:36:32 | openstackgerrit | Sundar Nadathur proposed openstack/cyborg master: Add driver_name to deployable reported by fake driver. https://review.opendev.org/680533 | |
| #openstack-cyborg - 2019-09-06 | |||
| 03:01:20 | openstackgerrit | zhurong proposed openstack/cyborg master: Remove the delete rc_fields in fake driver https://review.opendev.org/680561 | |
| 06:06:00 | openstackgerrit | zhurong proposed openstack/cyborg master: Fix placement report error in python3 https://review.opendev.org/680347 | |
| 06:06:29 | openstackgerrit | Merged openstack/cyborg master: Remove the delete rc_fields in fake driver https://review.opendev.org/680561 | |
| 06:24:37 | chenke | Hi xinran | |
| 06:30:05 | xinranwang | hello | |
| 07:17:19 | chenke | https://review.opendev.org/#/c/670468/25/cyborg/api/controllers/v2/arqs.py@241 | |
| 11:16:21 | openstackgerrit | Sundar Nadathur proposed openstack/cyborg master: P5.5: Additional changes to db layer. https://review.opendev.org/677115 | |
| 11:16:21 | openstackgerrit | Sundar Nadathur proposed openstack/cyborg master: P5: Basic changes for API layer. https://review.opendev.org/670466 | |
| 11:16:22 | openstackgerrit | Sundar Nadathur proposed openstack/cyborg master: P7: Changes for ARQs and ExtARQs. https://review.opendev.org/670468 | |
| 11:16:22 | openstackgerrit | Sundar Nadathur proposed openstack/cyborg master: P6: Changes for device profiles. https://review.opendev.org/670467 | |
| 11:16:23 | openstackgerrit | Sundar Nadathur proposed openstack/cyborg master: P9: Enable v2 API in devstack. https://review.opendev.org/670470 | |
| 11:16:23 | openstackgerrit | Sundar Nadathur proposed openstack/cyborg master: P8: Changes for programming. https://review.opendev.org/670469 | |
| 11:16:24 | openstackgerrit | Sundar Nadathur proposed openstack/cyborg master: Notify Nova when binding finished https://review.opendev.org/674520 | |
| #openstack-cyborg - 2019-09-07 | |||
| 16:31:13 | openstackgerrit | Merged openstack/cyborg master: Fix placement report error in python3 https://review.opendev.org/680347 | |