Posted	Nick	Remark
#openstack-cyborg - 2019-09-04
03:40:39	openstackgerrit	Xinran WANG proposed openstack/cyborg master: Placement report https://review.opendev.org/659233
03:41:57	openstackgerrit	Sundar Nadathur proposed openstack/cyborg master: P5: Basic changes for API layer. https://review.opendev.org/670466
03:41:58	openstackgerrit	Sundar Nadathur proposed openstack/cyborg master: P6: Changes for device profiles. https://review.opendev.org/670467
03:41:58	openstackgerrit	Sundar Nadathur proposed openstack/cyborg master: P5.5: Additional changes to db layer. https://review.opendev.org/677115
03:41:59	openstackgerrit	Sundar Nadathur proposed openstack/cyborg master: P8: Changes for programming. https://review.opendev.org/670469
03:41:59	openstackgerrit	Sundar Nadathur proposed openstack/cyborg master: P7: Changes for ARQs and ExtARQs. https://review.opendev.org/670468
03:42:00	openstackgerrit	Sundar Nadathur proposed openstack/cyborg master: P9: Enable v2 API in devstack. https://review.opendev.org/670470
06:39:45	openstackgerrit	Merged openstack/cyborg master: bug fix: generate attach_handle query in DB session https://review.opendev.org/679314
07:07:31	openstackgerrit	Sundar Nadathur proposed openstack/cyborg master: P5.5: Additional changes to db layer. https://review.opendev.org/677115
07:07:31	openstackgerrit	Sundar Nadathur proposed openstack/cyborg master: P5: Basic changes for API layer. https://review.opendev.org/670466
07:07:32	openstackgerrit	Sundar Nadathur proposed openstack/cyborg master: P7: Changes for ARQs and ExtARQs. https://review.opendev.org/670468
07:07:32	openstackgerrit	Sundar Nadathur proposed openstack/cyborg master: P6: Changes for device profiles. https://review.opendev.org/670467
07:07:33	openstackgerrit	Sundar Nadathur proposed openstack/cyborg master: P9: Enable v2 API in devstack. https://review.opendev.org/670470
07:07:33	openstackgerrit	Sundar Nadathur proposed openstack/cyborg master: P8: Changes for programming. https://review.opendev.org/670469
07:40:45	openstackgerrit	Xinran WANG proposed openstack/cyborg master: Placement report https://review.opendev.org/659233
07:50:30	openstackgerrit	Merged openstack/cyborg master: P2: Fix pep8 error in cyborg/conf and cyborg/cmd https://review.opendev.org/679045
07:50:34	openstackgerrit	Merged openstack/cyborg master: P3: Fix pep8 error in cyborg/common and cyborg/conductor https://review.opendev.org/679062
07:58:01	openstackgerrit	Merged openstack/cyborg master: P4: Fix pep8 error in cyborg/api https://review.opendev.org/679172
08:13:39	openstackgerrit	Sundar Nadathur proposed openstack/cyborg master: P5.5: Additional changes to db layer. https://review.opendev.org/677115
08:13:39	openstackgerrit	Sundar Nadathur proposed openstack/cyborg master: P5: Basic changes for API layer. https://review.opendev.org/670466
08:13:40	openstackgerrit	Sundar Nadathur proposed openstack/cyborg master: P7: Changes for ARQs and ExtARQs. https://review.opendev.org/670468
08:13:40	openstackgerrit	Sundar Nadathur proposed openstack/cyborg master: P6: Changes for device profiles. https://review.opendev.org/670467
08:13:41	openstackgerrit	Sundar Nadathur proposed openstack/cyborg master: P9: Enable v2 API in devstack. https://review.opendev.org/670470
08:13:41	openstackgerrit	Sundar Nadathur proposed openstack/cyborg master: P8: Changes for programming. https://review.opendev.org/670469
08:44:12	openstackgerrit	Xinran WANG proposed openstack/cyborg master: Placement report https://review.opendev.org/659233
10:25:31	openstackgerrit	Sundar Nadathur proposed openstack/cyborg master: P5.5: Additional changes to db layer. https://review.opendev.org/677115
10:25:32	openstackgerrit	Sundar Nadathur proposed openstack/cyborg master: P7: Changes for ARQs and ExtARQs. https://review.opendev.org/670468
10:25:32	openstackgerrit	Sundar Nadathur proposed openstack/cyborg master: P6: Changes for device profiles. https://review.opendev.org/670467
10:25:33	openstackgerrit	Sundar Nadathur proposed openstack/cyborg master: P9: Enable v2 API in devstack. https://review.opendev.org/670470
10:25:33	openstackgerrit	Sundar Nadathur proposed openstack/cyborg master: P8: Changes for programming. https://review.opendev.org/670469
10:43:31	openstackgerrit	Sundar Nadathur proposed openstack/cyborg master: P5.5: Additional changes to db layer. https://review.opendev.org/677115
10:43:32	openstackgerrit	Sundar Nadathur proposed openstack/cyborg master: P7: Changes for ARQs and ExtARQs. https://review.opendev.org/670468
10:43:32	openstackgerrit	Sundar Nadathur proposed openstack/cyborg master: P6: Changes for device profiles. https://review.opendev.org/670467
10:43:33	openstackgerrit	Sundar Nadathur proposed openstack/cyborg master: P9: Enable v2 API in devstack. https://review.opendev.org/670470
10:43:33	openstackgerrit	Sundar Nadathur proposed openstack/cyborg master: P8: Changes for programming. https://review.opendev.org/670469
10:55:05	openstackgerrit	Merged openstack/cyborg master: Placement report https://review.opendev.org/659233
13:43:28	openstackgerrit	Xinran WANG proposed openstack/cyborg master: Notify Nova when binding finished https://review.opendev.org/674520
16:11:31	openstackgerrit	Sundar Nadathur proposed openstack/cyborg master: P5.5: Additional changes to db layer. https://review.opendev.org/677115
16:11:31	openstackgerrit	Sundar Nadathur proposed openstack/cyborg master: P5: Basic changes for API layer. https://review.opendev.org/670466
16:11:32	openstackgerrit	Sundar Nadathur proposed openstack/cyborg master: P7: Changes for ARQs and ExtARQs. https://review.opendev.org/670468
16:11:32	openstackgerrit	Sundar Nadathur proposed openstack/cyborg master: P6: Changes for device profiles. https://review.opendev.org/670467
16:11:33	openstackgerrit	Sundar Nadathur proposed openstack/cyborg master: P9: Enable v2 API in devstack. https://review.opendev.org/670470
16:11:33	openstackgerrit	Sundar Nadathur proposed openstack/cyborg master: P8: Changes for programming. https://review.opendev.org/670469
20:33:28	openstackgerrit	Sundar Nadathur proposed openstack/cyborg master: P6: Changes for device profiles. https://review.opendev.org/670467
20:33:29	openstackgerrit	Sundar Nadathur proposed openstack/cyborg master: P8: Changes for programming. https://review.opendev.org/670469
20:33:29	openstackgerrit	Sundar Nadathur proposed openstack/cyborg master: P7: Changes for ARQs and ExtARQs. https://review.opendev.org/670468
20:33:30	openstackgerrit	Sundar Nadathur proposed openstack/cyborg master: P9: Enable v2 API in devstack. https://review.opendev.org/670470
#openstack-cyborg - 2019-09-05
03:01:14	Sundar	Hi xinranwang
03:01:30	chenke	hello
03:01:37	Sundar	Hi chenke
03:01:40	Sundar	#startmeeting openstack-cyborg
03:01:41	xinranwang	Hi Sundar
03:01:42	openstack	Meeting started Thu Sep 5 03:01:40 2019 UTC and is due to finish in 60 minutes. The chair is Sundar. Information about MeetBot at http://wiki.debian.org/MeetBot.
03:01:43	openstack	Useful Commands: #action #agreed #help #info #idea #link #topic #startvote.
03:01:44	xinranwang	Hi chenke
03:01:45	openstack	The meeting name has been set to 'openstack_cyborg'
03:01:56	Sundar	#topic Who's here
03:02:05	Sundar	o/
03:02:06	xinranwang	#info xinranwang
03:02:11	s_shogo	#info s_shogo
03:02:12	yikun	o/
03:02:15	chenke	#info chenke
03:02:18	shaohe_feng	o/
03:02:20	chenke	o/
03:02:25	Sundar	Hi all
03:02:25	s_shogo	o/
03:02:31	zhurong	\0/
03:02:46	Sundar	zhurong: Welcome
03:03:10	Sundar	The main item on the agenda is, of course, the reviews
03:04:06	Sundar	Please focus on the P5-P9 patches. They and Nova notifn patch need to merge soon, before we get reviews of Nova patches. Also, they are needed for tempest to work, and that is a prereq too.
03:05:14	Sundar	yikun and all: Would you be able to review it? (Sorry for calling you out, yikun :))
03:05:34	yikun	Sure, I will review it today
03:05:40	Sundar	Thanks :)
03:06:32	yikun	and one detail question about db migrations on P5.5
03:06:34	yikun	https://review.opendev.org/#/c/677115/12/cyborg/db/sqlalchemy/alembic/versions/c1b5abada09c_update_for_nova_integ.py
03:06:51	Sundar	We had a bit of a wrinkle on the Nova side too. The Cyborg's notification event would come too soon after we start the bind and would get lost. I think we have a way to solve it which (a) should hopefully be acceptable to Nova and (b) does not involve change to Nova objects or db
03:06:53	yikun	Can we append the change on existing migration script?
03:07:16	yikun	and most of other patches are okay to me
03:08:01	Sundar	yikun: There is one migration script for v2 API, so that we can show people exactly what we did. Once we releaseTrain, of course, previous migration scripts cannot be edited.
03:08:35	Sundar	As long as we don't change the migration script for Stein, I think we should be ok. Any concerns?
03:10:41	yikun	it will break upgrade from existing to now, but as you said if we still think the train relaase it's a start version, if other people have no question, I have no objection
03:12:01	Sundar	I understand the existing practice but (a) too many migration scripts slows down upgrade for operators and (b) it is good to show onw script for all v2 API IMHO. Thanks for your understanding.
03:12:13	wangzhh	Agree with yikun. It's better to append a migration script. And other patch is fine with me.
03:12:37	wangzhh	*patches are
03:13:16	Sundar	wangzhh: Given the reasons above, would you still ask for a separate migration script?
03:14:30	Coco_gao_	#info Coco_gao
03:15:07	Sundar	Hi Coco_gao
03:15:16	Sundar	We are discussing the patch review
03:15:50	wangzhh	So, we 'll consider T as a start version?
03:17:00	Sundar	Stein is the starting version -- v1 API. We should not modify or change the Stein migration script. We introduced a new migration script in Train, for v2 API. Anything unrelated to it can be in a separate script. But, so far, everything we did has been for v2 and Nova integ, I think.
03:18:16	Sundar	From operators' point of view, the migration scripts that are part of a release should not be changed. Within a release, we usually introduce separate scripts for developers' convenience, I think.
03:19:10	wangzhh	Uh, Okay. I have no objection.
03:19:33	Sundar	Anyways, that is just my view. Thank you, wangzhh, yikun and all.
03:19:43	Sundar	Any other concerns or thoughts on P5-P9?
03:21:19	chenke	why are you put -2 on P5?
03:23:06	Sundar	chenke: It is only a procedure, so that the patch series does not merge piece by piece. Once we get +2 on all patches, I will remove -2, so that it will all merge together. Nova guys are following this practice for my patch series too:
03:23:09	Sundar	https://review.opendev.org/#/c/631242/
03:23:30	Sundar	I should have done that right at the beginning.
03:24:05	chenke	Okay. I understand it.
03:24:05	Sundar	So, even P5 can be reviewed fully.

Earlier   Later