Earlier  
Later
New Search
Posted Nick Remark
#openstack-cyborg - 2019-08-29
03:40:13 shaohe_feng for I need time to read up it.
03:40:31 shaohe_feng do not look into it at present.
03:40:35 Sundar ok
03:40:55 shaohe_feng maybe after the whole flow code are finished
03:41:07 shaohe_feng we can have a look for cons and pros
03:41:32 Sundar Sure. We'll trust your judgement on this :)
03:41:48 shaohe_feng another things, should the async job timeout?
03:42:01 Sundar On a different note, I am seeing this issue for allocating attach handles: https://opendev.org/openstack/cyborg/src/branch/master/cyborg/db/sqlalchemy/api.py#L269 The in_use field does not get written to db
03:42:37 shaohe_feng but there's still a problem.
03:42:40 Sundar The timeout should correspond to default Nova timeout
03:43:10 shaohe_feng maybe it is in programming or other critical job
03:43:34 Sundar The programming typically takes a few seconds, so default of 300 seconds (I think) is good enough
03:43:40 shaohe_feng timeout can be disaster
03:44:21 shaohe_feng another things
03:44:43 shaohe_feng currently the bind process is specify for FPGA
03:45:40 Sundar Umm, bind if for all accelerators. Only programming is for FPGA. the bind means the ARQ is associated with a host and deployable in Cyborg's db, and the device is ready to use
03:45:44 Sundar *is for
03:45:55 shaohe_feng there should be good extension for other kinds
03:46:05 shaohe_feng I means:
03:46:22 shaohe_feng 1. get the resource type.
03:46:50 shaohe_feng every resource type should has its own extend bind action
03:46:56 shaohe_feng for FPGA it is program.
03:47:08 shaohe_feng other's maybe evn setup, not sure.
03:47:43 shaohe_feng 2. every resource should be has its own placement report.
03:48:20 shaohe_feng the report info maybe different
03:48:35 shaohe_feng so the code should be:
03:49:09 shaohe_feng type, num = arq.group_get_resource()
03:49:17 shaohe_feng for n in num:
03:50:05 shaohe_feng action = get_accelerator_action(type) # fpga is program
03:50:08 shaohe_feng action()
03:50:15 shaohe_feng somethings like this
03:50:38 shaohe_feng and these code should be split from the arq object file
03:51:36 Sundar In general, the process should be generic for all accelerators. The current code looks at the device profile request group to see if it has function_id or bitstream_id entries, which are specific to FPGA, to decide if programming is needed
03:52:32 shaohe_feng we maybe add other spec in
03:52:36 Sundar AFAIK, for non-FPGA devices in this release, there is nothing required to prepare the device, right?
03:53:10 shaohe_feng devices profile for different acclerations
03:53:14 shaohe_feng such as HDDL
03:53:19 shaohe_feng we can add
03:54:18 shaohe_feng "accel:affinity": true
03:54:44 Sundar Ok
03:54:46 shaohe_feng which means we need 4 accelerator in one card
03:54:49 Sundar We had an idea of a generic prepare_device API in the driver, which gets a dictionary as a parameter, where the dictionary values depend on the device type.
03:55:26 shaohe_feng yes, different devices maybe take different action during bind.
03:56:14 Sundar Quick process check: Since we have only few minutes left, should we continue this via email, copying all of us and openstack-ML? What do you all think?
03:56:34 shaohe_feng also another things, where we init the threadpoolexcutor?
03:56:43 shaohe_feng int the arq object file?
03:56:48 shaohe_feng seems not good.
03:57:11 shaohe_feng OK.
03:57:52 Sundar All, please look at this issue for allocating attach handles: https://opendev.org/openstack/cyborg/src/branch/master/cyborg/db/sqlalchemy/api.py#L269 The in_use field does not get written to db
03:58:34 Sundar All, we are seeing good review activity of late. Thank you all, and please keep it up. We are literally 2 weeks from the milestone. :)
03:58:41 Sundar #topic AoB
03:59:20 Sundar shaohe_feng: if you prefer, I can initiate an email thread for the good points that you brought up. Good?
03:59:39 shaohe_feng OK
03:59:48 Sundar Anything else, folks?
04:00:50 shaohe_feng do you have a look that the in_use is in the arguments of the update function?
04:01:00 Sundar Yes
04:01:14 shaohe_feng and the your DB really have the in_use field?
04:01:32 shaohe_feng directly use mysql command.
04:02:04 Sundar Oh yes. The ref.update has it, but it doesn;t get written to db. Use mysql cmd from Python code?
04:02:20 shaohe_feng no
04:02:22 shaohe_feng such as:
04:02:33 shaohe_feng mysql -uroot -ppass cyborg
04:02:58 Sundar Yes, update command works from CLI
04:03:25 Sundar We'll follow up on this too by email.
04:03:33 shaohe_feng desc haddler;
04:03:43 shaohe_feng OK.
04:03:52 Sundar Thanks, everybody. Happy coding and reviewing :). Have a good day. Bye.
04:03:58 Sundar #endmeeting
04:04:00 openstack Meeting ended Thu Aug 29 04:03:58 2019 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4)
04:04:01 openstack Minutes: http://eavesdrop.openstack.org/meetings/openstack_cyborg/2019/openstack_cyborg.2019-08-29-03.05.html
04:04:02 openstack Minutes (text): http://eavesdrop.openstack.org/meetings/openstack_cyborg/2019/openstack_cyborg.2019-08-29-03.05.txt
04:04:03 openstack Log: http://eavesdrop.openstack.org/meetings/openstack_cyborg/2019/openstack_cyborg.2019-08-29-03.05.log.html
04:04:21 shaohe_feng you can update the field manully by mysql CLI, right?
04:04:32 shaohe_feng manually
04:07:03 Sundar Hi shaohe_feng: Yes
04:07:15 shaohe_feng can I login your evn?
04:07:30 Sundar Sure, I'll send you the info separately
04:07:38 shaohe_feng OK. thanks.
06:03:17 openstackgerrit chenker proposed openstack/cyborg master: Fix pep8 error in cyborg/*.py and add Forbidden class https://review.opendev.org/679042
06:07:50 openstackgerrit YumengBao proposed openstack/cyborg master: enable branch selection in devstack installation https://review.opendev.org/669303
06:24:24 openstackgerrit chenker proposed openstack/cyborg master: P3: Fix pep8 error in cyborg/common and cyborg/conductor https://review.opendev.org/679062
06:27:56 openstackgerrit chenker proposed openstack/cyborg master: P4: Fix pep8 error in cyborg/api https://review.opendev.org/679172
06:36:44 openstackgerrit YumengBao proposed openstack/cyborg master: enable branch selection in devstack installation https://review.opendev.org/669303
07:01:32 openstackgerrit chenker proposed openstack/cyborg master: Fix pep8 error in cyborg/agent and cyborg/db https://review.opendev.org/679193
07:07:09 openstackgerrit chenker proposed openstack/cyborg master: P4: Fix pep8 error in cyborg/api https://review.opendev.org/679172
07:21:23 openstackgerrit chenker proposed openstack/cyborg master: Fix pep8 error in cyborg/*.py and add Forbidden class https://review.opendev.org/679042
07:21:24 openstackgerrit chenker proposed openstack/cyborg master: P3: Fix pep8 error in cyborg/common and cyborg/conductor https://review.opendev.org/679062
07:21:24 openstackgerrit chenker proposed openstack/cyborg master: P2: Fix pep8 error in cyborg/conf and cyborg/cmd https://review.opendev.org/679045
07:21:25 openstackgerrit chenker proposed openstack/cyborg master: P4: Fix pep8 error in cyborg/api https://review.opendev.org/679172
07:26:14 openstackgerrit chenker proposed openstack/cyborg master: P5: Fix pep8 error in cyborg/accelerator https://review.opendev.org/679175
07:26:15 openstackgerrit chenker proposed openstack/cyborg master: P6: Fix pep8 error in cyborg/agent and cyborg/db https://review.opendev.org/679193
07:52:13 chenke Hi, all. When you have time, please help me review the pep8 related commit. I think this should be merged as soon as possible, which will facilitate the code in cyborg. Thanks.
12:39:40 openstackgerrit chenker proposed openstack/cyborg master: P6: Fix pep8 error in cyborg/agent and cyborg/db https://review.opendev.org/679193
12:41:51 openstackgerrit chenker proposed openstack/cyborg master: P6: Fix pep8 error in cyborg/agent and cyborg/db https://review.opendev.org/679193
14:06:28 openstackgerrit Merged openstack/cyborg master: enable branch selection in devstack installation https://review.opendev.org/669303
14:36:33 openstackgerrit Merged openstack/cyborg master: Fill "driver_name" field in Deployable object https://review.opendev.org/677952
18:00:10 openstackgerrit ShaoHe Feng proposed openstack/cyborg master: bug fix: update in DB instead of in cache https://review.opendev.org/679314
18:40:04 openstackgerrit ShaoHe Feng proposed openstack/cyborg master: bug fix: update in DB instead of in cache https://review.opendev.org/679314
21:13:59 openstackgerrit Merged openstack/cyborg master: Move to releases.openstack.org https://review.opendev.org/664774
#openstack-cyborg - 2019-08-30
00:43:04 openstackgerrit Yikun Jiang proposed openstack/cyborg master: Add Huawei Ascend driver https://review.opendev.org/660874

Earlier   Later