| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-cyborg - 2019-06-12 | |||
| 03:13:22 | Biwei | yikun, there's a cyborg-tempest-plugin repo, living outside of the cyborg repo | |
| 03:14:12 | Sundar | The tempest plugins are going to call that fake driver. | |
| 03:14:22 | xinranwang | Sundar: what should fake driver return exactly, the info returned by this fake driver will be used in nova to boot vm, right ? | |
| 03:15:19 | Sundar | xinranwang: Yes. Its discover() API should return a pre-defined device OVO object | |
| 03:15:26 | yikun | Biwei: OK, https://github.com/openstack/cyborg-tempest-plugin | |
| 03:15:43 | xinranwang | Sundar: tempest has api test and scenario test, those 2 types only interact with API layers, I don't think tempest should call driver directly. | |
| 03:15:44 | Sundar | It could define a device with soem fake controlpath-IDs, 1 deployable and an attach handle, all with fake PCI addresses | |
| 03:15:51 | xinranwang | Biwei: what do you think? | |
| 03:16:17 | xinranwang | Sundar: yes, but what info stored in this OVO, like pci address | |
| 03:16:29 | Biwei | tempest will not call driver directly | |
| 03:17:26 | Sundar | Can be totally bogus PCI addresses. The VM may not boot up without the hardware. | |
| 03:17:51 | Sundar | To quote Eric Fried: "It should be sufficient to wait for the instance to go ACTIVE (according to Nova) (which will happen even if the guest OS boot pukes) and scrape its domain XML to assert that the correct PCI devices are present." | |
| 03:18:56 | yikun | Biwei: how to call driver directly, shouldn't it call cyborg api and cyborg api call the fake driver | |
| 03:19:00 | Sundar | Biwei Yes. Not sure if the CYborg agent will call driver API in tempest env, as it happens in real env | |
| 03:20:19 | Biwei | Sundar in tempest test, we only need to call the cyborg restful APIs. | |
| 03:20:25 | Sundar | The API invocation need not even call the driver -- as long as the driver has reported the device(s). | |
| 03:21:03 | yikun | Biwei: "Sundar in tempest test, we only need to call the cyborg restful APIs." < Yes, so the fake driver should be in cyborg repo, right? | |
| 03:21:27 | yikun | and tempest should do something config the cyborg to use the fake dirver | |
| 03:21:58 | Sundar | Biwei, if there were some way to set up the Cyborg database in tempest env, like I did with initial_setup.sh in pilot code, we may not even need a fake driver perhaps | |
| 03:22:27 | Sundar | Have you seen if tempest can run some script to set up the env? | |
| 03:22:37 | xinranwang | I have some discussion with others like Alex, Shaohe. We are not sure if the status will switch to active in that case. I test in local with fake device, it failed. | |
| 03:22:57 | Biwei | I haven't figured that out yet. I have done the steps including creating flavor and update the flavor with device and all working so far | |
| 03:23:39 | Biwei | but not sure how to do the database set up | |
| 03:24:44 | xinranwang | tempest run in an installed openstack env where already have cybrog db, every thing same as a real env | |
| 03:24:54 | Sundar | xinranwang: True, I think it goes to error state. However, if we can do 'virsh dumpxml' equivalent and look for the hostdev device, that should be good enough | |
| 03:26:20 | xinranwang | Sundar: yes, I agree, but nova api will return error directly to tempest. where should we got the xml from virt driver. | |
| 03:26:47 | Sundar | Can you run a comand like 'virsh dumpxml'? | |
| 03:27:04 | xinranwang | you mean in tempest? | |
| 03:27:08 | Sundar | Yes | |
| 03:28:49 | xinranwang | I am not sure if libvirt will really boot it, I wonder that libvirt may do pci | |
| 03:29:17 | xinranwang | I am not sure if libvirt will really boot it, I wonder that libvirt may do pci check first before boot a vm | |
| 03:29:48 | Sundar | I have tried to launch a VM inside a development VM. It will error out but the VM exists in error state as shown by 'openstack server list' | |
| 03:30:00 | Sundar | Then we can look at Nova logs | |
| 03:31:00 | Sundar | You are right, the instance won't launch -- so can't do 'virsh dumpxml' | |
| 03:31:02 | openstackgerrit | tonybrad proposed openstack/cyborg master: Move to releases.openstack.org https://review.opendev.org/664774 | |
| 03:31:24 | xinranwang | I know, the xml file is generate before calling libvirt. Have you run virsh list to see if the instance exists. | |
| 03:32:43 | Sundar | The 'virsh list' won't show the instance -- so we should scrap that idea. I used to look at Nova logs. But I also modify the LOG statement in Nova virt driver to dump the xml all the time | |
| 03:33:35 | Sundar | We should probably ask other projects that use hardware. I'll get back on this. | |
| 03:34:58 | xinranwang | Ok, we should find another way. | |
| 03:35:04 | Sundar | Even if it fails in a predictable way, we can look for that specific error in n-cpu logs and declare success. | |
| 03:35:36 | Sundar | OK, let's table it for now. | |
| 03:35:47 | Sundar | #topic Python 3 migration | |
| 03:35:48 | xinranwang | Yes, of course. I agree with you. That was what I did when I don't have devices lol | |
| 03:36:26 | Sundar | ikuo_o and all: are there any questions or comments on Py3 migration? | |
| 03:36:33 | yikun | [1] https://github.com/openstack/cyborg/blob/master/cyborg/agent/resource_tracker.py#L57 | |
| 03:36:33 | yikun | And the tempest can test the case which the fake driver can complete, such as some cyborg API, but for Nova-cyborg intergration test, we should run in real env. | |
| 03:36:33 | yikun | The fake driver in my mind it's that: we implement a fake driver in *Cyborg driver*, and tempest set the CONF.agent.enabled_drivers to this fakedriver when test setup. | |
| 03:37:44 | ikuo_o | We just fixed stable/stein cord. | |
| 03:38:04 | ikuo_o | and will throw patches in some days. | |
| 03:38:16 | Sundar | ikuo_o: Great. Was that much work? | |
| 03:39:15 | Sundar | Will look for the patches. | |
| 03:39:30 | Sundar | #topic Cyborg client migration | |
| 03:39:42 | ikuo_o | Not so much, but we should fix continuously because new patches will come out. | |
| 03:40:16 | Sundar | ikuo_o: Can you please let us know where this stands? Do you need any help? | |
| 03:41:09 | ikuo_o | I will tell you If I post patchs, off cource, I ask you help if needed. | |
| 03:41:39 | ikuo_o | sorry, "this" means cyborg client migration? | |
| 03:41:44 | Sundar | Yes | |
| 03:42:10 | ikuo_o | We are discussing how to break down tasks. | |
| 03:42:36 | Sundar | OK. Good. | |
| 03:42:45 | ikuo_o | I think the tasks would be: 1) implement object open via API eg, device_profile, arq | |
| 03:42:53 | Sundar | #topic Cyborg specs and patches | |
| 03:42:59 | ikuo_o | 2) implement operation (CRUD) open via API | |
| 03:43:07 | ikuo_o | 3)implement call point from library users | |
| 03:43:13 | ikuo_o | 4)all the functional tests (toX) | |
| 03:43:29 | ikuo_o | any advices welcome! | |
| 03:43:34 | Sundar | ikuo_o: I would think the first step is to adopt openstack-sdk? | |
| 03:44:15 | ikuo_o | yes, It include adopting openstacksdk. | |
| 03:44:32 | Sundar | ok | |
| 03:44:46 | ikuo_o | we are preparing write storyboard, pls wait. | |
| 03:44:51 | Sundar | Re. Cyborg patches, I approved the generic driver and got it merged. Thanks, yikun | |
| 03:45:14 | Sundar | Also, approved a bunch of small patches on fixing opendev URL or email addresses | |
| 03:46:11 | yikun | Sundar: thanks, but we should first https://review.opendev.org/#/c/658986 first, :) | |
| 03:46:39 | Sundar | I have partial fixes for the pilot code comments. Unfortunately, I could not dedicate a few days to get this done completely. | |
| 03:47:37 | Sundar | yikun: Agreed. Missed that | |
| 03:48:14 | Sundar | Will refresh the pilot code this week with whatever I have. | |
| 03:48:33 | Sundar | @all, please do review the specs | |
| 03:48:59 | Sundar | Can we aim to get one set of reviews by this week? | |
| 03:49:36 | Sundar | #link https://review.opendev.org/#/q/status:open+project:openstack/cyborg-specs+owner:Sundar | |
| 03:50:56 | Sundar | wangzhh, Li_Liu, yikun, xinranwang, all: Can we aim to get one set of reviews for the specs by this week? | |
| 03:51:59 | ikuo_o | sorry, poor connection | |
| 03:52:25 | Sundar | NP, ikuo_o. I was asking if we can get the specs reviewed by this week. | |
| 03:53:04 | ikuo_o | ok, I will check logs. | |
| 03:53:21 | Sundar | #topic AoB | |
| 03:53:43 | Sundar | I think we can skip the Zoom call tomorrow, and use that time to get the specs reviewed | |
| 03:54:41 | ikuo_o | all right, thank you Sundar. | |
| 03:55:07 | Sundar | Thanks, ikuo_o and all. Have a good day. Bye. | |
| 03:55:10 | Sundar | #endmeeting | |
| 03:55:12 | openstack | Meeting ended Wed Jun 12 03:55:10 2019 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) | |
| 03:55:13 | openstack | Minutes: http://eavesdrop.openstack.org/meetings/openstack_cyborg/2019/openstack_cyborg.2019-06-12-03.02.html | |
| 03:55:14 | openstack | Minutes (text): http://eavesdrop.openstack.org/meetings/openstack_cyborg/2019/openstack_cyborg.2019-06-12-03.02.txt | |
| 03:55:16 | openstack | Log: http://eavesdrop.openstack.org/meetings/openstack_cyborg/2019/openstack_cyborg.2019-06-12-03.02.log.html | |
| 16:02:55 | Sundar | yikun, xinranwang, Biwei: Please see http://eavesdrop.openstack.org/irclogs/%23openstack-nova/%23openstack-nova.2019-06-12.log.html#t2019-06-12T15:55:18 | |
| #openstack-cyborg - 2019-06-14 | |||
| 07:14:39 | openstackgerrit | Yikun Jiang proposed openstack/cyborg master: Add the fake driver https://review.opendev.org/665318 | |
| 07:43:51 | openstackgerrit | Yikun Jiang proposed openstack/cyborg master: Add the fake driver https://review.opendev.org/665318 | |
| #openstack-cyborg - 2019-06-17 | |||
| 14:02:48 | openstackgerrit | chenker proposed openstack/cyborg-tempest-plugin master: Switch to the new canonical constraints URL on master https://review.opendev.org/665678 | |
| 14:06:28 | openstackgerrit | chenker proposed openstack/cyborg-specs master: Switch to the new canonical constraints URL on master https://review.opendev.org/665679 | |
| #openstack-cyborg - 2019-06-18 | |||
| 01:56:17 | openstackgerrit | Yikun Jiang proposed openstack/cyborg master: Add the fake driver https://review.opendev.org/665318 | |
| 07:56:40 | openstackgerrit | Yikun Jiang proposed openstack/cyborg master: Fix the section of enabled_drivers https://review.opendev.org/660603 | |
| 08:08:59 | openstackgerrit | Yikun Jiang proposed openstack/cyborg master: Add AICHIP and GENERIC type in DB and obj https://review.opendev.org/660548 | |
| 08:09:26 | openstackgerrit | Yikun Jiang proposed openstack/cyborg master: Add Huawei Ascend driver https://review.opendev.org/660874 | |