| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-cyborg - 2019-02-20 | |||
| 03:04:55 | Li_Liu | we have merged a quite a few patches recently | |
| 03:05:04 | Li_Liu | thanks guys for the efforts | |
| 03:05:32 | Coco_gao | What about yumeng's patch? | |
| 03:05:44 | Coco_gao | I saw Sundar's comments on that. | |
| 03:05:44 | Sundar | #info Sundar | |
| 03:06:15 | Li_Liu | Coco_gao, could you quickly help summarize the DB refactor work so far? | |
| 03:08:42 | Li_Liu | what's still missing? | |
| 03:08:57 | Coco_gao | AttachHandle ControlPathID, Arq and ExtArq Object are done and merged. | |
| 03:08:57 | Coco_gao | Migration Script, Model are done and merged. | |
| 03:09:25 | Coco_gao | Device and DeviceProfile Object are done but not merged right now. | |
| 03:09:47 | Coco_gao | Still, we need Deployable Object, which is not implemented. | |
| 03:10:14 | Li_Liu | I am working on the Deployable | |
| 03:10:26 | Coco_gao | OK. | |
| 03:10:44 | Coco_gao | Can yumeng's patch merge now? | |
| 03:11:01 | Li_Liu | I think Sundar still has some comments | |
| 03:11:17 | Coco_gao | Sundar, What's your opinion? | |
| 03:11:59 | Yumeng_ | Sundar: I see your comments on https://review.openstack.org/#/c/631683/8. IMHO we already merged some device_profile related codes, and device_profile_id will be the ForeignKey in ExternalAcceleratorRequest. So I would suggest we merge device_profiles codes for now (since we already have), and we can refactor in the future | |
| 03:12:37 | Coco_gao | I agree with yumeng. | |
| 03:12:41 | Yumeng_ | If we leave out it now, there may be errors | |
| 03:13:54 | Li_Liu | hmm, I agree | |
| 03:14:20 | Li_Liu | Sundar, what do you think? | |
| 03:15:18 | Li_Liu | he's disconnected >< | |
| 03:15:24 | wangzhh | I agree, too. | |
| 03:15:31 | Sundar | Hello | |
| 03:15:40 | Li_Liu | Sundar, did you see what we discussed? | |
| 03:15:43 | Sundar | Lost connection to IRC alone, for some reason | |
| 03:16:16 | Sundar | Yumeng_: The db layer has already been agreed upon | |
| 03:16:36 | Sundar | Yumeng_, the question is now about the objects layer only | |
| 03:17:12 | Sundar | The device profile code is going to go through changes based on feedback. So, what do we gain by merging it? | |
| 03:17:45 | Sundar | If we just want to merge some code, and are ok with total refactor later, then no issue. But I guess I don't see the point. | |
| 03:17:56 | Sundar | What do you all think? | |
| 03:17:58 | Coco_gao | So your opinion is to seperate that patch into two, we merge device object at first? | |
| 03:18:11 | Sundar | Yes, Coco_gao | |
| 03:18:51 | Sundar | Do we want to merge device profiles, esp. without other supporting code like APIs? | |
| 03:19:59 | Sundar | Just my 2 cents :) | |
| 03:21:03 | Li_Liu | I think there's no harm to merge the current one and modify it in a separated patch. It's more efficient than splitting | |
| 03:21:16 | Li_Liu | and some outcome eventually | |
| 03:21:54 | Sundar | Li_liu, ok | |
| 03:22:14 | Li_Liu | What do others think? | |
| 03:22:45 | Coco_gao | That depends on yumeng. | |
| 03:23:34 | xinranwang | yes I agree with Li. It's more efficient. | |
| 03:24:03 | Li_Liu | yumeng_ to address Sundar's comment, you can mark a TODO in the current patch and submit a different one when you have time to fix it | |
| 03:24:47 | Sundar | If we are going with the current one, we may as well leave it in for Stein | |
| 03:25:00 | Sundar | No need for further updates | |
| 03:25:35 | Li_Liu | cool | |
| 03:25:47 | Coco_gao | ok | |
| 03:26:21 | Li_Liu | ok, move on to the next item | |
| 03:26:25 | Yumeng_ | great. Thxs all for your opinions. | |
| 03:26:44 | Li_Liu | Coco_gao, how about the OVO? | |
| 03:26:52 | Li_Liu | do you need help for them? | |
| 03:27:38 | Coco_gao | I am working on that, maybe I can submmit a new patch set at the end of this week. | |
| 03:28:01 | Li_Liu | are you going to update https://review.openstack.org/#/c/624138/ | |
| 03:28:05 | Li_Liu | or submit a new one? | |
| 03:28:18 | wangzhh | I can help to finish this part, too. Coco. | |
| 03:28:40 | Coco_gao | I prefer to update the old patch. | |
| 03:29:08 | Coco_gao | And try to address all the comments | |
| 03:29:22 | Li_Liu | wangzhh, please help out Coco_gao. we don't wanna overload her too much ><! | |
| 03:29:30 | Coco_gao | wangzhh, thank you. | |
| 03:29:32 | wangzhh | Yep | |
| 03:29:49 | Li_Liu | and you guys can work out the work distribution | |
| 03:30:18 | Li_Liu | if you guys can sumbit the patch by the end Friday, I can start working on conductor over the weekend | |
| 03:30:42 | Li_Liu | but totally up to you :P | |
| 03:31:04 | Coco_gao | we will try. | |
| 03:31:14 | Li_Liu | as long as we can have some thing by Sunday | |
| 03:31:28 | Li_Liu | thanks a lot :) | |
| 03:32:52 | xinranwang | I can help too, please let me know if you need. | |
| 03:33:26 | Li_Liu | Sundar, after this, can we try to integrate with nova based on your nova patch? | |
| 03:33:44 | xinranwang | Li_Liu: Li, you mean you will take the make diff part on conductor, right ? | |
| 03:34:00 | Coco_gao | Li_Liu, we still need API about bind, unbind operations... | |
| 03:34:04 | Li_Liu | xinranwang, yup, I will take care of that port | |
| 03:34:04 | Sundar | I don't want to put any Nova-related changes in Stein in a rushed way | |
| 03:34:37 | xinranwang | Li_Liu: ok, and i will take the DB update part tho | |
| 03:35:00 | xinranwang | *then | |
| 03:35:01 | Li_Liu | Coco_gao, sure, I am trying to find out the missing piece] | |
| 03:35:15 | Li_Liu | xinranwang, we can sync up for that offline | |
| 03:35:46 | xinranwang | Li_Liu: ok | |
| 03:35:48 | Coco_gao | OK | |
| 03:36:46 | Coco_gao | anything else to sync today? | |
| 03:36:52 | Li_Liu | there are about 2 weeks left.. let's try out best to push as much as possible | |
| 03:37:03 | Li_Liu | I think that's it | |
| 03:37:10 | Li_Liu | #topic AoB | |
| 03:37:31 | Li_Liu | If there's no other issue, let's call the meeting for today | |
| 03:37:39 | Coco_gao | OK. | |
| 03:38:11 | Yumeng_ | see you guys. | |
| 03:38:15 | Li_Liu | ok, thanks a lot guys | |
| 03:38:19 | Coco_gao | BTW, happy birthday to you Li | |
| 03:38:21 | Li_Liu | have a good day/night | |
| 03:38:30 | Li_Liu | haha, thanks a lot Coco :P | |
| 03:38:37 | xinranwang | wow, happy birthday | |
| 03:38:40 | Yumeng_ | wow~~ happy birthday | |
| 03:38:42 | Coco_gao | bye | |
| 03:38:46 | Li_Liu | 1 year older now | |
| 03:38:53 | Li_Liu | bye | |
| 03:38:55 | Li_Liu | #endmeeting | |
| 03:38:57 | openstack | Meeting ended Wed Feb 20 03:38:55 2019 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) | |
| 03:38:58 | openstack | Minutes: http://eavesdrop.openstack.org/meetings/openstack_cyborg/2019/openstack_cyborg.2019-02-20-03.03.html | |
| 03:38:59 | openstack | Minutes (text): http://eavesdrop.openstack.org/meetings/openstack_cyborg/2019/openstack_cyborg.2019-02-20-03.03.txt | |
| 03:39:00 | openstack | Log: http://eavesdrop.openstack.org/meetings/openstack_cyborg/2019/openstack_cyborg.2019-02-20-03.03.log.html | |
| #openstack-cyborg - 2019-02-21 | |||
| 04:52:28 | openstackgerrit | Merged openstack/cyborg master: Add Device and DeviceProfile objects https://review.openstack.org/631683 | |
| #openstack-cyborg - 2019-02-22 | |||
| 04:45:53 | openstackgerrit | Li Liu proposed openstack/cyborg master: Modified the Deployable Object https://review.openstack.org/638580 | |