Earlier  
Posted Nick Remark
#openstack-cyborg - 2019-02-19
06:13:51 openstackgerrit coco-Gao proposed openstack/cyborg master: Modify "extended_accelerator_requests" table "project_id" field. https://review.openstack.org/637706
06:19:25 openstackgerrit YumengBao proposed openstack/cyborg master: Add AttachHandle and ControlpathID objects https://review.openstack.org/630579
06:19:26 openstackgerrit YumengBao proposed openstack/cyborg master: Add Device and DeviceProfile objects https://review.openstack.org/631683
08:48:29 openstackgerrit YumengBao proposed openstack/cyborg master: Add Device and DeviceProfile objects https://review.openstack.org/631683
09:05:56 openstackgerrit zhongshengping proposed openstack/python-cyborgclient master: add python 3.7 unit test job https://review.openstack.org/637738
15:28:16 openstackgerrit Merged openstack/cyborg master: Add AttachHandle and ControlpathID objects https://review.openstack.org/630579
20:06:36 openstackgerrit Merged openstack/cyborg master: Modify "extended_accelerator_requests" table "project_id" field. https://review.openstack.org/637706
#openstack-cyborg - 2019-02-20
03:01:59 Li_Liu Hi guys
03:02:25 xinranwang Hi, Lishu :)
03:02:33 Li_Liu Let's wait for a bit
03:02:42 Li_Liu Hi Hi Xinran
03:02:45 Sundar Hi Li
03:02:50 Li_Liu Hi Sundar
03:03:47 Li_Liu #startmeeting openstack-cyborg
03:03:48 openstack Meeting started Wed Feb 20 03:03:47 2019 UTC and is due to finish in 60 minutes. The chair is Li_Liu. Information about MeetBot at http://wiki.debian.org/MeetBot.
03:03:49 openstack Useful Commands: #action #agreed #help #info #idea #link #topic #startvote.
03:03:51 openstack The meeting name has been set to 'openstack_cyborg'
03:03:58 Coco_gao #info Coco_gao
03:03:59 Li_Liu #topic Roll Call
03:04:06 xinranwang #info xinranwang
03:04:06 Li_Liu #info Li_Liu
03:04:19 Li_Liu #topic status updates
03:04:43 Li_Liu https://review.openstack.org/#/q/project:openstack/cyborg
03:04:45 Yumeng_ #info Yumeng
03:04:55 Li_Liu we have merged a quite a few patches recently
03:05:04 Li_Liu thanks guys for the efforts
03:05:32 Coco_gao What about yumeng's patch?
03:05:44 Coco_gao I saw Sundar's comments on that.
03:05:44 Sundar #info Sundar
03:06:15 Li_Liu Coco_gao, could you quickly help summarize the DB refactor work so far?
03:08:42 Li_Liu what's still missing?
03:08:57 Coco_gao AttachHandle ControlPathID, Arq and ExtArq Object are done and merged.
03:08:57 Coco_gao Migration Script, Model are done and merged.
03:09:25 Coco_gao Device and DeviceProfile Object are done but not merged right now.
03:09:47 Coco_gao Still, we need Deployable Object, which is not implemented.
03:10:14 Li_Liu I am working on the Deployable
03:10:26 Coco_gao OK.
03:10:44 Coco_gao Can yumeng's patch merge now?
03:11:01 Li_Liu I think Sundar still has some comments
03:11:17 Coco_gao Sundar, What's your opinion?
03:11:59 Yumeng_ Sundar: I see your comments on https://review.openstack.org/#/c/631683/8. IMHO we already merged some device_profile related codes, and device_profile_id will be the ForeignKey in ExternalAcceleratorRequest. So I would suggest we merge device_profiles codes for now (since we already have), and we can refactor in the future
03:12:37 Coco_gao I agree with yumeng.
03:12:41 Yumeng_ If we leave out it now, there may be errors
03:13:54 Li_Liu hmm, I agree
03:14:20 Li_Liu Sundar, what do you think?
03:15:18 Li_Liu he's disconnected ><
03:15:24 wangzhh I agree, too.
03:15:31 Sundar Hello
03:15:40 Li_Liu Sundar, did you see what we discussed?
03:15:43 Sundar Lost connection to IRC alone, for some reason
03:16:16 Sundar Yumeng_: The db layer has already been agreed upon
03:16:36 Sundar Yumeng_, the question is now about the objects layer only
03:17:12 Sundar The device profile code is going to go through changes based on feedback. So, what do we gain by merging it?
03:17:45 Sundar If we just want to merge some code, and are ok with total refactor later, then no issue. But I guess I don't see the point.
03:17:56 Sundar What do you all think?
03:17:58 Coco_gao So your opinion is to seperate that patch into two, we merge device object at first?
03:18:11 Sundar Yes, Coco_gao
03:18:51 Sundar Do we want to merge device profiles, esp. without other supporting code like APIs?
03:19:59 Sundar Just my 2 cents :)
03:21:03 Li_Liu I think there's no harm to merge the current one and modify it in a separated patch. It's more efficient than splitting
03:21:16 Li_Liu and some outcome eventually
03:21:54 Sundar Li_liu, ok
03:22:14 Li_Liu What do others think?
03:22:45 Coco_gao That depends on yumeng.
03:23:34 xinranwang yes I agree with Li. It's more efficient.
03:24:03 Li_Liu yumeng_ to address Sundar's comment, you can mark a TODO in the current patch and submit a different one when you have time to fix it
03:24:47 Sundar If we are going with the current one, we may as well leave it in for Stein
03:25:00 Sundar No need for further updates
03:25:35 Li_Liu cool
03:25:47 Coco_gao ok
03:26:21 Li_Liu ok, move on to the next item
03:26:25 Yumeng_ great. Thxs all for your opinions.
03:26:44 Li_Liu Coco_gao, how about the OVO?
03:26:52 Li_Liu do you need help for them?
03:27:38 Coco_gao I am working on that, maybe I can submmit a new patch set at the end of this week.
03:28:01 Li_Liu are you going to update https://review.openstack.org/#/c/624138/
03:28:05 Li_Liu or submit a new one?
03:28:18 wangzhh I can help to finish this part, too. Coco.
03:28:40 Coco_gao I prefer to update the old patch.
03:29:08 Coco_gao And try to address all the comments
03:29:22 Li_Liu wangzhh, please help out Coco_gao. we don't wanna overload her too much ><!
03:29:30 Coco_gao wangzhh, thank you.
03:29:32 wangzhh Yep
03:29:49 Li_Liu and you guys can work out the work distribution
03:30:18 Li_Liu if you guys can sumbit the patch by the end Friday, I can start working on conductor over the weekend
03:30:42 Li_Liu but totally up to you :P
03:31:04 Coco_gao we will try.
03:31:14 Li_Liu as long as we can have some thing by Sunday
03:31:28 Li_Liu thanks a lot :)
03:32:52 xinranwang I can help too, please let me know if you need.
03:33:26 Li_Liu Sundar, after this, can we try to integrate with nova based on your nova patch?
03:33:44 xinranwang Li_Liu: Li, you mean you will take the make diff part on conductor, right ?
03:34:00 Coco_gao Li_Liu, we still need API about bind, unbind operations...
03:34:04 Li_Liu xinranwang, yup, I will take care of that port
03:34:04 Sundar I don't want to put any Nova-related changes in Stein in a rushed way
03:34:37 xinranwang Li_Liu: ok, and i will take the DB update part tho
03:35:00 xinranwang *then
03:35:01 Li_Liu Coco_gao, sure, I am trying to find out the missing piece]
03:35:15 Li_Liu xinranwang, we can sync up for that offline
03:35:46 xinranwang Li_Liu: ok

Earlier   Later