| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-cyborg - 2018-04-18 | |||
| 14:22:21 | shaohe_feng_ | zhipeng: how to reproduce it? | |
| 14:23:00 | zhipeng | i'm asking the author to join irc right now :) | |
| 14:23:01 | shaohe_feng_ | zhipeng: OK, mutil-host | |
| 14:23:17 | shaohe_feng_ | zhipeng: we does not try multi-host. | |
| 14:23:36 | zhipeng | MULTI_HOST=False | |
| 14:24:18 | shaohe_feng_ | zhipeng: got it. | |
| 14:24:36 | shaohe_feng_ | more details more easy to fix it. | |
| 14:26:18 | zhipeng | yes I was just saying that to the author | |
| 14:27:06 | zhipeng | ok I just reviewed kosamara's bug report | |
| 14:27:09 | zhipeng | i think it is related | |
| 14:27:23 | zhipeng | maybe we should not have a enable_service cyborg | |
| 14:27:32 | zhipeng | since there is no cyborg service | |
| 14:27:56 | zhipeng | let me re-paste kosamara's report | |
| 14:28:12 | shaohe_feng_ | zhipeng: enable cyborg plugin? | |
| 14:28:22 | zhipengh[m] | Hi! I was trying cyborg in devstack again. At some point devstack is checking if every service is running and 2 things related to cyborg occur: | |
| 14:30:02 | zhipeng | .... | |
| 14:30:25 | zhipeng | Guest52678 we are reviewing another bug report | |
| 14:30:31 | zhipeng | which might be related to yours | |
| 14:30:39 | shaohe_feng_ | zhipeng: does the author enable cyborg plugin? | |
| 14:30:53 | zhipeng | shaohe_feng_ i don't think so | |
| 14:31:16 | shaohe_feng_ | zhipeng: https://storyboard.openstack.org/#!/story/2001827 the link just enable service. | |
| 14:31:31 | Li_Liu | I remember Jinghan or someone provided a localrc file or something like that before | |
| 14:31:38 | Guest52678 | Hi .. Yes i have enabled cyborg services | |
| 14:31:51 | Guest52678 | But still it was failing | |
| 14:32:02 | zhipeng | #link http://paste.openstack.org/show/ym8eEtMcHQjEWeLSkT0F/ | |
| 14:32:07 | shaohe_feng_ | it should enable both service and plugin | |
| 14:32:24 | zhipeng | I think another reason is my enable mutable config patch | |
| 14:32:49 | zhipeng | ERROR cyborg TypeError: launch_service() got an unexpected keyword argument 'restart_method' | |
| 14:32:55 | Guest52678 | Hi Zhipeng, i got the same type of error msg | |
| 14:32:58 | zhipeng | i will take a look into that | |
| 14:33:02 | Guest52678 | like the link you provided | |
| 14:33:21 | zhipeng | Guest52678 yeah I probably know what triggers it lol | |
| 14:33:44 | shaohe_feng_ | good | |
| 14:33:53 | zhipeng | #link https://review.openstack.org/559303 | |
| 14:35:02 | zhipeng | Guest52678 the solution is three fold I guess: (1)remove cyborg from enable_service(2)add cyborg plugin in the enable_service(3) wait for my patch on the restart_method error | |
| 14:36:15 | Guest52678 | ok | |
| 14:36:38 | zhipeng | thx for the bug report :) | |
| 14:36:54 | zhipeng | I would otherwise has no clue about the problem I introduced | |
| 14:37:33 | zhipeng | okey let's move on | |
| 14:37:44 | zhipeng | #topic Rocky Critical Spec Review | |
| 14:37:59 | zhipeng | now let's start from the mature ones | |
| 14:38:15 | zhipeng | #info Sundar's sched spec | |
| 14:38:18 | zhipeng | #link https://review.openstack.org/554717 | |
| 14:38:30 | zhipeng | shaohe_feng_ Li_Liu looks good to you guys ? | |
| 14:38:35 | zhipeng | edleaf | |
| 14:38:50 | zhipeng | edleafe sorry | |
| 14:40:54 | Li_Liu | Overall looks good to me. But I think Jay's most recently comment still needs to be addressed | |
| 14:41:01 | zhipeng | okey | |
| 14:41:30 | Li_Liu | shouldn't be a big change | |
| 14:42:21 | zhipeng | #info programming spec | |
| 14:42:27 | zhipeng | #link https://review.openstack.org/559395 | |
| 14:42:33 | edleafe | zhipeng: sorry, on a call | |
| 14:42:42 | edleafe | zhipeng: I'll review it today | |
| 14:42:47 | zhipeng | edleafe no problem :) thx man | |
| 14:43:51 | zhipeng | Guest18705 are you around ? | |
| 14:44:06 | zhipeng | I think you or chuck should help review the programming spec | |
| 14:44:13 | shaohe_feng_ | zhipeng: looks good to me. | |
| 14:44:34 | zhipeng | altho Li_Liu should have more than enough exprience on Xilinx FPGA :) | |
| 14:46:14 | zhipeng | okey next | |
| 14:46:25 | zhipeng | #info bitstream metadata standardization | |
| 14:46:27 | zhipeng | #link https://review.openstack.org/558265 | |
| 14:46:28 | Li_Liu | zhipeng: about the fpga reconfigure spec, should we put that in for R? or we wait for future? | |
| 14:46:40 | Li_Liu | I mentioned in the community email last week | |
| 14:46:48 | zhipeng | Li_Liu I doubt we have enough bandwidth on that | |
| 14:46:57 | Li_Liu | ok, great | |
| 14:47:00 | zhipeng | don't forget to reply to Jay's comment :) | |
| 14:47:30 | Li_Liu | Sure, but hope Sundar can provide some insights as well | |
| 14:47:39 | zhipeng | of course | |
| 14:47:39 | Li_Liu | for Jay's comment I mean | |
| 14:48:21 | chucksong | ok, I will take a look at the programming spec | |
| 14:48:22 | zhipeng | I guess metadata still needs Sundar's further review | |
| 14:48:31 | zhipeng | hey thx chucksong | |
| 14:48:38 | zhipeng | also the metadata one I just mentioned :) | |
| 14:49:17 | chucksong | sure | |
| 14:49:24 | zhipeng | #info quota spec still needs more work | |
| 14:49:38 | zhipeng | #info will need Sundar to present on the new agent-driver api spec | |
| 14:49:52 | zhipeng | okey I think that was we could do for today | |
| 14:50:13 | zhipeng | #topic other open patches | |
| 14:50:31 | zhipeng | #info object/api implementation for vf/pf | |
| 14:50:41 | zhipeng | #link https://review.openstack.org/552734 | |
| 14:50:47 | zhipeng | I think this looks great now | |
| 14:51:09 | zhipeng | shaohe_feng_ could you help workflow+1 it ? | |
| 14:51:11 | Li_Liu | good to see this patch can be merged. Will have another follow up patch | |
| 14:51:26 | zhipeng | Li_Liu lol | |
| 14:51:33 | shaohe_feng_ | zhipeng: yes | |
| 14:51:41 | Li_Liu | shaohe_feng_ could you try the patch after it merged? | |
| 14:52:55 | shaohe_feng_ | Li_Liu: yes. | |
| 14:53:02 | shaohe_feng_ | will try | |
| 14:53:16 | zhipeng | okey gr8t | |
| 14:53:35 | zhipeng | #topic AoB | |
| 14:53:45 | zhipeng | any other business ? | |
| 14:54:03 | shaohe_feng_ | what is AoB? | |
| 14:54:40 | Coco | same question for me | |
| 14:55:00 | zhipeng | any other business | |
| 14:55:04 | zhipeng | any other topics | |
| 14:55:07 | zhipeng | :) | |
| 14:55:55 | shaohe_feng_ | zhipeng: client? https://review.openstack.org/#/c/560400/ | |
| 14:56:47 | zhipeng | Li_Liu just workflow+1 it :) | |
| 14:56:54 | Li_Liu | thanks a lot :) | |
| 14:57:06 | zhipeng | i mean plz workflow+1 that patch | |