Re: [dabo-dev] dabo Commit 5762

Author: Paul McNett

Posted: 2010-03-22 at 12:15:31

On 3/22/10 8:13 AM, Ed Leafe wrote:

> dabo Commit

> Revision 5762

> Date: 2010-03-22 08:13:05 -0700 (Mon, 22 Mar 2010)

> Author: Ed

> Trac: http://trac.dabodev.com/changeset/5762

>

> Changed:

> U trunk/dabo/dApp.py

>

> Log:

> Changed the HomeDirectory setter to write an errorLog entry instead of throwing an exception when an invalid path is passed. Again, this is an issue with moving a cdxml from one system to another.

Not objecting, just discussing.

If someone is explicitly setting HomeDirectory, but the path doesn't exist, IMO an

exception *should* be raised.

I've never found the need to *set* HomeDirectory.

Not sure what to recommend as I know you've done lots of refactoring of HomeDirectory

lately, but the original intent of HomeDirectory was to be the location of the root

of the application at runtime. That can obviously be different depending on what OS

we are on, where the user decided to install the application, whether we are frozen

into an exe, app, etc. So I guess it doesn't make sense to save HomeDirectory as a

cdxml property in the first place.

But it *does* make sense to me to raise exceptions when the appdev sets properties

incorrectly.

Paul

_______________________________________________

Post Messages to: Dabo-dev@leafe.com

Subscription Maintenance: http://leafe.com/mailman/listinfo/dabo-dev

Searchable Archives: http://leafe.com/archives/search/dabo-dev

This message: http://leafe.com/archives/byMID/4BA797A3.6090000@ulmcnett.com

©2010 Paul McNett